From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06AD5CA9EC3 for ; Thu, 31 Oct 2019 11:08:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8F4820862 for ; Thu, 31 Oct 2019 11:08:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727151AbfJaLIl (ORCPT ); Thu, 31 Oct 2019 07:08:41 -0400 Received: from mga04.intel.com ([192.55.52.120]:26460 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726945AbfJaLIl (ORCPT ); Thu, 31 Oct 2019 07:08:41 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 04:08:40 -0700 X-IronPort-AV: E=Sophos;i="5.68,250,1569308400"; d="scan'208";a="203496356" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 04:08:38 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id AA8DB2075A; Thu, 31 Oct 2019 13:08:36 +0200 (EET) Date: Thu, 31 Oct 2019 13:08:36 +0200 From: Sakari Ailus To: "Tu, ShawnX" Cc: "linux-media@vger.kernel.org" , "Yeh, Andy" Subject: Re: [PATCH v3] hi556: Add support for Hi-556 sensor Message-ID: <20191031110836.GJ10211@paasikivi.fi.intel.com> References: <1572513535-20091-1-git-send-email-shawnx.tu@intel.com> <20191031093534.GI10211@paasikivi.fi.intel.com> <55E713954908ED4DB5E8817B2B5C2CDF01123803@PGSMSX107.gar.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55E713954908ED4DB5E8817B2B5C2CDF01123803@PGSMSX107.gar.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Shawn, On Thu, Oct 31, 2019 at 09:53:56AM +0000, Tu, ShawnX wrote: > Hi Sakari, > > The patch v3 modified & fixed Kconfig conflict issue base latest codebase. Please avoid top posting. The Kconfig chunk appears to be the same as in v2. > > Thanks, > Shawn > -----Original Message----- > From: Sakari Ailus [mailto:sakari.ailus@linux.intel.com] > Sent: Thursday, October 31, 2019 5:36 PM > To: Tu, ShawnX > Cc: linux-media@vger.kernel.org; Yeh, Andy > Subject: Re: [PATCH v3] hi556: Add support for Hi-556 sensor > > Hi Shawn, > > On Thu, Oct 31, 2019 at 05:18:55PM +0800, Shawnx Tu wrote: > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 7eee181..eab4b78 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drivers/media/i2c/Kconfig > > @@ -566,6 +566,19 @@ config VIDEO_APTINA_PLL config VIDEO_SMIAPP_PLL > > tristate > > > > +config VIDEO_HI556 > > + tristate "Hynix Hi-556 sensor support" > > + depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > > + depends on MEDIA_CAMERA_SUPPORT > > + depends on MEDIA_CONTROLLER > > + select V4L2_FWNODE > > + help > > + This is a Video4Linux2 sensor driver for the Hynix > > + Hi-556 camera. > > + > > + To compile this driver as a module, choose M here: the > > + module will be called hi556. > > + > > Can you fix the Kconfig issue kbuild bot found? > > -- > Sakari Ailus -- Sakari Ailus