From: Will Deacon <will@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: perf: Simplify the ARMv8 PMUv3 event attributes
Date: Thu, 31 Oct 2019 16:08:04 +0000 [thread overview]
Message-ID: <20191031160804.GA28325@willie-the-truck> (raw)
In-Reply-To: <1572407177-48229-1-git-send-email-zhangshaokun@hisilicon.com>
On Wed, Oct 30, 2019 at 11:46:17AM +0800, Shaokun Zhang wrote:
> For each PMU event, there is a ARMV8_EVENT_ATTR(xx, XX) and
> &armv8_event_attr_xx.attr.attr. Let's redefine the ARMV8_EVENT_ATTR
> to simplify the armv8_pmuv3_event_attrs.
>
> Cc: Will Deacon <will@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> arch/arm64/kernel/perf_event.c | 189 ++++++++++++++---------------------------
> 1 file changed, 65 insertions(+), 124 deletions(-)
>
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index a0b4f1bca491..d0f084939bcf 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -159,132 +159,73 @@ armv8pmu_events_sysfs_show(struct device *dev,
> }
[...]
> + (&((struct perf_pmu_events_attr[]) { \
> + { .attr = __ATTR(name, 0444, armv8pmu_events_sysfs_show, NULL), \
> + .id = config, } \
> + })[0].attr.attr)
I don't get the need for the array here. Why can't you do:
(&((struct perf_pmu_events_attr) {
.attr = ...,
.id = ...,
}).attr.attr)
?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-31 16:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 3:46 [PATCH] arm64: perf: Simplify the ARMv8 PMUv3 event attributes Shaokun Zhang
2019-10-30 13:34 ` Richard Henderson
2019-10-31 7:55 ` Mark Rutland
2019-10-31 8:45 ` Shaokun Zhang
2019-10-31 16:08 ` Will Deacon [this message]
2019-11-01 3:45 ` Shaokun Zhang
2019-11-01 8:53 ` Mark Rutland
2019-11-01 10:36 ` Will Deacon
2019-11-01 10:54 ` Robin Murphy
2019-11-01 10:55 ` Will Deacon
2019-11-01 11:11 ` Robin Murphy
2019-11-01 14:36 ` Mark Rutland
2019-11-01 16:05 ` Will Deacon
2019-11-04 2:02 ` Shaokun Zhang
2019-11-04 3:25 ` Shaokun Zhang
2019-11-04 1:02 ` Shaokun Zhang
2019-11-04 3:18 ` Shaokun Zhang
2019-11-01 14:32 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031160804.GA28325@willie-the-truck \
--to=will@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.