From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B91ECA9ECB for ; Thu, 31 Oct 2019 17:22:04 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 05A852086D for ; Thu, 31 Oct 2019 17:22:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b="AhXNXSGy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05A852086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=6wind.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21C4E1D160; Thu, 31 Oct 2019 18:22:03 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 5B53D1D158 for ; Thu, 31 Oct 2019 18:22:01 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id a15so7127685wrf.9 for ; Thu, 31 Oct 2019 10:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ohfC0cpnrF754myISgJ58p0X4b+kuQIRCpJ6oqUrcDE=; b=AhXNXSGyGrZfXwr4k+oYcwxdSqXmT+BSVQlSfn/WlZ7qQ2ML1/rLCv+JWUMYLgt5pr 5cYxlRelMLJvzKL9h7llUgcFUI9cIMCw0f3DjAdOhCqwun4ifUKK7k6Th6/QM9/X21yr gLWOtV0fl2VGNm/9RvLgggjFsE9hdP4F6y2PfIAquK9KDPVUhglYPga7HKJOguylgn5r /6a8UMeYkxA2ySaqifGGWz3sDl/bgba6BprTtn4c6M17V/Vu+Ia1egg/2HuVw4JuxJay cy0VhDsl3ml10hS4ceEO7MTQ9PRE2CGKPn64lBJEqmDDSz5HOBxMIajbU36P3aRXoEAa 5UQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ohfC0cpnrF754myISgJ58p0X4b+kuQIRCpJ6oqUrcDE=; b=Rc6YKXBTZJkLOLId4sZ1vc3JGtC5VGG772/8D9F4s9Mqk8FZtKTtqlxl7oxqhqb8lp Ci7JyYOSsPSc3jjb97WUm1Wc83NK7HEh0L88c3CZwEmUgFIdh8uhxxmWMhNIfMU6jXmL Boz5svMm+RsfpJGPVfGS1W+y+vMhTE+zshzzlEiSrzACfoDGVKF89Zw5TvCvvds7uDlL axgoWqw1UTdU1wVCIEhh7UUtw+tgV1pMp8xdH1wyDpcAg6mT5Tr4ta8c6An30S+Tox+h tCbtZna0OFTCGNzoJcjgRY6O+RyTD/HIuR+qKpaOs5pie9vMDCYjExvYfEsFmAXPLDrn GsWg== X-Gm-Message-State: APjAAAV+IIz/4etmb6w9CMyosFh8r7UqODBMbBXVXEnymCSPawfY7UqF 7Osh7cxVmQB7QJ8vBFyDRdjpTg== X-Google-Smtp-Source: APXvYqyDIkznqUMuHY6TB4VR3/XGu8WD34bGM8AppO8hjrWi5sX843UH8iTMnATvVaNVGgnFhIIc2A== X-Received: by 2002:adf:e747:: with SMTP id c7mr6752105wrn.384.1572542520937; Thu, 31 Oct 2019 10:22:00 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a6000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id t16sm5044502wrq.52.2019.10.31.10.21.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2019 10:22:00 -0700 (PDT) Date: Thu, 31 Oct 2019 18:21:59 +0100 From: Olivier Matz To: Viacheslav Ovsiienko Cc: dev@dpdk.org, matan@mellanox.com, rasland@mellanox.com, thomas@monjalon.net, arybchenko@solarflare.com, orika@mellanox.com Message-ID: <20191031172159.3hqkqco66qvd3bq3@platinum> References: <1572527121-13133-2-git-send-email-viacheslavo@mellanox.com> <1572540506-531-1-git-send-email-viacheslavo@mellanox.com> <1572540506-531-3-git-send-email-viacheslavo@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572540506-531-3-git-send-email-viacheslavo@mellanox.com> User-Agent: NeoMutt/20180716 Subject: Re: [dpdk-dev] [PATCH v8 2/2] ethdev: move egress metadata to dynamic field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 31, 2019 at 04:48:26PM +0000, Viacheslav Ovsiienko wrote: > The dynamic mbuf fields were introduced by [1]. The egress metadata is > good candidate to be moved from statically allocated field tx_metadata to > dynamic one. Because mbufs are used in half-duplex fashion only, it is > safe to share this dynamic field with ingress metadata. > > The shared dynamic field contains either egress (if application going to > transmit mbuf with tx_burst) or ingress (if mbuf is received with rx_burst) > metadata and can be accessed by RTE_FLOW_DYNF_METADATA() macro or with > rte_flow_dynf_metadata_set() and rte_flow_dynf_metadata_get() helper > routines. PKT_TX_DYNF_METADATA/PKT_RX_DYNF_METADATA flag will be set > along with the data. > > The mbuf dynamic field must be registered by calling > rte_flow_dynf_metadata_register() prior accessing the data. > > The availability of dynamic mbuf metadata field can be checked with > rte_flow_dynf_metadata_avail() routine. > > DEV_TX_OFFLOAD_MATCH_METADATA offload and configuration flag is removed. > The metadata support in PMDs is engaged on dynamic field registration. > > Metadata feature is getting complex. We might have some set of actions > and items that might be supported by PMDs in multiple combinations, > the supported values and masks are the subjects to query by perfroming > trials (with rte_flow_validate). > > [1] http://patches.dpdk.org/patch/62040/ > > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Ori Kam Acked-by: Olivier Matz