From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE54CA9ECF for ; Thu, 31 Oct 2019 23:35:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E87FA20862 for ; Thu, 31 Oct 2019 23:35:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727630AbfJaXfW (ORCPT ); Thu, 31 Oct 2019 19:35:22 -0400 Received: from mga01.intel.com ([192.55.52.88]:53761 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726506AbfJaXfV (ORCPT ); Thu, 31 Oct 2019 19:35:21 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 16:35:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,253,1569308400"; d="scan'208";a="206259359" Received: from iweiny-desk2.sc.intel.com ([10.3.52.157]) by FMSMGA003.fm.intel.com with ESMTP; 31 Oct 2019 16:35:19 -0700 Date: Thu, 31 Oct 2019 16:35:19 -0700 From: Ira Weiny To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?iso-8859-1?B?Suly9G1l?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH 08/19] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote() Message-ID: <20191031233519.GH14771@iweiny-DESK2.sc.intel.com> References: <20191030224930.3990755-1-jhubbard@nvidia.com> <20191030224930.3990755-9-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030224930.3990755-9-jhubbard@nvidia.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Oct 30, 2019 at 03:49:19PM -0700, John Hubbard wrote: > Convert process_vm_access to use the new pin_user_pages_remote() > call, which sets FOLL_PIN. Setting FOLL_PIN is now required for > code that requires tracking of pinned pages. > > Also, release the pages via put_user_page*(). > > Also, rename "pages" to "pinned_pages", as this makes for > easier reading of process_vm_rw_single_vec(). Ok... but it made review a bit harder... Reviewed-by: Ira Weiny > > Signed-off-by: John Hubbard > --- > mm/process_vm_access.c | 28 +++++++++++++++------------- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c > index 357aa7bef6c0..fd20ab675b85 100644 > --- a/mm/process_vm_access.c > +++ b/mm/process_vm_access.c > @@ -42,12 +42,11 @@ static int process_vm_rw_pages(struct page **pages, > if (copy > len) > copy = len; > > - if (vm_write) { > + if (vm_write) > copied = copy_page_from_iter(page, offset, copy, iter); > - set_page_dirty_lock(page); > - } else { > + else > copied = copy_page_to_iter(page, offset, copy, iter); > - } > + > len -= copied; > if (copied < copy && iov_iter_count(iter)) > return -EFAULT; > @@ -96,7 +95,7 @@ static int process_vm_rw_single_vec(unsigned long addr, > flags |= FOLL_WRITE; > > while (!rc && nr_pages && iov_iter_count(iter)) { > - int pages = min(nr_pages, max_pages_per_loop); > + int pinned_pages = min(nr_pages, max_pages_per_loop); > int locked = 1; > size_t bytes; > > @@ -106,14 +105,15 @@ static int process_vm_rw_single_vec(unsigned long addr, > * current/current->mm > */ > down_read(&mm->mmap_sem); > - pages = get_user_pages_remote(task, mm, pa, pages, flags, > - process_pages, NULL, &locked); > + pinned_pages = pin_user_pages_remote(task, mm, pa, pinned_pages, > + flags, process_pages, > + NULL, &locked); > if (locked) > up_read(&mm->mmap_sem); > - if (pages <= 0) > + if (pinned_pages <= 0) > return -EFAULT; > > - bytes = pages * PAGE_SIZE - start_offset; > + bytes = pinned_pages * PAGE_SIZE - start_offset; > if (bytes > len) > bytes = len; > > @@ -122,10 +122,12 @@ static int process_vm_rw_single_vec(unsigned long addr, > vm_write); > len -= bytes; > start_offset = 0; > - nr_pages -= pages; > - pa += pages * PAGE_SIZE; > - while (pages) > - put_page(process_pages[--pages]); > + nr_pages -= pinned_pages; > + pa += pinned_pages * PAGE_SIZE; > + > + /* If vm_write is set, the pages need to be made dirty: */ > + put_user_pages_dirty_lock(process_pages, pinned_pages, > + vm_write); > } > > return rc; > -- > 2.23.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D399DCA9ECB for ; Thu, 31 Oct 2019 23:37:54 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5729220862 for ; Thu, 31 Oct 2019 23:37:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5729220862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4741w0021DzF4d8 for ; Fri, 1 Nov 2019 10:37:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ira.weiny@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4741sD4Y1TzF6HT for ; Fri, 1 Nov 2019 10:35:23 +1100 (AEDT) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 16:35:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,253,1569308400"; d="scan'208";a="206259359" Received: from iweiny-desk2.sc.intel.com ([10.3.52.157]) by FMSMGA003.fm.intel.com with ESMTP; 31 Oct 2019 16:35:19 -0700 Date: Thu, 31 Oct 2019 16:35:19 -0700 From: Ira Weiny To: John Hubbard Subject: Re: [PATCH 08/19] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote() Message-ID: <20191031233519.GH14771@iweiny-DESK2.sc.intel.com> References: <20191030224930.3990755-1-jhubbard@nvidia.com> <20191030224930.3990755-9-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030224930.3990755-9-jhubbard@nvidia.com> User-Agent: Mutt/1.11.1 (2018-12-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Shuah Khan , Jonathan Corbet , linux-rdma@vger.kernel.org, Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , Daniel Vetter , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Oct 30, 2019 at 03:49:19PM -0700, John Hubbard wrote: > Convert process_vm_access to use the new pin_user_pages_remote() > call, which sets FOLL_PIN. Setting FOLL_PIN is now required for > code that requires tracking of pinned pages. > > Also, release the pages via put_user_page*(). > > Also, rename "pages" to "pinned_pages", as this makes for > easier reading of process_vm_rw_single_vec(). Ok... but it made review a bit harder... Reviewed-by: Ira Weiny > > Signed-off-by: John Hubbard > --- > mm/process_vm_access.c | 28 +++++++++++++++------------- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c > index 357aa7bef6c0..fd20ab675b85 100644 > --- a/mm/process_vm_access.c > +++ b/mm/process_vm_access.c > @@ -42,12 +42,11 @@ static int process_vm_rw_pages(struct page **pages, > if (copy > len) > copy = len; > > - if (vm_write) { > + if (vm_write) > copied = copy_page_from_iter(page, offset, copy, iter); > - set_page_dirty_lock(page); > - } else { > + else > copied = copy_page_to_iter(page, offset, copy, iter); > - } > + > len -= copied; > if (copied < copy && iov_iter_count(iter)) > return -EFAULT; > @@ -96,7 +95,7 @@ static int process_vm_rw_single_vec(unsigned long addr, > flags |= FOLL_WRITE; > > while (!rc && nr_pages && iov_iter_count(iter)) { > - int pages = min(nr_pages, max_pages_per_loop); > + int pinned_pages = min(nr_pages, max_pages_per_loop); > int locked = 1; > size_t bytes; > > @@ -106,14 +105,15 @@ static int process_vm_rw_single_vec(unsigned long addr, > * current/current->mm > */ > down_read(&mm->mmap_sem); > - pages = get_user_pages_remote(task, mm, pa, pages, flags, > - process_pages, NULL, &locked); > + pinned_pages = pin_user_pages_remote(task, mm, pa, pinned_pages, > + flags, process_pages, > + NULL, &locked); > if (locked) > up_read(&mm->mmap_sem); > - if (pages <= 0) > + if (pinned_pages <= 0) > return -EFAULT; > > - bytes = pages * PAGE_SIZE - start_offset; > + bytes = pinned_pages * PAGE_SIZE - start_offset; > if (bytes > len) > bytes = len; > > @@ -122,10 +122,12 @@ static int process_vm_rw_single_vec(unsigned long addr, > vm_write); > len -= bytes; > start_offset = 0; > - nr_pages -= pages; > - pa += pages * PAGE_SIZE; > - while (pages) > - put_page(process_pages[--pages]); > + nr_pages -= pinned_pages; > + pa += pinned_pages * PAGE_SIZE; > + > + /* If vm_write is set, the pages need to be made dirty: */ > + put_user_pages_dirty_lock(process_pages, pinned_pages, > + vm_write); > } > > return rc; > -- > 2.23.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ira Weiny Subject: Re: [PATCH 08/19] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote() Date: Thu, 31 Oct 2019 16:35:19 -0700 Message-ID: <20191031233519.GH14771@iweiny-DESK2.sc.intel.com> References: <20191030224930.3990755-1-jhubbard@nvidia.com> <20191030224930.3990755-9-jhubbard@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B30A56F691 for ; Thu, 31 Oct 2019 23:35:20 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20191030224930.3990755-9-jhubbard@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Hubbard Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Shuah Khan , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.orgM List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBPY3QgMzAsIDIwMTkgYXQgMDM6NDk6MTlQTSAtMDcwMCwgSm9obiBIdWJiYXJkIHdy b3RlOgo+IENvbnZlcnQgcHJvY2Vzc192bV9hY2Nlc3MgdG8gdXNlIHRoZSBuZXcgcGluX3VzZXJf cGFnZXNfcmVtb3RlKCkKPiBjYWxsLCB3aGljaCBzZXRzIEZPTExfUElOLiBTZXR0aW5nIEZPTExf UElOIGlzIG5vdyByZXF1aXJlZCBmb3IKPiBjb2RlIHRoYXQgcmVxdWlyZXMgdHJhY2tpbmcgb2Yg cGlubmVkIHBhZ2VzLgo+IAo+IEFsc28sIHJlbGVhc2UgdGhlIHBhZ2VzIHZpYSBwdXRfdXNlcl9w YWdlKigpLgo+IAo+IEFsc28sIHJlbmFtZSAicGFnZXMiIHRvICJwaW5uZWRfcGFnZXMiLCBhcyB0 aGlzIG1ha2VzIGZvcgo+IGVhc2llciByZWFkaW5nIG9mIHByb2Nlc3Nfdm1fcndfc2luZ2xlX3Zl YygpLgoKT2suLi4gIGJ1dCBpdCBtYWRlIHJldmlldyBhIGJpdCBoYXJkZXIuLi4KClJldmlld2Vk LWJ5OiBJcmEgV2VpbnkgPGlyYS53ZWlueUBpbnRlbC5jb20+Cgo+IAo+IFNpZ25lZC1vZmYtYnk6 IEpvaG4gSHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KPiAtLS0KPiAgbW0vcHJvY2Vzc192 bV9hY2Nlc3MuYyB8IDI4ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9tbS9wcm9jZXNzX3ZtX2FjY2Vzcy5jIGIvbW0vcHJvY2Vzc192bV9hY2Nlc3MuYwo+IGluZGV4 IDM1N2FhN2JlZjZjMC4uZmQyMGFiNjc1Yjg1IDEwMDY0NAo+IC0tLSBhL21tL3Byb2Nlc3Nfdm1f YWNjZXNzLmMKPiArKysgYi9tbS9wcm9jZXNzX3ZtX2FjY2Vzcy5jCj4gQEAgLTQyLDEyICs0Miwx MSBAQCBzdGF0aWMgaW50IHByb2Nlc3Nfdm1fcndfcGFnZXMoc3RydWN0IHBhZ2UgKipwYWdlcywK PiAgCQlpZiAoY29weSA+IGxlbikKPiAgCQkJY29weSA9IGxlbjsKPiAgCj4gLQkJaWYgKHZtX3dy aXRlKSB7Cj4gKwkJaWYgKHZtX3dyaXRlKQo+ICAJCQljb3BpZWQgPSBjb3B5X3BhZ2VfZnJvbV9p dGVyKHBhZ2UsIG9mZnNldCwgY29weSwgaXRlcik7Cj4gLQkJCXNldF9wYWdlX2RpcnR5X2xvY2so cGFnZSk7Cj4gLQkJfSBlbHNlIHsKPiArCQllbHNlCj4gIAkJCWNvcGllZCA9IGNvcHlfcGFnZV90 b19pdGVyKHBhZ2UsIG9mZnNldCwgY29weSwgaXRlcik7Cj4gLQkJfQo+ICsKPiAgCQlsZW4gLT0g Y29waWVkOwo+ICAJCWlmIChjb3BpZWQgPCBjb3B5ICYmIGlvdl9pdGVyX2NvdW50KGl0ZXIpKQo+ ICAJCQlyZXR1cm4gLUVGQVVMVDsKPiBAQCAtOTYsNyArOTUsNyBAQCBzdGF0aWMgaW50IHByb2Nl c3Nfdm1fcndfc2luZ2xlX3ZlYyh1bnNpZ25lZCBsb25nIGFkZHIsCj4gIAkJZmxhZ3MgfD0gRk9M TF9XUklURTsKPiAgCj4gIAl3aGlsZSAoIXJjICYmIG5yX3BhZ2VzICYmIGlvdl9pdGVyX2NvdW50 KGl0ZXIpKSB7Cj4gLQkJaW50IHBhZ2VzID0gbWluKG5yX3BhZ2VzLCBtYXhfcGFnZXNfcGVyX2xv b3ApOwo+ICsJCWludCBwaW5uZWRfcGFnZXMgPSBtaW4obnJfcGFnZXMsIG1heF9wYWdlc19wZXJf bG9vcCk7Cj4gIAkJaW50IGxvY2tlZCA9IDE7Cj4gIAkJc2l6ZV90IGJ5dGVzOwo+ICAKPiBAQCAt MTA2LDE0ICsxMDUsMTUgQEAgc3RhdGljIGludCBwcm9jZXNzX3ZtX3J3X3NpbmdsZV92ZWModW5z aWduZWQgbG9uZyBhZGRyLAo+ICAJCSAqIGN1cnJlbnQvY3VycmVudC0+bW0KPiAgCQkgKi8KPiAg CQlkb3duX3JlYWQoJm1tLT5tbWFwX3NlbSk7Cj4gLQkJcGFnZXMgPSBnZXRfdXNlcl9wYWdlc19y ZW1vdGUodGFzaywgbW0sIHBhLCBwYWdlcywgZmxhZ3MsCj4gLQkJCQkJICAgICAgcHJvY2Vzc19w YWdlcywgTlVMTCwgJmxvY2tlZCk7Cj4gKwkJcGlubmVkX3BhZ2VzID0gcGluX3VzZXJfcGFnZXNf cmVtb3RlKHRhc2ssIG1tLCBwYSwgcGlubmVkX3BhZ2VzLAo+ICsJCQkJCQkgICAgIGZsYWdzLCBw cm9jZXNzX3BhZ2VzLAo+ICsJCQkJCQkgICAgIE5VTEwsICZsb2NrZWQpOwo+ICAJCWlmIChsb2Nr ZWQpCj4gIAkJCXVwX3JlYWQoJm1tLT5tbWFwX3NlbSk7Cj4gLQkJaWYgKHBhZ2VzIDw9IDApCj4g KwkJaWYgKHBpbm5lZF9wYWdlcyA8PSAwKQo+ICAJCQlyZXR1cm4gLUVGQVVMVDsKPiAgCj4gLQkJ Ynl0ZXMgPSBwYWdlcyAqIFBBR0VfU0laRSAtIHN0YXJ0X29mZnNldDsKPiArCQlieXRlcyA9IHBp bm5lZF9wYWdlcyAqIFBBR0VfU0laRSAtIHN0YXJ0X29mZnNldDsKPiAgCQlpZiAoYnl0ZXMgPiBs ZW4pCj4gIAkJCWJ5dGVzID0gbGVuOwo+ICAKPiBAQCAtMTIyLDEwICsxMjIsMTIgQEAgc3RhdGlj IGludCBwcm9jZXNzX3ZtX3J3X3NpbmdsZV92ZWModW5zaWduZWQgbG9uZyBhZGRyLAo+ICAJCQkJ CSB2bV93cml0ZSk7Cj4gIAkJbGVuIC09IGJ5dGVzOwo+ICAJCXN0YXJ0X29mZnNldCA9IDA7Cj4g LQkJbnJfcGFnZXMgLT0gcGFnZXM7Cj4gLQkJcGEgKz0gcGFnZXMgKiBQQUdFX1NJWkU7Cj4gLQkJ d2hpbGUgKHBhZ2VzKQo+IC0JCQlwdXRfcGFnZShwcm9jZXNzX3BhZ2VzWy0tcGFnZXNdKTsKPiAr CQlucl9wYWdlcyAtPSBwaW5uZWRfcGFnZXM7Cj4gKwkJcGEgKz0gcGlubmVkX3BhZ2VzICogUEFH RV9TSVpFOwo+ICsKPiArCQkvKiBJZiB2bV93cml0ZSBpcyBzZXQsIHRoZSBwYWdlcyBuZWVkIHRv IGJlIG1hZGUgZGlydHk6ICovCj4gKwkJcHV0X3VzZXJfcGFnZXNfZGlydHlfbG9jayhwcm9jZXNz X3BhZ2VzLCBwaW5uZWRfcGFnZXMsCj4gKwkJCQkJICB2bV93cml0ZSk7Cj4gIAl9Cj4gIAo+ICAJ cmV0dXJuIHJjOwo+IC0tIAo+IDIuMjMuMAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC44CA9ECB for ; Thu, 31 Oct 2019 23:35:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C83620862 for ; Thu, 31 Oct 2019 23:35:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C83620862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 871BC6F691; Thu, 31 Oct 2019 23:35:22 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B30A56F691 for ; Thu, 31 Oct 2019 23:35:20 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 16:35:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,253,1569308400"; d="scan'208";a="206259359" Received: from iweiny-desk2.sc.intel.com ([10.3.52.157]) by FMSMGA003.fm.intel.com with ESMTP; 31 Oct 2019 16:35:19 -0700 Date: Thu, 31 Oct 2019 16:35:19 -0700 From: Ira Weiny To: John Hubbard Subject: Re: [PATCH 08/19] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote() Message-ID: <20191031233519.GH14771@iweiny-DESK2.sc.intel.com> References: <20191030224930.3990755-1-jhubbard@nvidia.com> <20191030224930.3990755-9-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191030224930.3990755-9-jhubbard@nvidia.com> User-Agent: Mutt/1.11.1 (2018-12-01) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Shuah Khan , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191031233519.9GGmeWtrIcRLcGZ4hP4vsMZ7qm3mK5y_62mp9m4EufM@z> T24gV2VkLCBPY3QgMzAsIDIwMTkgYXQgMDM6NDk6MTlQTSAtMDcwMCwgSm9obiBIdWJiYXJkIHdy b3RlOgo+IENvbnZlcnQgcHJvY2Vzc192bV9hY2Nlc3MgdG8gdXNlIHRoZSBuZXcgcGluX3VzZXJf cGFnZXNfcmVtb3RlKCkKPiBjYWxsLCB3aGljaCBzZXRzIEZPTExfUElOLiBTZXR0aW5nIEZPTExf UElOIGlzIG5vdyByZXF1aXJlZCBmb3IKPiBjb2RlIHRoYXQgcmVxdWlyZXMgdHJhY2tpbmcgb2Yg cGlubmVkIHBhZ2VzLgo+IAo+IEFsc28sIHJlbGVhc2UgdGhlIHBhZ2VzIHZpYSBwdXRfdXNlcl9w YWdlKigpLgo+IAo+IEFsc28sIHJlbmFtZSAicGFnZXMiIHRvICJwaW5uZWRfcGFnZXMiLCBhcyB0 aGlzIG1ha2VzIGZvcgo+IGVhc2llciByZWFkaW5nIG9mIHByb2Nlc3Nfdm1fcndfc2luZ2xlX3Zl YygpLgoKT2suLi4gIGJ1dCBpdCBtYWRlIHJldmlldyBhIGJpdCBoYXJkZXIuLi4KClJldmlld2Vk LWJ5OiBJcmEgV2VpbnkgPGlyYS53ZWlueUBpbnRlbC5jb20+Cgo+IAo+IFNpZ25lZC1vZmYtYnk6 IEpvaG4gSHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KPiAtLS0KPiAgbW0vcHJvY2Vzc192 bV9hY2Nlc3MuYyB8IDI4ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9tbS9wcm9jZXNzX3ZtX2FjY2Vzcy5jIGIvbW0vcHJvY2Vzc192bV9hY2Nlc3MuYwo+IGluZGV4 IDM1N2FhN2JlZjZjMC4uZmQyMGFiNjc1Yjg1IDEwMDY0NAo+IC0tLSBhL21tL3Byb2Nlc3Nfdm1f YWNjZXNzLmMKPiArKysgYi9tbS9wcm9jZXNzX3ZtX2FjY2Vzcy5jCj4gQEAgLTQyLDEyICs0Miwx MSBAQCBzdGF0aWMgaW50IHByb2Nlc3Nfdm1fcndfcGFnZXMoc3RydWN0IHBhZ2UgKipwYWdlcywK PiAgCQlpZiAoY29weSA+IGxlbikKPiAgCQkJY29weSA9IGxlbjsKPiAgCj4gLQkJaWYgKHZtX3dy aXRlKSB7Cj4gKwkJaWYgKHZtX3dyaXRlKQo+ICAJCQljb3BpZWQgPSBjb3B5X3BhZ2VfZnJvbV9p dGVyKHBhZ2UsIG9mZnNldCwgY29weSwgaXRlcik7Cj4gLQkJCXNldF9wYWdlX2RpcnR5X2xvY2so cGFnZSk7Cj4gLQkJfSBlbHNlIHsKPiArCQllbHNlCj4gIAkJCWNvcGllZCA9IGNvcHlfcGFnZV90 b19pdGVyKHBhZ2UsIG9mZnNldCwgY29weSwgaXRlcik7Cj4gLQkJfQo+ICsKPiAgCQlsZW4gLT0g Y29waWVkOwo+ICAJCWlmIChjb3BpZWQgPCBjb3B5ICYmIGlvdl9pdGVyX2NvdW50KGl0ZXIpKQo+ ICAJCQlyZXR1cm4gLUVGQVVMVDsKPiBAQCAtOTYsNyArOTUsNyBAQCBzdGF0aWMgaW50IHByb2Nl c3Nfdm1fcndfc2luZ2xlX3ZlYyh1bnNpZ25lZCBsb25nIGFkZHIsCj4gIAkJZmxhZ3MgfD0gRk9M TF9XUklURTsKPiAgCj4gIAl3aGlsZSAoIXJjICYmIG5yX3BhZ2VzICYmIGlvdl9pdGVyX2NvdW50 KGl0ZXIpKSB7Cj4gLQkJaW50IHBhZ2VzID0gbWluKG5yX3BhZ2VzLCBtYXhfcGFnZXNfcGVyX2xv b3ApOwo+ICsJCWludCBwaW5uZWRfcGFnZXMgPSBtaW4obnJfcGFnZXMsIG1heF9wYWdlc19wZXJf bG9vcCk7Cj4gIAkJaW50IGxvY2tlZCA9IDE7Cj4gIAkJc2l6ZV90IGJ5dGVzOwo+ICAKPiBAQCAt MTA2LDE0ICsxMDUsMTUgQEAgc3RhdGljIGludCBwcm9jZXNzX3ZtX3J3X3NpbmdsZV92ZWModW5z aWduZWQgbG9uZyBhZGRyLAo+ICAJCSAqIGN1cnJlbnQvY3VycmVudC0+bW0KPiAgCQkgKi8KPiAg CQlkb3duX3JlYWQoJm1tLT5tbWFwX3NlbSk7Cj4gLQkJcGFnZXMgPSBnZXRfdXNlcl9wYWdlc19y ZW1vdGUodGFzaywgbW0sIHBhLCBwYWdlcywgZmxhZ3MsCj4gLQkJCQkJICAgICAgcHJvY2Vzc19w YWdlcywgTlVMTCwgJmxvY2tlZCk7Cj4gKwkJcGlubmVkX3BhZ2VzID0gcGluX3VzZXJfcGFnZXNf cmVtb3RlKHRhc2ssIG1tLCBwYSwgcGlubmVkX3BhZ2VzLAo+ICsJCQkJCQkgICAgIGZsYWdzLCBw cm9jZXNzX3BhZ2VzLAo+ICsJCQkJCQkgICAgIE5VTEwsICZsb2NrZWQpOwo+ICAJCWlmIChsb2Nr ZWQpCj4gIAkJCXVwX3JlYWQoJm1tLT5tbWFwX3NlbSk7Cj4gLQkJaWYgKHBhZ2VzIDw9IDApCj4g KwkJaWYgKHBpbm5lZF9wYWdlcyA8PSAwKQo+ICAJCQlyZXR1cm4gLUVGQVVMVDsKPiAgCj4gLQkJ Ynl0ZXMgPSBwYWdlcyAqIFBBR0VfU0laRSAtIHN0YXJ0X29mZnNldDsKPiArCQlieXRlcyA9IHBp bm5lZF9wYWdlcyAqIFBBR0VfU0laRSAtIHN0YXJ0X29mZnNldDsKPiAgCQlpZiAoYnl0ZXMgPiBs ZW4pCj4gIAkJCWJ5dGVzID0gbGVuOwo+ICAKPiBAQCAtMTIyLDEwICsxMjIsMTIgQEAgc3RhdGlj IGludCBwcm9jZXNzX3ZtX3J3X3NpbmdsZV92ZWModW5zaWduZWQgbG9uZyBhZGRyLAo+ICAJCQkJ CSB2bV93cml0ZSk7Cj4gIAkJbGVuIC09IGJ5dGVzOwo+ICAJCXN0YXJ0X29mZnNldCA9IDA7Cj4g LQkJbnJfcGFnZXMgLT0gcGFnZXM7Cj4gLQkJcGEgKz0gcGFnZXMgKiBQQUdFX1NJWkU7Cj4gLQkJ d2hpbGUgKHBhZ2VzKQo+IC0JCQlwdXRfcGFnZShwcm9jZXNzX3BhZ2VzWy0tcGFnZXNdKTsKPiAr CQlucl9wYWdlcyAtPSBwaW5uZWRfcGFnZXM7Cj4gKwkJcGEgKz0gcGlubmVkX3BhZ2VzICogUEFH RV9TSVpFOwo+ICsKPiArCQkvKiBJZiB2bV93cml0ZSBpcyBzZXQsIHRoZSBwYWdlcyBuZWVkIHRv IGJlIG1hZGUgZGlydHk6ICovCj4gKwkJcHV0X3VzZXJfcGFnZXNfZGlydHlfbG9jayhwcm9jZXNz X3BhZ2VzLCBwaW5uZWRfcGFnZXMsCj4gKwkJCQkJICB2bV93cml0ZSk7Cj4gIAl9Cj4gIAo+ICAJ cmV0dXJuIHJjOwo+IC0tIAo+IDIuMjMuMAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw=