From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C5DCA9ECF for ; Fri, 1 Nov 2019 19:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 445FE2086D for ; Fri, 1 Nov 2019 19:02:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FdSEwR9X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727615AbfKATCR (ORCPT ); Fri, 1 Nov 2019 15:02:17 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44811 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727372AbfKATCQ (ORCPT ); Fri, 1 Nov 2019 15:02:16 -0400 Received: by mail-pg1-f195.google.com with SMTP id e10so7017642pgd.11 for ; Fri, 01 Nov 2019 12:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2fG4DzCLulQ+v7huA1kdMQ2RtRpH3xT6PP3dcQOR3YM=; b=FdSEwR9X5l9Wqc+/eshiHPMlZ+qbVGkM0VrADZRZNoPKl47i8lf6Ah2ogK43O9mLBz C38lxuGZvsa0tFqnuBBHY2YWJOfGOTokdGNGz6+UQ9XWtZ1Qp16zcUsqtprBYXlv+ny5 fD8DNC5oZHJ6AV27OHsxTC/ul2AuGnuvtGGk4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2fG4DzCLulQ+v7huA1kdMQ2RtRpH3xT6PP3dcQOR3YM=; b=e18B8sB6gjCrvPVWieI0Bzq5PcqgZduZh753BFDf9y7N2QtDgffmJXEVUlkGyxk7lb +40k6sI1Emof9gmLZ12qWEAyOY4Waz/Hfx+6cjTN1kpcwVYMgMRY07IVeiOheUW/5Uee 2gzA3cspEjgBiSrK2uC4myywe1JJWIFlZhPeMjipcfKH1Wo2GUSR/UqD1eX26cLlr8g8 beERjotpaTwT9TyXz4uP80GAisEqdoV7kdb/ivh2MpBGC0dz+ke6rRKoRuHi5tMV0zWU JCpJoCGvHNBaHZQ/JHAS7P/YdNTRnGLUx4jFGovpJPBIbFw2cIk5+gf3Mq1QyfxY8z4M kEHA== X-Gm-Message-State: APjAAAUQbHLMPYVghGrTXSJUajKimPLKbulk+VJYwV2fNuxlcUxEB8KH /4cp+2f6ho+B66D5NcY36S/8hw== X-Google-Smtp-Source: APXvYqzEjD8mlyAQagoCql+H8OD47PXOJ5YDq8BZhhrYFD67Vj1PkcdsuEn3Dl9QXx9NFWLOxoUDbw== X-Received: by 2002:a65:5a06:: with SMTP id y6mr15317180pgs.9.1572634935932; Fri, 01 Nov 2019 12:02:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w10sm7985756pjq.3.2019.11.01.12.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 12:02:14 -0700 (PDT) Date: Fri, 1 Nov 2019 12:02:13 -0700 From: Kees Cook To: Sami Tolvanen Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Laura Abbott , Mark Rutland , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Subject: Re: [PATCH v3 07/17] scs: add support for stack usage debugging Message-ID: <201911011201.A070D143D@keescook> References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-8-samitolvanen@google.com> <201910312054.3064999E@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 01, 2019 at 09:32:54AM -0700, Sami Tolvanen wrote: > On Thu, Oct 31, 2019 at 8:55 PM Kees Cook wrote: > > > > On Thu, Oct 31, 2019 at 09:46:27AM -0700, samitolvanen@google.com wrote: > > > Implements CONFIG_DEBUG_STACK_USAGE for shadow stacks. > > > > Did I miss it, or is there no Kconfig section for this? I just realized > > I can't find it. I was going to say "this commit log should explain > > why/when this option is used", but then figured it might be explained in > > the Kconfig ... but I couldn't find it. ;) > > It's in lib/Kconfig.debug. But yes, I will add a commit message in v4. Oh duh -- it's an existing option. Cool; I'm all good. :) -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA55CA9ECF for ; Fri, 1 Nov 2019 19:02:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFB032086D for ; Fri, 1 Nov 2019 19:02:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L5BQN2F9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FdSEwR9X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFB032086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pt3NRANnmw76MrmWm0h0FR2uyM+Yeo2xP652GwUHH1s=; b=L5BQN2F9nulE7/ DefhJysnqI2y/XHYHRR1fWfX8e9OJCE6n2SaIaIweDN8vutjxWEvUQegwW9LiBy5WDkkRPbUBuZgm B5IP/0mCKXQycCfmyvbsviqELYS/LiBJEil77dlj8hQxq/szQomo4yDnycdkT5mzjo7sff4aj3npT lV3YNZzwkqPo6bNnUdpBjUFAv1voVu+khwnBdtVnxG9YvgRrkDWls645barIWjfoIt4ZTEUDUXuJH 9cNApHFE+hCEQzHVXq9DXVVsnplQHCWUaBHIglXx3wxk4JrN9G7yGlKU+3yEclUW14h15oPOkz9G0 8pXAZvCAzEhbCvnpiUaQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQcBf-0007al-Qq; Fri, 01 Nov 2019 19:02:19 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQcBc-0007aI-Fu for linux-arm-kernel@lists.infradead.org; Fri, 01 Nov 2019 19:02:18 +0000 Received: by mail-pg1-x543.google.com with SMTP id j30so3547827pgn.5 for ; Fri, 01 Nov 2019 12:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2fG4DzCLulQ+v7huA1kdMQ2RtRpH3xT6PP3dcQOR3YM=; b=FdSEwR9X5l9Wqc+/eshiHPMlZ+qbVGkM0VrADZRZNoPKl47i8lf6Ah2ogK43O9mLBz C38lxuGZvsa0tFqnuBBHY2YWJOfGOTokdGNGz6+UQ9XWtZ1Qp16zcUsqtprBYXlv+ny5 fD8DNC5oZHJ6AV27OHsxTC/ul2AuGnuvtGGk4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2fG4DzCLulQ+v7huA1kdMQ2RtRpH3xT6PP3dcQOR3YM=; b=c963nYv+xEeuRtvxpMCYKdp703GXyB+O7BFOc2SAGlqWEE9A9lEuw0RRNRU/o/Acpb GLyAzIQfKYlhPqfFfZLMnOho63V8UMdENpuOgXZVZd90sYsiCq5mr2ddDyZo3KbDIt4V fiGFoYf1w5Ch7o7Fytt4RIZzYXHvHXVCBTJTbUZL96HwPh8ToojekNmgZ4bkTeUv5JLM +HL+DJ1uq9cJkzEG/KYtEvwvWJhp/9MigpBg01VcSuR+M6q3nMpFic+As7R4sntvpfv2 1xdF3uJZjKnLNhQZG7GfDRZLfpoyvIsp5FrSmYO5UoDwOPBPeFzPmFSPapyHi3GQUCzM yF8g== X-Gm-Message-State: APjAAAX8AbacOA68xlAK9tzOrfbFy4SZ8snsztIkgoR8dyVfZ9RMcbz4 fTHc4pulRm6kt7YMv3w2d/VMHQ== X-Google-Smtp-Source: APXvYqzEjD8mlyAQagoCql+H8OD47PXOJ5YDq8BZhhrYFD67Vj1PkcdsuEn3Dl9QXx9NFWLOxoUDbw== X-Received: by 2002:a65:5a06:: with SMTP id y6mr15317180pgs.9.1572634935932; Fri, 01 Nov 2019 12:02:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w10sm7985756pjq.3.2019.11.01.12.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 12:02:14 -0700 (PDT) Date: Fri, 1 Nov 2019 12:02:13 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v3 07/17] scs: add support for stack usage debugging Message-ID: <201911011201.A070D143D@keescook> References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-8-samitolvanen@google.com> <201910312054.3064999E@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191101_120216_864934_EA45AD54 X-CRM114-Status: GOOD ( 12.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , clang-built-linux , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , Masami Hiramatsu , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 01, 2019 at 09:32:54AM -0700, Sami Tolvanen wrote: > On Thu, Oct 31, 2019 at 8:55 PM Kees Cook wrote: > > > > On Thu, Oct 31, 2019 at 09:46:27AM -0700, samitolvanen@google.com wrote: > > > Implements CONFIG_DEBUG_STACK_USAGE for shadow stacks. > > > > Did I miss it, or is there no Kconfig section for this? I just realized > > I can't find it. I was going to say "this commit log should explain > > why/when this option is used", but then figured it might be explained in > > the Kconfig ... but I couldn't find it. ;) > > It's in lib/Kconfig.debug. But yes, I will add a commit message in v4. Oh duh -- it's an existing option. Cool; I'm all good. :) -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel