* [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.
@ 2019-11-01 11:40 ` Mao Wenan
0 siblings, 0 replies; 8+ messages in thread
From: Mao Wenan @ 2019-11-01 11:40 UTC (permalink / raw)
To: bfields, chuck.lever, trond.myklebust, dros, jeff.layton, richard.sharpe
Cc: linux-nfs, linux-kernel, kernel-janitors, Mao Wenan
The declarations were introduced with the file, but the declared
variables were not used.
Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
fs/nfsd/filecache.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
index ef55e9b..32a9bf2 100644
--- a/fs/nfsd/filecache.c
+++ b/fs/nfsd/filecache.c
@@ -685,8 +685,6 @@ nfsd_file_cache_purge(struct net *net)
void
nfsd_file_cache_shutdown(void)
{
- LIST_HEAD(dispose);
-
set_bit(NFSD_FILE_SHUTDOWN, &nfsd_file_lru_flags);
lease_unregister_notifier(&nfsd_file_lease_notifier);
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.
@ 2019-11-01 11:40 ` Mao Wenan
0 siblings, 0 replies; 8+ messages in thread
From: Mao Wenan @ 2019-11-01 11:40 UTC (permalink / raw)
To: bfields, chuck.lever, trond.myklebust, dros, jeff.layton, richard.sharpe
Cc: linux-nfs, linux-kernel, kernel-janitors, Mao Wenan
The declarations were introduced with the file, but the declared
variables were not used.
Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
fs/nfsd/filecache.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
index ef55e9b..32a9bf2 100644
--- a/fs/nfsd/filecache.c
+++ b/fs/nfsd/filecache.c
@@ -685,8 +685,6 @@ nfsd_file_cache_purge(struct net *net)
void
nfsd_file_cache_shutdown(void)
{
- LIST_HEAD(dispose);
-
set_bit(NFSD_FILE_SHUTDOWN, &nfsd_file_lru_flags);
lease_unregister_notifier(&nfsd_file_lease_notifier);
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.
2019-11-01 11:40 ` Mao Wenan
@ 2019-11-01 13:36 ` Chuck Lever
-1 siblings, 0 replies; 8+ messages in thread
From: Chuck Lever @ 2019-11-01 13:36 UTC (permalink / raw)
To: Mao Wenan
Cc: Bruce Fields, Trond Myklebust, Dros Adamson, jeff.layton,
richard.sharpe, Linux NFS Mailing List, linux-kernel,
kernel-janitors
Hi Mao-
> On Nov 1, 2019, at 7:40 AM, Mao Wenan <maowenan@huawei.com> wrote:
>
> The declarations were introduced with the file, but the declared
> variables were not used.
>
> Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
I'm not sure a Fixes: tag is necessary here? 65294c1f2c5e
works fine without this change, and it's not something we
would need to backport into stable kernels.
This is more of a clean up patch.
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> fs/nfsd/filecache.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index ef55e9b..32a9bf2 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -685,8 +685,6 @@ nfsd_file_cache_purge(struct net *net)
> void
> nfsd_file_cache_shutdown(void)
> {
> - LIST_HEAD(dispose);
> -
> set_bit(NFSD_FILE_SHUTDOWN, &nfsd_file_lru_flags);
>
> lease_unregister_notifier(&nfsd_file_lease_notifier);
> --
> 2.7.4
>
--
Chuck Lever
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.
@ 2019-11-01 13:36 ` Chuck Lever
0 siblings, 0 replies; 8+ messages in thread
From: Chuck Lever @ 2019-11-01 13:36 UTC (permalink / raw)
To: Mao Wenan
Cc: Bruce Fields, Trond Myklebust, Dros Adamson, jeff.layton,
richard.sharpe, Linux NFS Mailing List, linux-kernel,
kernel-janitors
Hi Mao-
> On Nov 1, 2019, at 7:40 AM, Mao Wenan <maowenan@huawei.com> wrote:
>
> The declarations were introduced with the file, but the declared
> variables were not used.
>
> Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
I'm not sure a Fixes: tag is necessary here? 65294c1f2c5e
works fine without this change, and it's not something we
would need to backport into stable kernels.
This is more of a clean up patch.
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> fs/nfsd/filecache.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index ef55e9b..32a9bf2 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -685,8 +685,6 @@ nfsd_file_cache_purge(struct net *net)
> void
> nfsd_file_cache_shutdown(void)
> {
> - LIST_HEAD(dispose);
> -
> set_bit(NFSD_FILE_SHUTDOWN, &nfsd_file_lru_flags);
>
> lease_unregister_notifier(&nfsd_file_lease_notifier);
> --
> 2.7.4
>
--
Chuck Lever
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.
2019-11-01 13:36 ` Chuck Lever
@ 2019-11-01 14:49 ` Dan Carpenter
-1 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2019-11-01 14:49 UTC (permalink / raw)
To: Chuck Lever
Cc: Mao Wenan, Bruce Fields, Trond Myklebust, Dros Adamson,
jeff.layton, richard.sharpe, Linux NFS Mailing List,
linux-kernel, kernel-janitors
On Fri, Nov 01, 2019 at 09:36:27AM -0400, Chuck Lever wrote:
> Hi Mao-
>
> > On Nov 1, 2019, at 7:40 AM, Mao Wenan <maowenan@huawei.com> wrote:
> >
> > The declarations were introduced with the file, but the declared
> > variables were not used.
> >
> > Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
>
> I'm not sure a Fixes: tag is necessary here? 65294c1f2c5e
> works fine without this change, and it's not something we
> would need to backport into stable kernels.
>
> This is more of a clean up patch.
>
Fixes is not really related to backports or stable. I would agree that
this isn't a bug but just a cleanup, but the problem is that other
people want Fixes tags for everything...
Yesterday I sent a cleanup patch and I almost put the Fixes tag under
the --- cut off but in the end I just deleted it... It's hard to know
what the right thing is.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.
@ 2019-11-01 14:49 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2019-11-01 14:49 UTC (permalink / raw)
To: Chuck Lever
Cc: Mao Wenan, Bruce Fields, Trond Myklebust, Dros Adamson,
jeff.layton, richard.sharpe, Linux NFS Mailing List,
linux-kernel, kernel-janitors
On Fri, Nov 01, 2019 at 09:36:27AM -0400, Chuck Lever wrote:
> Hi Mao-
>
> > On Nov 1, 2019, at 7:40 AM, Mao Wenan <maowenan@huawei.com> wrote:
> >
> > The declarations were introduced with the file, but the declared
> > variables were not used.
> >
> > Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
>
> I'm not sure a Fixes: tag is necessary here? 65294c1f2c5e
> works fine without this change, and it's not something we
> would need to backport into stable kernels.
>
> This is more of a clean up patch.
>
Fixes is not really related to backports or stable. I would agree that
this isn't a bug but just a cleanup, but the problem is that other
people want Fixes tags for everything...
Yesterday I sent a cleanup patch and I almost put the Fixes tag under
the --- cut off but in the end I just deleted it... It's hard to know
what the right thing is.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.
2019-11-01 14:49 ` Dan Carpenter
@ 2019-11-01 15:51 ` J. Bruce Fields
-1 siblings, 0 replies; 8+ messages in thread
From: J. Bruce Fields @ 2019-11-01 15:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Chuck Lever, Mao Wenan, Trond Myklebust, Dros Adamson,
jeff.layton, richard.sharpe, Linux NFS Mailing List,
linux-kernel, kernel-janitors
On Fri, Nov 01, 2019 at 05:49:21PM +0300, Dan Carpenter wrote:
> On Fri, Nov 01, 2019 at 09:36:27AM -0400, Chuck Lever wrote:
> > > On Nov 1, 2019, at 7:40 AM, Mao Wenan <maowenan@huawei.com> wrote:
> > >
> > > The declarations were introduced with the file, but the declared
> > > variables were not used.
> > >
> > > Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
Thanks, applying for 5.5.
> > I'm not sure a Fixes: tag is necessary here? 65294c1f2c5e
> > works fine without this change, and it's not something we
> > would need to backport into stable kernels.
> >
> > This is more of a clean up patch.
> >
>
> Fixes is not really related to backports or stable. I would agree that
> this isn't a bug but just a cleanup, but the problem is that other
> people want Fixes tags for everything...
>
> Yesterday I sent a cleanup patch and I almost put the Fixes tag under
> the --- cut off but in the end I just deleted it... It's hard to know
> what the right thing is.
It doesn't have a stable cc and it's pretty obvious cleanup, so I guess
there's no harm in it.
I could go either way. But I'll leave the patch as is unless someone
comes up with a clear policy.
--b.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.
@ 2019-11-01 15:51 ` J. Bruce Fields
0 siblings, 0 replies; 8+ messages in thread
From: J. Bruce Fields @ 2019-11-01 15:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Chuck Lever, Mao Wenan, Trond Myklebust, Dros Adamson,
jeff.layton, richard.sharpe, Linux NFS Mailing List,
linux-kernel, kernel-janitors
On Fri, Nov 01, 2019 at 05:49:21PM +0300, Dan Carpenter wrote:
> On Fri, Nov 01, 2019 at 09:36:27AM -0400, Chuck Lever wrote:
> > > On Nov 1, 2019, at 7:40 AM, Mao Wenan <maowenan@huawei.com> wrote:
> > >
> > > The declarations were introduced with the file, but the declared
> > > variables were not used.
> > >
> > > Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
Thanks, applying for 5.5.
> > I'm not sure a Fixes: tag is necessary here? 65294c1f2c5e
> > works fine without this change, and it's not something we
> > would need to backport into stable kernels.
> >
> > This is more of a clean up patch.
> >
>
> Fixes is not really related to backports or stable. I would agree that
> this isn't a bug but just a cleanup, but the problem is that other
> people want Fixes tags for everything...
>
> Yesterday I sent a cleanup patch and I almost put the Fixes tag under
> the --- cut off but in the end I just deleted it... It's hard to know
> what the right thing is.
It doesn't have a stable cc and it's pretty obvious cleanup, so I guess
there's no harm in it.
I could go either way. But I'll leave the patch as is unless someone
comes up with a clear policy.
--b.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-11-01 15:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-01 11:40 [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used Mao Wenan
2019-11-01 11:40 ` Mao Wenan
2019-11-01 13:36 ` Chuck Lever
2019-11-01 13:36 ` Chuck Lever
2019-11-01 14:49 ` Dan Carpenter
2019-11-01 14:49 ` Dan Carpenter
2019-11-01 15:51 ` J. Bruce Fields
2019-11-01 15:51 ` J. Bruce Fields
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.