From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97E3CA9ECF for ; Fri, 1 Nov 2019 19:20:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A57F221855 for ; Fri, 1 Nov 2019 19:20:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="kA4XkYgh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727551AbfKATUC (ORCPT ); Fri, 1 Nov 2019 15:20:02 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:33744 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727473AbfKATUB (ORCPT ); Fri, 1 Nov 2019 15:20:01 -0400 Received: by mail-qk1-f194.google.com with SMTP id 71so11758468qkl.0 for ; Fri, 01 Nov 2019 12:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GwL3BzOKq0ds1hKB7ElDSudCiv4GvOB/hy58iKY5/B8=; b=kA4XkYghuc1JhsLIKqtgHvYOYkbQmmO6SYAQeEOYSvqnxdZ9jZjDhUnlYr3SdULzs/ VoX2uPnnM2cxYanlj78zNtQ8A185ZcJgnYIuK+wcaBJKUjnadFHxwWHFnNobP8aT09Cn HnhVwCqE58/HmHF5+ja6RFYUyhDE8o8qki7WdccEAWeGPWKB8fIH17+S7MdnxhZ3jZwr y9zYt4pe9WYFRB7vGaJ1TV38vnomkwp60DMN7hZ5n6Ba4axjFUG3uuRMMSdF/nELroE0 XD1ENSPS4tRu1keLPM7zbG3a+3hiST+P1cHzfwyt+Rx8K72rUFTYxupuLkm6utoV1HB1 nhHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GwL3BzOKq0ds1hKB7ElDSudCiv4GvOB/hy58iKY5/B8=; b=muSVJgIVB3L+V3CQuMEVjIHSpcTRmaclq4Fg1SDE4KatD3pdj5ooCR9U2GZvFWASsU YmLchOYzDtmUngCV6zsQDZvi+1IOk6VZDGIBvxuvTvyyMYYJaVilv7aiIhxbsuQisIYx cYFOxFJ4Kcwqmo+5QdE/unsP0ZZ1w+iPKIB2/QA6IaR36D9LUy/RxiQMhmi2gzF43e4r dV6U2kwfVjT+6ojTcpSPm/BIrMwOJSY9qYzDM6q37eMUc1nnDoII7c3kvuAqnAps/0Lo p7NnqI3q1S1ZhV6c+FQDa/0PgoNh8m+UD77CTsK11R6gcelmXXtyWGehNQ6Z/svzrFFe 0pQQ== X-Gm-Message-State: APjAAAVzmD6/PZc/FPh0j6YgUEzYvQgNxO2Ypqi8cwYI1Xwfw2PMgE3d B5vqpQOsIfga0Rh6ScYn5jzliA== X-Google-Smtp-Source: APXvYqzEDkQfD72DvPVzNHUDGv0HzF9IhjVJJOU3fqLQvuuBBx1c6gvz8fC1Pmu9FXNbHzO5K/kLfA== X-Received: by 2002:a37:a5d3:: with SMTP id o202mr11070822qke.283.1572636000661; Fri, 01 Nov 2019 12:20:00 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id n20sm4777802qkn.118.2019.11.01.12.19.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Nov 2019 12:19:59 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iQcSl-0001WJ-Af; Fri, 01 Nov 2019 16:19:59 -0300 Date: Fri, 1 Nov 2019 16:19:59 -0300 From: Jason Gunthorpe To: "Yang, Philip" Cc: "linux-mm@kvack.org" , "linux-rdma@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "Deucher, Alexander" , "Koenig, Christian" Subject: Re: [PATCH v2 14/15] drm/amdgpu: Use mmu_range_notifier instead of hmm_mirror Message-ID: <20191101191959.GC30938@ziepe.ca> References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-15-jgg@ziepe.ca> <20191029192544.GU22766@mellanox.com> <30b2f569-bf7a-5166-c98d-4a4a13d1351f@amd.com> <20191101151222.GN22766@mellanox.com> <8280fb65-a897-3d71-79f9-9f80d9e474e9@amd.com> <20191101174221.GO22766@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191101174221.GO22766@mellanox.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Nov 01, 2019 at 02:42:21PM -0300, Jason Gunthorpe wrote: > On Fri, Nov 01, 2019 at 03:59:26PM +0000, Yang, Philip wrote: > > > This test for range_blockable should be before mutex_lock, I can move > > > it up > > > > > yes, thanks. > > Okay, I wrote it like this: > > if (mmu_notifier_range_blockable(range)) > mutex_lock(&adev->notifier_lock); > else if (!mutex_trylock(&adev->notifier_lock)) > return false; Never mind, this routine sleeps for other reasons it should just be as it was: if (!mmu_notifier_range_blockable(range)) return false; mutex_lock(&adev->notifier_lock); Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 14/15] drm/amdgpu: Use mmu_range_notifier instead of hmm_mirror Date: Fri, 1 Nov 2019 16:19:59 -0300 Message-ID: <20191101191959.GC30938@ziepe.ca> References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-15-jgg@ziepe.ca> <20191029192544.GU22766@mellanox.com> <30b2f569-bf7a-5166-c98d-4a4a13d1351f@amd.com> <20191101151222.GN22766@mellanox.com> <8280fb65-a897-3d71-79f9-9f80d9e474e9@amd.com> <20191101174221.GO22766@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DDB46E2C8 for ; Fri, 1 Nov 2019 19:20:01 +0000 (UTC) Received: by mail-qk1-x742.google.com with SMTP id 15so11716215qkh.6 for ; Fri, 01 Nov 2019 12:20:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191101174221.GO22766@mellanox.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Yang, Philip" Cc: "linux-rdma@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "amd-gfx@lists.freedesktop.org" , "Deucher, Alexander" , "Koenig, Christian" List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBOb3YgMDEsIDIwMTkgYXQgMDI6NDI6MjFQTSAtMDMwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IE9uIEZyaSwgTm92IDAxLCAyMDE5IGF0IDAzOjU5OjI2UE0gKzAwMDAsIFlhbmcs IFBoaWxpcCB3cm90ZToKPiA+ID4gVGhpcyB0ZXN0IGZvciByYW5nZV9ibG9ja2FibGUgc2hvdWxk IGJlIGJlZm9yZSBtdXRleF9sb2NrLCBJIGNhbiBtb3ZlCj4gPiA+IGl0IHVwCj4gPiA+IAo+ID4g eWVzLCB0aGFua3MuCj4gCj4gT2theSwgSSB3cm90ZSBpdCBsaWtlIHRoaXM6Cj4gCj4gCWlmICht bXVfbm90aWZpZXJfcmFuZ2VfYmxvY2thYmxlKHJhbmdlKSkKPiAJCW11dGV4X2xvY2soJmFkZXYt Pm5vdGlmaWVyX2xvY2spOwo+IAllbHNlIGlmICghbXV0ZXhfdHJ5bG9jaygmYWRldi0+bm90aWZp ZXJfbG9jaykpCj4gCQlyZXR1cm4gZmFsc2U7CgpOZXZlciBtaW5kLCB0aGlzIHJvdXRpbmUgc2xl ZXBzIGZvciBvdGhlciByZWFzb25zIGl0IHNob3VsZCBqdXN0IGJlIGFzCml0IHdhczoKCglpZiAo IW1tdV9ub3RpZmllcl9yYW5nZV9ibG9ja2FibGUocmFuZ2UpKQoJCXJldHVybiBmYWxzZTsKCglt dXRleF9sb2NrKCZhZGV2LT5ub3RpZmllcl9sb2NrKTsKCkphc29uCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC73CA9EC7 for ; Sat, 2 Nov 2019 15:44:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DBE720663 for ; Sat, 2 Nov 2019 15:44:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DBE720663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C91006E4CB; Sat, 2 Nov 2019 15:44:04 +0000 (UTC) Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2B4D6E2DA for ; Fri, 1 Nov 2019 19:20:01 +0000 (UTC) Received: by mail-qk1-x743.google.com with SMTP id a194so11686357qkg.10 for ; Fri, 01 Nov 2019 12:20:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GwL3BzOKq0ds1hKB7ElDSudCiv4GvOB/hy58iKY5/B8=; b=HDxA62XfZKrT8DhnrdCIEdr6388ur8rHCm9nRiICC8xHbqHKZjkUYHuCmqtJ2UP2tz BcIInk3O6cGh+OnqJ/0lZOba6v0CyNwJBEOF3EJ093aHhSKdkYVagFUccB2mry2uJGUT npv7oEsTVqLBIuaC5MTEc0l+o9M0b9PJ+b7WUBKh15ULftMfk7rrAokW1dohJD3UW9GM Ki85ZA9HIhDGkTHYdPJi6o3V+XpQGrkH/NhACQ9f4Sa/NdhjJBAPHulDEgWv28nAEloC TDD9wy2EQTdFaL40DuDoe3kyScTVrNrNsVmMCW+fEzo2kWLFvD6peujDXGb894TE4LWd z1lw== X-Gm-Message-State: APjAAAWsrX3gU+e6xBbP9VusIRcn3GYduhOeFJbxuWA4YYcLLyxV14lY ES9Zq/Lrt5b94LBNhUOYBRETnw== X-Google-Smtp-Source: APXvYqzEDkQfD72DvPVzNHUDGv0HzF9IhjVJJOU3fqLQvuuBBx1c6gvz8fC1Pmu9FXNbHzO5K/kLfA== X-Received: by 2002:a37:a5d3:: with SMTP id o202mr11070822qke.283.1572636000661; Fri, 01 Nov 2019 12:20:00 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id n20sm4777802qkn.118.2019.11.01.12.19.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Nov 2019 12:19:59 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iQcSl-0001WJ-Af; Fri, 01 Nov 2019 16:19:59 -0300 Date: Fri, 1 Nov 2019 16:19:59 -0300 From: Jason Gunthorpe To: "Yang, Philip" Subject: Re: [PATCH v2 14/15] drm/amdgpu: Use mmu_range_notifier instead of hmm_mirror Message-ID: <20191101191959.GC30938@ziepe.ca> References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-15-jgg@ziepe.ca> <20191029192544.GU22766@mellanox.com> <30b2f569-bf7a-5166-c98d-4a4a13d1351f@amd.com> <20191101151222.GN22766@mellanox.com> <8280fb65-a897-3d71-79f9-9f80d9e474e9@amd.com> <20191101174221.GO22766@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191101174221.GO22766@mellanox.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Sat, 02 Nov 2019 15:44:01 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GwL3BzOKq0ds1hKB7ElDSudCiv4GvOB/hy58iKY5/B8=; b=kA4XkYghuc1JhsLIKqtgHvYOYkbQmmO6SYAQeEOYSvqnxdZ9jZjDhUnlYr3SdULzs/ VoX2uPnnM2cxYanlj78zNtQ8A185ZcJgnYIuK+wcaBJKUjnadFHxwWHFnNobP8aT09Cn HnhVwCqE58/HmHF5+ja6RFYUyhDE8o8qki7WdccEAWeGPWKB8fIH17+S7MdnxhZ3jZwr y9zYt4pe9WYFRB7vGaJ1TV38vnomkwp60DMN7hZ5n6Ba4axjFUG3uuRMMSdF/nELroE0 XD1ENSPS4tRu1keLPM7zbG3a+3hiST+P1cHzfwyt+Rx8K72rUFTYxupuLkm6utoV1HB1 nhHA== X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-rdma@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "amd-gfx@lists.freedesktop.org" , "Deucher, Alexander" , "Koenig, Christian" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Message-ID: <20191101191959.KzlNVCcr1y91URvza3gNht-ebs8rTu-Utj0hNjIVF6s@z> T24gRnJpLCBOb3YgMDEsIDIwMTkgYXQgMDI6NDI6MjFQTSAtMDMwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IE9uIEZyaSwgTm92IDAxLCAyMDE5IGF0IDAzOjU5OjI2UE0gKzAwMDAsIFlhbmcs IFBoaWxpcCB3cm90ZToKPiA+ID4gVGhpcyB0ZXN0IGZvciByYW5nZV9ibG9ja2FibGUgc2hvdWxk IGJlIGJlZm9yZSBtdXRleF9sb2NrLCBJIGNhbiBtb3ZlCj4gPiA+IGl0IHVwCj4gPiA+IAo+ID4g eWVzLCB0aGFua3MuCj4gCj4gT2theSwgSSB3cm90ZSBpdCBsaWtlIHRoaXM6Cj4gCj4gCWlmICht bXVfbm90aWZpZXJfcmFuZ2VfYmxvY2thYmxlKHJhbmdlKSkKPiAJCW11dGV4X2xvY2soJmFkZXYt Pm5vdGlmaWVyX2xvY2spOwo+IAllbHNlIGlmICghbXV0ZXhfdHJ5bG9jaygmYWRldi0+bm90aWZp ZXJfbG9jaykpCj4gCQlyZXR1cm4gZmFsc2U7CgpOZXZlciBtaW5kLCB0aGlzIHJvdXRpbmUgc2xl ZXBzIGZvciBvdGhlciByZWFzb25zIGl0IHNob3VsZCBqdXN0IGJlIGFzCml0IHdhczoKCglpZiAo IW1tdV9ub3RpZmllcl9yYW5nZV9ibG9ja2FibGUocmFuZ2UpKQoJCXJldHVybiBmYWxzZTsKCglt dXRleF9sb2NrKCZhZGV2LT5ub3RpZmllcl9sb2NrKTsKCkphc29uCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vYW1kLWdmeA==