From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F406CA9EC7 for ; Sat, 2 Nov 2019 07:39:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 363B42085B for ; Sat, 2 Nov 2019 07:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572680376; bh=YEAQqDGj7v6sYWQ1kt+iZ4QoTk0LxJxXBQzcvHiakUg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PFRB5Ji4pjhoCcOvZ7od7iSZcQvvCDfKcH/amxkoQZidLc0zcbeauLDdbyKYXTJIs m4djaJAIq1mO+HX0ZQnUuaWiaTDmf2SxAowKgijYRkMVGoR0YaJKdJg+7PkZzaqOpM JFVwhOtOIK81OgaZ4qBqMPgZpjI+nh5GdFDfXIyk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727439AbfKBHjd (ORCPT ); Sat, 2 Nov 2019 03:39:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:48946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbfKBHjd (ORCPT ); Sat, 2 Nov 2019 03:39:33 -0400 Received: from localhost (smb-adpcdg1-02.hotspot.hub-one.net [213.174.99.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2844B2085B; Sat, 2 Nov 2019 07:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572680372; bh=YEAQqDGj7v6sYWQ1kt+iZ4QoTk0LxJxXBQzcvHiakUg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wTwraJcZhlgLkIKU0xVKzoIGr3OTqmQx+Sooqe0c1+rspsrVG2ES4pZih8I87f3s9 dFBPufPHU8T24popkM3cGEZQ8AqtHhEBw57rBVWAR/ygXyOg3knxX6P+2SGve0kICT ILmciY53u/rmf1HUQvDKyzKaNOSvXWOdV8zgqnrc= Date: Sat, 2 Nov 2019 03:39:30 -0400 From: Sasha Levin To: Joe Perches Cc: Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Greg KH , akpm@linux-foundation.org, Denis Kirjanov , Like Xu , Paolo Bonzini Subject: Re: [PATCH 3.16 47/47] KVM: x86/vPMU: refine kvm_pmu err msg when event creation failed Message-ID: <20191102073930.GZ1554@sasha-vm> References: <220d8f2c1b299d2e71fdcf50b98286aae5b0c6f2.camel@perches.com> <05be6a70382f1990a2ba6aba9ac75dac0c55f7fb.camel@decadent.org.uk> <3078d0a186cca2dfae741908ffff41f1bdb30eae.camel@perches.com> <20191101080745.GT1554@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 01, 2019 at 08:40:23AM -0700, Joe Perches wrote: >On Fri, 2019-11-01 at 04:07 -0400, Sasha Levin wrote: >> On Thu, Oct 31, 2019 at 03:53:23PM -0700, Joe Perches wrote: >> > On Thu, 2019-10-31 at 22:14 +0000, Ben Hutchings wrote: >> > > On Fri, 2019-10-25 at 12:05 -0700, Joe Perches wrote: >> > > > On Fri, 2019-10-25 at 19:03 +0100, Ben Hutchings wrote: >> > > > > 3.16.76-rc1 review patch. If anyone has any objections, please let me know. >> > > > >> > > > This seems more like an enhancement than a bug fix. >> > > > >> > > > Is this really the type of patch that is appropriate >> > > > for stable? >> > > >> > > Apparently so: >> > > >> > > v4.14.135: eba797dbf352 KVM: x86/vPMU: refine kvm_pmu err msg when event creation failed >> > > v4.19.61: ba27a25df6df KVM: x86/vPMU: refine kvm_pmu err msg when event creation failed >> > > v4.4.187: 505c011f9f53 KVM: x86/vPMU: refine kvm_pmu err msg when event creation failed >> > > v4.9.187: 3984eae04473 KVM: x86/vPMU: refine kvm_pmu err msg when event creation failed >> > > v5.1.20: edadec197fbf KVM: x86/vPMU: refine kvm_pmu err msg when event creation failed >> > > v5.2.3: 9f062aef7356 KVM: x86/vPMU: refine kvm_pmu err msg when event creation failed >> > >> > I think not, but hey, maybe you and Greg do. >> > >> > Porting enhancements, even trivial ones, imo is >> > not a great thing for stable branches. >> > >> > My perspective is that only bug fixes should be >> > applied to stable branches. >> >> Usability issues are just as bad as code bugs. Our human interface is at >> least as important as the functionality of our code. > >Umm. > >#define DEBUG is not set here. > >Changing from printk_once to pr_debug_ratelimited completely >eliminates the output from non CONFIG_DYNAMIC_DEBUG configs, >and this output message is not enabled by default either. Maybe I'm missing something, but Paolo explained why: it was a useless debug feature because it used to print once early on but not when it's actually needed. Now it's actually useful for users who want to debug but it won't flood regular users who are not inteterested in it. -- Thanks, Sasha