All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: [PATCH 3/8] mtk-vpu: fix two smatch warnings
Date: Sun,  3 Nov 2019 12:23:33 +0100	[thread overview]
Message-ID: <20191103112338.22569-4-hverkuil-cisco@xs4all.nl> (raw)
In-Reply-To: <20191103112338.22569-1-hverkuil-cisco@xs4all.nl>

Drop the "id >= 0" test in two conditions to fix these warnings:

drivers/media/platform/mtk-vpu/mtk_vpu.c:276 vpu_ipi_register() warn: always true condition '(id >= 0) => (0-u32max >= 0)'
drivers/media/platform/mtk-vpu/mtk_vpu.c:401 vpu_wdt_reg_handler() warn: always true condition '(id >= 0) => (0-u32max >= 0)'

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
 drivers/media/platform/mtk-vpu/mtk_vpu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c
index cc2ff40d060d..a768707abb94 100644
--- a/drivers/media/platform/mtk-vpu/mtk_vpu.c
+++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c
@@ -273,7 +273,7 @@ int vpu_ipi_register(struct platform_device *pdev,
 		return -EPROBE_DEFER;
 	}
 
-	if (id >= 0 && id < IPI_MAX && handler) {
+	if (id < IPI_MAX && handler) {
 		ipi_desc = vpu->ipi_desc;
 		ipi_desc[id].name = name;
 		ipi_desc[id].handler = handler;
@@ -398,7 +398,7 @@ int vpu_wdt_reg_handler(struct platform_device *pdev,
 
 	handler = vpu->wdt.handler;
 
-	if (id >= 0 && id < VPU_RST_MAX && wdt_reset) {
+	if (id < VPU_RST_MAX && wdt_reset) {
 		dev_dbg(vpu->dev, "wdt register id %d\n", id);
 		mutex_lock(&vpu->vpu_mutex);
 		handler[id].reset_func = wdt_reset;
-- 
2.23.0


  parent reply	other threads:[~2019-11-03 11:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-03 11:23 [PATCH 0/8] Fix various smatch warnings/errors Hans Verkuil
2019-11-03 11:23 ` [PATCH 1/8] am437x: fix smatch warning Hans Verkuil
2019-11-04 17:40   ` Benoit Parrot
2019-11-03 11:23 ` [PATCH 2/8] smiapp: smiapp_start_streaming(): replace return by goto Hans Verkuil
2019-11-04  8:12   ` Sakari Ailus
2019-11-04  8:17     ` Hans Verkuil
2019-11-03 11:23 ` Hans Verkuil [this message]
2019-11-03 11:23 ` [PATCH 4/8] rc/ite-cir: fix smatch warning Hans Verkuil
2019-11-03 22:02   ` Sean Young
2019-11-03 11:23 ` [PATCH 5/8] em28xx: fix two smatch warnings Hans Verkuil
2019-11-03 11:23 ` [PATCH 6/8] ti-vpe: fix smatch error Hans Verkuil
2019-11-04 17:40   ` Benoit Parrot
2019-11-03 11:23 ` [PATCH 7/8] ov6650: fix smatch warning Hans Verkuil
2019-11-04  8:13   ` Sakari Ailus
2019-11-03 11:23 ` [PATCH 8/8] mantis: fix two smatch errors Hans Verkuil
2019-11-03 14:01 ` [PATCH 9/8] vivid: add vivid_create_queue() helper Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191103112338.22569-4-hverkuil-cisco@xs4all.nl \
    --to=hverkuil-cisco@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.