From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4505CA9ED3 for ; Tue, 5 Nov 2019 01:32:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEA8820717 for ; Tue, 5 Nov 2019 01:32:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730164AbfKEBc3 (ORCPT ); Mon, 4 Nov 2019 20:32:29 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:54724 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728987AbfKEBc3 (ORCPT ); Mon, 4 Nov 2019 20:32:29 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EF3DC15252E0F; Mon, 4 Nov 2019 17:32:28 -0800 (PST) Date: Mon, 04 Nov 2019 17:32:26 -0800 (PST) Message-Id: <20191104.173226.388214102826562799.davem@davemloft.net> To: fugang.duan@nxp.com Cc: hslester96@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [EXT] Re: [PATCH] net: fec: add missed clk_disable_unprepare in remove From: David Miller In-Reply-To: References: <20191104155000.8993-1-hslester96@gmail.com> <20191104.113601.407489006150341765.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 Nov 2019 17:32:29 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Duan Date: Tue, 5 Nov 2019 01:27:10 +0000 > From: David Miller Sent: Tuesday, November 5, 2019 3:36 AM >> From: Chuhong Yuan >> Date: Mon, 4 Nov 2019 23:50:00 +0800 >> >> > This driver forgets to disable and unprepare clks when remove. >> > Add calls to clk_disable_unprepare to fix it. >> > >> > Signed-off-by: Chuhong Yuan >> >> Applied. > > David, the patch introduces clock count mismatch issue, please drop it. Please send me a revert, I'm backlogged at the moment. Thanks.