All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	Bamvor Jian Zhang <bamv2005@gmail.com>,
	Drew Fustini <drew@pdp7.com>
Subject: Re: [PATCH v4 0/5] gpio: expose line bias flags to userspace
Date: Mon, 4 Nov 2019 09:07:36 +0800	[thread overview]
Message-ID: <20191104010736.GA9134@sol> (raw)
In-Reply-To: <CACRpkdayzONkSnHr+C7e2NVrDP7_Di+PTK6MtM0Kx_Mte+=2Cg@mail.gmail.com>

On Mon, Nov 04, 2019 at 01:26:54AM +0100, Linus Walleij wrote:
> On Thu, Oct 31, 2019 at 8:10 AM Bartosz Golaszewski
> <bgolaszewski@baylibre.com> wrote:
> 
> > [Kent]
> > > This series adds gross control of pull-up/pull-down to the GPIO uAPI.
> > > Gross control means enabling and disabling of bias functionality,
> > > not finer grained control such as setting biasing impedances.
> 
> Right, excellent and persistent work here, much appreciated!
> 

No problem - hopefully I haven't irritated too many people in the process.

> As long as I get Bartosz's blanket ACK on v5 I think it is ready
> to merge. His consent is required for this.
> 

I'm still waiting on open questions from v4 before submitting v5:

One, handling of errors when setting bias, Bart has referred to Thomas, 
so waiting for feedback on that.

The other, where gpio_set_bias is hooked into gpiod_direction_output,
is fine as is for the UAPI - it can always be relocated subsequently if 
other APIs need to set bias.  On the other hand, if decoupling setting 
direction and bias is in order then that really should be done now.
Can I get an an ACK on that either way?

I've also made a couple of minor changes myself while reviewing v4 - 
reordering the patches to group the gpiolib.c ones and leaving the 
gpio-mockup til last, and removing the "bias requires input mode" check 
from lineevent_create as the line is assumed to be input for events 
regardless of the input flag - there is no such thing as as-is for
event requests.
Only mentioning here in case such changes are clearly wrong...

Cheers,
Kent.

> It looks pretty much as I imagined it when I discussed it with
> Drew some while back, with some gritty details fixed up.
> 
> Yours,
> Linus Walleij

  reply	other threads:[~2019-11-04  1:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28  7:37 [PATCH v4 0/5] gpio: expose line bias flags to userspace Kent Gibson
2019-10-28  7:37 ` [PATCH v4 1/5] gpio: expose pull-up/pull-down line " Kent Gibson
2019-10-28  7:37 ` [PATCH v4 2/5] gpiolib: add support for pull up/down to lineevent_create Kent Gibson
2019-10-31  7:11   ` Bartosz Golaszewski
2019-10-31  7:24     ` Kent Gibson
2019-10-28  7:37 ` [PATCH v4 3/5] gpio: mockup: add set_config to support pull up/down Kent Gibson
2019-10-28  7:37 ` [PATCH v4 4/5] gpiolib: add support for disabling line bias Kent Gibson
2019-10-28  7:37 ` [PATCH v4 5/5] gpiolib: add support for biasing output lines Kent Gibson
2019-10-31  7:10 ` [PATCH v4 0/5] gpio: expose line bias flags to userspace Bartosz Golaszewski
2019-11-04  0:26   ` Linus Walleij
2019-11-04  1:07     ` Kent Gibson [this message]
2019-11-04 10:14       ` Bartosz Golaszewski
2019-11-04 11:11         ` Kent Gibson
2019-11-04 11:48           ` Bartosz Golaszewski
2019-11-04 14:22             ` Kent Gibson
2019-11-04 15:20               ` Bartosz Golaszewski
2019-11-04 15:35                 ` Kent Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191104010736.GA9134@sol \
    --to=warthog618@gmail.com \
    --cc=bamv2005@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=drew@pdp7.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.