Coverity: meson_allocate_chanlist(): Uninitialized variables

Coverity: meson_allocate_chanlist(): Uninitialized variables

[coverity-bot]

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")

Coverity reported the following:

*** CID 1487398:  Uninitialized variables  (UNINIT)
/drivers/crypto/amlogic/amlogic-gxl-core.c: 184 in meson_allocate_chanlist()
178     			goto error_engine;
179     		}
180     	}
181     	return 0;
182     error_engine:
183     	meson_free_chanlist(mc, i);
vvv     CID 1487398:  Uninitialized variables  (UNINIT)
vvv     Using uninitialized value "err".
184     	return err;
185     }
186
187     static int meson_register_algs(struct meson_dev *mc)
188     {
189     	int err, i;

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487398 ("Uninitialized variables")
Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")


Thanks for your attention!

-- 
Coverity-bot

Re: Coverity: meson_allocate_chanlist(): Uninitialized variables

[LABBE Corentin]

On Mon, Nov 04, 2019 at 09:39:49AM -0800, coverity-bot wrote:
> Hello!
> 
> This is an experimental automated report about issues detected by Coverity
> from a scan of next-20191031 as part of the linux-next weekly scan project:
> https://scan.coverity.com/projects/linux-next-weekly-scan
> 
> You're getting this email because you were associated with the identified
> lines of code (noted below) that were touched by recent commits:
> 
> 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
> 
> Coverity reported the following:
> 
> *** CID 1487398:  Uninitialized variables  (UNINIT)
> /drivers/crypto/amlogic/amlogic-gxl-core.c: 184 in meson_allocate_chanlist()
> 178     			goto error_engine;
> 179     		}
> 180     	}
> 181     	return 0;
> 182     error_engine:
> 183     	meson_free_chanlist(mc, i);
> vvv     CID 1487398:  Uninitialized variables  (UNINIT)
> vvv     Using uninitialized value "err".
> 184     	return err;
> 185     }
> 186
> 187     static int meson_register_algs(struct meson_dev *mc)
> 188     {
> 189     	int err, i;
> 
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include these lines (but double-check the "Fixes" first):
> 
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1487398 ("Uninitialized variables")
> Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
> 
> 
> Thanks for your attention!

Hello

A patch was already posted for this issue ("[PATCH][next] crypto: amlogic: ensure error variable err is set before returning it")

Regards

Re: Coverity: meson_allocate_chanlist(): Uninitialized variables

[Kees Cook]

On Tue, Nov 05, 2019 at 08:16:44PM +0100, LABBE Corentin wrote:
> On Mon, Nov 04, 2019 at 09:39:49AM -0800, coverity-bot wrote:
> > Hello!
> > 
> > This is an experimental automated report about issues detected by Coverity
> > from a scan of next-20191031 as part of the linux-next weekly scan project:
> > https://scan.coverity.com/projects/linux-next-weekly-scan
> > 
> > You're getting this email because you were associated with the identified
> > lines of code (noted below) that were touched by recent commits:
> > 
> > 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
> > 
> > Coverity reported the following:
> > 
> > *** CID 1487398:  Uninitialized variables  (UNINIT)
> > /drivers/crypto/amlogic/amlogic-gxl-core.c: 184 in meson_allocate_chanlist()
> > 178     			goto error_engine;
> > 179     		}
> > 180     	}
> > 181     	return 0;
> > 182     error_engine:
> > 183     	meson_free_chanlist(mc, i);
> > vvv     CID 1487398:  Uninitialized variables  (UNINIT)
> > vvv     Using uninitialized value "err".
> > 184     	return err;
> > 185     }
> > 186
> > 187     static int meson_register_algs(struct meson_dev *mc)
> > 188     {
> > 189     	int err, i;
> > 
> > If this is a false positive, please let us know so we can mark it as
> > such, or teach the Coverity rules to be smarter. If not, please make
> > sure fixes get into linux-next. :) For patches fixing this, please
> > include these lines (but double-check the "Fixes" first):
> > 
> > Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> > Addresses-Coverity-ID: 1487398 ("Uninitialized variables")
> > Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL")
> > 
> > 
> > Thanks for your attention!
> 
> Hello
> 
> A patch was already posted for this issue ("[PATCH][next] crypto: amlogic: ensure error variable err is set before returning it")

Excellent, thank you! (And for the upcoming patches!)

-- 
Kees Cook