From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iRZZG-0006uG-FR for mharc-grub-devel@gnu.org; Mon, 04 Nov 2019 05:26:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52469) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRZZD-0006rG-4w for grub-devel@gnu.org; Mon, 04 Nov 2019 05:26:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRZZA-0007qb-N9 for grub-devel@gnu.org; Mon, 04 Nov 2019 05:26:33 -0500 Received: from mx0a-00190b01.pphosted.com ([2620:100:9001:583::1]:46290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iRZZA-0007me-6r for grub-devel@gnu.org; Mon, 04 Nov 2019 05:26:32 -0500 Received: from pps.filterd (m0050095.ppops.net [127.0.0.1]) by m0050095.ppops.net-00190b01. (8.16.0.42/8.16.0.42) with SMTP id xA4AI0FL005166; Mon, 4 Nov 2019 10:26:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=jan2016.eng; bh=RuLqMBLX9bNYz/FM44/Nj47h9rNeJuusz87lm7LUnF4=; b=UBdo17mukYRpkDP8rkat+jcNdKYzUJNvvuI4pv0dErQobJ3w25MELdGMU7cbYOhLnyzX 4S6ors0FGL/CIXA5OgbKSDVyuftdbnhrwGmxQM1vnduevJS52mVaaSElxaGIMRLIqQvK FCbd8aksaqbkGrThEU+W9fDFjg2EjUlddxBIliwxHULpmlJyB5dXEE4sWW6R3AIHX2z/ dofoobpg7CId4GF+fKCJxLGYUv6MKySRqP7hcnuVqpxH50cwdN3YWFAI736YxfSR04Lz Dp2Owsmcid5/G7wT5ZpdGKsvWJ7p6Pbtt76eHpvUJN6x/rMcghIF2fIKMi1UEHpyoPVI IQ== Received: from prod-mail-ppoint2 (prod-mail-ppoint2.akamai.com [184.51.33.19] (may be forged)) by m0050095.ppops.net-00190b01. with ESMTP id 2w12788qh0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Nov 2019 10:26:29 +0000 Received: from pps.filterd (prod-mail-ppoint2.akamai.com [127.0.0.1]) by prod-mail-ppoint2.akamai.com (8.16.0.27/8.16.0.27) with SMTP id xA4A7XcS028983; Mon, 4 Nov 2019 05:26:27 -0500 Received: from email.msg.corp.akamai.com ([172.27.123.57]) by prod-mail-ppoint2.akamai.com with ESMTP id 2w154wfna1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 04 Nov 2019 05:26:27 -0500 Received: from usma1ex-cas5.msg.corp.akamai.com (172.27.123.53) by usma1ex-dag1mb6.msg.corp.akamai.com (172.27.123.65) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 4 Nov 2019 05:26:27 -0500 Received: from lon-lp55b.london.corp.akamai.com (172.29.67.77) by usma1ex-cas5.msg.corp.akamai.com (172.27.123.53) with Microsoft SMTP Server id 15.0.1473.3 via Frontend Transport; Mon, 4 Nov 2019 02:26:22 -0800 Received: by lon-lp55b.london.corp.akamai.com (Postfix, from userid 37336) id AB531E00A6; Mon, 4 Nov 2019 10:26:21 +0000 (GMT) Date: Mon, 4 Nov 2019 10:26:21 +0000 From: Max Tottenham To: The development of GNU GRUB CC: Patrick Steinhardt Subject: Re: [PATCH 2/6] jsmn: Add convenience functions Message-ID: <20191104102620.GA923@akamai.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-11-04_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=803 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911040101 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-11-04_07:2019-11-04,2019-11-04 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 suspectscore=0 spamscore=0 mlxscore=0 clxscore=1011 mlxlogscore=793 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1911040101 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 2620:100:9001:583::1 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Nov 2019 10:26:36 -0000 On 11/02, Patrick Steinhardt wrote: > The newly added jsmn library is a really bare-bones library that > focusses on simplicity. Because of that, it is lacking some functions > for convenience to abstract away some of its inner workings and to make > code easier to read. As such, we're now adding some functions that are > going to be used by the LUKS2 implementation later on. > > Signed-off-by: Patrick Steinhardt > --- > include/grub/jsmn.h | 108 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 108 insertions(+) > Would it not make sense to keep the additions in a separate header from the vendored upstream library? That way it'll likely be easier to pull in any updates. -- Max Tottenham | mtottenh@akamai.com Senior Software Engineer, Server Platform Engineering /(* Akamai Technologies