From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iRa8J-0002HK-E0 for mharc-grub-devel@gnu.org; Mon, 04 Nov 2019 06:02:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57478) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRa8G-0002F1-N9 for grub-devel@gnu.org; Mon, 04 Nov 2019 06:02:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRa8F-0006Rh-Mf for grub-devel@gnu.org; Mon, 04 Nov 2019 06:02:48 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:40817) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iRa8F-0006RV-Et for grub-devel@gnu.org; Mon, 04 Nov 2019 06:02:47 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 741535C1; Mon, 4 Nov 2019 06:02:46 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 04 Nov 2019 06:02:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=pU5VUfPsBRchJGTb6lJHWlu1HgU IYUL/R1H9S0RnjWs=; b=NhLMVe6gNgOcLmWO8yQ6+hsdhpeCLQ8qB5p0SgQp3+b okBpLHby5ZnrU3t8EoILDLCovdR8HBZZRXtT2RmPeC4eT+NSs1wbP6eRVHAOyL8i XZ+yJq8xqWm8GbNUHzEwjQnKH4b0kvialS6CFqxRey2WtdYJAGIgctcga0G856z7 IwyYuqsTxf6eHbjYzwp82C8MmE1mx6lOBQKDX/SfSAUNIa7QTuVuUAYy/ixSaki6 7Sg91XrT1JyLQDcjoWofFJGazHT1goSL86+EBz4tUXHVLNzaLPB2IHG0GFaivNn/ P8ip2OoY0DrhouHRTOL7fOUpv6oVPzajspStQuA+P4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=pU5VUf PsBRchJGTb6lJHWlu1HgUIYUL/R1H9S0RnjWs=; b=pc3qHWeXQY2n2D5DIB3bu2 PScLzmx1AReZEhn4QI3C43hyLjizlxaOXFYJ2tiT9LQg4/Nq0iHODDCa0UB04A6V pl25qeOaPBv+cDNzjW+pihhPF3ch0Xm34Rs1FYTo4Z1s0bW1Mle2TyV8ovP+A6Li 37x/sNwe8eCh2uNMmG5TZvTPCcAbdohNSbng1eXxkYkFa3P96yq43fl4B5Myf44w +gvgc5sYObEI/TIG0mFLvffLhuhkzuIyjbAMKCh/duBQnBTaHUCATeNp+awz+JHR hDB8PDP2gRsSKtYrKvoqu9crnyB7i9p0JmOB0XH/Wwsq5weFia8vVaSSsk0k76cQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddufedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucfkphepkeelrdduvd drheelrdegheenucfrrghrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimhenucev lhhushhtvghrufhiiigvpedu X-ME-Proxy: Received: from NSJAIL (x590c3b2d.dyn.telefonica.de [89.12.59.45]) by mail.messagingengine.com (Postfix) with ESMTPA id 29A053060057; Mon, 4 Nov 2019 06:02:45 -0500 (EST) Received: from localhost (10.192.0.11 [10.192.0.11]) by NSJAIL (OpenSMTPD) with ESMTPSA id cf0c6d13 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 4 Nov 2019 11:02:43 +0000 (UTC) Date: Mon, 4 Nov 2019 12:02:42 +0100 From: Patrick Steinhardt To: Max Tottenham Cc: The development of GNU GRUB Subject: Re: [PATCH 3/6] bootstrap: Add gnulib's base64 module Message-ID: <20191104110242.GB2673@ncase> References: <886d2a055eed285759cff7cc9272116a8934f3d3.1572717208.git.ps@pks.im> <20191104103000.GB923@akamai.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EuxKj2iCbKjpUGkD" Content-Disposition: inline In-Reply-To: <20191104103000.GB923@akamai.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.123.19 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Nov 2019 11:02:49 -0000 --EuxKj2iCbKjpUGkD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 04, 2019 at 10:30:01AM +0000, Max Tottenham wrote: > On 11/02, Patrick Steinhardt wrote: [snip] > > --- /dev/null > > +++ b/grub-core/lib/gnulib-patches/fix-base64.patch > > @@ -0,0 +1,26 @@ > > +diff --git a/lib/base64.h b/lib/base64.h > > +index 9cd0183b8..7b06e03df 100644 > > +--- a/lib/base64.h > > ++++ b/lib/base64.h > > +@@ -21,8 +21,10 @@ > > + /* Get size_t. */ > > + # include > > +=20 > > +-/* Get bool. */ > > +-# include > > ++#ifndef GRUB_POSIX_BOOL_DEFINED > > ++typedef enum { false =3D 0, true =3D 1 } bool; > > ++#define GRUB_POSIX_BOOL_DEFINED 1 > > ++#endif > > +=20 > > + # ifdef __cplusplus > > + extern "C" { > > +@@ -38,7 +40,7 @@ struct base64_decode_context > > + char buf[4]; > > + }; > > +=20 > > +-extern bool isbase64 (char ch) _GL_ATTRIBUTE_CONST; > > ++extern bool isbase64 (char ch); >=20 > Is there a reason the const attribute has been removed from this > function in this patch? If so then I think you should add a rationale > for that in your commit message. Fair. I remember that the attribute wasn't defined when it's been included by others, probably due to a missing include. I'll make sure to add some more details to the commit message. Patrick --EuxKj2iCbKjpUGkD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEtmscHsieVjl9VyNUEXxntp6r8SwFAl3ABVIACgkQEXxntp6r 8Sw2yQ//fh6mNFM8RWdbnpcPz/aA5EA1qPdObUADWLIrQ6egCZFbm6wiTwq1xS8k q5My+GTT6+vStPLh8cZ1cTDuLIiW/2liZt/zXiBZvA33ruG4bquOXbtL6RTMuOhL r4KSm7Faw0vWSOy4m/XHTom6/uCpsMoWhu8RyBxqRNY7JV/7weVS318EJmAc/a3M xfUjiqfDXWHe8QXOL6hMxycHxjAM3HRQ04+kTnPbOhMpcVaLsE4ywM6jrBzuKliK 7lXTOM3ai5Z78iOqMGRYtfJVKqgGnT/0jMSqTHEavXXrZhA+ITOsOAuL6Dy6fEhw j8Q0txQ6RrsiX025k0ZcUQeEZwqWbWYjwkohp+Lwk3xOiUJhhV/3soFY4fmNpeim xqCpaxN2InZcXdeltMg/bR7I3nW38xCnYib+PIUJ+ZYr19T9sg+F0K8XMJuZfjkL 65oH3xIL7p+cyFnxZrvscHl5Tjeut6qClzbq9R6812uAWqVARRri1tmKZs4gSA1Q zps9fJj2CsGJNDP/ib8Ip9ui1sFwcEeYR49hoGV9XesnVCo4r+vYjev12aMhg6ni Bjsd6SYV0eWl9ljA/cN+9Sqk9AwpuNZsvRiASnOtx1xy1J7VJNf9xWlUnVUjx5Sw z0zG/L7QmiSHn9Nl1YExBVqojmjcOf6w4omAkmfe8RrDIlFcmjc= =4eeu -----END PGP SIGNATURE----- --EuxKj2iCbKjpUGkD--