From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D37CA9EB5 for ; Mon, 4 Nov 2019 18:19:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1D8920578 for ; Mon, 4 Nov 2019 18:19:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rCPl+46h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729554AbfKDSTX (ORCPT ); Mon, 4 Nov 2019 13:19:23 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:35342 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729496AbfKDSTV (ORCPT ); Mon, 4 Nov 2019 13:19:21 -0500 Received: by mail-wm1-f66.google.com with SMTP id 8so10116591wmo.0; Mon, 04 Nov 2019 10:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=crl/sUJTIYngi8fCHSniOxSSni3lgNa7iQh3Jutt6vc=; b=rCPl+46hCB8Mnj8qi6TYtxjg6Ezu+S1u9FI7m3WICddeN51CJeVMntsykKw9XxBwcp 9IUdFhOkA2la4PN3vJv9GrNi7JET4iS5y265fGNnb8SHwd0GlRiqnexA6tLXX5JGwKeV /K1ASK6k89Obg7/lasOFryB+BWSwTgROvyS1s0aO1nPzd9LHq7NGxdLpw/ygTa/62Tpe 9tpZ8uXwtmBQ3KKnVIDG8vANv9F6XwRO12Pw4JgIyQ/XNpy4PrPUhrQxIegc71nrMGkV Y3YkNNOnbDpPRDz+4OEJg0deyP0bWWL+W2iYgURBBYgFggTWefElTHO8G6qX6xdpDRzf +NaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=crl/sUJTIYngi8fCHSniOxSSni3lgNa7iQh3Jutt6vc=; b=jCri6EdDleWfsHSfFZwtHAz091bQWTx6Dp+lwz6pDuP510GUEGWUkM6B5rbMFBHLxC Xz7rTJAq3+MMuyLW/QMmJKPfNsviukcGYz8zXwvEhj5wnhHAu6w9Nsq/TR6Cvx64ifj+ owhSG2iwnIrQw0VqscJ2JaFtJQDMLit+fTcYfhRzQe5JEHJ4142TMoZk01QSVyEkewH5 SJnzOB4cwoT+RyURwHhrJYODRJCcUAZmy2VFaC5guBR3B7efciKFZl0anEnvAEXGhNHx hRTyRUyVpai3E7oDBOysKcouD3rf2qOi1qKwpBLC3G3qmZkLsTQYGaJVh/Ikuuk+FVPl TF1Q== X-Gm-Message-State: APjAAAWi79Om+QJWZ1r57/tu6HWygJzqqiYCrRQfyyx/8eW6LN3ZTTu3 iv+dpfJtmr97g/Z8ipXzZww= X-Google-Smtp-Source: APXvYqyi85IXeYNlKiRU9CfS3VUsHIeGRvcoN3KGVKyN/8gCemDLZxmG2aberbhL23uSfab6ZAZFnA== X-Received: by 2002:a1c:6a14:: with SMTP id f20mr375073wmc.110.1572891559775; Mon, 04 Nov 2019 10:19:19 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id w8sm23127580wrr.44.2019.11.04.10.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 10:19:18 -0800 (PST) From: Florian Fainelli To: linux-arm-kernel@lists.infradead.org Cc: Florian Fainelli , Philipp Zabel , Rob Herring , Mark Rutland , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/2] reset: brcmstb: Remove resource checks Date: Mon, 4 Nov 2019 10:15:02 -0800 Message-Id: <20191104181502.15679-3-f.fainelli@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191104181502.15679-1-f.fainelli@gmail.com> References: <20191104181502.15679-1-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The use of IS_ALIGNED() is incorrect, the typical resource we pass looks like this: start: 0x8404318, size: 0x30. When using IS_ALIGNED() we will get the following 0x8404318 & (0x18 - 1) = 0x10 which is definitively not equal to 0, same goes with the size. These two checks would make the driver fail probing. Remove the resource checks, since there should be no constraint on the base addresse or size. Fixes: 77750bc089e4 ("reset: Add Broadcom STB SW_INIT reset controller driver") Signed-off-by: Florian Fainelli --- drivers/reset/reset-brcmstb.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/reset/reset-brcmstb.c b/drivers/reset/reset-brcmstb.c index a608f445dad6..f213264c8567 100644 --- a/drivers/reset/reset-brcmstb.c +++ b/drivers/reset/reset-brcmstb.c @@ -91,12 +91,6 @@ static int brcmstb_reset_probe(struct platform_device *pdev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!IS_ALIGNED(res->start, SW_INIT_BANK_SIZE) || - !IS_ALIGNED(resource_size(res), SW_INIT_BANK_SIZE)) { - dev_err(kdev, "incorrect register range\n"); - return -EINVAL; - } - priv->base = devm_ioremap_resource(kdev, res); if (IS_ERR(priv->base)) return PTR_ERR(priv->base); -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3F3BCA9EB5 for ; Mon, 4 Nov 2019 18:19:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA1B220578 for ; Mon, 4 Nov 2019 18:19:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PMsB3YQY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rCPl+46h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA1B220578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=HJV1R8YxdGDBmiUPuoaYEHxsUk4kMnH6AuDMK04e1j8=; b=PMsB3YQYiyrWjb01VpqQhJfYcH 6GTnFRBeOjbV6MkJtmOzsuT+4xyA8ZDrQxAxenwep+DZJDwT1QoghrmEJ4MoI8HbOtUc2dRjq/Bs2 sQSFB0NVPOAt9zpHUBdbMXD6b9nMsRPLdb4gV1kDYE487JsrVLftpdg6C9lN37luk7SBzGsKNum7b x9fIbZ/QaHDkIreZs9ZjuqiOjGWrqfFpYvDGuZ2q9O3ezYm0MkbXoxLtUExrYXXzcb2XMxMdC0TtH Gt3lfMHQL6/o4MATg5qOXbF7k7hn5FeDVXgdykbBY2dfVP6QXpNlWwSC003ErYxbSkMCyXRcen+KL JbAQpLQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRgxA-0004su-Bn; Mon, 04 Nov 2019 18:19:48 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRgwj-0004So-UU for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2019 18:19:23 +0000 Received: by mail-wm1-x341.google.com with SMTP id t26so13042702wmi.4 for ; Mon, 04 Nov 2019 10:19:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=crl/sUJTIYngi8fCHSniOxSSni3lgNa7iQh3Jutt6vc=; b=rCPl+46hCB8Mnj8qi6TYtxjg6Ezu+S1u9FI7m3WICddeN51CJeVMntsykKw9XxBwcp 9IUdFhOkA2la4PN3vJv9GrNi7JET4iS5y265fGNnb8SHwd0GlRiqnexA6tLXX5JGwKeV /K1ASK6k89Obg7/lasOFryB+BWSwTgROvyS1s0aO1nPzd9LHq7NGxdLpw/ygTa/62Tpe 9tpZ8uXwtmBQ3KKnVIDG8vANv9F6XwRO12Pw4JgIyQ/XNpy4PrPUhrQxIegc71nrMGkV Y3YkNNOnbDpPRDz+4OEJg0deyP0bWWL+W2iYgURBBYgFggTWefElTHO8G6qX6xdpDRzf +NaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=crl/sUJTIYngi8fCHSniOxSSni3lgNa7iQh3Jutt6vc=; b=ujxmoZlk05ymw8hfE4wgtzulZSWJjjxHLsVps0alvy+i8Whk5T4ILS876h6KhVplqj IUgHwXQmb5KeqqVPGeRZ73PVMQKM40D9fmlPt1ZeLUEa1ixuNYgt5xXzXEQV41oQaGa8 pR/BKrtXJ1mS9eld/T4Kfi+OAeQQiNI0uz7RFS6KbSP3hEFuqpHttVFBxcZC0s1+HPFV uaCfwyBY4wXPew7C383xvzve/I+FgKCXhrDUH2m9Oacq3h7wsS4WHgeMNUZV7/8kbV7E bFKmV9krkY9l3O8I/sW7bS9zS61mowaqJo58RQxVVmukOBPLGcqMMhBO4WdJ5hkr/gKQ Z74Q== X-Gm-Message-State: APjAAAUkQZEBIjTQz2qBVaUFsM16reDfv2INQ0a5UqhAkPyDY5FLAvr1 I+cLg4PMXZqDD3oOG0DFRSZLi4bp X-Google-Smtp-Source: APXvYqyi85IXeYNlKiRU9CfS3VUsHIeGRvcoN3KGVKyN/8gCemDLZxmG2aberbhL23uSfab6ZAZFnA== X-Received: by 2002:a1c:6a14:: with SMTP id f20mr375073wmc.110.1572891559775; Mon, 04 Nov 2019 10:19:19 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id w8sm23127580wrr.44.2019.11.04.10.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 10:19:18 -0800 (PST) From: Florian Fainelli To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] reset: brcmstb: Remove resource checks Date: Mon, 4 Nov 2019 10:15:02 -0800 Message-Id: <20191104181502.15679-3-f.fainelli@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191104181502.15679-1-f.fainelli@gmail.com> References: <20191104181502.15679-1-f.fainelli@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_101921_996710_C05F1033 X-CRM114-Status: GOOD ( 12.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Florian Fainelli , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Philipp Zabel MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org The use of IS_ALIGNED() is incorrect, the typical resource we pass looks like this: start: 0x8404318, size: 0x30. When using IS_ALIGNED() we will get the following 0x8404318 & (0x18 - 1) = 0x10 which is definitively not equal to 0, same goes with the size. These two checks would make the driver fail probing. Remove the resource checks, since there should be no constraint on the base addresse or size. Fixes: 77750bc089e4 ("reset: Add Broadcom STB SW_INIT reset controller driver") Signed-off-by: Florian Fainelli --- drivers/reset/reset-brcmstb.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/reset/reset-brcmstb.c b/drivers/reset/reset-brcmstb.c index a608f445dad6..f213264c8567 100644 --- a/drivers/reset/reset-brcmstb.c +++ b/drivers/reset/reset-brcmstb.c @@ -91,12 +91,6 @@ static int brcmstb_reset_probe(struct platform_device *pdev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!IS_ALIGNED(res->start, SW_INIT_BANK_SIZE) || - !IS_ALIGNED(resource_size(res), SW_INIT_BANK_SIZE)) { - dev_err(kdev, "incorrect register range\n"); - return -EINVAL; - } - priv->base = devm_ioremap_resource(kdev, res); if (IS_ERR(priv->base)) return PTR_ERR(priv->base); -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel