From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Adam Ford <aford173@gmail.com>
Cc: Sven Van Asbroeck <thesven73@gmail.com>,
Marek Vasut <marex@denx.de>,
linux-input@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] Input: ili210x - add ILI2117 support
Date: Mon, 4 Nov 2019 10:36:56 -0800 [thread overview]
Message-ID: <20191104183656.GO57214@dtor-ws> (raw)
In-Reply-To: <CAHCN7xJmJH1gqnE1TBi7hEYnhg0aV8TOW8==QxXV3CEOOk560g@mail.gmail.com>
On Mon, Nov 04, 2019 at 08:19:28AM -0600, Adam Ford wrote:
> On Mon, Nov 4, 2019 at 7:49 AM Sven Van Asbroeck <thesven73@gmail.com> wrote:
> >
> > On Mon, Nov 4, 2019 at 2:01 AM Dmitry Torokhov
> > <dmitry.torokhov@gmail.com> wrote:
> > >
> > > Can you please tell me what device you have? Do the patches work for
> > > you?
> >
> > I have an ILI2117A/ILI2118A.
> >
> > I'll try out the patches today. I'm stuck with a 4.1 vendor kernel, so
> > I'll need to backport the (patched) mainline driver to 4.1 before
> > I'm able to test.
> >
> > I wil try Marek's patch, and Dmitry's rebased patch from
> > https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/log/?h=ili2xxx-touchscreen
> > and let you know the results.
>
> For what it's worth, I tried the 3-patch series from that branch on
> 5.4-RC5, but the ts_calibrate and ts_test_mt do not appear to receive
> touch info. They execute when I 'export
> TSLIB_TSDEVICE=/dev/input/event0' but I don't get touch data.
>
> If I do a hex-dump of /dev/event0 and it dumps data if and only if I
> hold my finger on the touch screen for a while.
>
> I'll try just doing the 1st patch to see if it it's any better.
OK, I see where I messed up ili211x_read_touch_data(), it should use
i2c_master_recv() and not ili210x_read_reg(). I'll make a fix up patch
later today.
--
Dmitry
next prev parent reply other threads:[~2019-11-04 18:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 14:17 [PATCH 1/2] Input: ili210x - Add DT binding for the Ilitek ILI2117 touch controller Marek Vasut
2019-03-27 19:44 ` Rob Herring
2019-08-07 11:27 ` Marek Vasut
2019-11-01 20:48 ` [PATCH 2/2] Input: ili210x - add ILI2117 support Sven Van Asbroeck
2019-11-03 23:55 ` Adam Ford
2019-11-04 0:16 ` Marek Vasut
2019-11-04 7:02 ` Dmitry Torokhov
2019-11-04 7:01 ` Dmitry Torokhov
2019-11-04 9:13 ` Marek Vasut
2019-11-04 13:49 ` Sven Van Asbroeck
2019-11-04 14:19 ` Adam Ford
2019-11-04 18:36 ` Dmitry Torokhov [this message]
2019-11-04 18:37 ` Sven Van Asbroeck
2019-11-04 21:28 ` Adam Ford
2019-11-04 21:43 ` Sven Van Asbroeck
2019-11-04 23:25 ` Adam Ford
2019-11-04 23:36 ` Dmitry Torokhov
2019-11-04 23:40 ` Adam Ford
2019-11-05 2:04 ` Sven Van Asbroeck
2019-11-05 13:27 ` Adam Ford
2019-11-05 15:26 ` Sven Van Asbroeck
2019-11-05 15:29 ` Sven Van Asbroeck
2019-11-05 15:53 ` Sven Van Asbroeck
2019-11-11 18:16 ` Dmitry Torokhov
2019-11-11 18:43 ` Rob Herring
2019-11-12 0:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104183656.GO57214@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aford173@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.