From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8753C5DF60 for ; Wed, 6 Nov 2019 02:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DAFD2178F for ; Wed, 6 Nov 2019 02:30:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730832AbfKFCar (ORCPT ); Tue, 5 Nov 2019 21:30:47 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42308 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727252AbfKFCar (ORCPT ); Tue, 5 Nov 2019 21:30:47 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A6D5F15108908; Tue, 5 Nov 2019 18:30:46 -0800 (PST) Date: Tue, 05 Nov 2019 18:30:46 -0800 (PST) Message-Id: <20191105.183046.464228788999222253.davem@davemloft.net> To: kai.heng.feng@canonical.com Cc: oliver@neukum.org, hayeswang@realtek.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] r8152: Add macpassthru support for ThinkPad Thunderbolt 3 Dock Gen 2 From: David Miller In-Reply-To: <20191105112452.13905-1-kai.heng.feng@canonical.com> References: <20191105112452.13905-1-kai.heng.feng@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Nov 2019 18:30:46 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kai-Heng Feng Date: Tue, 5 Nov 2019 19:24:52 +0800 > ThinkPad Thunderbolt 3 Dock Gen 2 is another docking station that uses > RTL8153 based USB ethernet. > > The device supports macpassthru, but it failed to pass the test of -AD, > -BND and -BD. Simply bypass these tests since the device supports this > feature just fine. > > Also the ACPI objects have some differences between Dell's and Lenovo's, > so make those ACPI infos no longer hardcoded. > > BugLink: https://bugs.launchpad.net/bugs/1827961 > Signed-off-by: Kai-Heng Feng > --- > v3: > - Simplify the logic of bypassing macpassthru test. > v2: > - Use idVendor and idProduct directly. Applied to net-next, thank you.