All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jim Mattson <jmattson@google.com>
Cc: Aaron Lewis <aaronlewis@google.com>, kvm list <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/4] kvm: nested: Introduce read_and_check_msr_entry()
Date: Mon, 4 Nov 2019 18:01:55 -0800	[thread overview]
Message-ID: <20191105020155.GA6392@linux.intel.com> (raw)
In-Reply-To: <CALMp9eQJGyPAnBiQF=fgLLDh4Jq8MF5N0dZ1wy+Run-nC8oeSw@mail.gmail.com>

On Mon, Nov 04, 2019 at 02:41:10PM -0800, Jim Mattson wrote:
> On Tue, Oct 29, 2019 at 2:06 PM Aaron Lewis <aaronlewis@google.com> wrote:
> >
> > Add the function read_and_check_msr_entry() which just pulls some code
> > out of nested_vmx_store_msr() for now, however, this is in preparation
> > for a change later in this series were we reuse the code in
> > read_and_check_msr_entry().
> >
> > Signed-off-by: Aaron Lewis <aaronlewis@google.com>
> > Change-Id: Iaf8787198c06674e8b0555982a962f5bd288e43f
> Drop the Change-Id.

Even better, incoporate checkpatch into your flow, this is one of the few
things that is unequivocally considered an error.

  reply	other threads:[~2019-11-05  2:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 21:05 [PATCH 0/4] Add support for capturing the highest observable L2 TSC Aaron Lewis
2019-10-29 21:05 ` [PATCH 1/4] kvm: nested: Introduce read_and_check_msr_entry() Aaron Lewis
2019-11-04 22:41   ` Jim Mattson
2019-11-05  2:01     ` Sean Christopherson [this message]
2019-10-29 21:05 ` [PATCH 2/4] kvm: vmx: Rename NR_AUTOLOAD_MSRS to NR_MSR_ENTRIES Aaron Lewis
2019-11-04 22:42   ` Jim Mattson
2019-10-29 21:05 ` [PATCH 3/4] kvm: vmx: Rename function find_msr() to vmx_find_msr_index() Aaron Lewis
2019-11-04 22:44   ` Jim Mattson
2019-10-29 21:05 ` [PATCH 4/4] KVM: nVMX: Add support for capturing highest observable L2 TSC Aaron Lewis
2019-11-04 22:48   ` Jim Mattson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191105020155.GA6392@linux.intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=aaronlewis@google.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.