From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 0/2] bdev: Refresh bdev size for disks without partitioning
Date: Tue, 5 Nov 2019 09:59:16 +0100 [thread overview]
Message-ID: <20191105085916.GH22379@quack2.suse.cz> (raw)
In-Reply-To: <20191104234841.GA7593@infradead.org>
On Mon 04-11-19 15:48:41, Christoph Hellwig wrote:
> On Mon, Nov 04, 2019 at 09:08:47AM +0100, Jan Kara wrote:
> > Thanks Jens! I'll look into refactoring the size change / revalidation code
> > so that it's easier to understand what's going on...
>
> I actualy have a series for this. I've started rebasing it on top
> of you work and will need to do some testing. My current WIP is here:
>
> http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/partition-cleanup
Cool. Thanks for that! Skimming over the series it looks good to me. The
only remaining thing I wanted to look into is bdev->bd_invalidated
handling. Because the only thing it actually indicates in practice is that
DISK_EVENT_MEDIA_CHANGE was set in check_disk_change(). All the other call
chains end up clearing bdev->bd_invalidated before it has any effect. And
that just looks very cryptic to me... So my plan was to at least move the
setting of bdev->bd_invalidated to check_disk_change() and rename it to
something saner if I cannot come up with anything better for propagating
the information from check_disk_change() to __blkdev_get().
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2019-11-05 8:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 8:37 [PATCH 0/2] bdev: Refresh bdev size for disks without partitioning Jan Kara
2019-10-21 8:37 ` [PATCH 1/2] bdev: Factor out bdev revalidation into a common helper Jan Kara
2019-10-22 7:58 ` Damien Le Moal
2019-10-22 9:15 ` Jan Kara
2019-10-22 9:31 ` Damien Le Moal
2019-10-21 8:38 ` [PATCH 2/2] bdev: Refresh bdev size for disks without partitioning Jan Kara
2019-10-21 8:49 ` Guoqing Jiang
2019-10-21 9:12 ` Jan Kara
2019-10-21 9:27 ` Guoqing Jiang
2019-10-21 9:36 ` Johannes Thumshirn
2019-10-21 9:38 ` Guoqing Jiang
2019-10-21 9:40 ` Jan Kara
2019-10-21 9:43 ` Guoqing Jiang
2019-11-03 14:53 ` [PATCH 0/2] " Jens Axboe
2019-11-04 8:08 ` Jan Kara
2019-11-04 23:48 ` Christoph Hellwig
2019-11-05 8:59 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105085916.GH22379@quack2.suse.cz \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.