From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 5/5] drm/dsi: add helpers for DSI compression mode and PPS packets Date: Tue, 5 Nov 2019 10:55:10 +0100 Message-ID: <20191105095510.GC1607358@ulmo> References: <20191028150047.22048-1-jani.nikula@intel.com> <20191028150047.22048-5-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1686533265==" Return-path: In-Reply-To: <20191028150047.22048-5-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: Vandita Kulkarni , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1686533265== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XMCwj5IQnwKtuyBG" Content-Disposition: inline --XMCwj5IQnwKtuyBG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 28, 2019 at 05:00:47PM +0200, Jani Nikula wrote: > Add helper functions for sending the DSI compression mode and picture > parameter set data type packets. For the time being, limit the support > to using VESA DSC 1.1 and the default PPS. This may need updating if the > need arises for proprietary compression or non-default PPS, however keep > it simple for starters. >=20 > v2: Add missing EXPORT_SYMBOL >=20 > Cc: Vandita Kulkarni > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_mipi_dsi.c | 51 ++++++++++++++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 4 +++ > 2 files changed, 55 insertions(+) Looks good: Reviewed-by: Thierry Reding --XMCwj5IQnwKtuyBG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl3BRvsACgkQ3SOs138+ s6EKMA//QB10EwD6UvSWkeNmA61pfpHrKfgLxU7jChKqaD1ZlyRs8tDxMph9D0Jx /3OwNAWG651eT1wI7omGrE4aeZl46YsGV1dDcn/7grnG4uDZsVeVHMUWbb7pPmhx 9jrHiyOkyGvMyj7LHeSHiKOlE1oYhX6Wcq/evwJR5maFJSJGu0r3wq2GvGpRfQHe zrbfegYINh+5eVkb0pd84kj5VLpHbxP8nImTG8Ns5XNJ6pOHvXEPCeaLN7O9CWC3 L8mLvFgjtGgcS+9Z086f2zq9gLfZ0xGX6VWfpnz6a5GAyTb3akM+djAJ6HuqNtIw r94JPbimhxCMd5YQeK2qpKI90n+LFN70AZFXUrIcIuJDZpwruhO15rGtZSvhj/kT uWIPvj8mlSGNz4oq52qBH0LeKbtAG7uEkiEbSbEGuQepiV6qgbHLT2uo9eaM8ISq Plrxt7m4Usks2IoNI+cTz7GcsqKManWKn+6eGXI6ecRzF4e68nMyvhTM9vxYjowh Xx3H91HfjVFo85tK5rVXQdEg06O1XHRtVMtLQgG8Y2ZQwRyHDxVHuf2uVEFoRKQA 9GjbHdb/Zo2e1OOu6WbYxnN47R/cvwtWZ3bvgB3rd0EhIDYtI7ja+3bsSc48HoZF 5BfTmZN8QXRcA7EIHd+VDDjidonPX4khuxv/5vuxWfjEtbmL+Fk= =kzu8 -----END PGP SIGNATURE----- --XMCwj5IQnwKtuyBG-- --===============1686533265== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1686533265==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B0C9C49EAB for ; Tue, 5 Nov 2019 09:55:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2988221929 for ; Tue, 5 Nov 2019 09:55:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2988221929 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D5296E98B; Tue, 5 Nov 2019 09:55:15 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id F318E6E98A; Tue, 5 Nov 2019 09:55:13 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id 6so16105995wmf.0; Tue, 05 Nov 2019 01:55:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QVOGXOR5z3z9S+IAuOwn5dLHaPdb1fFyiscI5E8C7HY=; b=ACKE0t79vM/hHHIo2WUfWa/X1i/7rqaHBwklyU901yB+8b9rPoKzutjB3URaTq1gAn Udhiys3Tf39s8A3VocrL44W37ZDVOEVq/L5k4c6aSBURhqre8jA9LaH9/AXL//ssJ2hD omE7lpHGLVVEDq185x9Q2epoyMPTfyVFAc8tqnQV0Dv87BzD+NOmqe366lP40hxCsn+4 eLjCR04UzgW8tKYl4mXAqx+XjGM12WOHj51IgWusSbqkoM47wJTEcJ/YL0lrboT4+sET acRZk+AgLRehtwmWyWrjSZTrUgPvl2UONAyHy1AGN43YCs+9OqUA/03HcFQs7CWStm0V nxuA== X-Gm-Message-State: APjAAAVJVYK2B2P3INnAMEq39RKtKDIjMaBZtQgI3lKTNh568XH0UiRC rsVlnZJbzyc3Djfo4rE3JX2YjsMd X-Google-Smtp-Source: APXvYqwPtnn2BnkfYLYU5tUTjGydA8m72+6aAim+Sk4wbYHWfIkQ4Lh1urGRjppdhnZoMWqBooLWbQ== X-Received: by 2002:a1c:67d7:: with SMTP id b206mr3268864wmc.68.1572947712564; Tue, 05 Nov 2019 01:55:12 -0800 (PST) Received: from localhost (p2E5BE2CE.dip0.t-ipconnect.de. [46.91.226.206]) by smtp.gmail.com with ESMTPSA id l5sm17852413wmj.44.2019.11.05.01.55.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 01:55:11 -0800 (PST) Date: Tue, 5 Nov 2019 10:55:10 +0100 From: Thierry Reding To: Jani Nikula Message-ID: <20191105095510.GC1607358@ulmo> References: <20191028150047.22048-1-jani.nikula@intel.com> <20191028150047.22048-5-jani.nikula@intel.com> MIME-Version: 1.0 In-Reply-To: <20191028150047.22048-5-jani.nikula@intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QVOGXOR5z3z9S+IAuOwn5dLHaPdb1fFyiscI5E8C7HY=; b=FpuchXC75efoRHFc2FvLXWQc9Yq/FiVRd9uLvppjJE+Ey8wfMwW0L7ncKifLrVlUEZ o28hrC8CsB6wR3J+YoniUWIYm4cgdq52aGGJiz9vwTUq7PcI0mE1Hr5pVSEhFYE+TfYv C/jprrPYlIXud12Ch4XQ5RA/WUYVK+u4G9eF50jU2BoPhQV918hPeP6hdMFAJpK2Y0ry 6x770029MqNAw4W79XrklJJhC8s0AiWvK0Vc8qN3dG+A/2UfeJwdMXDatskILb1utMuY al/FzgjXN+JpwvAadrg9Bqd/AOUyTLl7REbis3LcicsfoLReNmTFG6WPKKyHDmRdJJ9U wq6A== Subject: Re: [Intel-gfx] [PATCH v2 5/5] drm/dsi: add helpers for DSI compression mode and PPS packets X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: multipart/mixed; boundary="===============0871092192==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191105095510.6CbUOJuKuTxcmQKRTyDVjEaCj4YEx3SXxDD5dRWm1Co@z> --===============0871092192== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XMCwj5IQnwKtuyBG" Content-Disposition: inline --XMCwj5IQnwKtuyBG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 28, 2019 at 05:00:47PM +0200, Jani Nikula wrote: > Add helper functions for sending the DSI compression mode and picture > parameter set data type packets. For the time being, limit the support > to using VESA DSC 1.1 and the default PPS. This may need updating if the > need arises for proprietary compression or non-default PPS, however keep > it simple for starters. >=20 > v2: Add missing EXPORT_SYMBOL >=20 > Cc: Vandita Kulkarni > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_mipi_dsi.c | 51 ++++++++++++++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 4 +++ > 2 files changed, 55 insertions(+) Looks good: Reviewed-by: Thierry Reding --XMCwj5IQnwKtuyBG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl3BRvsACgkQ3SOs138+ s6EKMA//QB10EwD6UvSWkeNmA61pfpHrKfgLxU7jChKqaD1ZlyRs8tDxMph9D0Jx /3OwNAWG651eT1wI7omGrE4aeZl46YsGV1dDcn/7grnG4uDZsVeVHMUWbb7pPmhx 9jrHiyOkyGvMyj7LHeSHiKOlE1oYhX6Wcq/evwJR5maFJSJGu0r3wq2GvGpRfQHe zrbfegYINh+5eVkb0pd84kj5VLpHbxP8nImTG8Ns5XNJ6pOHvXEPCeaLN7O9CWC3 L8mLvFgjtGgcS+9Z086f2zq9gLfZ0xGX6VWfpnz6a5GAyTb3akM+djAJ6HuqNtIw r94JPbimhxCMd5YQeK2qpKI90n+LFN70AZFXUrIcIuJDZpwruhO15rGtZSvhj/kT uWIPvj8mlSGNz4oq52qBH0LeKbtAG7uEkiEbSbEGuQepiV6qgbHLT2uo9eaM8ISq Plrxt7m4Usks2IoNI+cTz7GcsqKManWKn+6eGXI6ecRzF4e68nMyvhTM9vxYjowh Xx3H91HfjVFo85tK5rVXQdEg06O1XHRtVMtLQgG8Y2ZQwRyHDxVHuf2uVEFoRKQA 9GjbHdb/Zo2e1OOu6WbYxnN47R/cvwtWZ3bvgB3rd0EhIDYtI7ja+3bsSc48HoZF 5BfTmZN8QXRcA7EIHd+VDDjidonPX4khuxv/5vuxWfjEtbmL+Fk= =kzu8 -----END PGP SIGNATURE----- --XMCwj5IQnwKtuyBG-- --===============0871092192== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============0871092192==--