From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: sean@poorly.run, dri-devel@lists.freedesktop.org,
airlied@redhat.com, sam@ravnborg.org, emil.velikov@collabora.com
Subject: Re: [PATCH 3/3] drm/udl: Switch to SHMEM
Date: Tue, 5 Nov 2019 12:05:21 +0100 [thread overview]
Message-ID: <20191105110521.zwv35ihnqlmwla3u@sirius.home.kraxel.org> (raw)
In-Reply-To: <20191028084549.30243-4-tzimmermann@suse.de>
On Mon, Oct 28, 2019 at 09:45:49AM +0100, Thomas Zimmermann wrote:
> Udl's GEM code and the generic SHMEM are almost identical. Replace
> the former with SHMEM. The dmabuf support in udl is being removed
> in favor of the generic GEM PRIME functions.
>
> The main difference is in the caching flags for mmap pages. By
> default, SHMEM always sets (uncached) write combining. In udl's
> memory management code, only imported buffers use write combining.
> Memory pages of locally created buffer objects are mmap'ed with
> caching enabled. To keep the optimization, udl provides its own
> mmap function for GEM objects where it fixes up the mapping flags.
Hmm, couldn't spot anything wrong, but it's rather hard to see the
actual changes here ...
Any chance that having a separate "remove all dead code obsoleted by
shmem helpers" patch helps?
cheers,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-05 11:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 8:45 [PATCH 0/3] drm/udl: Convert to SHMEM Thomas Zimmermann
2019-10-28 8:45 ` [PATCH 1/3] drm/udl: Remove flags field from struct udl_gem_object Thomas Zimmermann
2019-11-05 11:05 ` Gerd Hoffmann
2019-10-28 8:45 ` [PATCH 2/3] drm/udl: Allocate GEM object via struct drm_driver.gem_create_object Thomas Zimmermann
2019-11-05 11:05 ` Gerd Hoffmann
2019-10-28 8:45 ` [PATCH 3/3] drm/udl: Switch to SHMEM Thomas Zimmermann
2019-10-30 0:15 ` kbuild test robot
2019-10-30 0:15 ` kbuild test robot
2019-10-30 0:15 ` kbuild test robot
2019-10-31 12:53 ` kbuild test robot
2019-10-31 12:53 ` kbuild test robot
2019-10-31 12:53 ` kbuild test robot
2019-11-05 11:05 ` Gerd Hoffmann [this message]
2019-11-06 8:22 ` Thomas Zimmermann
2019-10-28 8:48 ` [PATCH 0/3] drm/udl: Convert " Thomas Zimmermann
2019-10-28 8:48 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105110521.zwv35ihnqlmwla3u@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.