From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E28FFC010A3 for ; Tue, 5 Nov 2019 11:11:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4FAB21928 for ; Tue, 5 Nov 2019 11:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572952300; bh=L0MQuT4XYxAFwm79QAhiL05f/SdnH/s1jkfSPz113BE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QJNR0XM2ql5KN8amqOOGUItIUlidUEVJgrxwZHJU/NWQSCzaImnI2bcMobNJ9WM+0 BNBerohQuW68xax9Rg/mcDOTKKVLlxp1lkrQ5cVwJNmAQTUU7ykNDM8sxUsG9kVG8n pBNqBJN4c60xuDkH5nQ+YIR58fhjFeaS/Sw0YT3s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388620AbfKELLj (ORCPT ); Tue, 5 Nov 2019 06:11:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:60224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388494AbfKELLj (ORCPT ); Tue, 5 Nov 2019 06:11:39 -0500 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E4BA820869; Tue, 5 Nov 2019 11:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572952297; bh=L0MQuT4XYxAFwm79QAhiL05f/SdnH/s1jkfSPz113BE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yl1o9f4oD62go+SoZTI/xdBt6WJXvvuOwVzpe7vPn+ctS79K7B1/M8YvcKQlgyXiJ BE2CNaKz1BaPD3A6kklxIl+zEHlVAvYshsIDdrpTGwnP16AI0jIK7jzvyj0RyhME5g DlR6EqbQDkkEYmG8eIj2b92ZyKXifryUwNnjalY8= Date: Tue, 5 Nov 2019 12:11:34 +0100 From: Maxime Ripard To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: =?iso-8859-1?Q?Cl=E9ment_P=E9ron?= , Thierry Reding , Rob Herring , Mark Rutland , Chen-Yu Tsai , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jernej Skrabec , kernel@pengutronix.de Subject: Re: [PATCH v2 1/7] dt-bindings: pwm: allwinner: Add H6 PWM description Message-ID: <20191105111134.GG3876@gilmour.lan> References: <20191103203334.10539-1-peron.clem@gmail.com> <20191103203334.10539-2-peron.clem@gmail.com> <20191104080359.6kjugbt3yi63ywhb@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+jhVVhN62yS6hEJ8" Content-Disposition: inline In-Reply-To: <20191104080359.6kjugbt3yi63ywhb@pengutronix.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+jhVVhN62yS6hEJ8 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Clement, Uwe, On Mon, Nov 04, 2019 at 09:03:59AM +0100, Uwe Kleine-K=F6nig wrote: > On Sun, Nov 03, 2019 at 09:33:28PM +0100, Cl=E9ment P=E9ron wrote: > > From: Jernej Skrabec > > > > H6 PWM block is basically the same as A20 PWM, except that it also has > > bus clock and reset line which needs to be handled accordingly. > > > > Expand Allwinner PWM binding with H6 PWM specifics. > > > > Signed-off-by: Jernej Skrabec > > Signed-off-by: Cl=E9ment P=E9ron > > --- > > .../bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 45 ++++++++++++++++++- > > 1 file changed, 44 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-= pwm.yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.ya= ml > > index 0ac52f83a58c..bf36ea509f31 100644 > > --- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml > > +++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml > > @@ -30,13 +30,46 @@ properties: > > - items: > > - const: allwinner,sun50i-h5-pwm > > - const: allwinner,sun5i-a13-pwm > > + - const: allwinner,sun50i-h6-pwm > > > > reg: > > maxItems: 1 > > > > - clocks: > > + # Even though it only applies to subschemas under the conditionals, > > + # not listing them here will trigger a warning because of the > > + # additionalsProperties set to false. > > + clocks: true > > + clock-names: true > > + resets: > > maxItems: 1 > > > > + if: > > + properties: > > + compatible: > > + contains: > > + const: allwinner,sun50i-h6-pwm > > + > > + then: > > + properties: > > + clocks: > > + items: > > + - description: Module Clock > > + - description: Bus Clock > > + > > + clock-names: > > + items: > > + - const: mod > > + - const: bus > > + > > + required: > > + - clock-names > > + - resets > > + > > + else: > > + properties: > > + clocks: > > + maxItems: 1 > > + > > I guess this hunk says "If this is a allwinner,sun50i-h6-pwm, a mod and > bus clock is required.", right? > > I wonder if it is sensible to require a clock-names property in the else > branch, too. This would make it obvious if the clock there corresponds > to the "mod" or the "bus" clock on H6. (I guess it's "mod".) This can be done a bit differently and could address your concerns Something like properties: ... clocks: minItems: 1 maxItems: 2 items: - description: Bus Clock - description: Module Clock required: - clocks if: ... then: properties: clocks: maxItems: 2 clocks-names: items: - const: mod - const: bus required: - clock-names else: properties: clocks: maxItems: 1 That way, the definition of the order and which clock is which is pretty obvious in both cases, and we don't get any weird warnings. Maxime --+jhVVhN62yS6hEJ8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXcFY5gAKCRDj7w1vZxhR xbV/AQCe7CHt/mkieAm/L+E98h/loKt0hEB6kyNqdnXH0QKxZAEA3BWTeLZyVpFc GGWBi+MvM8vrJsH5MAMILsm76CTF6QE= =GzAC -----END PGP SIGNATURE----- --+jhVVhN62yS6hEJ8-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7186C010A2 for ; Tue, 5 Nov 2019 11:11:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA27520869 for ; Tue, 5 Nov 2019 11:11:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QCVRiBzk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="yl1o9f4o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA27520869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=43ZK2tqx6MYSPuIzvglfYzcfWRET1UwsnNh7DEj+4rY=; b=QCVRiBzkY7Aapk/GbC1SJnptO c5S45uaJqqN3hFx1ljBPxJHsUa/OEoNEqoQu9JPmXROMh1gVNf49OY381b5T9J5A9xgnhWA97nvnV uOMrocuXzsrbgKWFetHdjdPqirhW3NzvKtEaQ29bWDHn6UYMozY36HmS6ptyTIDXP+U0gGUO5JbbF Ou5EjlTajGKrOLlVRZgISB59W1E60Wqd3UdQ4xyooAUdY0XrNPYxVLGkWb42X6g3yvjKIeZQfQSKY bhYOIeR7I5rSyeuGgK1/H9Y5iuOAAgVrBYBchYj/8UNrGxcxRc9O8yiLc2qZOHuDLi/Bgk93u+v4B hXuANmn2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRwkP-00086i-W1; Tue, 05 Nov 2019 11:11:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRwkM-00085s-DU for linux-arm-kernel@lists.infradead.org; Tue, 05 Nov 2019 11:11:39 +0000 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E4BA820869; Tue, 5 Nov 2019 11:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572952297; bh=L0MQuT4XYxAFwm79QAhiL05f/SdnH/s1jkfSPz113BE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yl1o9f4oD62go+SoZTI/xdBt6WJXvvuOwVzpe7vPn+ctS79K7B1/M8YvcKQlgyXiJ BE2CNaKz1BaPD3A6kklxIl+zEHlVAvYshsIDdrpTGwnP16AI0jIK7jzvyj0RyhME5g DlR6EqbQDkkEYmG8eIj2b92ZyKXifryUwNnjalY8= Date: Tue, 5 Nov 2019 12:11:34 +0100 From: Maxime Ripard To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2 1/7] dt-bindings: pwm: allwinner: Add H6 PWM description Message-ID: <20191105111134.GG3876@gilmour.lan> References: <20191103203334.10539-1-peron.clem@gmail.com> <20191103203334.10539-2-peron.clem@gmail.com> <20191104080359.6kjugbt3yi63ywhb@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20191104080359.6kjugbt3yi63ywhb@pengutronix.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191105_031138_497845_B0EE630F X-CRM114-Status: GOOD ( 21.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-pwm@vger.kernel.org, Jernej Skrabec , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Chen-Yu Tsai , Thierry Reding , =?iso-8859-1?Q?Cl=E9ment_P=E9ron?= , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0847931596429936085==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0847931596429936085== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+jhVVhN62yS6hEJ8" Content-Disposition: inline --+jhVVhN62yS6hEJ8 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Clement, Uwe, On Mon, Nov 04, 2019 at 09:03:59AM +0100, Uwe Kleine-K=F6nig wrote: > On Sun, Nov 03, 2019 at 09:33:28PM +0100, Cl=E9ment P=E9ron wrote: > > From: Jernej Skrabec > > > > H6 PWM block is basically the same as A20 PWM, except that it also has > > bus clock and reset line which needs to be handled accordingly. > > > > Expand Allwinner PWM binding with H6 PWM specifics. > > > > Signed-off-by: Jernej Skrabec > > Signed-off-by: Cl=E9ment P=E9ron > > --- > > .../bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 45 ++++++++++++++++++- > > 1 file changed, 44 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-= pwm.yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.ya= ml > > index 0ac52f83a58c..bf36ea509f31 100644 > > --- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml > > +++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml > > @@ -30,13 +30,46 @@ properties: > > - items: > > - const: allwinner,sun50i-h5-pwm > > - const: allwinner,sun5i-a13-pwm > > + - const: allwinner,sun50i-h6-pwm > > > > reg: > > maxItems: 1 > > > > - clocks: > > + # Even though it only applies to subschemas under the conditionals, > > + # not listing them here will trigger a warning because of the > > + # additionalsProperties set to false. > > + clocks: true > > + clock-names: true > > + resets: > > maxItems: 1 > > > > + if: > > + properties: > > + compatible: > > + contains: > > + const: allwinner,sun50i-h6-pwm > > + > > + then: > > + properties: > > + clocks: > > + items: > > + - description: Module Clock > > + - description: Bus Clock > > + > > + clock-names: > > + items: > > + - const: mod > > + - const: bus > > + > > + required: > > + - clock-names > > + - resets > > + > > + else: > > + properties: > > + clocks: > > + maxItems: 1 > > + > > I guess this hunk says "If this is a allwinner,sun50i-h6-pwm, a mod and > bus clock is required.", right? > > I wonder if it is sensible to require a clock-names property in the else > branch, too. This would make it obvious if the clock there corresponds > to the "mod" or the "bus" clock on H6. (I guess it's "mod".) This can be done a bit differently and could address your concerns Something like properties: ... clocks: minItems: 1 maxItems: 2 items: - description: Bus Clock - description: Module Clock required: - clocks if: ... then: properties: clocks: maxItems: 2 clocks-names: items: - const: mod - const: bus required: - clock-names else: properties: clocks: maxItems: 1 That way, the definition of the order and which clock is which is pretty obvious in both cases, and we don't get any weird warnings. Maxime --+jhVVhN62yS6hEJ8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXcFY5gAKCRDj7w1vZxhR xbV/AQCe7CHt/mkieAm/L+E98h/loKt0hEB6kyNqdnXH0QKxZAEA3BWTeLZyVpFc GGWBi+MvM8vrJsH5MAMILsm76CTF6QE= =GzAC -----END PGP SIGNATURE----- --+jhVVhN62yS6hEJ8-- --===============0847931596429936085== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0847931596429936085==--