From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] fanotify: Rename fanotify_event_info_fid struct
Date: Tue, 5 Nov 2019 14:04:12 +0100 [thread overview]
Message-ID: <20191105130412.GC8511@rei.lan> (raw)
In-Reply-To: <20191105005341.19033-3-petr.vorel@gmail.com>
Hi!
> To fix build on musl, which also defines fanotify_event_info_fid,
> but uses fsid_t type for fsid instead of __kernel_fsid_t.
>
> This fixes errors:
>
> fanotify13.c: In function ???do_test???:
> fanotify13.c:278:20: error: ???fsid_t??? {aka ???struct __fsid_t???} has no member named ???val???; did you mean ???__val????
> event_fid->fsid.val[0],
> ^~~
> ../../../../include/tst_test.h:49:53: note: in definition of macro ???tst_res???
> tst_res_(__FILE__, __LINE__, (ttype), (arg_fmt), ##__VA_ARGS__)
> ^~~~~~~~~~~
> fanotify13.c:279:20: error: ???fsid_t??? {aka ???struct __fsid_t???} has no member named ???val???; did you mean ???__val????
> event_fid->fsid.val[1],
>
> musl (unlike glibc and uclibc-ng) defines fanotify_event_info_fid in
> fanotify.h and uses fsid_t as type for fanotify_event_info_fid.fsid
> member, which defines __val[2] (unlike val[2] in __kernel_fsid_t).
I don't know, this really sounds like a bug in musl.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-11-05 13:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 0:53 [LTP] [PATCH 0/2] fanotify musl fixes Petr Vorel
2019-11-05 0:53 ` [LTP] [PATCH 1/2] fanotify: Move __kernel_fsid_t definition to correct place Petr Vorel
2019-11-05 12:58 ` Cyril Hrubis
2019-11-06 18:41 ` Petr Vorel
2019-11-05 0:53 ` [LTP] [PATCH 2/2] fanotify: Rename fanotify_event_info_fid struct Petr Vorel
2019-11-05 13:04 ` Cyril Hrubis [this message]
2019-11-06 18:42 ` Petr Vorel
2019-11-05 13:11 ` Jan Stancek
2019-11-06 18:44 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105130412.GC8511@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.