All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jamal Shareef <jamal.k.shareef@gmail.com>
Cc: outreachy-kernel@googlegroups.com, eric@anholt.net, wahrenst@gmx.net
Subject: Re: [PATCH 01/14] staging: vc04_services: Remove instance struct typedef
Date: Tue, 5 Nov 2019 18:13:08 +0100	[thread overview]
Message-ID: <20191105171308.GA2815447@kroah.com> (raw)
In-Reply-To: <ecf031601dd7c0beb9bf6ac279dbeb912994025a.1572915104.git.jamal.k.shareef@gmail.com>

On Mon, Nov 04, 2019 at 04:55:11PM -0800, Jamal Shareef wrote:
> Removes vchi instance struct typedef. Issue found by checkpatch.
> 

Your changelog text still needs a lot of work.

And your subject line is wrong there is no "instance struct typedef".

A "better" subject might be:
	staging: vc04_services: replace VCHI_INSTANCE_T with struct vhci_instance_handle

And then describe why you did this in the changelog text.

You are not just "removing" you are changeing something, and you need to
say exactly what you are doing and again, why you are doing it.

Please fix up the changelogs for all of these patches.

Often times splitting patches up and writing good changelogs are more
work than the original coding part was.  It seems to be that way here.

thanks,

greg k-h


  reply	other threads:[~2019-11-05 17:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05  0:55 [PATCH 00/14] staging: vc04_services: Remove typedefs Jamal Shareef
2019-11-05  0:55 ` [PATCH 01/14] staging: vc04_services: Remove instance struct typedef Jamal Shareef
2019-11-05 17:13   ` Greg KH [this message]
2019-11-05  0:55 ` [PATCH 02/14] staging: vc04_services: Remove service " Jamal Shareef
2019-11-05  0:55 ` [PATCH 03/14] staging: vc04_services: Rename function pointer typedef Jamal Shareef
2019-11-05  0:55 ` [PATCH 04/14] staging: vc04_services: Remove status enum typedef Jamal Shareef
2019-11-05  0:55 ` [PATCH 05/14] staging: vc04_services: Remove bulk mode " Jamal Shareef
2019-11-05  0:55 ` [PATCH 06/14] staging: vc04_services: Remove option " Jamal Shareef
2019-11-05  0:55 ` [PATCH 07/14] staging: vc04_services: Remove connstate " Jamal Shareef
2019-11-05  0:55 ` [PATCH 08/14] staging: vc04_services: Remove bulk dir " Jamal Shareef
2019-11-05  0:55 ` [PATCH 09/14] staging: vc04_services: Rename userdata callback Jamal Shareef
2019-11-05  0:55 ` [PATCH 10/14] staging: vc04_services: Rename vchiq callback Jamal Shareef
2019-11-05  0:55 ` [PATCH 11/14] staging: vc04_services: Rename remote use callback Jamal Shareef
2019-11-05  0:55 ` [PATCH 12/14] staging: vc04_services: Remove int typedef Jamal Shareef
2019-11-05  0:55 ` [PATCH 13/14] staging: vc04_services: Remove vchiq instance typedef Jamal Shareef
2019-11-05  0:55 ` [PATCH 14/14] staging: vc04_services: Remove platform typedef Jamal Shareef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191105171308.GA2815447@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=eric@anholt.net \
    --cc=jamal.k.shareef@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.