From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04AE5C47E49 for ; Tue, 5 Nov 2019 20:13:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B611520656 for ; Tue, 5 Nov 2019 20:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572984785; bh=2QBblLpKCvzCWyBYMNf7InpwQgKLfDh8gTCdbys05h0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=oiMpqviV3+bhJrPs8sJR+KwRMM3I0vO5SUuwjNMLItwYU7Ra5jaCdBhL6qiwkbBOw Ohl39nLq9+/erXLPVOiBAS3zv1MgTYgOorpwVgHD5YdXK9f/NXCzeQ3RtZCyrwA3km Rofrd6CEwXsYLjtYM5eyxaaY3gvzqOtxpRbgKe5c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726988AbfKEUNF (ORCPT ); Tue, 5 Nov 2019 15:13:05 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:45623 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbfKEUNF (ORCPT ); Tue, 5 Nov 2019 15:13:05 -0500 Received: by mail-oi1-f196.google.com with SMTP id k2so18737385oij.12; Tue, 05 Nov 2019 12:13:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mU9UcOU7sHcf7HCmRIHXhWHMA1uoQHabE8Uv8Jt+A7E=; b=deYGSv8p6GIzQ3anqm/7VuAyUdkL8f4vSLJd//erntmjUeSYr369cjy2nWUkkDX8BX 1T6PqCjcVp8lm3GY5LohQhIQEVqUjZXpAZ8LxMs0d5GaO599TdUR3E2umG8fppna7E/K pn12fGx312nfP23kG7KaPJeUd+QzOi77BifVXHYjMuKy6g2fZqLu+J20/UpJSMONwzLH 1k+JRJ9nrTd3Fo0mhO7ZmWsHoWNOYMk7qVcM1pZAYiwbqyTQyCyKo7kEhtyu47DVDi9h sxnJAHPK8SfuYH5nCCzv5+QwLWUssw2vxAp0gAEuTlCW1QHFKGPhnHYvmXhANpkywSKE 5qFA== X-Gm-Message-State: APjAAAWET6wphwNAdWYbdfGmT6cssUm9sQwmXeUNShouijm4e9DSXMgp T6/aEYB2bu61bbrtu2bt6Q== X-Google-Smtp-Source: APXvYqzy0m98tPqHlFSqTVQuTPMUjEJDLNZe7DOwoduqbUy3ipM2+KtNECfZLQnN0fel0V++XN/OPg== X-Received: by 2002:aca:dd0a:: with SMTP id u10mr740393oig.130.1572984783628; Tue, 05 Nov 2019 12:13:03 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id v13sm1077013ota.53.2019.11.05.12.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 12:13:03 -0800 (PST) Date: Tue, 5 Nov 2019 14:13:02 -0600 From: Rob Herring To: Leonard Crestez Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Stephen Boyd , "Rafael J. Wysocki" , Shawn Guo , Mark Rutland , Michael Turquette , Artur =?utf-8?B?xZp3aWdvxYQ=?= , Saravana Kannan , Angus Ainslie , Martin Kepplinger , Matthias Kaehlcke , Krzysztof Kozlowski , Alexandre Bailon , Georgi Djakov , Aisheng Dong , Abel Vesa , Jacky Bai , Anson Huang , Fabio Estevam , Viresh Kumar , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-clk@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 3/6] dt-bindings: devfreq: Add bindings for imx ddr controller Message-ID: <20191105201302.GA4772@bogus> References: <20191104222126.GB5218@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Nov 05, 2019 at 07:25:57PM +0000, Leonard Crestez wrote: > On 05.11.2019 00:21, Rob Herring wrote: > > On Thu, Oct 31, 2019 at 11:50:24PM +0200, Leonard Crestez wrote: > >> Add devicetree bindings for the i.MX DDR Controller on imx8m series > >> chips. It supports dynamic frequency switching between multiple data > >> rates and this is exposed to Linux via the devfreq subsystem. > >> > >> Signed-off-by: Leonard Crestez > >> --- > >> .../devicetree/bindings/devfreq/imx-ddrc.yaml | 60 +++++++++++++++++++ > > > > .../bindings/memory-controllers/ > > Okay, but I'm not sure about the rules here. Usually there is a 1:1 > mapping between subsystems and bindings directory but I guess devfreq is > odd since it's not really a physical class of device. Mostly true, but it's not completely 1:1. > I saw there is also a drivers/memory and there is already a > devfreq-using driver in there (EXYNOS5422_DMC). Yeah, well it's been a while since I last tried to clean up locations of things. DDR controller bindings are not in the best shape. > It's not clear if my driver fits in there; as far as I can see the only > "core" functionality in drivers/memory is parsing DDR timings from DTS > but for imx8m this is all controlled in firmware. You shouldn't have to think about that. Bindings should be for DDR controllers regardless of whether there's a driver for devfreq, EDAC, perf, or ??? or all of those. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9ADEC5DF60 for ; Tue, 5 Nov 2019 20:13:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5AF820656 for ; Tue, 5 Nov 2019 20:13:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y9xl7UoD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5AF820656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k/foHOClUQ7gXr5hnk69OmP/adNHquahfLkpi5r9TD0=; b=Y9xl7UoDO4eMDx wyiPF+M+ULBqBYzfcFoXcO/prIBsscvTn6f71ltxMs6eqZpjgzbHGHRZni1HLrltQmibOGGnWLEwb KbjZqwLaOof/pf0X6oCB6kXd/9DozehPtp+yFoAi0AfCgtmqkpJW2+7lqwbIhQmVlTaorTPGSrTBK X3iLpO3VfbjiC6h5LgPcyiaRyUVtcNWQ5rdRMtPzXwOls6N+xxyQGezP463p+MpldQrnZ8P2/GIJ/ olqFdfLaf8al35zQPP/kbEM87qGM5dPQ//rtwkRD/8D1MwtRT3h887BfEQ6NH/vcxZX5ST9CPdVZy 6uBu0PBhNrZw7G9ycBsw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iS5CO-0001JR-IG; Tue, 05 Nov 2019 20:13:08 +0000 Received: from mail-oi1-f193.google.com ([209.85.167.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iS5CK-0001Iv-Ku for linux-arm-kernel@lists.infradead.org; Tue, 05 Nov 2019 20:13:06 +0000 Received: by mail-oi1-f193.google.com with SMTP id i185so18756691oif.9 for ; Tue, 05 Nov 2019 12:13:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mU9UcOU7sHcf7HCmRIHXhWHMA1uoQHabE8Uv8Jt+A7E=; b=ezQdxC2CeFaS2s/bbyppjYUWAEKASTxROgfArsnNrysCKPjUJagrVc1VeRfrD3XOca 4IY4kAaAOpNmjQWo56GBdY2nyF5DiarGCR+8H0Fk4wsRbo7w8L25rIz26Yr65Aw9gFn9 vnOjWm2/E4Ppxj+G8afY5DWebMnbYIgh+K2E+YMX9mF6iQtRf35+bhBUGf0ah3lKip47 WweGTshlr+VJyeI3+m5kA7G9j8ch+z5vBoZzURrYxABbUeSP7OJE2E/dLpajMQaI8Ie5 fqSLpQpUnGhbzgPwbdPxs4HvOt7gohNoOVf9RVYuso6PJmnkq2PVPyNJ7whINh4JRPwE 8VbQ== X-Gm-Message-State: APjAAAV7TJ6kplnTMoy1piWfHi5/ALffJEGKpQW31r9XQUxGCHYzFHeW LrjufWJjTCMCmHQdu0dDBA== X-Google-Smtp-Source: APXvYqzy0m98tPqHlFSqTVQuTPMUjEJDLNZe7DOwoduqbUy3ipM2+KtNECfZLQnN0fel0V++XN/OPg== X-Received: by 2002:aca:dd0a:: with SMTP id u10mr740393oig.130.1572984783628; Tue, 05 Nov 2019 12:13:03 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id v13sm1077013ota.53.2019.11.05.12.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 12:13:03 -0800 (PST) Date: Tue, 5 Nov 2019 14:13:02 -0600 From: Rob Herring To: Leonard Crestez Subject: Re: [PATCH v3 3/6] dt-bindings: devfreq: Add bindings for imx ddr controller Message-ID: <20191105201302.GA4772@bogus> References: <20191104222126.GB5218@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191105_121304_684448_A0342DA7 X-CRM114-Status: GOOD ( 18.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Artur =?utf-8?B?xZp3aWdvxYQ=?= , Jacky Bai , Viresh Kumar , Michael Turquette , Angus Ainslie , Alexandre Bailon , Matthias Kaehlcke , Abel Vesa , Saravana Kannan , Krzysztof Kozlowski , "linux-clk@vger.kernel.org" , Chanwoo Choi , MyungJoo Ham , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , Martin Kepplinger , "linux-arm-kernel@lists.infradead.org" , Aisheng Dong , Anson Huang , Stephen Boyd , "Rafael J. Wysocki" , Kyungmin Park , "kernel@pengutronix.de" , Fabio Estevam , Shawn Guo , Georgi Djakov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 05, 2019 at 07:25:57PM +0000, Leonard Crestez wrote: > On 05.11.2019 00:21, Rob Herring wrote: > > On Thu, Oct 31, 2019 at 11:50:24PM +0200, Leonard Crestez wrote: > >> Add devicetree bindings for the i.MX DDR Controller on imx8m series > >> chips. It supports dynamic frequency switching between multiple data > >> rates and this is exposed to Linux via the devfreq subsystem. > >> > >> Signed-off-by: Leonard Crestez > >> --- > >> .../devicetree/bindings/devfreq/imx-ddrc.yaml | 60 +++++++++++++++++++ > > > > .../bindings/memory-controllers/ > > Okay, but I'm not sure about the rules here. Usually there is a 1:1 > mapping between subsystems and bindings directory but I guess devfreq is > odd since it's not really a physical class of device. Mostly true, but it's not completely 1:1. > I saw there is also a drivers/memory and there is already a > devfreq-using driver in there (EXYNOS5422_DMC). Yeah, well it's been a while since I last tried to clean up locations of things. DDR controller bindings are not in the best shape. > It's not clear if my driver fits in there; as far as I can see the only > "core" functionality in drivers/memory is parsing DDR timings from DTS > but for imx8m this is all controlled in firmware. You shouldn't have to think about that. Bindings should be for DDR controllers regardless of whether there's a driver for devfreq, EDAC, perf, or ??? or all of those. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel