From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0CE2C5DF61 for ; Thu, 7 Nov 2019 05:25:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C2532178F for ; Thu, 7 Nov 2019 05:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726426AbfKGFZH (ORCPT ); Thu, 7 Nov 2019 00:25:07 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:33798 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfKGFZH (ORCPT ); Thu, 7 Nov 2019 00:25:07 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D54F615110082; Wed, 6 Nov 2019 21:25:06 -0800 (PST) Date: Wed, 06 Nov 2019 21:25:06 -0800 (PST) Message-Id: <20191106.212506.946721274328639751.davem@davemloft.net> To: weiyongjun1@huawei.com Cc: radhey.shyam.pandey@xilinx.com, michal.simek@xilinx.com, linux@armlinux.org.uk, hancock@sedsystems.ca, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] net: axienet: Fix error return code in axienet_probe() From: David Miller In-Reply-To: <20191106.212441.931590542340055489.davem@davemloft.net> References: <20191106155449.107672-1-weiyongjun1@huawei.com> <20191106.212441.931590542340055489.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Nov 2019 21:25:07 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Miller Date: Wed, 06 Nov 2019 21:24:41 -0800 (PST) > From: Wei Yongjun > Date: Wed, 6 Nov 2019 15:54:49 +0000 > >> In the DMA memory resource get failed case, the error is not >> set and 0 will be returned. Fix it by reove redundant check >> since devm_ioremap_resource() will handle it. >> >> Fixes: 28ef9ebdb64c ("net: axienet: make use of axistream-connected attribute optional") >> Signed-off-by: Wei Yongjun > > Fixed with the commit message typo fixed. I meant "Applied with the commit message typo fixed." :-) From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Thu, 07 Nov 2019 05:25:06 +0000 Subject: Re: [PATCH net-next] net: axienet: Fix error return code in axienet_probe() Message-Id: <20191106.212506.946721274328639751.davem@davemloft.net> List-Id: References: <20191106155449.107672-1-weiyongjun1@huawei.com> <20191106.212441.931590542340055489.davem@davemloft.net> In-Reply-To: <20191106.212441.931590542340055489.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: weiyongjun1@huawei.com Cc: netdev@vger.kernel.org, radhey.shyam.pandey@xilinx.com, kernel-janitors@vger.kernel.org, michal.simek@xilinx.com, linux@armlinux.org.uk, hancock@sedsystems.ca, linux-arm-kernel@lists.infradead.org From: David Miller Date: Wed, 06 Nov 2019 21:24:41 -0800 (PST) > From: Wei Yongjun > Date: Wed, 6 Nov 2019 15:54:49 +0000 > >> In the DMA memory resource get failed case, the error is not >> set and 0 will be returned. Fix it by reove redundant check >> since devm_ioremap_resource() will handle it. >> >> Fixes: 28ef9ebdb64c ("net: axienet: make use of axistream-connected attribute optional") >> Signed-off-by: Wei Yongjun > > Fixed with the commit message typo fixed. I meant "Applied with the commit message typo fixed." :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D472DC5DF61 for ; Thu, 7 Nov 2019 05:25:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4499218AE for ; Thu, 7 Nov 2019 05:25:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZWvT9t5a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4499218AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: From:Subject:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LzTfrDdzc1iwKxoE/cIc25JXWAH2WVTZYNmDtOKGdNg=; b=ZWvT9t5alMMU2r vkAQDvNtSjho59krjZXH+U6YZAlgVt62zHUGSVKYffYMK+IbKgWM1Q9HldeukGw80qzR6DpXmBsdm 5gMenGCPJahItyTLKHrmMNUrDWP/KNB82G2l9r9fnDvraJXKqqJjydbx3MtiRrm/ODln3mBlFdEBU vTSQrTqqmqJlt3QvfV0ef652Pdy2GXOrEEb8UghjZ2Df2tAkyrgcB98fDPr9Ia7IgPaF6M5pP+CbW RjUiRZMLvxkIWSAdJqRq05ps5FqIMblnVMDIe5WVfjNqCYMQZbd4K/j7XZq5JjSO3YHKHCESz/g7a oozxpJOFtkP8PZZAPhTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSaIA-0003Lc-Rj; Thu, 07 Nov 2019 05:25:10 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSaI7-0002uJ-Ah for linux-arm-kernel@lists.infradead.org; Thu, 07 Nov 2019 05:25:08 +0000 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D54F615110082; Wed, 6 Nov 2019 21:25:06 -0800 (PST) Date: Wed, 06 Nov 2019 21:25:06 -0800 (PST) Message-Id: <20191106.212506.946721274328639751.davem@davemloft.net> To: weiyongjun1@huawei.com Subject: Re: [PATCH net-next] net: axienet: Fix error return code in axienet_probe() From: David Miller In-Reply-To: <20191106.212441.931590542340055489.davem@davemloft.net> References: <20191106155449.107672-1-weiyongjun1@huawei.com> <20191106.212441.931590542340055489.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Nov 2019 21:25:07 -0800 (PST) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191106_212507_376137_27ABEE34 X-CRM114-Status: UNSURE ( 6.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, radhey.shyam.pandey@xilinx.com, kernel-janitors@vger.kernel.org, michal.simek@xilinx.com, linux@armlinux.org.uk, hancock@sedsystems.ca, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: David Miller Date: Wed, 06 Nov 2019 21:24:41 -0800 (PST) > From: Wei Yongjun > Date: Wed, 6 Nov 2019 15:54:49 +0000 > >> In the DMA memory resource get failed case, the error is not >> set and 0 will be returned. Fix it by reove redundant check >> since devm_ioremap_resource() will handle it. >> >> Fixes: 28ef9ebdb64c ("net: axienet: make use of axistream-connected attribute optional") >> Signed-off-by: Wei Yongjun > > Fixed with the commit message typo fixed. I meant "Applied with the commit message typo fixed." :-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel