From: Niranjan Vishwanathapura <niranjana.vishwanathapura@intel.com> To: Chris Wilson <chris.p.wilson@intel.com> Cc: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/3] drm/i915: Check for ips_mchdev being NULL Date: Tue, 5 Nov 2019 18:14:45 -0800 [thread overview] Message-ID: <20191106021444.GE19940@nvishwa1-DESK.sc.intel.com> (raw) In-Reply-To: <157300063402.21573.3655512947994232648@skylake-alporthouse-com> On Wed, Nov 06, 2019 at 12:37:14AM +0000, Chris Wilson wrote: >Quoting Niranjana Vishwanathapura (2019-11-06 00:02:04) >> Guard against uninitalized (NULL) ips_mchdev before >> dereferencing. > >Because? I am seeing some exported functions like i915_read_mch_val() that try to dereference ips_mchdev via mchdev_get(). I don't know full usage here, but probably make these APIs fail safe? Niranjana >-Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Niranjan Vishwanathapura <niranjana.vishwanathapura@intel.com> To: Chris Wilson <chris.p.wilson@intel.com> Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915: Check for ips_mchdev being NULL Date: Tue, 5 Nov 2019 18:14:45 -0800 [thread overview] Message-ID: <20191106021444.GE19940@nvishwa1-DESK.sc.intel.com> (raw) Message-ID: <20191106021445.8wHDApTM8t5RL3onNxyXlgD84u9Xymx9zw6MfQodmJ4@z> (raw) In-Reply-To: <157300063402.21573.3655512947994232648@skylake-alporthouse-com> On Wed, Nov 06, 2019 at 12:37:14AM +0000, Chris Wilson wrote: >Quoting Niranjana Vishwanathapura (2019-11-06 00:02:04) >> Guard against uninitalized (NULL) ips_mchdev before >> dereferencing. > >Because? I am seeing some exported functions like i915_read_mch_val() that try to dereference ips_mchdev via mchdev_get(). I don't know full usage here, but probably make these APIs fail safe? Niranjana >-Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-06 2:26 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20191106000205.22480-1-niranjana.vishwanathapura@intel.com> [not found] ` <20191106000205.22480-4-niranjana.vishwanathapura@intel.com> 2019-11-06 0:36 ` [PATCH 3/3] drm/i915: Use rcu_dereference for rcu protected pointer Chris Wilson 2019-11-06 0:36 ` [Intel-gfx] " Chris Wilson 2019-11-06 2:16 ` Niranjan Vishwanathapura 2019-11-06 2:16 ` [Intel-gfx] " Niranjan Vishwanathapura 2019-11-06 8:52 ` Chris Wilson 2019-11-06 8:52 ` [Intel-gfx] " Chris Wilson 2019-11-07 5:05 ` Niranjan Vishwanathapura 2019-11-07 5:05 ` [Intel-gfx] " Niranjan Vishwanathapura 2019-11-07 9:49 ` Chris Wilson 2019-11-07 9:49 ` [Intel-gfx] " Chris Wilson [not found] ` <20191106000205.22480-3-niranjana.vishwanathapura@intel.com> 2019-11-06 0:37 ` [PATCH 2/3] drm/i915: Check for ips_mchdev being NULL Chris Wilson 2019-11-06 0:37 ` [Intel-gfx] " Chris Wilson 2019-11-06 2:14 ` Niranjan Vishwanathapura [this message] 2019-11-06 2:14 ` Niranjan Vishwanathapura 2019-11-06 8:40 ` Chris Wilson 2019-11-06 8:40 ` [Intel-gfx] " Chris Wilson [not found] ` <20191106000205.22480-2-niranjana.vishwanathapura@intel.com> 2019-11-06 0:42 ` [PATCH 1/3] drm/i915: Remove unwanted rcu_read_lock/unlock Chris Wilson 2019-11-06 0:42 ` [Intel-gfx] " Chris Wilson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191106021444.GE19940@nvishwa1-DESK.sc.intel.com \ --to=niranjana.vishwanathapura@intel.com \ --cc=chris.p.wilson@intel.com \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.