All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	daniel@iogearbox.net, oss-drivers@netronome.com
Subject: Re: [PATCH net-next 1/2] netdevsim: drop code duplicated by a merge
Date: Wed, 6 Nov 2019 09:55:33 +0100	[thread overview]
Message-ID: <20191106085533.GF2112@nanopsycho> (raw)
In-Reply-To: <20191105212612.10737-2-jakub.kicinski@netronome.com>

Tue, Nov 05, 2019 at 10:26:11PM CET, jakub.kicinski@netronome.com wrote:
>Looks like the port adding loop makes a re-appearance on net-next
>after net was merged back into it (even though it doesn't feature
>in the merge diff).
>
>The ports are already added in nsim_dev_create() so when we try
>to add them again get EEXIST, and see:
>
>netdevsim: probe of netdevsim0 failed with error -17
>
>in the logs. When we remove the loop again the nsim_dev_probe()
>and nsim_dev_remove() become a wrapper of nsim_dev_create() and
>nsim_dev_destroy(). Remove this layer of indirection.
>
>Fixes: d31e95585ca6 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
>Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>

lgtm
Acked-by: Jiri Pirko <jiri@mellanox.com>

  reply	other threads:[~2019-11-06  8:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 21:26 [PATCH net-next 0/2] netdevsim: fix tests and netdevsim Jakub Kicinski
2019-11-05 21:26 ` [PATCH net-next 1/2] netdevsim: drop code duplicated by a merge Jakub Kicinski
2019-11-06  8:55   ` Jiri Pirko [this message]
2019-11-05 21:26 ` [PATCH net-next 2/2] selftests: bpf: log direct file writes Jakub Kicinski
2019-11-06 12:42   ` Daniel Borkmann
2019-11-06 18:12 ` [PATCH net-next 0/2] netdevsim: fix tests and netdevsim David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106085533.GF2112@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.