From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90700C5DF62 for ; Wed, 6 Nov 2019 09:13:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 582D92178F for ; Wed, 6 Nov 2019 09:13:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="JZ7pcRrn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727084AbfKFJNi (ORCPT ); Wed, 6 Nov 2019 04:13:38 -0500 Received: from onstation.org ([52.200.56.107]:50818 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbfKFJNh (ORCPT ); Wed, 6 Nov 2019 04:13:37 -0500 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id 4C6AD3E89E; Wed, 6 Nov 2019 09:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1573031616; bh=RUF1WwHyOvF/ICJ9FPqUfBjj8jBynQSgDGGQCKj3KcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JZ7pcRrncpt2INI1fhnGVZld48I0H1BWpwgs/IFVtpcbeS3G0hex4iVWfr2R9CiAk ilG9jWvfBz7JtizUD21xVJSid8A/XPYJn+J3RL0SvBM2aS0s7PV+nkZrLi5UUPcbiG WncMd6mFPNbEg7eMg5YKAyiHFBJs1AopFvKSpK7Y= Date: Wed, 6 Nov 2019 04:13:35 -0500 From: Brian Masney To: Rob Clark Cc: Rob Clark , freedreno , Sean Paul , Linux Kernel Mailing List , dri-devel , linux-arm-msm Subject: Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes Message-ID: <20191106091335.GA16729@onstation.org> References: <20191105000129.GA6536@onstation.org> <20191105100804.GA9492@onstation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Nov 05, 2019 at 08:23:27AM -0800, Rob Clark wrote: > On Tue, Nov 5, 2019 at 2:08 AM Brian Masney wrote: > > The 'pp done time out' errors go away if I revert the following three > > commits: > > > > cd6d923167b1 ("drm/msm/dpu: async commit support") > > d934a712c5e6 ("drm/msm: add atomic traces") > > 2d99ced787e3 ("drm/msm: async commit support") > > > > I reverted the first one to fix a compiler error, and the second one so > > that the last patch can be reverted without any merge conflicts. > > > > I see that crtc_flush() calls mdp5_ctl_commit(). I tried to use > > crtc_flush_all() in mdp5_flush_commit() and the contents of the frame > > buffer dance around the screen like its out of sync. I renamed > > crtc_flush_all() to mdp5_crtc_flush_all() and removed the static > > declaration. Here's the relevant part of what I tried: > > > > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > > @@ -171,7 +171,15 @@ static void mdp5_prepare_commit(struct msm_kms *kms, struct drm_atomic_state *st > > > > static void mdp5_flush_commit(struct msm_kms *kms, unsigned crtc_mask) > > { > > - /* TODO */ > > + struct mdp5_kms *mdp5_kms = to_mdp5_kms(to_mdp_kms(kms)); > > + struct drm_crtc *crtc; > > + > > + for_each_crtc_mask(mdp5_kms->dev, crtc, crtc_mask) { > > + if (!crtc->state->active) > > + continue; > > + > > + mdp5_crtc_flush_all(crtc); > > + } > > } > > > > Any tips would be appreciated. > > > I think this is along the lines of what we need to enable async commit > for mdp5 (but also removing the flush from the atomic-commit path).. > the principle behind the async commit is to do all the atomic state > commit normally, but defer writing the flush bits. This way, if you > get another async update before the next vblank, you just apply it > immediately instead of waiting for vblank. > > But I guess you are on a command mode panel, if I remember? Which is > a case I didn't have a way to test. And I'm not entirely about how > kms_funcs->vsync_time() should be implemented for cmd mode panels. Yes, this is a command-mode panel and there's no hardware frame counter available. The key to getting the display working on this phone was this patch: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2bab52af6fe68c43b327a57e5ce5fc10eefdfadf > That all said, I think we should first fix what is broken, before > worrying about extending async commit support to mdp5.. which > shouldn't hit the async==true path, due to not implementing > kms_funcs->vsync_time(). > > What I think is going on is that, in the cmd mode case, > mdp5_wait_flush() (indirectly) calls mdp5_crtc_wait_for_pp_done(), > which waits for a pp-done irq regardless of whether there is a flush > in progress. Since there is no flush pending, the irq never comes. > But the expectation is that kms_funcs->wait_flush() returns > immediately if there is nothing to wait for. I don't think that's happening in this case. I added some pr_info() statements to request_pp_done_pending() and mdp5_crtc_pp_done_irq(). Here's the first two sets of messages that appear in dmesg: [ 14.018907] msm fd900000.mdss: pp done time out, lm=0 [ 14.018993] request_pp_done_pending: HERE [ 14.074208] mdp5_crtc_pp_done_irq: HERE [ 14.074368] Console: switching to colour frame buffer device 135x120 [ 14.138938] msm fd900000.mdss: pp done time out, lm=0 [ 14.139021] request_pp_done_pending: HERE [ 14.158097] mdp5_crtc_pp_done_irq: HERE The messages go on like this with the same pattern. I tried two different changes: 1) I moved the request_pp_done_pending() and corresponding if statement from mdp5_crtc_atomic_flush() and into mdp5_crtc_atomic_begin(). 2) I increased the timeout in wait_for_completion_timeout() by several increments; all the way to 5 seconds. I haven't dug into the new code anymore. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89249C5DF61 for ; Thu, 7 Nov 2019 07:43:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66D9921882 for ; Thu, 7 Nov 2019 07:43:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66D9921882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=onstation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A8CF6EE9B; Thu, 7 Nov 2019 07:43:24 +0000 (UTC) Received: from onstation.org (onstation.org [52.200.56.107]) by gabe.freedesktop.org (Postfix) with ESMTPS id 823AB6EC69; Wed, 6 Nov 2019 09:13:38 +0000 (UTC) Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id 4C6AD3E89E; Wed, 6 Nov 2019 09:13:36 +0000 (UTC) Date: Wed, 6 Nov 2019 04:13:35 -0500 From: Brian Masney To: Rob Clark Subject: Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes Message-ID: <20191106091335.GA16729@onstation.org> References: <20191105000129.GA6536@onstation.org> <20191105100804.GA9492@onstation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Thu, 07 Nov 2019 07:43:23 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1573031616; bh=RUF1WwHyOvF/ICJ9FPqUfBjj8jBynQSgDGGQCKj3KcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JZ7pcRrncpt2INI1fhnGVZld48I0H1BWpwgs/IFVtpcbeS3G0hex4iVWfr2R9CiAk ilG9jWvfBz7JtizUD21xVJSid8A/XPYJn+J3RL0SvBM2aS0s7PV+nkZrLi5UUPcbiG WncMd6mFPNbEg7eMg5YKAyiHFBJs1AopFvKSpK7Y= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , freedreno , Linux Kernel Mailing List , dri-devel , linux-arm-msm , Sean Paul Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191106091335.9CAOpAxVbh6Wfq6Er6WgWLhcjez7ELvm6GiHsJe6H6Y@z> T24gVHVlLCBOb3YgMDUsIDIwMTkgYXQgMDg6MjM6MjdBTSAtMDgwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IE9uIFR1ZSwgTm92IDUsIDIwMTkgYXQgMjowOCBBTSBCcmlhbiBNYXNuZXkgPG1hc25leWJA b25zdGF0aW9uLm9yZz4gd3JvdGU6Cj4gPiBUaGUgJ3BwIGRvbmUgdGltZSBvdXQnIGVycm9ycyBn byBhd2F5IGlmIEkgcmV2ZXJ0IHRoZSBmb2xsb3dpbmcgdGhyZWUKPiA+IGNvbW1pdHM6Cj4gPgo+ ID4gY2Q2ZDkyMzE2N2IxICgiZHJtL21zbS9kcHU6IGFzeW5jIGNvbW1pdCBzdXBwb3J0IikKPiA+ IGQ5MzRhNzEyYzVlNiAoImRybS9tc206IGFkZCBhdG9taWMgdHJhY2VzIikKPiA+IDJkOTljZWQ3 ODdlMyAoImRybS9tc206IGFzeW5jIGNvbW1pdCBzdXBwb3J0IikKPiA+Cj4gPiBJIHJldmVydGVk IHRoZSBmaXJzdCBvbmUgdG8gZml4IGEgY29tcGlsZXIgZXJyb3IsIGFuZCB0aGUgc2Vjb25kIG9u ZSBzbwo+ID4gdGhhdCB0aGUgbGFzdCBwYXRjaCBjYW4gYmUgcmV2ZXJ0ZWQgd2l0aG91dCBhbnkg bWVyZ2UgY29uZmxpY3RzLgo+ID4KPiA+IEkgc2VlIHRoYXQgY3J0Y19mbHVzaCgpIGNhbGxzIG1k cDVfY3RsX2NvbW1pdCgpLiBJIHRyaWVkIHRvIHVzZQo+ID4gY3J0Y19mbHVzaF9hbGwoKSBpbiBt ZHA1X2ZsdXNoX2NvbW1pdCgpIGFuZCB0aGUgY29udGVudHMgb2YgdGhlIGZyYW1lCj4gPiBidWZm ZXIgZGFuY2UgYXJvdW5kIHRoZSBzY3JlZW4gbGlrZSBpdHMgb3V0IG9mIHN5bmMuIEkgcmVuYW1l ZAo+ID4gY3J0Y19mbHVzaF9hbGwoKSB0byBtZHA1X2NydGNfZmx1c2hfYWxsKCkgYW5kIHJlbW92 ZWQgdGhlIHN0YXRpYwo+ID4gZGVjbGFyYXRpb24uIEhlcmUncyB0aGUgcmVsZXZhbnQgcGFydCBv ZiB3aGF0IEkgdHJpZWQ6Cj4gPgo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL21k cDUvbWRwNV9rbXMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL21kcDUvbWRw NV9rbXMuYwo+ID4gQEAgLTE3MSw3ICsxNzEsMTUgQEAgc3RhdGljIHZvaWQgbWRwNV9wcmVwYXJl X2NvbW1pdChzdHJ1Y3QgbXNtX2ttcyAqa21zLCBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3QK PiA+Cj4gPiAgc3RhdGljIHZvaWQgbWRwNV9mbHVzaF9jb21taXQoc3RydWN0IG1zbV9rbXMgKmtt cywgdW5zaWduZWQgY3J0Y19tYXNrKQo+ID4gIHsKPiA+IC0gICAgICAgLyogVE9ETyAqLwo+ID4g KyAgICAgICBzdHJ1Y3QgbWRwNV9rbXMgKm1kcDVfa21zID0gdG9fbWRwNV9rbXModG9fbWRwX2tt cyhrbXMpKTsKPiA+ICsgICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ID4gKwo+ID4gKyAg ICAgICBmb3JfZWFjaF9jcnRjX21hc2sobWRwNV9rbXMtPmRldiwgY3J0YywgY3J0Y19tYXNrKSB7 Cj4gPiArICAgICAgICAgICAgICAgaWYgKCFjcnRjLT5zdGF0ZS0+YWN0aXZlKQo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgY29udGludWU7Cj4gPiArCj4gPiArICAgICAgICAgICAgICAgbWRw NV9jcnRjX2ZsdXNoX2FsbChjcnRjKTsKPiA+ICsgICAgICAgfQo+ID4gIH0KPiA+Cj4gPiBBbnkg dGlwcyB3b3VsZCBiZSBhcHByZWNpYXRlZC4KPiAKPiAKPiBJIHRoaW5rIHRoaXMgaXMgYWxvbmcg dGhlIGxpbmVzIG9mIHdoYXQgd2UgbmVlZCB0byBlbmFibGUgYXN5bmMgY29tbWl0Cj4gZm9yIG1k cDUgKGJ1dCBhbHNvIHJlbW92aW5nIHRoZSBmbHVzaCBmcm9tIHRoZSBhdG9taWMtY29tbWl0IHBh dGgpLi4KPiB0aGUgcHJpbmNpcGxlIGJlaGluZCB0aGUgYXN5bmMgY29tbWl0IGlzIHRvIGRvIGFs bCB0aGUgYXRvbWljIHN0YXRlCj4gY29tbWl0IG5vcm1hbGx5LCBidXQgZGVmZXIgd3JpdGluZyB0 aGUgZmx1c2ggYml0cy4gIFRoaXMgd2F5LCBpZiB5b3UKPiBnZXQgYW5vdGhlciBhc3luYyB1cGRh dGUgYmVmb3JlIHRoZSBuZXh0IHZibGFuaywgeW91IGp1c3QgYXBwbHkgaXQKPiBpbW1lZGlhdGVs eSBpbnN0ZWFkIG9mIHdhaXRpbmcgZm9yIHZibGFuay4KPiAKPiBCdXQgSSBndWVzcyB5b3UgYXJl IG9uIGEgY29tbWFuZCBtb2RlIHBhbmVsLCBpZiBJIHJlbWVtYmVyPyAgV2hpY2ggaXMKPiBhIGNh c2UgSSBkaWRuJ3QgaGF2ZSBhIHdheSB0byB0ZXN0LiAgQW5kIEknbSBub3QgZW50aXJlbHkgYWJv dXQgaG93Cj4ga21zX2Z1bmNzLT52c3luY190aW1lKCkgc2hvdWxkIGJlIGltcGxlbWVudGVkIGZv ciBjbWQgbW9kZSBwYW5lbHMuCgpZZXMsIHRoaXMgaXMgYSBjb21tYW5kLW1vZGUgcGFuZWwgYW5k IHRoZXJlJ3Mgbm8gaGFyZHdhcmUgZnJhbWUgY291bnRlcgphdmFpbGFibGUuIFRoZSBrZXkgdG8g Z2V0dGluZyB0aGUgZGlzcGxheSB3b3JraW5nIG9uIHRoaXMgcGhvbmUgd2FzIHRoaXMKcGF0Y2g6 Cmh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRz L2xpbnV4LmdpdC9jb21taXQvP2lkPTJiYWI1MmFmNmZlNjhjNDNiMzI3YTU3ZTVjZTVmYzEwZWVm ZGZhZGYKCj4gVGhhdCBhbGwgc2FpZCwgSSB0aGluayB3ZSBzaG91bGQgZmlyc3QgZml4IHdoYXQg aXMgYnJva2VuLCBiZWZvcmUKPiB3b3JyeWluZyBhYm91dCBleHRlbmRpbmcgYXN5bmMgY29tbWl0 IHN1cHBvcnQgdG8gbWRwNS4uIHdoaWNoCj4gc2hvdWxkbid0IGhpdCB0aGUgYXN5bmM9PXRydWUg cGF0aCwgZHVlIHRvIG5vdCBpbXBsZW1lbnRpbmcKPiBrbXNfZnVuY3MtPnZzeW5jX3RpbWUoKS4K PiAKPiBXaGF0IEkgdGhpbmsgaXMgZ29pbmcgb24gaXMgdGhhdCwgaW4gdGhlIGNtZCBtb2RlIGNh c2UsCj4gbWRwNV93YWl0X2ZsdXNoKCkgKGluZGlyZWN0bHkpIGNhbGxzIG1kcDVfY3J0Y193YWl0 X2Zvcl9wcF9kb25lKCksCj4gd2hpY2ggd2FpdHMgZm9yIGEgcHAtZG9uZSBpcnEgcmVnYXJkbGVz cyBvZiB3aGV0aGVyIHRoZXJlIGlzIGEgZmx1c2gKPiBpbiBwcm9ncmVzcy4gIFNpbmNlIHRoZXJl IGlzIG5vIGZsdXNoIHBlbmRpbmcsIHRoZSBpcnEgbmV2ZXIgY29tZXMuCj4gQnV0IHRoZSBleHBl Y3RhdGlvbiBpcyB0aGF0IGttc19mdW5jcy0+d2FpdF9mbHVzaCgpIHJldHVybnMKPiBpbW1lZGlh dGVseSBpZiB0aGVyZSBpcyBub3RoaW5nIHRvIHdhaXQgZm9yLgoKSSBkb24ndCB0aGluayB0aGF0 J3MgaGFwcGVuaW5nIGluIHRoaXMgY2FzZS4gSSBhZGRlZCBzb21lIHByX2luZm8oKQpzdGF0ZW1l bnRzIHRvIHJlcXVlc3RfcHBfZG9uZV9wZW5kaW5nKCkgYW5kIG1kcDVfY3J0Y19wcF9kb25lX2ly cSgpLgpIZXJlJ3MgdGhlIGZpcnN0IHR3byBzZXRzIG9mIG1lc3NhZ2VzIHRoYXQgYXBwZWFyIGlu IGRtZXNnOgoKWyAgIDE0LjAxODkwN10gbXNtIGZkOTAwMDAwLm1kc3M6IHBwIGRvbmUgdGltZSBv dXQsIGxtPTAKWyAgIDE0LjAxODk5M10gcmVxdWVzdF9wcF9kb25lX3BlbmRpbmc6IEhFUkUKWyAg IDE0LjA3NDIwOF0gbWRwNV9jcnRjX3BwX2RvbmVfaXJxOiBIRVJFClsgICAxNC4wNzQzNjhdIENv bnNvbGU6IHN3aXRjaGluZyB0byBjb2xvdXIgZnJhbWUgYnVmZmVyIGRldmljZSAxMzV4MTIwClsg ICAxNC4xMzg5MzhdIG1zbSBmZDkwMDAwMC5tZHNzOiBwcCBkb25lIHRpbWUgb3V0LCBsbT0wClsg ICAxNC4xMzkwMjFdIHJlcXVlc3RfcHBfZG9uZV9wZW5kaW5nOiBIRVJFClsgICAxNC4xNTgwOTdd IG1kcDVfY3J0Y19wcF9kb25lX2lycTogSEVSRQoKVGhlIG1lc3NhZ2VzIGdvIG9uIGxpa2UgdGhp cyB3aXRoIHRoZSBzYW1lIHBhdHRlcm4uCgpJIHRyaWVkIHR3byBkaWZmZXJlbnQgY2hhbmdlczoK CjEpIEkgbW92ZWQgdGhlIHJlcXVlc3RfcHBfZG9uZV9wZW5kaW5nKCkgYW5kIGNvcnJlc3BvbmRp bmcgaWYgc3RhdGVtZW50CiAgIGZyb20gbWRwNV9jcnRjX2F0b21pY19mbHVzaCgpIGFuZCBpbnRv IG1kcDVfY3J0Y19hdG9taWNfYmVnaW4oKS4KCjIpIEkgaW5jcmVhc2VkIHRoZSB0aW1lb3V0IGlu IHdhaXRfZm9yX2NvbXBsZXRpb25fdGltZW91dCgpIGJ5IHNldmVyYWwKICAgaW5jcmVtZW50czsg YWxsIHRoZSB3YXkgdG8gNSBzZWNvbmRzLgoKSSBoYXZlbid0IGR1ZyBpbnRvIHRoZSBuZXcgY29k ZSBhbnltb3JlLgoKQnJpYW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVs