All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-10-29 16:51 ` Matthew Auld
  0 siblings, 0 replies; 22+ messages in thread
From: Matthew Auld @ 2019-10-29 16:51 UTC (permalink / raw)
  To: intel-gfx

Intended for upstream testing so that we can still exercise the LMEM
plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
device. This works by allocating an intel_memory_region for a reserved
portion of system memory, which we treat like LMEM. For the LMEMBAR we
steal the aperture and 1:1 it map to the stolen region.

To enable simply set the i915 modparam fake_lmem_start= on the kernel
cmdline with the start of reserved region(see memmap=). The size of the
region we can use is determined by the size of the mappable aperture, so
the size of reserved region should be >= mappable_end. For now we only
enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
enabled.

eg. memmap=2G$16G i915.fake_lmem_start=0x400000000

v2: make fake_lmem_start an i915 modparam

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gem/i915_gem_lmem.c   |  3 +
 drivers/gpu/drm/i915/i915_drv.c            | 15 ++++
 drivers/gpu/drm/i915/i915_params.c         |  5 ++
 drivers/gpu/drm/i915/i915_params.h         |  1 +
 drivers/gpu/drm/i915/intel_memory_region.c |  3 +
 drivers/gpu/drm/i915/intel_memory_region.h |  6 ++
 drivers/gpu/drm/i915/intel_region_lmem.c   | 92 ++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_region_lmem.h   |  5 ++
 8 files changed, 130 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_lmem.c b/drivers/gpu/drm/i915/gem/i915_gem_lmem.c
index 926f6c940e0d..0e2bf6b7e143 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_lmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_lmem.c
@@ -24,6 +24,7 @@ i915_gem_object_lmem_io_map_page(struct drm_i915_gem_object *obj,
 	resource_size_t offset;
 
 	offset = i915_gem_object_get_dma_address(obj, n);
+	offset -= obj->mm.region->region.start;
 
 	return io_mapping_map_wc(&obj->mm.region->iomap, offset, PAGE_SIZE);
 }
@@ -35,6 +36,7 @@ i915_gem_object_lmem_io_map_page_atomic(struct drm_i915_gem_object *obj,
 	resource_size_t offset;
 
 	offset = i915_gem_object_get_dma_address(obj, n);
+	offset -= obj->mm.region->region.start;
 
 	return io_mapping_map_atomic_wc(&obj->mm.region->iomap, offset);
 }
@@ -49,6 +51,7 @@ i915_gem_object_lmem_io_map(struct drm_i915_gem_object *obj,
 	GEM_BUG_ON(!i915_gem_object_is_contiguous(obj));
 
 	offset = i915_gem_object_get_dma_address(obj, n);
+	offset -= obj->mm.region->region.start;
 
 	return io_mapping_map_wc(&obj->mm.region->iomap, offset, size);
 }
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 21273b516dbe..db1736d95651 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1483,6 +1483,21 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (!i915_modparams.nuclear_pageflip && match_info->gen < 5)
 		dev_priv->drm.driver_features &= ~DRIVER_ATOMIC;
 
+	/*
+	 * Check if we support fake LMEM -- for now we only unleash this for
+	 * the live selftests.
+	 */
+	if (IS_ENABLED(CONFIG_DRM_I915_UNSTABLE)) {
+		if (INTEL_GEN(dev_priv) >= 9 && i915_selftest.live &&
+		    i915_modparams.fake_lmem_start) {
+			mkwrite_device_info(dev_priv)->memory_regions =
+				REGION_SMEM | REGION_LMEM | REGION_STOLEN;
+			mkwrite_device_info(dev_priv)->is_dgfx = true;
+			GEM_BUG_ON(!HAS_LMEM(dev_priv));
+			GEM_BUG_ON(!IS_DGFX(dev_priv));
+		}
+	}
+
 	ret = pci_enable_device(pdev);
 	if (ret)
 		goto out_fini;
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 3fa79adb2c1c..9db3437fbd14 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -179,6 +179,11 @@ i915_param_named(enable_gvt, bool, 0400,
 	"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
 #endif
 
+#if IS_ENABLED(CONFIG_DRM_I915_UNSTABLE)
+i915_param_named_unsafe(fake_lmem_start, ulong, 0600,
+	"Fake LMEM start offset (default: 0)");
+#endif
+
 static __always_inline void _print_param(struct drm_printer *p,
 					 const char *name,
 					 const char *type,
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index a276317ad74b..31b88f297fbc 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -66,6 +66,7 @@ struct drm_printer;
 	param(int, fastboot, -1) \
 	param(int, enable_dpcd_backlight, 0) \
 	param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE) \
+	param(unsigned long, fake_lmem_start, 0) \
 	/* leave bools at the end to not create holes */ \
 	param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
 	param(bool, enable_hangcheck, true) \
diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c
index a60f77ff58d4..baaeaecc64af 100644
--- a/drivers/gpu/drm/i915/intel_memory_region.c
+++ b/drivers/gpu/drm/i915/intel_memory_region.c
@@ -228,6 +228,9 @@ int intel_memory_regions_hw_probe(struct drm_i915_private *i915)
 		case INTEL_MEMORY_STOLEN:
 			mem = i915_gem_stolen_setup(i915);
 			break;
+		case INTEL_MEMORY_LOCAL:
+			mem = intel_setup_fake_lmem(i915);
+			break;
 		}
 
 		if (IS_ERR(mem)) {
diff --git a/drivers/gpu/drm/i915/intel_memory_region.h b/drivers/gpu/drm/i915/intel_memory_region.h
index 19920c256ede..238722009677 100644
--- a/drivers/gpu/drm/i915/intel_memory_region.h
+++ b/drivers/gpu/drm/i915/intel_memory_region.h
@@ -10,6 +10,7 @@
 #include <linux/ioport.h>
 #include <linux/mutex.h>
 #include <linux/io-mapping.h>
+#include <drm/drm_mm.h>
 
 #include "i915_buddy.h"
 
@@ -71,6 +72,9 @@ struct intel_memory_region {
 	struct io_mapping iomap;
 	struct resource region;
 
+	/* For fake LMEM */
+	struct drm_mm_node fake_mappable;
+
 	struct i915_buddy_mm mm;
 	struct mutex mm_lock;
 
@@ -83,6 +87,8 @@ struct intel_memory_region {
 	unsigned int instance;
 	unsigned int id;
 
+	dma_addr_t remap_addr;
+
 	struct {
 		struct mutex lock; /* Protects access to objects */
 		struct list_head list;
diff --git a/drivers/gpu/drm/i915/intel_region_lmem.c b/drivers/gpu/drm/i915/intel_region_lmem.c
index 9a351af45ce6..583118095635 100644
--- a/drivers/gpu/drm/i915/intel_region_lmem.c
+++ b/drivers/gpu/drm/i915/intel_region_lmem.c
@@ -9,9 +9,62 @@
 #include "gem/i915_gem_region.h"
 #include "intel_region_lmem.h"
 
+static int init_fake_lmem_bar(struct intel_memory_region *mem)
+{
+	struct drm_i915_private *i915 = mem->i915;
+	struct i915_ggtt *ggtt = &i915->ggtt;
+	unsigned long n;
+	int ret;
+
+	/* We want to 1:1 map the mappable aperture to our reserved region */
+
+	mem->fake_mappable.start = 0;
+	mem->fake_mappable.size = resource_size(&mem->region);
+	mem->fake_mappable.color = I915_COLOR_UNEVICTABLE;
+
+	ret = drm_mm_reserve_node(&ggtt->vm.mm, &mem->fake_mappable);
+	if (ret)
+		return ret;
+
+	mem->remap_addr = dma_map_resource(&i915->drm.pdev->dev,
+					   mem->region.start,
+					   mem->fake_mappable.size,
+					   PCI_DMA_BIDIRECTIONAL,
+					   DMA_ATTR_FORCE_CONTIGUOUS);
+	if (dma_mapping_error(&i915->drm.pdev->dev, mem->remap_addr)) {
+		drm_mm_remove_node(&mem->fake_mappable);
+		return -EINVAL;
+	}
+
+	for (n = 0; n < mem->fake_mappable.size >> PAGE_SHIFT; ++n) {
+		ggtt->vm.insert_page(&ggtt->vm,
+				     mem->remap_addr + (n << PAGE_SHIFT),
+				     n << PAGE_SHIFT,
+				     I915_CACHE_NONE, 0);
+	}
+
+	mem->region = (struct resource)DEFINE_RES_MEM(mem->remap_addr,
+						      mem->fake_mappable.size);
+
+	return 0;
+}
+
+static void release_fake_lmem_bar(struct intel_memory_region *mem)
+{
+	if (drm_mm_node_allocated(&mem->fake_mappable))
+		drm_mm_remove_node(&mem->fake_mappable);
+
+	dma_unmap_resource(&mem->i915->drm.pdev->dev,
+			   mem->remap_addr,
+			   mem->fake_mappable.size,
+			   PCI_DMA_BIDIRECTIONAL,
+			   DMA_ATTR_FORCE_CONTIGUOUS);
+}
+
 static void
 region_lmem_release(struct intel_memory_region *mem)
 {
+	release_fake_lmem_bar(mem);
 	io_mapping_fini(&mem->iomap);
 	intel_memory_region_release_buddy(mem);
 }
@@ -21,6 +74,11 @@ region_lmem_init(struct intel_memory_region *mem)
 {
 	int ret;
 
+	if (i915_modparams.fake_lmem_start) {
+		ret = init_fake_lmem_bar(mem);
+		GEM_BUG_ON(ret);
+	}
+
 	if (!io_mapping_init_wc(&mem->iomap,
 				mem->io_start,
 				resource_size(&mem->region)))
@@ -38,3 +96,37 @@ const struct intel_memory_region_ops intel_region_lmem_ops = {
 	.release = region_lmem_release,
 	.create_object = __i915_gem_lmem_object_create,
 };
+
+struct intel_memory_region *
+intel_setup_fake_lmem(struct drm_i915_private *i915)
+{
+	struct pci_dev *pdev = i915->drm.pdev;
+	struct intel_memory_region *mem;
+	resource_size_t mappable_end;
+	resource_size_t io_start;
+	resource_size_t start;
+
+	GEM_BUG_ON(i915_ggtt_has_aperture(&i915->ggtt));
+	GEM_BUG_ON(!i915_modparams.fake_lmem_start);
+
+	/* Your mappable aperture belongs to me now! */
+	mappable_end = pci_resource_len(pdev, 2);
+	io_start = pci_resource_start(pdev, 2),
+	start = i915_modparams.fake_lmem_start;
+
+	mem = intel_memory_region_create(i915,
+					 start,
+					 mappable_end,
+					 PAGE_SIZE,
+					 io_start,
+					 &intel_region_lmem_ops);
+	if (!IS_ERR(mem)) {
+		DRM_INFO("Intel graphics fake LMEM: %pR\n", &mem->region);
+		DRM_INFO("Intel graphics fake LMEM IO start: %llx\n",
+			 (u64)mem->io_start);
+		DRM_INFO("Intel graphics fake LMEM size: %llx\n",
+			 (u64)resource_size(&mem->region));
+	}
+
+	return mem;
+}
diff --git a/drivers/gpu/drm/i915/intel_region_lmem.h b/drivers/gpu/drm/i915/intel_region_lmem.h
index ed2a3bab6443..213def7c7b8a 100644
--- a/drivers/gpu/drm/i915/intel_region_lmem.h
+++ b/drivers/gpu/drm/i915/intel_region_lmem.h
@@ -6,6 +6,11 @@
 #ifndef __INTEL_REGION_LMEM_H
 #define __INTEL_REGION_LMEM_H
 
+struct drm_i915_private;
+
 extern const struct intel_memory_region_ops intel_region_lmem_ops;
 
+struct intel_memory_region *
+intel_setup_fake_lmem(struct drm_i915_private *i915);
+
 #endif /* !__INTEL_REGION_LMEM_H */
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-10-29 16:51 ` Matthew Auld
  0 siblings, 0 replies; 22+ messages in thread
From: Matthew Auld @ 2019-10-29 16:51 UTC (permalink / raw)
  To: intel-gfx

Intended for upstream testing so that we can still exercise the LMEM
plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
device. This works by allocating an intel_memory_region for a reserved
portion of system memory, which we treat like LMEM. For the LMEMBAR we
steal the aperture and 1:1 it map to the stolen region.

To enable simply set the i915 modparam fake_lmem_start= on the kernel
cmdline with the start of reserved region(see memmap=). The size of the
region we can use is determined by the size of the mappable aperture, so
the size of reserved region should be >= mappable_end. For now we only
enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
enabled.

eg. memmap=2G$16G i915.fake_lmem_start=0x400000000

v2: make fake_lmem_start an i915 modparam

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gem/i915_gem_lmem.c   |  3 +
 drivers/gpu/drm/i915/i915_drv.c            | 15 ++++
 drivers/gpu/drm/i915/i915_params.c         |  5 ++
 drivers/gpu/drm/i915/i915_params.h         |  1 +
 drivers/gpu/drm/i915/intel_memory_region.c |  3 +
 drivers/gpu/drm/i915/intel_memory_region.h |  6 ++
 drivers/gpu/drm/i915/intel_region_lmem.c   | 92 ++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_region_lmem.h   |  5 ++
 8 files changed, 130 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_lmem.c b/drivers/gpu/drm/i915/gem/i915_gem_lmem.c
index 926f6c940e0d..0e2bf6b7e143 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_lmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_lmem.c
@@ -24,6 +24,7 @@ i915_gem_object_lmem_io_map_page(struct drm_i915_gem_object *obj,
 	resource_size_t offset;
 
 	offset = i915_gem_object_get_dma_address(obj, n);
+	offset -= obj->mm.region->region.start;
 
 	return io_mapping_map_wc(&obj->mm.region->iomap, offset, PAGE_SIZE);
 }
@@ -35,6 +36,7 @@ i915_gem_object_lmem_io_map_page_atomic(struct drm_i915_gem_object *obj,
 	resource_size_t offset;
 
 	offset = i915_gem_object_get_dma_address(obj, n);
+	offset -= obj->mm.region->region.start;
 
 	return io_mapping_map_atomic_wc(&obj->mm.region->iomap, offset);
 }
@@ -49,6 +51,7 @@ i915_gem_object_lmem_io_map(struct drm_i915_gem_object *obj,
 	GEM_BUG_ON(!i915_gem_object_is_contiguous(obj));
 
 	offset = i915_gem_object_get_dma_address(obj, n);
+	offset -= obj->mm.region->region.start;
 
 	return io_mapping_map_wc(&obj->mm.region->iomap, offset, size);
 }
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 21273b516dbe..db1736d95651 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1483,6 +1483,21 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (!i915_modparams.nuclear_pageflip && match_info->gen < 5)
 		dev_priv->drm.driver_features &= ~DRIVER_ATOMIC;
 
+	/*
+	 * Check if we support fake LMEM -- for now we only unleash this for
+	 * the live selftests.
+	 */
+	if (IS_ENABLED(CONFIG_DRM_I915_UNSTABLE)) {
+		if (INTEL_GEN(dev_priv) >= 9 && i915_selftest.live &&
+		    i915_modparams.fake_lmem_start) {
+			mkwrite_device_info(dev_priv)->memory_regions =
+				REGION_SMEM | REGION_LMEM | REGION_STOLEN;
+			mkwrite_device_info(dev_priv)->is_dgfx = true;
+			GEM_BUG_ON(!HAS_LMEM(dev_priv));
+			GEM_BUG_ON(!IS_DGFX(dev_priv));
+		}
+	}
+
 	ret = pci_enable_device(pdev);
 	if (ret)
 		goto out_fini;
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 3fa79adb2c1c..9db3437fbd14 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -179,6 +179,11 @@ i915_param_named(enable_gvt, bool, 0400,
 	"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
 #endif
 
+#if IS_ENABLED(CONFIG_DRM_I915_UNSTABLE)
+i915_param_named_unsafe(fake_lmem_start, ulong, 0600,
+	"Fake LMEM start offset (default: 0)");
+#endif
+
 static __always_inline void _print_param(struct drm_printer *p,
 					 const char *name,
 					 const char *type,
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index a276317ad74b..31b88f297fbc 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -66,6 +66,7 @@ struct drm_printer;
 	param(int, fastboot, -1) \
 	param(int, enable_dpcd_backlight, 0) \
 	param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE) \
+	param(unsigned long, fake_lmem_start, 0) \
 	/* leave bools at the end to not create holes */ \
 	param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
 	param(bool, enable_hangcheck, true) \
diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c
index a60f77ff58d4..baaeaecc64af 100644
--- a/drivers/gpu/drm/i915/intel_memory_region.c
+++ b/drivers/gpu/drm/i915/intel_memory_region.c
@@ -228,6 +228,9 @@ int intel_memory_regions_hw_probe(struct drm_i915_private *i915)
 		case INTEL_MEMORY_STOLEN:
 			mem = i915_gem_stolen_setup(i915);
 			break;
+		case INTEL_MEMORY_LOCAL:
+			mem = intel_setup_fake_lmem(i915);
+			break;
 		}
 
 		if (IS_ERR(mem)) {
diff --git a/drivers/gpu/drm/i915/intel_memory_region.h b/drivers/gpu/drm/i915/intel_memory_region.h
index 19920c256ede..238722009677 100644
--- a/drivers/gpu/drm/i915/intel_memory_region.h
+++ b/drivers/gpu/drm/i915/intel_memory_region.h
@@ -10,6 +10,7 @@
 #include <linux/ioport.h>
 #include <linux/mutex.h>
 #include <linux/io-mapping.h>
+#include <drm/drm_mm.h>
 
 #include "i915_buddy.h"
 
@@ -71,6 +72,9 @@ struct intel_memory_region {
 	struct io_mapping iomap;
 	struct resource region;
 
+	/* For fake LMEM */
+	struct drm_mm_node fake_mappable;
+
 	struct i915_buddy_mm mm;
 	struct mutex mm_lock;
 
@@ -83,6 +87,8 @@ struct intel_memory_region {
 	unsigned int instance;
 	unsigned int id;
 
+	dma_addr_t remap_addr;
+
 	struct {
 		struct mutex lock; /* Protects access to objects */
 		struct list_head list;
diff --git a/drivers/gpu/drm/i915/intel_region_lmem.c b/drivers/gpu/drm/i915/intel_region_lmem.c
index 9a351af45ce6..583118095635 100644
--- a/drivers/gpu/drm/i915/intel_region_lmem.c
+++ b/drivers/gpu/drm/i915/intel_region_lmem.c
@@ -9,9 +9,62 @@
 #include "gem/i915_gem_region.h"
 #include "intel_region_lmem.h"
 
+static int init_fake_lmem_bar(struct intel_memory_region *mem)
+{
+	struct drm_i915_private *i915 = mem->i915;
+	struct i915_ggtt *ggtt = &i915->ggtt;
+	unsigned long n;
+	int ret;
+
+	/* We want to 1:1 map the mappable aperture to our reserved region */
+
+	mem->fake_mappable.start = 0;
+	mem->fake_mappable.size = resource_size(&mem->region);
+	mem->fake_mappable.color = I915_COLOR_UNEVICTABLE;
+
+	ret = drm_mm_reserve_node(&ggtt->vm.mm, &mem->fake_mappable);
+	if (ret)
+		return ret;
+
+	mem->remap_addr = dma_map_resource(&i915->drm.pdev->dev,
+					   mem->region.start,
+					   mem->fake_mappable.size,
+					   PCI_DMA_BIDIRECTIONAL,
+					   DMA_ATTR_FORCE_CONTIGUOUS);
+	if (dma_mapping_error(&i915->drm.pdev->dev, mem->remap_addr)) {
+		drm_mm_remove_node(&mem->fake_mappable);
+		return -EINVAL;
+	}
+
+	for (n = 0; n < mem->fake_mappable.size >> PAGE_SHIFT; ++n) {
+		ggtt->vm.insert_page(&ggtt->vm,
+				     mem->remap_addr + (n << PAGE_SHIFT),
+				     n << PAGE_SHIFT,
+				     I915_CACHE_NONE, 0);
+	}
+
+	mem->region = (struct resource)DEFINE_RES_MEM(mem->remap_addr,
+						      mem->fake_mappable.size);
+
+	return 0;
+}
+
+static void release_fake_lmem_bar(struct intel_memory_region *mem)
+{
+	if (drm_mm_node_allocated(&mem->fake_mappable))
+		drm_mm_remove_node(&mem->fake_mappable);
+
+	dma_unmap_resource(&mem->i915->drm.pdev->dev,
+			   mem->remap_addr,
+			   mem->fake_mappable.size,
+			   PCI_DMA_BIDIRECTIONAL,
+			   DMA_ATTR_FORCE_CONTIGUOUS);
+}
+
 static void
 region_lmem_release(struct intel_memory_region *mem)
 {
+	release_fake_lmem_bar(mem);
 	io_mapping_fini(&mem->iomap);
 	intel_memory_region_release_buddy(mem);
 }
@@ -21,6 +74,11 @@ region_lmem_init(struct intel_memory_region *mem)
 {
 	int ret;
 
+	if (i915_modparams.fake_lmem_start) {
+		ret = init_fake_lmem_bar(mem);
+		GEM_BUG_ON(ret);
+	}
+
 	if (!io_mapping_init_wc(&mem->iomap,
 				mem->io_start,
 				resource_size(&mem->region)))
@@ -38,3 +96,37 @@ const struct intel_memory_region_ops intel_region_lmem_ops = {
 	.release = region_lmem_release,
 	.create_object = __i915_gem_lmem_object_create,
 };
+
+struct intel_memory_region *
+intel_setup_fake_lmem(struct drm_i915_private *i915)
+{
+	struct pci_dev *pdev = i915->drm.pdev;
+	struct intel_memory_region *mem;
+	resource_size_t mappable_end;
+	resource_size_t io_start;
+	resource_size_t start;
+
+	GEM_BUG_ON(i915_ggtt_has_aperture(&i915->ggtt));
+	GEM_BUG_ON(!i915_modparams.fake_lmem_start);
+
+	/* Your mappable aperture belongs to me now! */
+	mappable_end = pci_resource_len(pdev, 2);
+	io_start = pci_resource_start(pdev, 2),
+	start = i915_modparams.fake_lmem_start;
+
+	mem = intel_memory_region_create(i915,
+					 start,
+					 mappable_end,
+					 PAGE_SIZE,
+					 io_start,
+					 &intel_region_lmem_ops);
+	if (!IS_ERR(mem)) {
+		DRM_INFO("Intel graphics fake LMEM: %pR\n", &mem->region);
+		DRM_INFO("Intel graphics fake LMEM IO start: %llx\n",
+			 (u64)mem->io_start);
+		DRM_INFO("Intel graphics fake LMEM size: %llx\n",
+			 (u64)resource_size(&mem->region));
+	}
+
+	return mem;
+}
diff --git a/drivers/gpu/drm/i915/intel_region_lmem.h b/drivers/gpu/drm/i915/intel_region_lmem.h
index ed2a3bab6443..213def7c7b8a 100644
--- a/drivers/gpu/drm/i915/intel_region_lmem.h
+++ b/drivers/gpu/drm/i915/intel_region_lmem.h
@@ -6,6 +6,11 @@
 #ifndef __INTEL_REGION_LMEM_H
 #define __INTEL_REGION_LMEM_H
 
+struct drm_i915_private;
+
 extern const struct intel_memory_region_ops intel_region_lmem_ops;
 
+struct intel_memory_region *
+intel_setup_fake_lmem(struct drm_i915_private *i915);
+
 #endif /* !__INTEL_REGION_LMEM_H */
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/lmem: add the fake lmem region
@ 2019-10-30  1:43   ` Patchwork
  0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-10-30  1:43 UTC (permalink / raw)
  To: Matthew Auld; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/lmem: add the fake lmem region
URL   : https://patchwork.freedesktop.org/series/68733/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9fd60b3f26c7 drm/i915/lmem: add the fake lmem region
-:93: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#93: FILE: drivers/gpu/drm/i915/i915_params.c:184:
+i915_param_named_unsafe(fake_lmem_start, ulong, 0600,
+	"Fake LMEM start offset (default: 0)");

total: 0 errors, 0 warnings, 1 checks, 214 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/lmem: add the fake lmem region
@ 2019-10-30  1:43   ` Patchwork
  0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-10-30  1:43 UTC (permalink / raw)
  To: Matthew Auld; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/lmem: add the fake lmem region
URL   : https://patchwork.freedesktop.org/series/68733/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9fd60b3f26c7 drm/i915/lmem: add the fake lmem region
-:93: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#93: FILE: drivers/gpu/drm/i915/i915_params.c:184:
+i915_param_named_unsafe(fake_lmem_start, ulong, 0600,
+	"Fake LMEM start offset (default: 0)");

total: 0 errors, 0 warnings, 1 checks, 214 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* ✗ Fi.CI.BAT: failure for drm/i915/lmem: add the fake lmem region
@ 2019-10-30  1:57   ` Patchwork
  0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-10-30  1:57 UTC (permalink / raw)
  To: Matthew Auld; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/lmem: add the fake lmem region
URL   : https://patchwork.freedesktop.org/series/68733/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7221 -> Patchwork_15061
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15061 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15061, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15061:

### IGT changes ###

#### Possible regressions ####

  * igt@debugfs_test@read_all_entries:
    - fi-skl-iommu:       [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-skl-iommu/igt@debugfs_test@read_all_entries.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-iommu/igt@debugfs_test@read_all_entries.html
    - fi-glk-dsi:         [PASS][3] -> [DMESG-WARN][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-glk-dsi/igt@debugfs_test@read_all_entries.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-glk-dsi/igt@debugfs_test@read_all_entries.html
    - fi-ivb-3770:        [PASS][5] -> [DMESG-WARN][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-ivb-3770/igt@debugfs_test@read_all_entries.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-ivb-3770/igt@debugfs_test@read_all_entries.html
    - fi-hsw-peppy:       [PASS][7] -> [DMESG-WARN][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-hsw-peppy/igt@debugfs_test@read_all_entries.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-hsw-peppy/igt@debugfs_test@read_all_entries.html
    - fi-icl-u3:          [PASS][9] -> [DMESG-WARN][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-icl-u3/igt@debugfs_test@read_all_entries.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-icl-u3/igt@debugfs_test@read_all_entries.html
    - fi-kbl-7500u:       [PASS][11] -> [DMESG-WARN][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-kbl-7500u/igt@debugfs_test@read_all_entries.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-7500u/igt@debugfs_test@read_all_entries.html
    - fi-snb-2520m:       [PASS][13] -> [DMESG-WARN][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-snb-2520m/igt@debugfs_test@read_all_entries.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-snb-2520m/igt@debugfs_test@read_all_entries.html
    - fi-gdg-551:         [PASS][15] -> [DMESG-WARN][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-gdg-551/igt@debugfs_test@read_all_entries.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-gdg-551/igt@debugfs_test@read_all_entries.html
    - fi-icl-u2:          [PASS][17] -> [DMESG-WARN][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-icl-u2/igt@debugfs_test@read_all_entries.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-icl-u2/igt@debugfs_test@read_all_entries.html
    - fi-cfl-8109u:       [PASS][19] -> [DMESG-WARN][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cfl-8109u/igt@debugfs_test@read_all_entries.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cfl-8109u/igt@debugfs_test@read_all_entries.html
    - fi-pnv-d510:        [PASS][21] -> [DMESG-WARN][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
    - fi-ilk-650:         [PASS][23] -> [DMESG-WARN][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-ilk-650/igt@debugfs_test@read_all_entries.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-ilk-650/igt@debugfs_test@read_all_entries.html
    - fi-skl-6770hq:      [PASS][25] -> [DMESG-WARN][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-skl-6770hq/igt@debugfs_test@read_all_entries.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-6770hq/igt@debugfs_test@read_all_entries.html
    - fi-byt-n2820:       NOTRUN -> [DMESG-WARN][27]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-byt-n2820/igt@debugfs_test@read_all_entries.html
    - fi-elk-e7500:       [PASS][28] -> [DMESG-WARN][29]
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-elk-e7500/igt@debugfs_test@read_all_entries.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-elk-e7500/igt@debugfs_test@read_all_entries.html
    - fi-skl-lmem:        [PASS][30] -> [DMESG-WARN][31]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-skl-lmem/igt@debugfs_test@read_all_entries.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-lmem/igt@debugfs_test@read_all_entries.html
    - fi-snb-2600:        [PASS][32] -> [DMESG-WARN][33]
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-snb-2600/igt@debugfs_test@read_all_entries.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-snb-2600/igt@debugfs_test@read_all_entries.html
    - fi-kbl-guc:         [PASS][34] -> [DMESG-WARN][35]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-kbl-guc/igt@debugfs_test@read_all_entries.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-guc/igt@debugfs_test@read_all_entries.html
    - fi-bsw-kefka:       [PASS][36] -> [DMESG-WARN][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-bsw-kefka/igt@debugfs_test@read_all_entries.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bsw-kefka/igt@debugfs_test@read_all_entries.html
    - fi-kbl-x1275:       [PASS][38] -> [DMESG-WARN][39]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
    - fi-blb-e6850:       [PASS][40] -> [DMESG-WARN][41]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-blb-e6850/igt@debugfs_test@read_all_entries.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-blb-e6850/igt@debugfs_test@read_all_entries.html
    - fi-bwr-2160:        [PASS][42] -> [DMESG-WARN][43]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-bwr-2160/igt@debugfs_test@read_all_entries.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bwr-2160/igt@debugfs_test@read_all_entries.html
    - fi-bdw-5557u:       [PASS][44] -> [DMESG-WARN][45]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-bdw-5557u/igt@debugfs_test@read_all_entries.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bdw-5557u/igt@debugfs_test@read_all_entries.html
    - fi-kbl-r:           [PASS][46] -> [DMESG-WARN][47]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-kbl-r/igt@debugfs_test@read_all_entries.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-r/igt@debugfs_test@read_all_entries.html
    - fi-skl-guc:         [PASS][48] -> [DMESG-WARN][49]
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-skl-guc/igt@debugfs_test@read_all_entries.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-guc/igt@debugfs_test@read_all_entries.html
    - fi-apl-guc:         [PASS][50] -> [DMESG-WARN][51]
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-apl-guc/igt@debugfs_test@read_all_entries.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-apl-guc/igt@debugfs_test@read_all_entries.html
    - fi-kbl-8809g:       [PASS][52] -> [DMESG-WARN][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-kbl-8809g/igt@debugfs_test@read_all_entries.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-8809g/igt@debugfs_test@read_all_entries.html
    - fi-skl-6600u:       [PASS][54] -> [DMESG-WARN][55]
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-skl-6600u/igt@debugfs_test@read_all_entries.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-6600u/igt@debugfs_test@read_all_entries.html
    - fi-byt-j1900:       [PASS][56] -> [DMESG-WARN][57]
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-byt-j1900/igt@debugfs_test@read_all_entries.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-byt-j1900/igt@debugfs_test@read_all_entries.html
    - fi-bxt-dsi:         [PASS][58] -> [DMESG-WARN][59]
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-bxt-dsi/igt@debugfs_test@read_all_entries.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bxt-dsi/igt@debugfs_test@read_all_entries.html
    - fi-cfl-8700k:       [PASS][60] -> [DMESG-WARN][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cfl-8700k/igt@debugfs_test@read_all_entries.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cfl-8700k/igt@debugfs_test@read_all_entries.html
    - fi-cml-u2:          [PASS][62] -> [DMESG-WARN][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cml-u2/igt@debugfs_test@read_all_entries.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cml-u2/igt@debugfs_test@read_all_entries.html
    - fi-whl-u:           [PASS][64] -> [DMESG-WARN][65]
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-whl-u/igt@debugfs_test@read_all_entries.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-whl-u/igt@debugfs_test@read_all_entries.html
    - fi-bsw-n3050:       [PASS][66] -> [DMESG-WARN][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-bsw-n3050/igt@debugfs_test@read_all_entries.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bsw-n3050/igt@debugfs_test@read_all_entries.html
    - fi-skl-6700k2:      NOTRUN -> [DMESG-WARN][68]
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-6700k2/igt@debugfs_test@read_all_entries.html
    - fi-hsw-4770:        [PASS][69] -> [DMESG-WARN][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-hsw-4770/igt@debugfs_test@read_all_entries.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-hsw-4770/igt@debugfs_test@read_all_entries.html
    - fi-kbl-soraka:      NOTRUN -> [DMESG-WARN][71]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-soraka/igt@debugfs_test@read_all_entries.html
    - fi-cfl-guc:         [PASS][72] -> [DMESG-WARN][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cfl-guc/igt@debugfs_test@read_all_entries.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cfl-guc/igt@debugfs_test@read_all_entries.html

  * igt@runner@aborted:
    - fi-pnv-d510:        NOTRUN -> [FAIL][74]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-pnv-d510/igt@runner@aborted.html
    - fi-cfl-8109u:       NOTRUN -> [FAIL][75]
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cfl-8109u/igt@runner@aborted.html
    - fi-hsw-peppy:       NOTRUN -> [FAIL][76]
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-hsw-peppy/igt@runner@aborted.html
    - fi-gdg-551:         NOTRUN -> [FAIL][77]
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-gdg-551/igt@runner@aborted.html
    - fi-snb-2520m:       NOTRUN -> [FAIL][78]
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-snb-2520m/igt@runner@aborted.html
    - fi-kbl-soraka:      NOTRUN -> [FAIL][79]
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-soraka/igt@runner@aborted.html
    - fi-hsw-4770:        NOTRUN -> [FAIL][80]
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-hsw-4770/igt@runner@aborted.html
    - fi-kbl-7500u:       NOTRUN -> [FAIL][81]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-7500u/igt@runner@aborted.html
    - fi-whl-u:           NOTRUN -> [FAIL][82]
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-whl-u/igt@runner@aborted.html
    - fi-cml-u2:          NOTRUN -> [FAIL][83]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cml-u2/igt@runner@aborted.html
    - fi-ivb-3770:        NOTRUN -> [FAIL][84]
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-ivb-3770/igt@runner@aborted.html
    - fi-bxt-dsi:         NOTRUN -> [FAIL][85]
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bxt-dsi/igt@runner@aborted.html
    - fi-byt-j1900:       NOTRUN -> [FAIL][86]
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-byt-j1900/igt@runner@aborted.html
    - fi-blb-e6850:       NOTRUN -> [FAIL][87]
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-blb-e6850/igt@runner@aborted.html
    - fi-kbl-x1275:       NOTRUN -> [FAIL][88]
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-x1275/igt@runner@aborted.html
    - fi-cfl-8700k:       NOTRUN -> [FAIL][89]
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cfl-8700k/igt@runner@aborted.html
    - fi-kbl-8809g:       NOTRUN -> [FAIL][90]
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-8809g/igt@runner@aborted.html
    - fi-kbl-r:           NOTRUN -> [FAIL][91]
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-r/igt@runner@aborted.html
    - fi-byt-n2820:       NOTRUN -> [FAIL][92]
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-byt-n2820/igt@runner@aborted.html
    - fi-snb-2600:        NOTRUN -> [FAIL][93]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-snb-2600/igt@runner@aborted.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@debugfs_test@read_all_entries:
    - {fi-cml-s}:         [PASS][94] -> [DMESG-WARN][95]
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cml-s/igt@debugfs_test@read_all_entries.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cml-s/igt@debugfs_test@read_all_entries.html
    - {fi-tgl-u}:         [PASS][96] -> [DMESG-WARN][97]
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-tgl-u/igt@debugfs_test@read_all_entries.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-tgl-u/igt@debugfs_test@read_all_entries.html
    - {fi-icl-u4}:        [PASS][98] -> [DMESG-WARN][99]
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-icl-u4/igt@debugfs_test@read_all_entries.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-icl-u4/igt@debugfs_test@read_all_entries.html
    - {fi-icl-dsi}:       [PASS][100] -> [DMESG-WARN][101]
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-icl-dsi/igt@debugfs_test@read_all_entries.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-icl-dsi/igt@debugfs_test@read_all_entries.html
    - {fi-icl-guc}:       [PASS][102] -> [DMESG-WARN][103]
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-icl-guc/igt@debugfs_test@read_all_entries.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-icl-guc/igt@debugfs_test@read_all_entries.html

  * igt@runner@aborted:
    - {fi-cml-s}:         [FAIL][104] ([fdo#111764]) -> [FAIL][105]
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cml-s/igt@runner@aborted.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cml-s/igt@runner@aborted.html
    - {fi-tgl-u}:         NOTRUN -> [FAIL][106]
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-tgl-u/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764


Participating hosts (50 -> 44)
------------------------------

  Additional (1): fi-kbl-soraka 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7221 -> Patchwork_15061

  CI-20190529: 20190529
  CI_DRM_7221: 2892915176b11a8afe7a4dfcbe2e49d498a0cf85 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5251: 6d30ec2314f22f465113f7a972944fee546ecbd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15061: 9fd60b3f26c7f8bb6896b487ef2500a45cd4d6c3 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

9fd60b3f26c7 drm/i915/lmem: add the fake lmem region

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/lmem: add the fake lmem region
@ 2019-10-30  1:57   ` Patchwork
  0 siblings, 0 replies; 22+ messages in thread
From: Patchwork @ 2019-10-30  1:57 UTC (permalink / raw)
  To: Matthew Auld; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/lmem: add the fake lmem region
URL   : https://patchwork.freedesktop.org/series/68733/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7221 -> Patchwork_15061
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15061 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15061, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15061:

### IGT changes ###

#### Possible regressions ####

  * igt@debugfs_test@read_all_entries:
    - fi-skl-iommu:       [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-skl-iommu/igt@debugfs_test@read_all_entries.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-iommu/igt@debugfs_test@read_all_entries.html
    - fi-glk-dsi:         [PASS][3] -> [DMESG-WARN][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-glk-dsi/igt@debugfs_test@read_all_entries.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-glk-dsi/igt@debugfs_test@read_all_entries.html
    - fi-ivb-3770:        [PASS][5] -> [DMESG-WARN][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-ivb-3770/igt@debugfs_test@read_all_entries.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-ivb-3770/igt@debugfs_test@read_all_entries.html
    - fi-hsw-peppy:       [PASS][7] -> [DMESG-WARN][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-hsw-peppy/igt@debugfs_test@read_all_entries.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-hsw-peppy/igt@debugfs_test@read_all_entries.html
    - fi-icl-u3:          [PASS][9] -> [DMESG-WARN][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-icl-u3/igt@debugfs_test@read_all_entries.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-icl-u3/igt@debugfs_test@read_all_entries.html
    - fi-kbl-7500u:       [PASS][11] -> [DMESG-WARN][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-kbl-7500u/igt@debugfs_test@read_all_entries.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-7500u/igt@debugfs_test@read_all_entries.html
    - fi-snb-2520m:       [PASS][13] -> [DMESG-WARN][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-snb-2520m/igt@debugfs_test@read_all_entries.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-snb-2520m/igt@debugfs_test@read_all_entries.html
    - fi-gdg-551:         [PASS][15] -> [DMESG-WARN][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-gdg-551/igt@debugfs_test@read_all_entries.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-gdg-551/igt@debugfs_test@read_all_entries.html
    - fi-icl-u2:          [PASS][17] -> [DMESG-WARN][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-icl-u2/igt@debugfs_test@read_all_entries.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-icl-u2/igt@debugfs_test@read_all_entries.html
    - fi-cfl-8109u:       [PASS][19] -> [DMESG-WARN][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cfl-8109u/igt@debugfs_test@read_all_entries.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cfl-8109u/igt@debugfs_test@read_all_entries.html
    - fi-pnv-d510:        [PASS][21] -> [DMESG-WARN][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
    - fi-ilk-650:         [PASS][23] -> [DMESG-WARN][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-ilk-650/igt@debugfs_test@read_all_entries.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-ilk-650/igt@debugfs_test@read_all_entries.html
    - fi-skl-6770hq:      [PASS][25] -> [DMESG-WARN][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-skl-6770hq/igt@debugfs_test@read_all_entries.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-6770hq/igt@debugfs_test@read_all_entries.html
    - fi-byt-n2820:       NOTRUN -> [DMESG-WARN][27]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-byt-n2820/igt@debugfs_test@read_all_entries.html
    - fi-elk-e7500:       [PASS][28] -> [DMESG-WARN][29]
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-elk-e7500/igt@debugfs_test@read_all_entries.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-elk-e7500/igt@debugfs_test@read_all_entries.html
    - fi-skl-lmem:        [PASS][30] -> [DMESG-WARN][31]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-skl-lmem/igt@debugfs_test@read_all_entries.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-lmem/igt@debugfs_test@read_all_entries.html
    - fi-snb-2600:        [PASS][32] -> [DMESG-WARN][33]
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-snb-2600/igt@debugfs_test@read_all_entries.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-snb-2600/igt@debugfs_test@read_all_entries.html
    - fi-kbl-guc:         [PASS][34] -> [DMESG-WARN][35]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-kbl-guc/igt@debugfs_test@read_all_entries.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-guc/igt@debugfs_test@read_all_entries.html
    - fi-bsw-kefka:       [PASS][36] -> [DMESG-WARN][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-bsw-kefka/igt@debugfs_test@read_all_entries.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bsw-kefka/igt@debugfs_test@read_all_entries.html
    - fi-kbl-x1275:       [PASS][38] -> [DMESG-WARN][39]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
    - fi-blb-e6850:       [PASS][40] -> [DMESG-WARN][41]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-blb-e6850/igt@debugfs_test@read_all_entries.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-blb-e6850/igt@debugfs_test@read_all_entries.html
    - fi-bwr-2160:        [PASS][42] -> [DMESG-WARN][43]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-bwr-2160/igt@debugfs_test@read_all_entries.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bwr-2160/igt@debugfs_test@read_all_entries.html
    - fi-bdw-5557u:       [PASS][44] -> [DMESG-WARN][45]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-bdw-5557u/igt@debugfs_test@read_all_entries.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bdw-5557u/igt@debugfs_test@read_all_entries.html
    - fi-kbl-r:           [PASS][46] -> [DMESG-WARN][47]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-kbl-r/igt@debugfs_test@read_all_entries.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-r/igt@debugfs_test@read_all_entries.html
    - fi-skl-guc:         [PASS][48] -> [DMESG-WARN][49]
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-skl-guc/igt@debugfs_test@read_all_entries.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-guc/igt@debugfs_test@read_all_entries.html
    - fi-apl-guc:         [PASS][50] -> [DMESG-WARN][51]
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-apl-guc/igt@debugfs_test@read_all_entries.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-apl-guc/igt@debugfs_test@read_all_entries.html
    - fi-kbl-8809g:       [PASS][52] -> [DMESG-WARN][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-kbl-8809g/igt@debugfs_test@read_all_entries.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-8809g/igt@debugfs_test@read_all_entries.html
    - fi-skl-6600u:       [PASS][54] -> [DMESG-WARN][55]
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-skl-6600u/igt@debugfs_test@read_all_entries.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-6600u/igt@debugfs_test@read_all_entries.html
    - fi-byt-j1900:       [PASS][56] -> [DMESG-WARN][57]
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-byt-j1900/igt@debugfs_test@read_all_entries.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-byt-j1900/igt@debugfs_test@read_all_entries.html
    - fi-bxt-dsi:         [PASS][58] -> [DMESG-WARN][59]
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-bxt-dsi/igt@debugfs_test@read_all_entries.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bxt-dsi/igt@debugfs_test@read_all_entries.html
    - fi-cfl-8700k:       [PASS][60] -> [DMESG-WARN][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cfl-8700k/igt@debugfs_test@read_all_entries.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cfl-8700k/igt@debugfs_test@read_all_entries.html
    - fi-cml-u2:          [PASS][62] -> [DMESG-WARN][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cml-u2/igt@debugfs_test@read_all_entries.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cml-u2/igt@debugfs_test@read_all_entries.html
    - fi-whl-u:           [PASS][64] -> [DMESG-WARN][65]
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-whl-u/igt@debugfs_test@read_all_entries.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-whl-u/igt@debugfs_test@read_all_entries.html
    - fi-bsw-n3050:       [PASS][66] -> [DMESG-WARN][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-bsw-n3050/igt@debugfs_test@read_all_entries.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bsw-n3050/igt@debugfs_test@read_all_entries.html
    - fi-skl-6700k2:      NOTRUN -> [DMESG-WARN][68]
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-skl-6700k2/igt@debugfs_test@read_all_entries.html
    - fi-hsw-4770:        [PASS][69] -> [DMESG-WARN][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-hsw-4770/igt@debugfs_test@read_all_entries.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-hsw-4770/igt@debugfs_test@read_all_entries.html
    - fi-kbl-soraka:      NOTRUN -> [DMESG-WARN][71]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-soraka/igt@debugfs_test@read_all_entries.html
    - fi-cfl-guc:         [PASS][72] -> [DMESG-WARN][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cfl-guc/igt@debugfs_test@read_all_entries.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cfl-guc/igt@debugfs_test@read_all_entries.html

  * igt@runner@aborted:
    - fi-pnv-d510:        NOTRUN -> [FAIL][74]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-pnv-d510/igt@runner@aborted.html
    - fi-cfl-8109u:       NOTRUN -> [FAIL][75]
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cfl-8109u/igt@runner@aborted.html
    - fi-hsw-peppy:       NOTRUN -> [FAIL][76]
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-hsw-peppy/igt@runner@aborted.html
    - fi-gdg-551:         NOTRUN -> [FAIL][77]
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-gdg-551/igt@runner@aborted.html
    - fi-snb-2520m:       NOTRUN -> [FAIL][78]
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-snb-2520m/igt@runner@aborted.html
    - fi-kbl-soraka:      NOTRUN -> [FAIL][79]
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-soraka/igt@runner@aborted.html
    - fi-hsw-4770:        NOTRUN -> [FAIL][80]
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-hsw-4770/igt@runner@aborted.html
    - fi-kbl-7500u:       NOTRUN -> [FAIL][81]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-7500u/igt@runner@aborted.html
    - fi-whl-u:           NOTRUN -> [FAIL][82]
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-whl-u/igt@runner@aborted.html
    - fi-cml-u2:          NOTRUN -> [FAIL][83]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cml-u2/igt@runner@aborted.html
    - fi-ivb-3770:        NOTRUN -> [FAIL][84]
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-ivb-3770/igt@runner@aborted.html
    - fi-bxt-dsi:         NOTRUN -> [FAIL][85]
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-bxt-dsi/igt@runner@aborted.html
    - fi-byt-j1900:       NOTRUN -> [FAIL][86]
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-byt-j1900/igt@runner@aborted.html
    - fi-blb-e6850:       NOTRUN -> [FAIL][87]
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-blb-e6850/igt@runner@aborted.html
    - fi-kbl-x1275:       NOTRUN -> [FAIL][88]
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-x1275/igt@runner@aborted.html
    - fi-cfl-8700k:       NOTRUN -> [FAIL][89]
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cfl-8700k/igt@runner@aborted.html
    - fi-kbl-8809g:       NOTRUN -> [FAIL][90]
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-8809g/igt@runner@aborted.html
    - fi-kbl-r:           NOTRUN -> [FAIL][91]
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-kbl-r/igt@runner@aborted.html
    - fi-byt-n2820:       NOTRUN -> [FAIL][92]
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-byt-n2820/igt@runner@aborted.html
    - fi-snb-2600:        NOTRUN -> [FAIL][93]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-snb-2600/igt@runner@aborted.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@debugfs_test@read_all_entries:
    - {fi-cml-s}:         [PASS][94] -> [DMESG-WARN][95]
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cml-s/igt@debugfs_test@read_all_entries.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cml-s/igt@debugfs_test@read_all_entries.html
    - {fi-tgl-u}:         [PASS][96] -> [DMESG-WARN][97]
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-tgl-u/igt@debugfs_test@read_all_entries.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-tgl-u/igt@debugfs_test@read_all_entries.html
    - {fi-icl-u4}:        [PASS][98] -> [DMESG-WARN][99]
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-icl-u4/igt@debugfs_test@read_all_entries.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-icl-u4/igt@debugfs_test@read_all_entries.html
    - {fi-icl-dsi}:       [PASS][100] -> [DMESG-WARN][101]
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-icl-dsi/igt@debugfs_test@read_all_entries.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-icl-dsi/igt@debugfs_test@read_all_entries.html
    - {fi-icl-guc}:       [PASS][102] -> [DMESG-WARN][103]
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-icl-guc/igt@debugfs_test@read_all_entries.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-icl-guc/igt@debugfs_test@read_all_entries.html

  * igt@runner@aborted:
    - {fi-cml-s}:         [FAIL][104] ([fdo#111764]) -> [FAIL][105]
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7221/fi-cml-s/igt@runner@aborted.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-cml-s/igt@runner@aborted.html
    - {fi-tgl-u}:         NOTRUN -> [FAIL][106]
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/fi-tgl-u/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764


Participating hosts (50 -> 44)
------------------------------

  Additional (1): fi-kbl-soraka 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7221 -> Patchwork_15061

  CI-20190529: 20190529
  CI_DRM_7221: 2892915176b11a8afe7a4dfcbe2e49d498a0cf85 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5251: 6d30ec2314f22f465113f7a972944fee546ecbd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15061: 9fd60b3f26c7f8bb6896b487ef2500a45cd4d6c3 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

9fd60b3f26c7 drm/i915/lmem: add the fake lmem region

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15061/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-10-30  9:14   ` Chris Wilson
  0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-10-30  9:14 UTC (permalink / raw)
  To: Matthew Auld, intel-gfx

Quoting Matthew Auld (2019-10-29 16:51:34)
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 21273b516dbe..db1736d95651 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1483,6 +1483,21 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>         if (!i915_modparams.nuclear_pageflip && match_info->gen < 5)
>                 dev_priv->drm.driver_features &= ~DRIVER_ATOMIC;
>  
> +       /*
> +        * Check if we support fake LMEM -- for now we only unleash this for
> +        * the live selftests.
> +        */
> +       if (IS_ENABLED(CONFIG_DRM_I915_UNSTABLE)) {

The pattern I have in mind for unstable config options was to add

config DRM_I915_UNSTABLE_FAKE_LMEM
        bool "Enable the experimental fake lmem"
        depends on DRM_I915_UNSTABLE
        default n
        help
          Convert some system memory into a fake local memory region for
	  testing.

So each is isolated and less likely to cross-contanimate.

> +               if (INTEL_GEN(dev_priv) >= 9 && i915_selftest.live &&

Probably want i915_selftest.live < 0 so that we only enable it for
selftest-and-exit rather than inline selftests that keep the module
loaded afterwards

i915_selftest.live=0 => no tests
i915_selftest.live=-1 => test and exit
i915_selftest.live=1 => test and run userspace

> +                   i915_modparams.fake_lmem_start) {
> +                       mkwrite_device_info(dev_priv)->memory_regions =
> +                               REGION_SMEM | REGION_LMEM | REGION_STOLEN;
> +                       mkwrite_device_info(dev_priv)->is_dgfx = true;
> +                       GEM_BUG_ON(!HAS_LMEM(dev_priv));
> +                       GEM_BUG_ON(!IS_DGFX(dev_priv));
> +               }
> +       }
> +

> +struct intel_memory_region *
> +intel_setup_fake_lmem(struct drm_i915_private *i915)
> +{
> +       struct pci_dev *pdev = i915->drm.pdev;
> +       struct intel_memory_region *mem;
> +       resource_size_t mappable_end;
> +       resource_size_t io_start;
> +       resource_size_t start;
> +
> +       GEM_BUG_ON(i915_ggtt_has_aperture(&i915->ggtt));
> +       GEM_BUG_ON(!i915_modparams.fake_lmem_start);
> +
> +       /* Your mappable aperture belongs to me now! */
> +       mappable_end = pci_resource_len(pdev, 2);
> +       io_start = pci_resource_start(pdev, 2),
> +       start = i915_modparams.fake_lmem_start;
> +
> +       mem = intel_memory_region_create(i915,
> +                                        start,
> +                                        mappable_end,
> +                                        PAGE_SIZE,
> +                                        io_start,
> +                                        &intel_region_lmem_ops);
> +       if (!IS_ERR(mem)) {
> +               DRM_INFO("Intel graphics fake LMEM: %pR\n", &mem->region);
> +               DRM_INFO("Intel graphics fake LMEM IO start: %llx\n",
> +                        (u64)mem->io_start);
> +               DRM_INFO("Intel graphics fake LMEM size: %llx\n",
> +                        (u64)resource_size(&mem->region));

Ok, as this is unstable and therefore dev-centric I'll let you off
having clear user information.

resource_size_t => %pa

Remember to make BAT happy!
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-10-30  9:14   ` Chris Wilson
  0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-10-30  9:14 UTC (permalink / raw)
  To: Matthew Auld, intel-gfx

Quoting Matthew Auld (2019-10-29 16:51:34)
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 21273b516dbe..db1736d95651 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1483,6 +1483,21 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>         if (!i915_modparams.nuclear_pageflip && match_info->gen < 5)
>                 dev_priv->drm.driver_features &= ~DRIVER_ATOMIC;
>  
> +       /*
> +        * Check if we support fake LMEM -- for now we only unleash this for
> +        * the live selftests.
> +        */
> +       if (IS_ENABLED(CONFIG_DRM_I915_UNSTABLE)) {

The pattern I have in mind for unstable config options was to add

config DRM_I915_UNSTABLE_FAKE_LMEM
        bool "Enable the experimental fake lmem"
        depends on DRM_I915_UNSTABLE
        default n
        help
          Convert some system memory into a fake local memory region for
	  testing.

So each is isolated and less likely to cross-contanimate.

> +               if (INTEL_GEN(dev_priv) >= 9 && i915_selftest.live &&

Probably want i915_selftest.live < 0 so that we only enable it for
selftest-and-exit rather than inline selftests that keep the module
loaded afterwards

i915_selftest.live=0 => no tests
i915_selftest.live=-1 => test and exit
i915_selftest.live=1 => test and run userspace

> +                   i915_modparams.fake_lmem_start) {
> +                       mkwrite_device_info(dev_priv)->memory_regions =
> +                               REGION_SMEM | REGION_LMEM | REGION_STOLEN;
> +                       mkwrite_device_info(dev_priv)->is_dgfx = true;
> +                       GEM_BUG_ON(!HAS_LMEM(dev_priv));
> +                       GEM_BUG_ON(!IS_DGFX(dev_priv));
> +               }
> +       }
> +

> +struct intel_memory_region *
> +intel_setup_fake_lmem(struct drm_i915_private *i915)
> +{
> +       struct pci_dev *pdev = i915->drm.pdev;
> +       struct intel_memory_region *mem;
> +       resource_size_t mappable_end;
> +       resource_size_t io_start;
> +       resource_size_t start;
> +
> +       GEM_BUG_ON(i915_ggtt_has_aperture(&i915->ggtt));
> +       GEM_BUG_ON(!i915_modparams.fake_lmem_start);
> +
> +       /* Your mappable aperture belongs to me now! */
> +       mappable_end = pci_resource_len(pdev, 2);
> +       io_start = pci_resource_start(pdev, 2),
> +       start = i915_modparams.fake_lmem_start;
> +
> +       mem = intel_memory_region_create(i915,
> +                                        start,
> +                                        mappable_end,
> +                                        PAGE_SIZE,
> +                                        io_start,
> +                                        &intel_region_lmem_ops);
> +       if (!IS_ERR(mem)) {
> +               DRM_INFO("Intel graphics fake LMEM: %pR\n", &mem->region);
> +               DRM_INFO("Intel graphics fake LMEM IO start: %llx\n",
> +                        (u64)mem->io_start);
> +               DRM_INFO("Intel graphics fake LMEM size: %llx\n",
> +                        (u64)resource_size(&mem->region));

Ok, as this is unstable and therefore dev-centric I'll let you off
having clear user information.

resource_size_t => %pa

Remember to make BAT happy!
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-10-30 22:22   ` Matthew Auld
  0 siblings, 0 replies; 22+ messages in thread
From: Matthew Auld @ 2019-10-30 22:22 UTC (permalink / raw)
  To: Matthew Auld, Arkadiusz Hiler; +Cc: Intel Graphics Development

On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
>
> Intended for upstream testing so that we can still exercise the LMEM
> plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> device. This works by allocating an intel_memory_region for a reserved
> portion of system memory, which we treat like LMEM. For the LMEMBAR we
> steal the aperture and 1:1 it map to the stolen region.
>
> To enable simply set the i915 modparam fake_lmem_start= on the kernel
> cmdline with the start of reserved region(see memmap=). The size of the
> region we can use is determined by the size of the mappable aperture, so
> the size of reserved region should be >= mappable_end. For now we only
> enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> enabled.
>
> eg. memmap=2G$16G i915.fake_lmem_start=0x400000000

Hi Arek,

Would you be able to update the fi-skl-lmem kernel cmd line with
s/i915_fake_lmem_start/i915.fake_lmem_start?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-10-30 22:22   ` Matthew Auld
  0 siblings, 0 replies; 22+ messages in thread
From: Matthew Auld @ 2019-10-30 22:22 UTC (permalink / raw)
  To: Matthew Auld, Arkadiusz Hiler; +Cc: Intel Graphics Development

On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
>
> Intended for upstream testing so that we can still exercise the LMEM
> plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> device. This works by allocating an intel_memory_region for a reserved
> portion of system memory, which we treat like LMEM. For the LMEMBAR we
> steal the aperture and 1:1 it map to the stolen region.
>
> To enable simply set the i915 modparam fake_lmem_start= on the kernel
> cmdline with the start of reserved region(see memmap=). The size of the
> region we can use is determined by the size of the mappable aperture, so
> the size of reserved region should be >= mappable_end. For now we only
> enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> enabled.
>
> eg. memmap=2G$16G i915.fake_lmem_start=0x400000000

Hi Arek,

Would you be able to update the fi-skl-lmem kernel cmd line with
s/i915_fake_lmem_start/i915.fake_lmem_start?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-10-31 12:40     ` Arkadiusz Hiler
  0 siblings, 0 replies; 22+ messages in thread
From: Arkadiusz Hiler @ 2019-10-31 12:40 UTC (permalink / raw)
  To: Matthew Auld; +Cc: Intel Graphics Development, Matthew Auld

On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> >
> > Intended for upstream testing so that we can still exercise the LMEM
> > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > device. This works by allocating an intel_memory_region for a reserved
> > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > steal the aperture and 1:1 it map to the stolen region.
> >
> > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > cmdline with the start of reserved region(see memmap=). The size of the
> > region we can use is determined by the size of the mappable aperture, so
> > the size of reserved region should be >= mappable_end. For now we only
> > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > enabled.
> >
> > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> 
> Hi Arek,
> 
> Would you be able to update the fi-skl-lmem kernel cmd line with
> s/i915_fake_lmem_start/i915.fake_lmem_start?

done
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-10-31 12:40     ` Arkadiusz Hiler
  0 siblings, 0 replies; 22+ messages in thread
From: Arkadiusz Hiler @ 2019-10-31 12:40 UTC (permalink / raw)
  To: Matthew Auld; +Cc: Intel Graphics Development, Matthew Auld

On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> >
> > Intended for upstream testing so that we can still exercise the LMEM
> > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > device. This works by allocating an intel_memory_region for a reserved
> > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > steal the aperture and 1:1 it map to the stolen region.
> >
> > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > cmdline with the start of reserved region(see memmap=). The size of the
> > region we can use is determined by the size of the mappable aperture, so
> > the size of reserved region should be >= mappable_end. For now we only
> > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > enabled.
> >
> > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> 
> Hi Arek,
> 
> Would you be able to update the fi-skl-lmem kernel cmd line with
> s/i915_fake_lmem_start/i915.fake_lmem_start?

done
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-10-31 20:40       ` Chris Wilson
  0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-10-31 20:40 UTC (permalink / raw)
  To: Arkadiusz Hiler, Matthew Auld; +Cc: Intel Graphics Development, Matthew Auld

Quoting Arkadiusz Hiler (2019-10-31 12:40:35)
> On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> > On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> > >
> > > Intended for upstream testing so that we can still exercise the LMEM
> > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > > device. This works by allocating an intel_memory_region for a reserved
> > > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > > steal the aperture and 1:1 it map to the stolen region.
> > >
> > > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > > cmdline with the start of reserved region(see memmap=). The size of the
> > > region we can use is determined by the size of the mappable aperture, so
> > > the size of reserved region should be >= mappable_end. For now we only
> > > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > > enabled.
> > >
> > > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> > 
> > Hi Arek,
> > 
> > Would you be able to update the fi-skl-lmem kernel cmd line with
> > s/i915_fake_lmem_start/i915.fake_lmem_start?
> 
> done

<6>[  497.897456] [drm] Intel graphics fake LMEM: [mem 0x100000000-0x13fffffff]
<6>[  497.897459] [drm] Intel graphics fake LMEM IO start: 40000000
<6>[  497.897461] [drm] Intel graphics fake LMEM size: 40000000

All present.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-10-31 20:40       ` Chris Wilson
  0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-10-31 20:40 UTC (permalink / raw)
  To: Arkadiusz Hiler, Matthew Auld; +Cc: Intel Graphics Development, Matthew Auld

Quoting Arkadiusz Hiler (2019-10-31 12:40:35)
> On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> > On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> > >
> > > Intended for upstream testing so that we can still exercise the LMEM
> > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > > device. This works by allocating an intel_memory_region for a reserved
> > > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > > steal the aperture and 1:1 it map to the stolen region.
> > >
> > > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > > cmdline with the start of reserved region(see memmap=). The size of the
> > > region we can use is determined by the size of the mappable aperture, so
> > > the size of reserved region should be >= mappable_end. For now we only
> > > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > > enabled.
> > >
> > > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> > 
> > Hi Arek,
> > 
> > Would you be able to update the fi-skl-lmem kernel cmd line with
> > s/i915_fake_lmem_start/i915.fake_lmem_start?
> 
> done

<6>[  497.897456] [drm] Intel graphics fake LMEM: [mem 0x100000000-0x13fffffff]
<6>[  497.897459] [drm] Intel graphics fake LMEM IO start: 40000000
<6>[  497.897461] [drm] Intel graphics fake LMEM size: 40000000

All present.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-11-05 13:05         ` Matthew Auld
  0 siblings, 0 replies; 22+ messages in thread
From: Matthew Auld @ 2019-11-05 13:05 UTC (permalink / raw)
  To: Chris Wilson; +Cc: Intel Graphics Development, Matthew Auld

On Thu, 31 Oct 2019 at 20:40, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Arkadiusz Hiler (2019-10-31 12:40:35)
> > On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> > > On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> > > >
> > > > Intended for upstream testing so that we can still exercise the LMEM
> > > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > > > device. This works by allocating an intel_memory_region for a reserved
> > > > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > > > steal the aperture and 1:1 it map to the stolen region.
> > > >
> > > > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > > > cmdline with the start of reserved region(see memmap=). The size of the
> > > > region we can use is determined by the size of the mappable aperture, so
> > > > the size of reserved region should be >= mappable_end. For now we only
> > > > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > > > enabled.
> > > >
> > > > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> > >
> > > Hi Arek,
> > >
> > > Would you be able to update the fi-skl-lmem kernel cmd line with
> > > s/i915_fake_lmem_start/i915.fake_lmem_start?
> >
> > done
>
> <6>[  497.897456] [drm] Intel graphics fake LMEM: [mem 0x100000000-0x13fffffff]
> <6>[  497.897459] [drm] Intel graphics fake LMEM IO start: 40000000
> <6>[  497.897461] [drm] Intel graphics fake LMEM size: 40000000
>
> All present.

Arek,

Could we enable DRM_I915_UNSTABLE_FAKE_LMEM in CI? That should give us
some coverage of the fake local-memory setup on fi-skl-lmem.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-11-05 13:05         ` Matthew Auld
  0 siblings, 0 replies; 22+ messages in thread
From: Matthew Auld @ 2019-11-05 13:05 UTC (permalink / raw)
  To: Chris Wilson; +Cc: Intel Graphics Development, Matthew Auld

On Thu, 31 Oct 2019 at 20:40, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Arkadiusz Hiler (2019-10-31 12:40:35)
> > On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> > > On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> > > >
> > > > Intended for upstream testing so that we can still exercise the LMEM
> > > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > > > device. This works by allocating an intel_memory_region for a reserved
> > > > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > > > steal the aperture and 1:1 it map to the stolen region.
> > > >
> > > > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > > > cmdline with the start of reserved region(see memmap=). The size of the
> > > > region we can use is determined by the size of the mappable aperture, so
> > > > the size of reserved region should be >= mappable_end. For now we only
> > > > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > > > enabled.
> > > >
> > > > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> > >
> > > Hi Arek,
> > >
> > > Would you be able to update the fi-skl-lmem kernel cmd line with
> > > s/i915_fake_lmem_start/i915.fake_lmem_start?
> >
> > done
>
> <6>[  497.897456] [drm] Intel graphics fake LMEM: [mem 0x100000000-0x13fffffff]
> <6>[  497.897459] [drm] Intel graphics fake LMEM IO start: 40000000
> <6>[  497.897461] [drm] Intel graphics fake LMEM size: 40000000
>
> All present.

Arek,

Could we enable DRM_I915_UNSTABLE_FAKE_LMEM in CI? That should give us
some coverage of the fake local-memory setup on fi-skl-lmem.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-11-06  8:30           ` Arkadiusz Hiler
  0 siblings, 0 replies; 22+ messages in thread
From: Arkadiusz Hiler @ 2019-11-06  8:30 UTC (permalink / raw)
  To: Matthew Auld; +Cc: Intel Graphics Development, Matthew Auld

On Tue, Nov 05, 2019 at 01:05:20PM +0000, Matthew Auld wrote:
> On Thu, 31 Oct 2019 at 20:40, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Arkadiusz Hiler (2019-10-31 12:40:35)
> > > On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> > > > On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> > > > >
> > > > > Intended for upstream testing so that we can still exercise the LMEM
> > > > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > > > > device. This works by allocating an intel_memory_region for a reserved
> > > > > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > > > > steal the aperture and 1:1 it map to the stolen region.
> > > > >
> > > > > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > > > > cmdline with the start of reserved region(see memmap=). The size of the
> > > > > region we can use is determined by the size of the mappable aperture, so
> > > > > the size of reserved region should be >= mappable_end. For now we only
> > > > > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > > > > enabled.
> > > > >
> > > > > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> > > >
> > > > Hi Arek,
> > > >
> > > > Would you be able to update the fi-skl-lmem kernel cmd line with
> > > > s/i915_fake_lmem_start/i915.fake_lmem_start?
> > >
> > > done
> >
> > <6>[  497.897456] [drm] Intel graphics fake LMEM: [mem 0x100000000-0x13fffffff]
> > <6>[  497.897459] [drm] Intel graphics fake LMEM IO start: 40000000
> > <6>[  497.897461] [drm] Intel graphics fake LMEM size: 40000000
> >
> > All present.
> 
> Arek,
> 
> Could we enable DRM_I915_UNSTABLE_FAKE_LMEM in CI? That should give us
> some coverage of the fake local-memory setup on fi-skl-lmem.

Hey,

  config DRM_I915_UNSTABLE
	  bool "Enable unstable API for early prototype development"
	  depends on EXPERT
	  depends on STAGING
	  depends on BROKEN # should never be enabled by distros!

  config DRM_I915_UNSTABLE_FAKE_LMEM
	  bool "Enable the experimental fake lmem"
	  depends on DRM_I915_UNSTABLE

AFAIU because of that dependency on CONFIG_BROKEN we cannot just enable
it through .config - we have to edit the value in init/Kconfig[0].

Please push that change to core-for-CI (or other branch that gets
integrated into drm-tip) and then just send a merge request to the
kernel configs the CI is using[1].

[0]: https://lkml.org/lkml/2006/1/6/248
[1]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/tree/master/kconfig

-- 
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-11-06  8:30           ` Arkadiusz Hiler
  0 siblings, 0 replies; 22+ messages in thread
From: Arkadiusz Hiler @ 2019-11-06  8:30 UTC (permalink / raw)
  To: Matthew Auld; +Cc: Intel Graphics Development, Matthew Auld

On Tue, Nov 05, 2019 at 01:05:20PM +0000, Matthew Auld wrote:
> On Thu, 31 Oct 2019 at 20:40, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Arkadiusz Hiler (2019-10-31 12:40:35)
> > > On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> > > > On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> > > > >
> > > > > Intended for upstream testing so that we can still exercise the LMEM
> > > > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > > > > device. This works by allocating an intel_memory_region for a reserved
> > > > > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > > > > steal the aperture and 1:1 it map to the stolen region.
> > > > >
> > > > > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > > > > cmdline with the start of reserved region(see memmap=). The size of the
> > > > > region we can use is determined by the size of the mappable aperture, so
> > > > > the size of reserved region should be >= mappable_end. For now we only
> > > > > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > > > > enabled.
> > > > >
> > > > > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> > > >
> > > > Hi Arek,
> > > >
> > > > Would you be able to update the fi-skl-lmem kernel cmd line with
> > > > s/i915_fake_lmem_start/i915.fake_lmem_start?
> > >
> > > done
> >
> > <6>[  497.897456] [drm] Intel graphics fake LMEM: [mem 0x100000000-0x13fffffff]
> > <6>[  497.897459] [drm] Intel graphics fake LMEM IO start: 40000000
> > <6>[  497.897461] [drm] Intel graphics fake LMEM size: 40000000
> >
> > All present.
> 
> Arek,
> 
> Could we enable DRM_I915_UNSTABLE_FAKE_LMEM in CI? That should give us
> some coverage of the fake local-memory setup on fi-skl-lmem.

Hey,

  config DRM_I915_UNSTABLE
	  bool "Enable unstable API for early prototype development"
	  depends on EXPERT
	  depends on STAGING
	  depends on BROKEN # should never be enabled by distros!

  config DRM_I915_UNSTABLE_FAKE_LMEM
	  bool "Enable the experimental fake lmem"
	  depends on DRM_I915_UNSTABLE

AFAIU because of that dependency on CONFIG_BROKEN we cannot just enable
it through .config - we have to edit the value in init/Kconfig[0].

Please push that change to core-for-CI (or other branch that gets
integrated into drm-tip) and then just send a merge request to the
kernel configs the CI is using[1].

[0]: https://lkml.org/lkml/2006/1/6/248
[1]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/tree/master/kconfig

-- 
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-11-06 11:17             ` Chris Wilson
  0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-06 11:17 UTC (permalink / raw)
  To: Arkadiusz Hiler, Matthew Auld; +Cc: Intel Graphics Development, Matthew Auld

Quoting Arkadiusz Hiler (2019-11-06 08:30:37)
> On Tue, Nov 05, 2019 at 01:05:20PM +0000, Matthew Auld wrote:
> > On Thu, 31 Oct 2019 at 20:40, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >
> > > Quoting Arkadiusz Hiler (2019-10-31 12:40:35)
> > > > On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> > > > > On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> > > > > >
> > > > > > Intended for upstream testing so that we can still exercise the LMEM
> > > > > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > > > > > device. This works by allocating an intel_memory_region for a reserved
> > > > > > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > > > > > steal the aperture and 1:1 it map to the stolen region.
> > > > > >
> > > > > > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > > > > > cmdline with the start of reserved region(see memmap=). The size of the
> > > > > > region we can use is determined by the size of the mappable aperture, so
> > > > > > the size of reserved region should be >= mappable_end. For now we only
> > > > > > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > > > > > enabled.
> > > > > >
> > > > > > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> > > > >
> > > > > Hi Arek,
> > > > >
> > > > > Would you be able to update the fi-skl-lmem kernel cmd line with
> > > > > s/i915_fake_lmem_start/i915.fake_lmem_start?
> > > >
> > > > done
> > >
> > > <6>[  497.897456] [drm] Intel graphics fake LMEM: [mem 0x100000000-0x13fffffff]
> > > <6>[  497.897459] [drm] Intel graphics fake LMEM IO start: 40000000
> > > <6>[  497.897461] [drm] Intel graphics fake LMEM size: 40000000
> > >
> > > All present.
> > 
> > Arek,
> > 
> > Could we enable DRM_I915_UNSTABLE_FAKE_LMEM in CI? That should give us
> > some coverage of the fake local-memory setup on fi-skl-lmem.
> 
> Hey,
> 
>   config DRM_I915_UNSTABLE
>           bool "Enable unstable API for early prototype development"
>           depends on EXPERT
>           depends on STAGING
>           depends on BROKEN # should never be enabled by distros!
> 
>   config DRM_I915_UNSTABLE_FAKE_LMEM
>           bool "Enable the experimental fake lmem"
>           depends on DRM_I915_UNSTABLE
> 
> AFAIU because of that dependency on CONFIG_BROKEN we cannot just enable
> it through .config - we have to edit the value in init/Kconfig[0].

Before the revert last night, CONFIG_BROKEN was already enabled in
CI. It's now enabled again. The above output was from CI setting up lmem
without extra hackery.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-11-06 11:17             ` Chris Wilson
  0 siblings, 0 replies; 22+ messages in thread
From: Chris Wilson @ 2019-11-06 11:17 UTC (permalink / raw)
  To: Arkadiusz Hiler, Matthew Auld; +Cc: Intel Graphics Development, Matthew Auld

Quoting Arkadiusz Hiler (2019-11-06 08:30:37)
> On Tue, Nov 05, 2019 at 01:05:20PM +0000, Matthew Auld wrote:
> > On Thu, 31 Oct 2019 at 20:40, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >
> > > Quoting Arkadiusz Hiler (2019-10-31 12:40:35)
> > > > On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> > > > > On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> > > > > >
> > > > > > Intended for upstream testing so that we can still exercise the LMEM
> > > > > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > > > > > device. This works by allocating an intel_memory_region for a reserved
> > > > > > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > > > > > steal the aperture and 1:1 it map to the stolen region.
> > > > > >
> > > > > > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > > > > > cmdline with the start of reserved region(see memmap=). The size of the
> > > > > > region we can use is determined by the size of the mappable aperture, so
> > > > > > the size of reserved region should be >= mappable_end. For now we only
> > > > > > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > > > > > enabled.
> > > > > >
> > > > > > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> > > > >
> > > > > Hi Arek,
> > > > >
> > > > > Would you be able to update the fi-skl-lmem kernel cmd line with
> > > > > s/i915_fake_lmem_start/i915.fake_lmem_start?
> > > >
> > > > done
> > >
> > > <6>[  497.897456] [drm] Intel graphics fake LMEM: [mem 0x100000000-0x13fffffff]
> > > <6>[  497.897459] [drm] Intel graphics fake LMEM IO start: 40000000
> > > <6>[  497.897461] [drm] Intel graphics fake LMEM size: 40000000
> > >
> > > All present.
> > 
> > Arek,
> > 
> > Could we enable DRM_I915_UNSTABLE_FAKE_LMEM in CI? That should give us
> > some coverage of the fake local-memory setup on fi-skl-lmem.
> 
> Hey,
> 
>   config DRM_I915_UNSTABLE
>           bool "Enable unstable API for early prototype development"
>           depends on EXPERT
>           depends on STAGING
>           depends on BROKEN # should never be enabled by distros!
> 
>   config DRM_I915_UNSTABLE_FAKE_LMEM
>           bool "Enable the experimental fake lmem"
>           depends on DRM_I915_UNSTABLE
> 
> AFAIU because of that dependency on CONFIG_BROKEN we cannot just enable
> it through .config - we have to edit the value in init/Kconfig[0].

Before the revert last night, CONFIG_BROKEN was already enabled in
CI. It's now enabled again. The above output was from CI setting up lmem
without extra hackery.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-11-06 13:58               ` Arkadiusz Hiler
  0 siblings, 0 replies; 22+ messages in thread
From: Arkadiusz Hiler @ 2019-11-06 13:58 UTC (permalink / raw)
  To: Chris Wilson; +Cc: Intel Graphics Development, Matthew Auld

On Wed, Nov 06, 2019 at 11:17:29AM +0000, Chris Wilson wrote:
> Quoting Arkadiusz Hiler (2019-11-06 08:30:37)
> > On Tue, Nov 05, 2019 at 01:05:20PM +0000, Matthew Auld wrote:
> > > On Thu, 31 Oct 2019 at 20:40, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > >
> > > > Quoting Arkadiusz Hiler (2019-10-31 12:40:35)
> > > > > On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> > > > > > On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> > > > > > >
> > > > > > > Intended for upstream testing so that we can still exercise the LMEM
> > > > > > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > > > > > > device. This works by allocating an intel_memory_region for a reserved
> > > > > > > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > > > > > > steal the aperture and 1:1 it map to the stolen region.
> > > > > > >
> > > > > > > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > > > > > > cmdline with the start of reserved region(see memmap=). The size of the
> > > > > > > region we can use is determined by the size of the mappable aperture, so
> > > > > > > the size of reserved region should be >= mappable_end. For now we only
> > > > > > > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > > > > > > enabled.
> > > > > > >
> > > > > > > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> > > > > >
> > > > > > Hi Arek,
> > > > > >
> > > > > > Would you be able to update the fi-skl-lmem kernel cmd line with
> > > > > > s/i915_fake_lmem_start/i915.fake_lmem_start?
> > > > >
> > > > > done
> > > >
> > > > <6>[  497.897456] [drm] Intel graphics fake LMEM: [mem 0x100000000-0x13fffffff]
> > > > <6>[  497.897459] [drm] Intel graphics fake LMEM IO start: 40000000
> > > > <6>[  497.897461] [drm] Intel graphics fake LMEM size: 40000000
> > > >
> > > > All present.
> > > 
> > > Arek,
> > > 
> > > Could we enable DRM_I915_UNSTABLE_FAKE_LMEM in CI? That should give us
> > > some coverage of the fake local-memory setup on fi-skl-lmem.
> > 
> > Hey,
> > 
> >   config DRM_I915_UNSTABLE
> >           bool "Enable unstable API for early prototype development"
> >           depends on EXPERT
> >           depends on STAGING
> >           depends on BROKEN # should never be enabled by distros!
> > 
> >   config DRM_I915_UNSTABLE_FAKE_LMEM
> >           bool "Enable the experimental fake lmem"
> >           depends on DRM_I915_UNSTABLE
> > 
> > AFAIU because of that dependency on CONFIG_BROKEN we cannot just enable
> > it through .config - we have to edit the value in init/Kconfig[0].
> 
> Before the revert last night, CONFIG_BROKEN was already enabled in
> CI. It's now enabled again. The above output was from CI setting up lmem
> without extra hackery.
> -Chris

CI_DRM_7269 should have the DRM_I915_UNSTABLE_FAKE_LMEM enabled.

-- 
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region
@ 2019-11-06 13:58               ` Arkadiusz Hiler
  0 siblings, 0 replies; 22+ messages in thread
From: Arkadiusz Hiler @ 2019-11-06 13:58 UTC (permalink / raw)
  To: Chris Wilson; +Cc: Intel Graphics Development, Matthew Auld

On Wed, Nov 06, 2019 at 11:17:29AM +0000, Chris Wilson wrote:
> Quoting Arkadiusz Hiler (2019-11-06 08:30:37)
> > On Tue, Nov 05, 2019 at 01:05:20PM +0000, Matthew Auld wrote:
> > > On Thu, 31 Oct 2019 at 20:40, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > >
> > > > Quoting Arkadiusz Hiler (2019-10-31 12:40:35)
> > > > > On Wed, Oct 30, 2019 at 10:22:37PM +0000, Matthew Auld wrote:
> > > > > > On Tue, 29 Oct 2019 at 16:51, Matthew Auld <matthew.auld@intel.com> wrote:
> > > > > > >
> > > > > > > Intended for upstream testing so that we can still exercise the LMEM
> > > > > > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon
> > > > > > > device. This works by allocating an intel_memory_region for a reserved
> > > > > > > portion of system memory, which we treat like LMEM. For the LMEMBAR we
> > > > > > > steal the aperture and 1:1 it map to the stolen region.
> > > > > > >
> > > > > > > To enable simply set the i915 modparam fake_lmem_start= on the kernel
> > > > > > > cmdline with the start of reserved region(see memmap=). The size of the
> > > > > > > region we can use is determined by the size of the mappable aperture, so
> > > > > > > the size of reserved region should be >= mappable_end. For now we only
> > > > > > > enable for the selftests. Depends on CONFIG_DRM_I915_UNSTABLE being
> > > > > > > enabled.
> > > > > > >
> > > > > > > eg. memmap=2G$16G i915.fake_lmem_start=0x400000000
> > > > > >
> > > > > > Hi Arek,
> > > > > >
> > > > > > Would you be able to update the fi-skl-lmem kernel cmd line with
> > > > > > s/i915_fake_lmem_start/i915.fake_lmem_start?
> > > > >
> > > > > done
> > > >
> > > > <6>[  497.897456] [drm] Intel graphics fake LMEM: [mem 0x100000000-0x13fffffff]
> > > > <6>[  497.897459] [drm] Intel graphics fake LMEM IO start: 40000000
> > > > <6>[  497.897461] [drm] Intel graphics fake LMEM size: 40000000
> > > >
> > > > All present.
> > > 
> > > Arek,
> > > 
> > > Could we enable DRM_I915_UNSTABLE_FAKE_LMEM in CI? That should give us
> > > some coverage of the fake local-memory setup on fi-skl-lmem.
> > 
> > Hey,
> > 
> >   config DRM_I915_UNSTABLE
> >           bool "Enable unstable API for early prototype development"
> >           depends on EXPERT
> >           depends on STAGING
> >           depends on BROKEN # should never be enabled by distros!
> > 
> >   config DRM_I915_UNSTABLE_FAKE_LMEM
> >           bool "Enable the experimental fake lmem"
> >           depends on DRM_I915_UNSTABLE
> > 
> > AFAIU because of that dependency on CONFIG_BROKEN we cannot just enable
> > it through .config - we have to edit the value in init/Kconfig[0].
> 
> Before the revert last night, CONFIG_BROKEN was already enabled in
> CI. It's now enabled again. The above output was from CI setting up lmem
> without extra hackery.
> -Chris

CI_DRM_7269 should have the DRM_I915_UNSTABLE_FAKE_LMEM enabled.

-- 
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2019-11-06 13:58 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29 16:51 [PATCH] drm/i915/lmem: add the fake lmem region Matthew Auld
2019-10-29 16:51 ` [Intel-gfx] " Matthew Auld
2019-10-30  1:43 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-10-30  1:43   ` [Intel-gfx] " Patchwork
2019-10-30  1:57 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-30  1:57   ` [Intel-gfx] " Patchwork
2019-10-30  9:14 ` [PATCH] " Chris Wilson
2019-10-30  9:14   ` [Intel-gfx] " Chris Wilson
2019-10-30 22:22 ` Matthew Auld
2019-10-30 22:22   ` [Intel-gfx] " Matthew Auld
2019-10-31 12:40   ` Arkadiusz Hiler
2019-10-31 12:40     ` [Intel-gfx] " Arkadiusz Hiler
2019-10-31 20:40     ` Chris Wilson
2019-10-31 20:40       ` [Intel-gfx] " Chris Wilson
2019-11-05 13:05       ` Matthew Auld
2019-11-05 13:05         ` [Intel-gfx] " Matthew Auld
2019-11-06  8:30         ` Arkadiusz Hiler
2019-11-06  8:30           ` [Intel-gfx] " Arkadiusz Hiler
2019-11-06 11:17           ` Chris Wilson
2019-11-06 11:17             ` [Intel-gfx] " Chris Wilson
2019-11-06 13:58             ` Arkadiusz Hiler
2019-11-06 13:58               ` [Intel-gfx] " Arkadiusz Hiler

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.