On Wed, Nov 06, 2019 at 03:48:59PM +0100, Christoph Hellwig wrote:
> On Wed, Nov 06, 2019 at 10:10:13AM +0100, Borislav Petkov wrote:
> > Also, building with a cross-compiler fails here:
> 
> What config?  riscv defconfig + CONFIG_SIFIVE_L2 works just fine for me.

Do you not see the one I attached?

I'm attaching it again.

$ grep -E "(EDAC|SIFIVE_L2)" .config
CONFIG_EDAC_SUPPORT=y
CONFIG_EDAC=y
# CONFIG_EDAC_LEGACY_SYSFS is not set
# CONFIG_EDAC_DEBUG is not set
CONFIG_EDAC_SIFIVE=y
CONFIG_SIFIVE_L2=m

$ make.cross ARCH=riscv
make CROSS_COMPILE=/home/share/src/crosstool/gcc-8.1.0-nolibc/riscv64-linux/bin/riscv64-linux- --jobs=32 ARCH=riscv
...

drivers/soc/sifive/sifive_l2_cache.c:178:1: warning: data definition has no type or storage class
 device_initcall(sifive_l2_init);
 ^~~~~~~~~~~~~~~
drivers/soc/sifive/sifive_l2_cache.c:178:1: error: type defaults to 'int' in declaration of 'device_initcall' [-Werror=implicit-int]
drivers/soc/sifive/sifive_l2_cache.c:178:1: warning: parameter names (without types) in function declaration
drivers/soc/sifive/sifive_l2_cache.c:145:19: warning: 'sifive_l2_init' defined but not used [-Wunused-function]
 static int __init sifive_l2_init(void)
                   ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:266: drivers/soc/sifive/sifive_l2_cache.o] Error 1
make[2]: *** [scripts/Makefile.build:509: drivers/soc/sifive] Error 2
make[1]: *** [scripts/Makefile.build:509: drivers/soc] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1649: drivers] Error 2

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette