All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v4 9/9] perf stat: Use affinity for enabling/disabling events
Date: Wed, 6 Nov 2019 17:34:31 +0100	[thread overview]
Message-ID: <20191106163431.GQ30214@krava> (raw)
In-Reply-To: <20191105002522.83803-10-andi@firstfloor.org>

On Mon, Nov 04, 2019 at 04:25:22PM -0800, Andi Kleen wrote:

SNIP

>  }
>  
>  static int perf_evsel__run_ioctl(struct perf_evsel *evsel,
> -				 int ioc,  void *arg)
> +				 int ioc,  void *arg,
> +				 int cpu)
>  {
> -	int cpu, thread;
> +	int thread;
>  
> -	for (cpu = 0; cpu < xyarray__max_x(evsel->fd); cpu++) {
> -		for (thread = 0; thread < xyarray__max_y(evsel->fd); thread++) {
> -			int fd = FD(evsel, cpu, thread),
> -			    err = ioctl(fd, ioc, arg);
> +	for (thread = 0; thread < xyarray__max_y(evsel->fd); thread++) {
> +		int fd = FD(evsel, cpu, thread),
> +		    err = ioctl(fd, ioc, arg);
>  
> -			if (err)
> -				return err;
> -		}
> +		if (err)
> +			return err;
>  	}
>  
>  	return 0;
>  }
>  
> +int perf_evsel__enable_cpu(struct perf_evsel *evsel, int cpu)
> +{
> +	return perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_ENABLE, 0, cpu);
> +}
> +
>  int perf_evsel__enable(struct perf_evsel *evsel)
>  {
> -	return perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_ENABLE, 0);
> +	int i;
> +	int err = 0;
> +
> +	for (i = 0; i < evsel->cpus->nr && !err; i++)
> +		err = perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_ENABLE, 0, i);
> +	return err;
> +}
> +
> +int perf_evsel__disable_cpu(struct perf_evsel *evsel, int cpu)
> +{
> +	return perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_DISABLE, 0, cpu);
>  }
>  
>  int perf_evsel__disable(struct perf_evsel *evsel)
>  {
> -	return perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_DISABLE, 0);
> +	int i;
> +	int err = 0;
> +
> +	for (i = 0; i < evsel->cpus->nr && !err; i++)
> +		err = perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_DISABLE, 0, i);
> +	return err;
>  }
>  
>  int perf_evsel__apply_filter(struct perf_evsel *evsel, const char *filter)
>  {
> -	return perf_evsel__run_ioctl(evsel,
> +	int err = 0, i;
> +
> +	for (i = 0; i < evsel->cpus->nr && !err; i++)
> +		err = perf_evsel__run_ioctl(evsel,
>  				     PERF_EVENT_IOC_SET_FILTER,
> -				     (void *)filter);
> +				     (void *)filter, i);
> +	return err;
>  }

please move the new function additions to separate patches

thanks,
jirka


      reply	other threads:[~2019-11-06 16:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05  0:25 Optimize perf stat for large number of events/cpus Andi Kleen
2019-11-05  0:25 ` [PATCH v4 1/9] perf pmu: Use file system cache to optimize sysfs access Andi Kleen
2019-11-05  0:25 ` [PATCH v4 2/9] perf affinity: Add infrastructure to save/restore affinity Andi Kleen
2019-11-05  0:25 ` [PATCH v4 3/9] perf evlist: Maintain evlist->all_cpus Andi Kleen
2019-11-06 16:34   ` Jiri Olsa
2019-11-05  0:25 ` [PATCH v4 4/9] perf evsel: Add iterator to iterate over events ordered by CPU Andi Kleen
2019-11-05  0:25 ` [PATCH v4 5/9] perf stat: Use affinity for closing file descriptors Andi Kleen
2019-11-06 16:33   ` Jiri Olsa
2019-11-06 16:34   ` Jiri Olsa
2019-11-05  0:25 ` [PATCH v4 6/9] perf stat: Factor out open error handling Andi Kleen
2019-11-06 16:33   ` Jiri Olsa
2019-11-05  0:25 ` [PATCH v4 7/9] perf stat: Use affinity for opening events Andi Kleen
2019-11-06 16:34   ` Jiri Olsa
2019-11-05  0:25 ` [PATCH v4 8/9] perf stat: Use affinity for reading Andi Kleen
2019-11-05  0:25 ` [PATCH v4 9/9] perf stat: Use affinity for enabling/disabling events Andi Kleen
2019-11-06 16:34   ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106163431.GQ30214@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.