All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v2 4/7] gpio: merrifield: Add GPIO <-> pin mapping ranges via callback
Date: Wed, 6 Nov 2019 18:52:11 +0200	[thread overview]
Message-ID: <20191106165211.GP32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191106135436.GR2552@lahna.fi.intel.com>

On Wed, Nov 06, 2019 at 03:54:36PM +0200, Mika Westerberg wrote:
> On Tue, Nov 05, 2019 at 10:35:54PM +0200, Andy Shevchenko wrote:
> > When IRQ chip is instantiated via GPIO library flow, the few functions,
> > in particular the ACPI event registration mechanism, on some of ACPI based
> > platforms expect that the pin ranges are initialized to that point.
> > 
> > Add GPIO <-> pin mapping ranges via callback in the GPIO library flow.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Thanks.

> > +		retval = gpiochip_add_pin_range(&priv->chip,
> > +						pinctrl_dev_name,
> > +						range->gpio_base,
> > +						range->pin_base,
> > +						range->npins);
> 
> IMHO the below looks slightly better:
> 

> 		ret = gpiochip_add_pin_range(&priv->chip, pinctrl_dev_name,

I did this one...

> 					     range->gpio_base, range->pin_base,

...but this, since over going thru 80 limit.

> 					     range->npins);

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2019-11-06 16:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 20:35 [RESEND][PATCH v2 0/7] gpiolib: fix GPIO <-> pin mapping registration Andy Shevchenko
2019-11-05 20:35 ` [PATCH v2 1/7] gpiolib: Switch order of valid mask and hw init Andy Shevchenko
2019-11-05 20:35 ` [PATCH v2 2/7] gpiolib: No need to call gpiochip_remove_pin_ranges() twice Andy Shevchenko
2019-11-05 20:35 ` [PATCH v2 3/7] gpiolib: Introduce ->add_pin_ranges() callback Andy Shevchenko
2019-11-06 13:51   ` Mika Westerberg
2019-11-13  9:46   ` Linus Walleij
2019-11-13 13:22     ` Andy Shevchenko
2019-11-13 17:25       ` Linus Walleij
2019-11-13 17:47         ` Andy Shevchenko
2019-11-05 20:35 ` [PATCH v2 4/7] gpio: merrifield: Add GPIO <-> pin mapping ranges via callback Andy Shevchenko
2019-11-06 13:54   ` Mika Westerberg
2019-11-06 16:52     ` Andy Shevchenko [this message]
2019-11-05 20:35 ` [PATCH v2 5/7] gpio: merrifield: Pass irqchip when adding gpiochip Andy Shevchenko
2019-11-06 13:56   ` Mika Westerberg
2019-11-05 20:35 ` [PATCH v2 6/7] pinctrl: baytrail: Add GPIO <-> pin mapping ranges via callback Andy Shevchenko
2019-11-06 13:56   ` Mika Westerberg
2019-11-05 20:35 ` [PATCH v2 7/7] pinctrl: baytrail: Pass irqchip when adding gpiochip Andy Shevchenko
2019-11-06 14:00   ` Mika Westerberg
2019-11-06 11:59 ` [RESEND][PATCH v2 0/7] gpiolib: fix GPIO <-> pin mapping registration Hans de Goede
2019-11-06 17:30 ` Andy Shevchenko
2019-11-08  9:40   ` Linus Walleij
2019-11-08 13:39     ` Andy Shevchenko
2019-11-13  9:43       ` Linus Walleij
2019-11-13 13:28         ` Andy Shevchenko
2019-11-13 13:37           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106165211.GP32742@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=hdegoede@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.