From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [PATCH 2/6] migration/postcopy: wait for decompress thread in precopy
Date: Wed, 6 Nov 2019 19:57:22 +0000 [thread overview]
Message-ID: <20191106195722.GI2802@work-vm> (raw)
In-Reply-To: <20191018004850.9888-3-richardw.yang@linux.intel.com>
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> Compress is not supported with postcopy, it is safe to wait for
> decompress thread just in precopy.
>
> This is a preparation for later patch.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
OK, since your last patch does this for postcopy.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/ram.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 7938a643d9..f59e3fe197 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -4375,6 +4375,7 @@ static int ram_load_precopy(QEMUFile *f)
> }
> }
>
> + ret |= wait_for_decompress_done();
> return ret;
> }
>
> @@ -4406,8 +4407,6 @@ static int ram_load(QEMUFile *f, void *opaque, int version_id)
> } else {
> ret = ram_load_precopy(f);
> }
> -
> - ret |= wait_for_decompress_done();
> }
> trace_ram_load_complete(ret, seq_iter);
>
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-11-06 19:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 0:48 [PATCH 0/6] migration/postcopy: enable compress during postcopy Wei Yang
2019-10-18 0:48 ` [PATCH 1/6] migration/postcopy: reduce memset when it is zero page and matches_target_page_size Wei Yang
2019-11-06 18:18 ` Dr. David Alan Gilbert
2019-10-18 0:48 ` [PATCH 2/6] migration/postcopy: wait for decompress thread in precopy Wei Yang
2019-11-06 19:57 ` Dr. David Alan Gilbert [this message]
2019-10-18 0:48 ` [PATCH 3/6] migration/postcopy: count target page number to decide the place_needed Wei Yang
2019-11-06 19:59 ` Dr. David Alan Gilbert
2019-10-18 0:48 ` [PATCH 4/6] migration/postcopy: set all_zero to true on the first target page Wei Yang
2019-11-06 20:04 ` Dr. David Alan Gilbert
2019-10-18 0:48 ` [PATCH 5/6] migration/postcopy: enable random order target page arrival Wei Yang
2019-11-06 20:08 ` Dr. David Alan Gilbert
2019-11-07 6:00 ` Wei Yang
2019-11-07 9:14 ` Dr. David Alan Gilbert
2019-10-18 0:48 ` [PATCH 6/6] migration/postcopy: enable compress during postcopy Wei Yang
2019-11-06 19:55 ` Dr. David Alan Gilbert
2019-10-18 16:50 ` [PATCH 0/6] " no-reply
2019-10-19 0:15 ` Wei Yang
2019-11-06 20:11 ` Dr. David Alan Gilbert
2019-11-07 6:02 ` Wei Yang
2019-11-07 9:15 ` Dr. David Alan Gilbert
2019-11-07 12:03 ` Wei Yang
2019-11-07 12:06 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106195722.GI2802@work-vm \
--to=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.