From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [BUGFIX PATCH 3/4] perf probe: Fix to show calling lines of inlined functions
Date: Wed, 6 Nov 2019 17:08:43 -0300 [thread overview]
Message-ID: <20191106200843.GD13829@kernel.org> (raw)
In-Reply-To: <157241937995.32002.17899884017011512577.stgit@devnote2>
Em Wed, Oct 30, 2019 at 04:09:40PM +0900, Masami Hiramatsu escreveu:
> Fix to show calling lines of inlined functions (where an
> inline function is called).
>
> die_walk_lines() filtered out the lines inside inlined functions
> based on the address. However this also filtered out the lines
> which call those inlined functions from the target function.
>
> To solve this issue, check the call_file and call_line attributes
> and do not filter out if it matches to the line information.
>
> Without this fix, perf probe -L doesn't show some lines correctly.
> (don't see the lines after 17)
Thanks, tested before and after and applied,
- Arnaldo
next prev parent reply other threads:[~2019-11-06 20:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 7:09 [BUGFIX PATCH 0/4] perf probe: Fixes bugs in show-lines and show vars etc Masami Hiramatsu
2019-10-30 7:09 ` [BUGFIX PATCH 1/4] perf probe: Skip end-of-sequence and non statement lines Masami Hiramatsu
2019-11-06 20:04 ` Arnaldo Carvalho de Melo
2020-01-10 9:29 ` Rantala, Tommi T. (Nokia - FI/Espoo)
2020-01-10 15:43 ` Masami Hiramatsu
2019-11-12 11:17 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
2019-10-30 7:09 ` [BUGFIX PATCH 2/4] perf probe: Filter out instances except for inlined subroutine and subprogram Masami Hiramatsu
2019-11-06 20:06 ` Arnaldo Carvalho de Melo
2019-11-12 11:17 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
2019-10-30 7:09 ` [BUGFIX PATCH 3/4] perf probe: Fix to show calling lines of inlined functions Masami Hiramatsu
2019-11-06 20:08 ` Arnaldo Carvalho de Melo [this message]
2019-11-12 11:17 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
2019-10-30 7:09 ` [BUGFIX PATCH 4/4] perf probe: Skip overlapped location on searching variables Masami Hiramatsu
2019-11-06 20:09 ` Arnaldo Carvalho de Melo
2019-11-12 11:17 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106200843.GD13829@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.