From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2798EC5DF64 for ; Wed, 6 Nov 2019 20:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDF872187F for ; Wed, 6 Nov 2019 20:23:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YC4Z2dHC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727862AbfKFUXz (ORCPT ); Wed, 6 Nov 2019 15:23:55 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43637 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727516AbfKFUXz (ORCPT ); Wed, 6 Nov 2019 15:23:55 -0500 Received: by mail-pg1-f196.google.com with SMTP id l24so17907297pgh.10 for ; Wed, 06 Nov 2019 12:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=y3ErlOr8zz0pSn0wPZ07CUTX0RGvOBpRtPLCuFwaNrU=; b=YC4Z2dHC4F15YVKn4yT41EJQgMIWuL7hjQk/OTXa3g0MxmASCu11F86facfUqg8IVP H74cF+N1vvF5qMKFjmYP/NyKznq/EYetZgGS6zVJbgY1dq/+fq8p9BCFpLgDY21xH6Fb ZF/c657P0QvNsknVIoB/RiiAskAZw8n8Aq8cRFXGQTepkqAifg9k8nR5fdGYuGUgUx6+ 4XvGXYfoPd0lD6/8+1TpiijrbwEPhh1HVGRAe18sBeWRhwhIdywCsQE6zJIAM+uGLl6o yJo1tYhCreBBrUBwKunybHKS/ir9sY/sAXJ37HcoRlpzhHLnq321EmAL3WxZbE3Pe/n8 ENHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=y3ErlOr8zz0pSn0wPZ07CUTX0RGvOBpRtPLCuFwaNrU=; b=lUlUKYW0i9uU4H9JomAodSr7arvuHTfBsdEpNfDzpYkirlzYcdH4wmyI/jxxx6IiWQ xOEhKIkx7qHjxJRvDUMTm9OdXcRHjhE5eh1JEerOBf9wq2RcT3Jg3/RzLv90E3Kyw2eZ bnvnplvYhUULXq1e1OlA6NDOa7kLUoNWbUUEJJglpGqzsEo3Z90kTY1nox8cD7z3ehhZ tpIaPyWmUoyiR+Q+0PmRYdpybFzFkFV5CP/6q8RqyxHjIrEs3nWr+a4t1TzKPbCJHFEl nggdcmokgGcYUzs9RsRkS7AT7HLudehgebifvJGVww12KBxXz7Qfgg2s5wNqx9S7V9UE hO4A== X-Gm-Message-State: APjAAAVHFeH/BYDA/10bubk74316rOMoKqox2SjvJKk7fcBreLd8fGoO OZZDF+gCKNax1EaxEB1uZwBlZQ== X-Google-Smtp-Source: APXvYqyYQ890RT5KorI4LSOMnM/qz6CZ76JmLNXzmgX+AVICrIQOgPg99MRUcCBfttjdwh5qqH78Sw== X-Received: by 2002:a65:47cd:: with SMTP id f13mr5023056pgs.356.1573071834146; Wed, 06 Nov 2019 12:23:54 -0800 (PST) Received: from minitux (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id p9sm27469818pfq.40.2019.11.06.12.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2019 12:23:53 -0800 (PST) Date: Wed, 6 Nov 2019 12:23:51 -0800 From: Bjorn Andersson To: Stanimir Varbanov Cc: Lorenzo Pieralisi , Andrew Murray , Bjorn Helgaas , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] PCI: qcom: Fix the fixup of PCI_VENDOR_ID_QCOM Message-ID: <20191106202351.GE36595@minitux> References: <20191102002420.4091061-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 04 Nov 05:00 PST 2019, Stanimir Varbanov wrote: > Hi Bjorn, > > Thanks for the fix! > > On 11/2/19 2:24 AM, Bjorn Andersson wrote: > > There exists non-bridge PCIe devices with PCI_VENDOR_ID_QCOM, so limit > > the fixup to only affect the PCIe 2.0 (0x106) and PCIe 3.0 (0x107) > > bridges. > > Are you sure that this will not break ops_1_0_0 (Qcom IP rev.: 1.0.0 > Synopsys IP rev.: 4.11a) i.e. apq8084 ? > I am not, I've only tested this on db820c and db845c. Unfortunately I'm unable to find a branch with the necessary dts snippets to test it. Do you perhaps have a branch somewhere? Regards, Bjorn > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Bjorn Andersson > > --- > > drivers/pci/controller/dwc/pcie-qcom.c | 3 ++- > > include/linux/pci_ids.h | 2 ++ > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > index 35f4980480bb..b91abf4d4905 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > @@ -1441,7 +1441,8 @@ static void qcom_fixup_class(struct pci_dev *dev) > > { > > dev->class = PCI_CLASS_BRIDGE_PCI << 8; > > } > > -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_QCOM, PCI_ANY_ID, qcom_fixup_class); > > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_QCOM, PCIE_DEVICE_ID_QCOM_PCIE20, qcom_fixup_class); > > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_QCOM, PCIE_DEVICE_ID_QCOM_PCIE30, qcom_fixup_class); > > > > static struct platform_driver qcom_pcie_driver = { > > .probe = qcom_pcie_probe, > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > index 21a572469a4e..3d0724ee4d2f 100644 > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2413,6 +2413,8 @@ > > #define PCI_VENDOR_ID_LENOVO 0x17aa > > > > #define PCI_VENDOR_ID_QCOM 0x17cb > > +#define PCIE_DEVICE_ID_QCOM_PCIE20 0x0106 > > +#define PCIE_DEVICE_ID_QCOM_PCIE30 0x0107 > > > > #define PCI_VENDOR_ID_CDNS 0x17cd > > > > > > -- > regards, > Stan