From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8714FC6194 for ; Thu, 7 Nov 2019 02:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9974E217D7 for ; Thu, 7 Nov 2019 02:04:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="cSPzIBJD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732864AbfKGCEk (ORCPT ); Wed, 6 Nov 2019 21:04:40 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:53114 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727328AbfKGCEk (ORCPT ); Wed, 6 Nov 2019 21:04:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XsahgORl/nC9fQXSgVRroYjqg6suN/1vTL2xj6w2qsQ=; b=cSPzIBJDGna4Z7tnh9m1l3Adbf 1ortmFg1/MKaNHHTvqEQ/ooaPQ8yfRu2OtCXOjcl4s2jICmOverdg87/KdWj3zLNILcwjaU+XVJ+T stBcu+x02pFH2OxvPrJThY1P8/EgTkyE5S3OaDjrofftUMecSYvGcmXaG5q/3QUb1DOM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iSXA4-0002l1-5k; Thu, 07 Nov 2019 03:04:36 +0100 Date: Thu, 7 Nov 2019 03:04:36 +0100 From: Andrew Lunn To: Michael Walle Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Rob Herring , David Miller , Florian Fainelli , Simon Horman , Oleksij Rempel Subject: Re: [PATCH v2 4/6] net: phy: at803x: mention AR8033 as same as AR8031 Message-ID: <20191107020436.GD8978@lunn.ch> References: <20191106223617.1655-1-michael@walle.cc> <20191106223617.1655-5-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191106223617.1655-5-michael@walle.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 06, 2019 at 11:36:15PM +0100, Michael Walle wrote: > The AR8033 is the AR8031 without PTP support. All other registers are > the same. Unfortunately, they share the same PHY ID. Therefore, we > cannot distinguish between the one with PTP support and the one without. Not nice. I suppose there might be a PTP register you can read to determine this, but that is not very helpful. Reviewed-by: Andrew Lunn Andrew