From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCHv2 1/4] drm/arm: Factor out generic afbc helpers Date: Thu, 7 Nov 2019 09:27:33 +0100 Message-ID: <20191107082733.GI23790@phenom.ffwll.local> References: <2485717.1SzL54aMiy@e123338-lin> <20191104221228.3588-1-andrzej.p@collabora.com> <20191104221228.3588-2-andrzej.p@collabora.com> <20191105092232.GV10326@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Pietrasiewicz Cc: kernel@collabora.com, Mihail Atanassov , David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, James Wang , Ayan Halder , Sean Paul List-Id: linux-rockchip.vger.kernel.org T24gV2VkLCBOb3YgMDYsIDIwMTkgYXQgMDE6NDU6MDVQTSArMDEwMCwgQW5kcnplaiBQaWV0cmFz aWV3aWN6IHdyb3RlOgo+IEhpIERhbmllbCwKPiAKPiBUaGFuayB5b3UgZm9yIHJldmlldywKPiAK PiBXIGRuaXUgMDUuMTEuMjAxOSBvwqAxMDoyMiwgRGFuaWVsIFZldHRlciBwaXN6ZToKPiA+IE9u IE1vbiwgTm92IDA0LCAyMDE5IGF0IDExOjEyOjI1UE0gKzAxMDAsIEFuZHJ6ZWogUGlldHJhc2ll d2ljeiB3cm90ZToKPiA+ID4gVGhlc2UgYXJlIHVzZWZ1bCBmb3Igb3RoZXIgdXNlcnMgb2YgYWZi YywgZS5nLiByb2NrY2hpcC4KPiA+ID4gCj4gCj4gPHNuaXA+Cj4gCj4gPiA+ICsKPiA+ID4gK2Jv b2wgZHJtX2FmYmNfY2hlY2tfZmJfc2l6ZV9yZXQodTMyIHBpdGNoLCBpbnQgYnBwLAo+ID4gPiAr CQkJCXUzMiB3LCB1MzIgaCwgdTMyIHN1cGVyYmxrX3csIHUzMiBzdXBlcmJsa19oLAo+ID4gPiAr CQkJCXNpemVfdCBzaXplLCB1MzIgb2Zmc2V0LCB1MzIgaGRyX2FsaWduLAo+ID4gPiArCQkJCXUz MiAqcGF5bG9hZF9vZmYsIHUzMiAqdG90YWxfc2l6ZSkKPiA+ID4gK3sKPiA+ID4gKwlpbnQgbl9z dXBlcmJsa3MgPSAwOwo+ID4gPiArCXUzMiBzdXBlcmJsa19zeiA9IDA7Cj4gPiA+ICsJdTMyIGFm YmNfc2l6ZSA9IDA7Cj4gPiA+ICsKPiA+ID4gKwluX3N1cGVyYmxrcyA9ICh3IC8gc3VwZXJibGtf dykgKiAoaCAvIHN1cGVyYmxrX2gpOwo+ID4gPiArCXN1cGVyYmxrX3N6ID0gKGJwcCAqIHN1cGVy YmxrX3cgKiBzdXBlcmJsa19oKSAvIEJJVFNfUEVSX0JZVEU7Cj4gPiA+ICsJYWZiY19zaXplID0g QUxJR04obl9zdXBlcmJsa3MgKiBBRkJDX0hFQURFUl9TSVpFLCBoZHJfYWxpZ24pOwo+ID4gPiAr CSpwYXlsb2FkX29mZiA9IGFmYmNfc2l6ZTsKPiA+ID4gKwo+ID4gPiArCWFmYmNfc2l6ZSArPSBu X3N1cGVyYmxrcyAqIEFMSUdOKHN1cGVyYmxrX3N6LCBBRkJDX1NVUEVSQkxLX0FMSUdOTUVOVCk7 Cj4gPiA+ICsJKnRvdGFsX3NpemUgPSBhZmJjX3NpemUgKyBvZmZzZXQ7Cj4gPiA+ICsKPiA+ID4g KwlpZiAoKHcgKiBicHApICE9IChwaXRjaCAqIEJJVFNfUEVSX0JZVEUpKSB7Cj4gPiA+ICsJCURS TV9ERUJVR19LTVMoIkludmFsaWQgdmFsdWUgb2YgKHBpdGNoICogQklUU19QRVJfQllURSkgKD0l dSkgc2hvdWxkIGJlIHNhbWUgYXMgd2lkdGggKD0ldSkgKiBicHAgKD0ldSlcbiIsCj4gPiA+ICsJ CQkgICAgICBwaXRjaCAqIEJJVFNfUEVSX0JZVEUsIHcsIGJwcAo+ID4gPiArCQkpOwo+ID4gPiAr CQlyZXR1cm4gZmFsc2U7Cj4gPiA+ICsJfQo+ID4gPiArCj4gPiA+ICsJaWYgKHNpemUgPCBhZmJj X3NpemUpIHsKPiA+ID4gKwkJRFJNX0RFQlVHX0tNUygiYnVmZmVyIHNpemUgKCV6dSkgdG9vIHNt YWxsIGZvciBBRkJDIGJ1ZmZlciBzaXplID0gJXVcbiIsCj4gPiA+ICsJCQkgICAgICBzaXplLCBh ZmJjX3NpemUKPiA+ID4gKwkJKTsKPiA+ID4gKwo+ID4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiA+ ICsJfQo+ID4gPiArCj4gPiA+ICsJcmV0dXJuIHRydWU7Cj4gPiA+ICt9Cj4gPiA+ICtFWFBPUlRf U1lNQk9MKGRybV9hZmJjX2NoZWNrX2ZiX3NpemVfcmV0KTsKPiA+ID4gKwo+ID4gPiArYm9vbCBk cm1fYWZiY19jaGVja19mYl9zaXplKHUzMiBwaXRjaCwgaW50IGJwcCwKPiA+ID4gKwkJCSAgICB1 MzIgdywgdTMyIGgsIHUzMiBzdXBlcmJsa193LCB1MzIgc3VwZXJibGtfaCwKPiA+ID4gKwkJCSAg ICBzaXplX3Qgc2l6ZSwgdTMyIG9mZnNldCwgdTMyIGhkcl9hbGlnbikKPiA+ID4gK3sKPiA+ID4g Kwl1MzIgcGF5bG9hZF9vZmZzZXQsIHRvdGFsX3NpemU7Cj4gPiA+ICsKPiA+ID4gKwlyZXR1cm4g ZHJtX2FmYmNfY2hlY2tfZmJfc2l6ZV9yZXQocGl0Y2gsIGJwcCwgdywgaCwKPiA+ID4gKwkJCQkJ ICBzdXBlcmJsa193LCBzdXBlcmJsa19oLAo+ID4gPiArCQkJCQkgIHNpemUsIG9mZnNldCwgaGRy X2FsaWduLAo+ID4gPiArCQkJCQkgICZwYXlsb2FkX29mZnNldCwgJnRvdGFsX3NpemUpOwo+ID4g PiArfQo+ID4gPiArRVhQT1JUX1NZTUJPTChkcm1fYWZiY19jaGVja19mYl9zaXplKTsKPiA+IAo+ ID4gV2h5IGRvbid0IHdlIGhhdmUgb25lIG92ZXJhbGwgImNoZWNrIGFmYmMgcGFyYW1ldGVycyBh Z2FpbnN0IGJ1ZmZlciIKPiA+IGZ1bmN0aW9uPwo+ID4gCj4gCj4gSSBub3RpY2VkIHRoYXQgZGlm ZmVyZW50IGRyaXZlcnMgaGF2ZSBkaWZmZXJlbnQgbmVlZHMgKG1hbGlkcAo+IGFuZCByb2NrY2hp cCBhcmUga2luZCBvZiBzaW1pbGFyLCBidXQga29tZWRhIGlzIGEgYml0IGRpZmZlcmVudCkuCj4g VGhhdCBpcyB3aHkgdGhlIGhlbHBlcnMgYXJlIG9ubHkgYnVpbGRpbmcgYmxvY2tzIG91dCBvZiB3 aGljaAo+IGVhY2ggZHJpdmVyIGJ1aWxkcyBpdHMgb3duIGNoZWNraW5nIGxvZ2ljLiBJbiBwYXJ0 aWN1bGFyIGtvbWVkYQo+IHdhbnRzIHNvbWUgYnktcHJvZHVjdHMgb2YgdGhlIGNoZWNrIHN0b3Jl ZCBpbiBpdHMgaW50ZXJuYWwgZGF0YQo+IHN0cnVjdHVyZXMsIGhlbmNlIGRybV9hZmJjX2NoZWNr X2ZiX3NpemVfcmV0KCkgYW5kIGl0cyB3cmFwcGVyCj4gZHJtX2FmYmNfY2hlY2tfZmJfc2l6ZSgp IHdoaWNoIGlnbm9yZXMgdGhlICJvdXQiIHBhcmFtZXRlcnMuCj4gCj4gSWYgSSB3YW50ZWQgdG8g Y3JlYXRlIG9uZSBvdmVyYWxsICJjaGVjayBhZmJjIHBhcmFtZXRlcnMiIEknZCBoYXZlCj4gdG8g Y29tZSB1cCB3aXRoIGEgd2F5IHRvIHBhc3MgZHJpdmVyLXNwZWNpZmljIHJlcXVpcmVtZW50cyB0 byBpdAo+IGFuZCB0aGVuIGluc2lkZSB0aGUgZnVuY3Rpb24gaGF2ZSBzb21lIGxvZ2ljIHRvIGRl Y2lkZSB3aGF0IHRvCj4gY2hlY2sgYWdhaW5zdCB3aGF0LiBEbyB5b3UgdGhpbmsgaXQgaXMgd29y dGggaXQ/CgpIbSBJIGZpZ3VyZWQgdGhlcmUncyBhdCBsZWFzdCB0d28gcGFydHMgb2YgdGhpczoK LSBHZW5lcmljIGNoZWNraW5nIG9mIGFmYmMgYWdhaW5zdCB0aGUgZmIgcGFyYW1ldGVycywgaS5l LiBpcyBpdCBiaWcKICBlbm91Z2gsIGNvcnJlY3RseSBhbGlnbmVkLCBhbGwgdGhhdC4KLSBBZGRp dGlvbmFsIGRyaXZlciBjaGVja3MsIHdoaWNoIG1pZ2h0IG5lZWQgc29tZSBvZiB0aGUgc2FtZSBw YXJhbWV0ZXJzCiAgYWdhaW4uCgpUaGUgaWRlYSBiZWhpbmQgYXNraW5nIGZvciB0aGUgZmlyc3Qg cGFydCBpcyB0aGF0IG1heWJlIHdlIHNob3VsZCBwdXQgdGhhdAppbnRvIHRoZSBjb3JlIGFzIHBh cnQgb2YgdGhlIGFkZGZiIGNoZWNrcyAobGlrZSB3ZSBkbyBmb3IgdGhlIHRpbGVkIE5WMTIKdGhp bmcgYWxyZWFkeSkuIFRoZW4gZHJpdmVycyBvbmx5IG5lZWQgdG8gZG8gYWRkaXRpb25hbCBjaGVj a3Mgb24gdG9wIGZvcgp0aGVpciBzcGVjaWZpYyBjb25zdHJhaW50cy4gRm9yIHRoYXQgeW91IGNv dWxkIGV4cG9zZSBzb21lIGhlbHBlcnMgb2ZjICh0bwpnZXQgdGhlIHBheWxvYWRfb2Zmc2V0IGFu ZCBhbnl0aGluZyBlbHNlIGNvbXB1dGVkIHlvdSBtaWdodCBuZWVkKS4KCkJ1dCB0aGUgYmFzaWMg ZHJtX2FmYmNfY2hlY2tfZmJfc2l6ZSgpIHNob3VsZCBpbW8gYmUgZG9uZSB1bmNvbmRpdGlvbmFs bHkKZm9yIGFueSBhZmJjIG1vZGlmaWVyLiBUbyBtYWtlIHN1cmUgd2UgZG9uJ3QgaGF2ZSBsb3Rz IG9mIGRyaXZlcnMgd2l0aApkaWZmZXJlbnQgYnVncyBpbiB0aGF0IHRoaW5nLgotRGFuaWVsCi0t IApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRw Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWw=