* [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence
@ 2019-11-07 10:32 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-11-07 10:32 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
The pre-initialized magic value is a bit silly, switch to a flag
instead.
v2: Reduce paranoia to a single sanity check (Ville)
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 10 +---------
drivers/gpu/drm/i915/display/intel_ddi.c | 13 +++++++------
drivers/gpu/drm/i915/i915_drv.h | 8 ++------
3 files changed, 10 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index a03f56b7b4ef..c19b234bebe6 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1509,6 +1509,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
port_name(port),
hdmi_level_shift);
info->hdmi_level_shift = hdmi_level_shift;
+ info->hdmi_level_shift_set = true;
}
if (bdb_version >= 204) {
@@ -1692,8 +1693,6 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
static void
init_vbt_defaults(struct drm_i915_private *dev_priv)
{
- enum port port;
-
dev_priv->vbt.crt_ddc_pin = GMBUS_PIN_VGADDC;
/* Default to having backlight */
@@ -1721,13 +1720,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
dev_priv->vbt.lvds_ssc_freq = intel_bios_ssc_frequency(dev_priv,
!HAS_PCH_SPLIT(dev_priv));
DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
-
- for_each_port(port) {
- struct ddi_vbt_port_info *info =
- &dev_priv->vbt.ddi_port_info[port];
-
- info->hdmi_level_shift = HDMI_LEVEL_SHIFT_UNKNOWN;
- }
}
/* Defaults to initialize only if there is no VBT. */
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 398c6f054a6e..4018c2e2a6fc 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -888,11 +888,10 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port port)
{
+ struct ddi_vbt_port_info *port_info = &dev_priv->vbt.ddi_port_info[port];
int n_entries, level, default_entry;
enum phy phy = intel_port_to_phy(dev_priv, port);
- level = dev_priv->vbt.ddi_port_info[port].hdmi_level_shift;
-
if (INTEL_GEN(dev_priv) >= 12) {
if (intel_phy_is_combo(dev_priv, phy))
icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
@@ -927,12 +926,14 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
return 0;
}
- /* Choose a good default if VBT is badly populated */
- if (level == HDMI_LEVEL_SHIFT_UNKNOWN || level >= n_entries)
- level = default_entry;
-
if (WARN_ON_ONCE(n_entries == 0))
return 0;
+
+ if (port_info->hdmi_level_shift_set)
+ level = port_info->hdmi_level_shift;
+ else
+ level = default_entry;
+
if (WARN_ON_ONCE(level >= n_entries))
level = n_entries - 1;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 7e0f67babe20..67bdfe6de3fa 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -627,13 +627,9 @@ struct ddi_vbt_port_info {
int max_tmds_clock;
- /*
- * This is an index in the HDMI/DVI DDI buffer translation table.
- * The special value HDMI_LEVEL_SHIFT_UNKNOWN means the VBT didn't
- * populate this field.
- */
-#define HDMI_LEVEL_SHIFT_UNKNOWN 0xff
+ /* This is an index in the HDMI/DVI DDI buffer translation table. */
u8 hdmi_level_shift;
+ u8 hdmi_level_shift_set:1;
u8 supports_dvi:1;
u8 supports_hdmi:1;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence
@ 2019-11-07 10:32 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-11-07 10:32 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
The pre-initialized magic value is a bit silly, switch to a flag
instead.
v2: Reduce paranoia to a single sanity check (Ville)
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 10 +---------
drivers/gpu/drm/i915/display/intel_ddi.c | 13 +++++++------
drivers/gpu/drm/i915/i915_drv.h | 8 ++------
3 files changed, 10 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index a03f56b7b4ef..c19b234bebe6 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1509,6 +1509,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
port_name(port),
hdmi_level_shift);
info->hdmi_level_shift = hdmi_level_shift;
+ info->hdmi_level_shift_set = true;
}
if (bdb_version >= 204) {
@@ -1692,8 +1693,6 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
static void
init_vbt_defaults(struct drm_i915_private *dev_priv)
{
- enum port port;
-
dev_priv->vbt.crt_ddc_pin = GMBUS_PIN_VGADDC;
/* Default to having backlight */
@@ -1721,13 +1720,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
dev_priv->vbt.lvds_ssc_freq = intel_bios_ssc_frequency(dev_priv,
!HAS_PCH_SPLIT(dev_priv));
DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
-
- for_each_port(port) {
- struct ddi_vbt_port_info *info =
- &dev_priv->vbt.ddi_port_info[port];
-
- info->hdmi_level_shift = HDMI_LEVEL_SHIFT_UNKNOWN;
- }
}
/* Defaults to initialize only if there is no VBT. */
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 398c6f054a6e..4018c2e2a6fc 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -888,11 +888,10 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port port)
{
+ struct ddi_vbt_port_info *port_info = &dev_priv->vbt.ddi_port_info[port];
int n_entries, level, default_entry;
enum phy phy = intel_port_to_phy(dev_priv, port);
- level = dev_priv->vbt.ddi_port_info[port].hdmi_level_shift;
-
if (INTEL_GEN(dev_priv) >= 12) {
if (intel_phy_is_combo(dev_priv, phy))
icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
@@ -927,12 +926,14 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
return 0;
}
- /* Choose a good default if VBT is badly populated */
- if (level == HDMI_LEVEL_SHIFT_UNKNOWN || level >= n_entries)
- level = default_entry;
-
if (WARN_ON_ONCE(n_entries == 0))
return 0;
+
+ if (port_info->hdmi_level_shift_set)
+ level = port_info->hdmi_level_shift;
+ else
+ level = default_entry;
+
if (WARN_ON_ONCE(level >= n_entries))
level = n_entries - 1;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 7e0f67babe20..67bdfe6de3fa 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -627,13 +627,9 @@ struct ddi_vbt_port_info {
int max_tmds_clock;
- /*
- * This is an index in the HDMI/DVI DDI buffer translation table.
- * The special value HDMI_LEVEL_SHIFT_UNKNOWN means the VBT didn't
- * populate this field.
- */
-#define HDMI_LEVEL_SHIFT_UNKNOWN 0xff
+ /* This is an index in the HDMI/DVI DDI buffer translation table. */
u8 hdmi_level_shift;
+ u8 hdmi_level_shift_set:1;
u8 supports_dvi:1;
u8 supports_hdmi:1;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence
@ 2019-11-07 10:47 ` Ville Syrjälä
0 siblings, 0 replies; 17+ messages in thread
From: Ville Syrjälä @ 2019-11-07 10:47 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, Nov 07, 2019 at 12:32:30PM +0200, Jani Nikula wrote:
> The pre-initialized magic value is a bit silly, switch to a flag
> instead.
>
> v2: Reduce paranoia to a single sanity check (Ville)
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
stands
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 10 +---------
> drivers/gpu/drm/i915/display/intel_ddi.c | 13 +++++++------
> drivers/gpu/drm/i915/i915_drv.h | 8 ++------
> 3 files changed, 10 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index a03f56b7b4ef..c19b234bebe6 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1509,6 +1509,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
> port_name(port),
> hdmi_level_shift);
> info->hdmi_level_shift = hdmi_level_shift;
> + info->hdmi_level_shift_set = true;
> }
>
> if (bdb_version >= 204) {
> @@ -1692,8 +1693,6 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
> static void
> init_vbt_defaults(struct drm_i915_private *dev_priv)
> {
> - enum port port;
> -
> dev_priv->vbt.crt_ddc_pin = GMBUS_PIN_VGADDC;
>
> /* Default to having backlight */
> @@ -1721,13 +1720,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
> dev_priv->vbt.lvds_ssc_freq = intel_bios_ssc_frequency(dev_priv,
> !HAS_PCH_SPLIT(dev_priv));
> DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
> -
> - for_each_port(port) {
> - struct ddi_vbt_port_info *info =
> - &dev_priv->vbt.ddi_port_info[port];
> -
> - info->hdmi_level_shift = HDMI_LEVEL_SHIFT_UNKNOWN;
> - }
> }
>
> /* Defaults to initialize only if there is no VBT. */
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 398c6f054a6e..4018c2e2a6fc 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -888,11 +888,10 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
>
> static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port port)
> {
> + struct ddi_vbt_port_info *port_info = &dev_priv->vbt.ddi_port_info[port];
> int n_entries, level, default_entry;
> enum phy phy = intel_port_to_phy(dev_priv, port);
>
> - level = dev_priv->vbt.ddi_port_info[port].hdmi_level_shift;
> -
> if (INTEL_GEN(dev_priv) >= 12) {
> if (intel_phy_is_combo(dev_priv, phy))
> icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
> @@ -927,12 +926,14 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
> return 0;
> }
>
> - /* Choose a good default if VBT is badly populated */
> - if (level == HDMI_LEVEL_SHIFT_UNKNOWN || level >= n_entries)
> - level = default_entry;
> -
> if (WARN_ON_ONCE(n_entries == 0))
> return 0;
> +
> + if (port_info->hdmi_level_shift_set)
> + level = port_info->hdmi_level_shift;
> + else
> + level = default_entry;
> +
> if (WARN_ON_ONCE(level >= n_entries))
> level = n_entries - 1;
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 7e0f67babe20..67bdfe6de3fa 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -627,13 +627,9 @@ struct ddi_vbt_port_info {
>
> int max_tmds_clock;
>
> - /*
> - * This is an index in the HDMI/DVI DDI buffer translation table.
> - * The special value HDMI_LEVEL_SHIFT_UNKNOWN means the VBT didn't
> - * populate this field.
> - */
> -#define HDMI_LEVEL_SHIFT_UNKNOWN 0xff
> + /* This is an index in the HDMI/DVI DDI buffer translation table. */
> u8 hdmi_level_shift;
> + u8 hdmi_level_shift_set:1;
>
> u8 supports_dvi:1;
> u8 supports_hdmi:1;
> --
> 2.20.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence
@ 2019-11-07 10:47 ` Ville Syrjälä
0 siblings, 0 replies; 17+ messages in thread
From: Ville Syrjälä @ 2019-11-07 10:47 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, Nov 07, 2019 at 12:32:30PM +0200, Jani Nikula wrote:
> The pre-initialized magic value is a bit silly, switch to a flag
> instead.
>
> v2: Reduce paranoia to a single sanity check (Ville)
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
stands
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 10 +---------
> drivers/gpu/drm/i915/display/intel_ddi.c | 13 +++++++------
> drivers/gpu/drm/i915/i915_drv.h | 8 ++------
> 3 files changed, 10 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index a03f56b7b4ef..c19b234bebe6 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1509,6 +1509,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
> port_name(port),
> hdmi_level_shift);
> info->hdmi_level_shift = hdmi_level_shift;
> + info->hdmi_level_shift_set = true;
> }
>
> if (bdb_version >= 204) {
> @@ -1692,8 +1693,6 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
> static void
> init_vbt_defaults(struct drm_i915_private *dev_priv)
> {
> - enum port port;
> -
> dev_priv->vbt.crt_ddc_pin = GMBUS_PIN_VGADDC;
>
> /* Default to having backlight */
> @@ -1721,13 +1720,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
> dev_priv->vbt.lvds_ssc_freq = intel_bios_ssc_frequency(dev_priv,
> !HAS_PCH_SPLIT(dev_priv));
> DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
> -
> - for_each_port(port) {
> - struct ddi_vbt_port_info *info =
> - &dev_priv->vbt.ddi_port_info[port];
> -
> - info->hdmi_level_shift = HDMI_LEVEL_SHIFT_UNKNOWN;
> - }
> }
>
> /* Defaults to initialize only if there is no VBT. */
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 398c6f054a6e..4018c2e2a6fc 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -888,11 +888,10 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
>
> static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port port)
> {
> + struct ddi_vbt_port_info *port_info = &dev_priv->vbt.ddi_port_info[port];
> int n_entries, level, default_entry;
> enum phy phy = intel_port_to_phy(dev_priv, port);
>
> - level = dev_priv->vbt.ddi_port_info[port].hdmi_level_shift;
> -
> if (INTEL_GEN(dev_priv) >= 12) {
> if (intel_phy_is_combo(dev_priv, phy))
> icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
> @@ -927,12 +926,14 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
> return 0;
> }
>
> - /* Choose a good default if VBT is badly populated */
> - if (level == HDMI_LEVEL_SHIFT_UNKNOWN || level >= n_entries)
> - level = default_entry;
> -
> if (WARN_ON_ONCE(n_entries == 0))
> return 0;
> +
> + if (port_info->hdmi_level_shift_set)
> + level = port_info->hdmi_level_shift;
> + else
> + level = default_entry;
> +
> if (WARN_ON_ONCE(level >= n_entries))
> level = n_entries - 1;
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 7e0f67babe20..67bdfe6de3fa 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -627,13 +627,9 @@ struct ddi_vbt_port_info {
>
> int max_tmds_clock;
>
> - /*
> - * This is an index in the HDMI/DVI DDI buffer translation table.
> - * The special value HDMI_LEVEL_SHIFT_UNKNOWN means the VBT didn't
> - * populate this field.
> - */
> -#define HDMI_LEVEL_SHIFT_UNKNOWN 0xff
> + /* This is an index in the HDMI/DVI DDI buffer translation table. */
> u8 hdmi_level_shift;
> + u8 hdmi_level_shift_set:1;
>
> u8 supports_dvi:1;
> u8 supports_hdmi:1;
> --
> 2.20.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)
@ 2019-11-07 13:03 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-07 13:03 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)
URL : https://patchwork.freedesktop.org/series/68998/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7282 -> Patchwork_15171
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/index.html
Known issues
------------
Here are the changes found in Patchwork_15171 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2] ([fdo# 111542])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
* igt@i915_selftest@live_hangcheck:
- fi-icl-y: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#108569])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/fi-icl-y/igt@i915_selftest@live_hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/fi-icl-y/igt@i915_selftest@live_hangcheck.html
#### Possible fixes ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [INCOMPLETE][5] ([fdo# 111542]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
Participating hosts (49 -> 45)
------------------------------
Additional (2): fi-tgl-u fi-cfl-guc
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7282 -> Patchwork_15171
CI-20190529: 20190529
CI_DRM_7282: de0aae8761dadbe7b5fb02cafe92aa7be099d95e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5265: 99f04b14e224998abbb4ca60340fd97c9c5f33e8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15171: a25ec1245235f8cd7254dead9780e86a0fdd46e7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a25ec1245235 drm/i915/bios: use a flag for vbt hdmi level shift presence
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)
@ 2019-11-07 13:03 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-07 13:03 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)
URL : https://patchwork.freedesktop.org/series/68998/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7282 -> Patchwork_15171
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/index.html
Known issues
------------
Here are the changes found in Patchwork_15171 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2] ([fdo# 111542])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
* igt@i915_selftest@live_hangcheck:
- fi-icl-y: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#108569])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/fi-icl-y/igt@i915_selftest@live_hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/fi-icl-y/igt@i915_selftest@live_hangcheck.html
#### Possible fixes ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [INCOMPLETE][5] ([fdo# 111542]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
Participating hosts (49 -> 45)
------------------------------
Additional (2): fi-tgl-u fi-cfl-guc
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7282 -> Patchwork_15171
CI-20190529: 20190529
CI_DRM_7282: de0aae8761dadbe7b5fb02cafe92aa7be099d95e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5265: 99f04b14e224998abbb4ca60340fd97c9c5f33e8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15171: a25ec1245235f8cd7254dead9780e86a0fdd46e7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a25ec1245235 drm/i915/bios: use a flag for vbt hdmi level shift presence
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)
@ 2019-11-08 14:25 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-08 14:25 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)
URL : https://patchwork.freedesktop.org/series/68998/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7282_full -> Patchwork_15171_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15171_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15171_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15171_full:
### Piglit changes ###
#### Possible regressions ####
* spec@!opengl 1.1@max-texture-size:
- pig-snb-2600: NOTRUN -> [INCOMPLETE][1]
[1]: None
Known issues
------------
Here are the changes found in Patchwork_15171_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [PASS][2] -> [SKIP][3] ([fdo#109276] / [fdo#112080]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb2/igt@gem_ctx_persistence@vcs1-mixed.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb5/igt@gem_ctx_persistence@vcs1-mixed.html
* igt@gem_exec_reuse@single:
- shard-hsw: [PASS][4] -> [INCOMPLETE][5] ([fdo#103540])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw4/igt@gem_exec_reuse@single.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw5/igt@gem_exec_reuse@single.html
* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#109276]) +6 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd2.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb6/igt@gem_exec_schedule@preempt-contexts-bsd2.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#112146]) +4 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb7/igt@gem_exec_schedule@preemptive-hang-bsd.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_suspend@basic-s0:
- shard-tglb: [PASS][10] -> [INCOMPLETE][11] ([fdo#111832]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb7/igt@gem_exec_suspend@basic-s0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb3/igt@gem_exec_suspend@basic-s0.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [PASS][12] -> [INCOMPLETE][13] ([fdo#104108])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl9/igt@gem_softpin@noreloc-s3.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl4/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [PASS][14] -> [DMESG-WARN][15] ([fdo#111870]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@i915_pm_rpm@system-suspend:
- shard-tglb: [PASS][16] -> [INCOMPLETE][17] ([fdo#111747] / [fdo#111850])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb9/igt@i915_pm_rpm@system-suspend.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb5/igt@i915_pm_rpm@system-suspend.html
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [PASS][18] -> [DMESG-WARN][19] ([fdo#106107])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl4/igt@kms_color@pipe-b-ctm-0-75.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl2/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_color@pipe-b-legacy-gamma:
- shard-skl: [PASS][20] -> [FAIL][21] ([fdo#104782])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl3/igt@kms_color@pipe-b-legacy-gamma.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl5/igt@kms_color@pipe-b-legacy-gamma.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][22] -> [DMESG-WARN][23] ([fdo#108566]) +7 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][24] -> [FAIL][25] ([fdo#105363])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl1/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][26] -> [DMESG-WARN][27] ([fdo#108566]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][28] -> [FAIL][29] ([fdo#103167]) +8 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff:
- shard-tglb: [PASS][30] -> [FAIL][31] ([fdo#103167]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][32] -> [SKIP][33] ([fdo#109642] / [fdo#111068])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb5/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][34] -> [SKIP][35] ([fdo#109441])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb1/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_psr@suspend:
- shard-tglb: [PASS][36] -> [INCOMPLETE][37] ([fdo#111832] / [fdo#111850])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb1/igt@kms_psr@suspend.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb2/igt@kms_psr@suspend.html
* igt@kms_setmode@basic:
- shard-hsw: [PASS][38] -> [FAIL][39] ([fdo#99912])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw1/igt@kms_setmode@basic.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw1/igt@kms_setmode@basic.html
* igt@perf_pmu@busy-start-vcs1:
- shard-iclb: [PASS][40] -> [SKIP][41] ([fdo#112080]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@perf_pmu@busy-start-vcs1.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb3/igt@perf_pmu@busy-start-vcs1.html
#### Possible fixes ####
* igt@gem_busy@extended-parallel-vcs1:
- shard-iclb: [SKIP][42] ([fdo#112080]) -> [PASS][43] +7 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@gem_busy@extended-parallel-vcs1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@gem_busy@extended-parallel-vcs1.html
* igt@gem_ctx_isolation@vcs1-s3:
- shard-tglb: [INCOMPLETE][44] ([fdo#111832]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb7/igt@gem_ctx_isolation@vcs1-s3.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb7/igt@gem_ctx_isolation@vcs1-s3.html
* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [SKIP][46] ([fdo#109276] / [fdo#112080]) -> [PASS][47] +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb7/igt@gem_ctx_persistence@vcs1-mixed-process.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][48] ([fdo#110841]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb6/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_create@basic:
- shard-tglb: [INCOMPLETE][50] ([fdo#111736]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb6/igt@gem_exec_create@basic.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb4/igt@gem_exec_create@basic.html
* igt@gem_exec_schedule@preempt-queue-contexts-bsd2:
- shard-iclb: [SKIP][52] ([fdo#109276]) -> [PASS][53] +7 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb6/igt@gem_exec_schedule@preempt-queue-contexts-bsd2.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@gem_exec_schedule@preempt-queue-contexts-bsd2.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][54] ([fdo#112146]) -> [PASS][55] +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@gem_exec_schedule@reorder-wide-bsd.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_mmap_gtt@cpuset-medium-copy-odd:
- shard-kbl: [FAIL][56] -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl6/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl6/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [TIMEOUT][58] ([fdo#112068 ]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb8/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-tglb: [FAIL][60] ([fdo#112037]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
- shard-kbl: [FAIL][62] ([fdo#112037]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_sync@basic-all:
- shard-tglb: [INCOMPLETE][64] ([fdo#111647]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb6/igt@gem_sync@basic-all.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb7/igt@gem_sync@basic-all.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][66] ([fdo#111870]) -> [PASS][67] +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-hsw: [DMESG-WARN][68] ([fdo#110789] / [fdo#111870]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@gem_wait@busy-vcs0:
- shard-skl: [DMESG-WARN][70] -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl10/igt@gem_wait@busy-vcs0.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl2/igt@gem_wait@busy-vcs0.html
* igt@gem_workarounds@suspend-resume:
- shard-tglb: [INCOMPLETE][72] ([fdo#111832] / [fdo#111850]) -> [PASS][73] +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb1/igt@gem_workarounds@suspend-resume.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb6/igt@gem_workarounds@suspend-resume.html
* igt@kms_color@pipe-a-ctm-green-to-red:
- shard-skl: [DMESG-WARN][74] ([fdo#106107]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl3/igt@kms_color@pipe-a-ctm-green-to-red.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl6/igt@kms_color@pipe-a-ctm-green-to-red.html
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-hsw: [FAIL][76] ([fdo#103355]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][78] ([fdo#103167]) -> [PASS][79] +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-tglb: [INCOMPLETE][80] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][82] ([fdo#109642] / [fdo#111068]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@kms_psr2_su@page_flip.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][84] ([fdo#109441]) -> [PASS][85] +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@kms_psr@psr2_cursor_render.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][86] ([fdo#99912]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl6/igt@kms_setmode@basic.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl2/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][88] ([fdo#108566]) -> [PASS][89] +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][90] ([fdo#111850]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb8/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb6/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs2-s3:
- shard-tglb: [SKIP][92] ([fdo#111912] / [fdo#112080]) -> [SKIP][93] ([fdo#112080])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb4/igt@gem_ctx_isolation@vcs2-s3.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb9/igt@gem_ctx_isolation@vcs2-s3.html
* igt@kms_atomic_transition@6x-modeset-transitions:
- shard-tglb: [SKIP][94] ([fdo#112016 ] / [fdo#112021 ]) -> [SKIP][95] ([fdo#112021 ])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb8/igt@kms_atomic_transition@6x-modeset-transitions.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-tglb: [INCOMPLETE][96] ([fdo#111832] / [fdo#111850]) -> [FAIL][97] ([fdo#111703]) +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-tglb: [FAIL][98] ([fdo#111703]) -> [INCOMPLETE][99] ([fdo#111832] / [fdo#111850])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb9/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111647]: https://bugs.freedesktop.org/show_bug.cgi?id=111647
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111736]: https://bugs.f
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)
@ 2019-11-08 14:25 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-08 14:25 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2)
URL : https://patchwork.freedesktop.org/series/68998/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7282_full -> Patchwork_15171_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15171_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15171_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15171_full:
### Piglit changes ###
#### Possible regressions ####
* spec@!opengl 1.1@max-texture-size:
- pig-snb-2600: NOTRUN -> [INCOMPLETE][1]
[1]: None
Known issues
------------
Here are the changes found in Patchwork_15171_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-mixed:
- shard-iclb: [PASS][2] -> [SKIP][3] ([fdo#109276] / [fdo#112080]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb2/igt@gem_ctx_persistence@vcs1-mixed.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb5/igt@gem_ctx_persistence@vcs1-mixed.html
* igt@gem_exec_reuse@single:
- shard-hsw: [PASS][4] -> [INCOMPLETE][5] ([fdo#103540])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw4/igt@gem_exec_reuse@single.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw5/igt@gem_exec_reuse@single.html
* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#109276]) +6 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@gem_exec_schedule@preempt-contexts-bsd2.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb6/igt@gem_exec_schedule@preempt-contexts-bsd2.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#112146]) +4 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb7/igt@gem_exec_schedule@preemptive-hang-bsd.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_suspend@basic-s0:
- shard-tglb: [PASS][10] -> [INCOMPLETE][11] ([fdo#111832]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb7/igt@gem_exec_suspend@basic-s0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb3/igt@gem_exec_suspend@basic-s0.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [PASS][12] -> [INCOMPLETE][13] ([fdo#104108])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl9/igt@gem_softpin@noreloc-s3.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl4/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [PASS][14] -> [DMESG-WARN][15] ([fdo#111870]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@i915_pm_rpm@system-suspend:
- shard-tglb: [PASS][16] -> [INCOMPLETE][17] ([fdo#111747] / [fdo#111850])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb9/igt@i915_pm_rpm@system-suspend.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb5/igt@i915_pm_rpm@system-suspend.html
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [PASS][18] -> [DMESG-WARN][19] ([fdo#106107])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl4/igt@kms_color@pipe-b-ctm-0-75.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl2/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_color@pipe-b-legacy-gamma:
- shard-skl: [PASS][20] -> [FAIL][21] ([fdo#104782])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl3/igt@kms_color@pipe-b-legacy-gamma.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl5/igt@kms_color@pipe-b-legacy-gamma.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][22] -> [DMESG-WARN][23] ([fdo#108566]) +7 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][24] -> [FAIL][25] ([fdo#105363])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl1/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][26] -> [DMESG-WARN][27] ([fdo#108566]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][28] -> [FAIL][29] ([fdo#103167]) +8 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff:
- shard-tglb: [PASS][30] -> [FAIL][31] ([fdo#103167]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][32] -> [SKIP][33] ([fdo#109642] / [fdo#111068])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb5/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][34] -> [SKIP][35] ([fdo#109441])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb1/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_psr@suspend:
- shard-tglb: [PASS][36] -> [INCOMPLETE][37] ([fdo#111832] / [fdo#111850])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb1/igt@kms_psr@suspend.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb2/igt@kms_psr@suspend.html
* igt@kms_setmode@basic:
- shard-hsw: [PASS][38] -> [FAIL][39] ([fdo#99912])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw1/igt@kms_setmode@basic.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw1/igt@kms_setmode@basic.html
* igt@perf_pmu@busy-start-vcs1:
- shard-iclb: [PASS][40] -> [SKIP][41] ([fdo#112080]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@perf_pmu@busy-start-vcs1.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb3/igt@perf_pmu@busy-start-vcs1.html
#### Possible fixes ####
* igt@gem_busy@extended-parallel-vcs1:
- shard-iclb: [SKIP][42] ([fdo#112080]) -> [PASS][43] +7 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@gem_busy@extended-parallel-vcs1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@gem_busy@extended-parallel-vcs1.html
* igt@gem_ctx_isolation@vcs1-s3:
- shard-tglb: [INCOMPLETE][44] ([fdo#111832]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb7/igt@gem_ctx_isolation@vcs1-s3.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb7/igt@gem_ctx_isolation@vcs1-s3.html
* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [SKIP][46] ([fdo#109276] / [fdo#112080]) -> [PASS][47] +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb7/igt@gem_ctx_persistence@vcs1-mixed-process.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][48] ([fdo#110841]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb6/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_create@basic:
- shard-tglb: [INCOMPLETE][50] ([fdo#111736]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb6/igt@gem_exec_create@basic.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb4/igt@gem_exec_create@basic.html
* igt@gem_exec_schedule@preempt-queue-contexts-bsd2:
- shard-iclb: [SKIP][52] ([fdo#109276]) -> [PASS][53] +7 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb6/igt@gem_exec_schedule@preempt-queue-contexts-bsd2.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@gem_exec_schedule@preempt-queue-contexts-bsd2.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][54] ([fdo#112146]) -> [PASS][55] +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@gem_exec_schedule@reorder-wide-bsd.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_mmap_gtt@cpuset-medium-copy-odd:
- shard-kbl: [FAIL][56] -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl6/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl6/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [TIMEOUT][58] ([fdo#112068 ]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb8/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-tglb: [FAIL][60] ([fdo#112037]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
- shard-kbl: [FAIL][62] ([fdo#112037]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_sync@basic-all:
- shard-tglb: [INCOMPLETE][64] ([fdo#111647]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb6/igt@gem_sync@basic-all.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb7/igt@gem_sync@basic-all.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][66] ([fdo#111870]) -> [PASS][67] +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-hsw: [DMESG-WARN][68] ([fdo#110789] / [fdo#111870]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@gem_wait@busy-vcs0:
- shard-skl: [DMESG-WARN][70] -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl10/igt@gem_wait@busy-vcs0.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl2/igt@gem_wait@busy-vcs0.html
* igt@gem_workarounds@suspend-resume:
- shard-tglb: [INCOMPLETE][72] ([fdo#111832] / [fdo#111850]) -> [PASS][73] +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb1/igt@gem_workarounds@suspend-resume.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb6/igt@gem_workarounds@suspend-resume.html
* igt@kms_color@pipe-a-ctm-green-to-red:
- shard-skl: [DMESG-WARN][74] ([fdo#106107]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-skl3/igt@kms_color@pipe-a-ctm-green-to-red.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-skl6/igt@kms_color@pipe-a-ctm-green-to-red.html
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-hsw: [FAIL][76] ([fdo#103355]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][78] ([fdo#103167]) -> [PASS][79] +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-tglb: [INCOMPLETE][80] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][82] ([fdo#109642] / [fdo#111068]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb1/igt@kms_psr2_su@page_flip.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][84] ([fdo#109441]) -> [PASS][85] +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-iclb5/igt@kms_psr@psr2_cursor_render.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][86] ([fdo#99912]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl6/igt@kms_setmode@basic.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl2/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][88] ([fdo#108566]) -> [PASS][89] +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][90] ([fdo#111850]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb8/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb6/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs2-s3:
- shard-tglb: [SKIP][92] ([fdo#111912] / [fdo#112080]) -> [SKIP][93] ([fdo#112080])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb4/igt@gem_ctx_isolation@vcs2-s3.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb9/igt@gem_ctx_isolation@vcs2-s3.html
* igt@kms_atomic_transition@6x-modeset-transitions:
- shard-tglb: [SKIP][94] ([fdo#112016 ] / [fdo#112021 ]) -> [SKIP][95] ([fdo#112021 ])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb8/igt@kms_atomic_transition@6x-modeset-transitions.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-tglb: [INCOMPLETE][96] ([fdo#111832] / [fdo#111850]) -> [FAIL][97] ([fdo#111703]) +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-tglb: [FAIL][98] ([fdo#111703]) -> [INCOMPLETE][99] ([fdo#111832] / [fdo#111850])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7282/shard-tglb9/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/shard-tglb3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111647]: https://bugs.freedesktop.org/show_bug.cgi?id=111647
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111736]: https://bugs.f
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15171/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev3)
@ 2019-11-12 14:09 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-12 14:09 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev3)
URL : https://patchwork.freedesktop.org/series/68998/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7314 -> Patchwork_15232
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15232 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15232, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15232:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
Known issues
------------
Here are the changes found in Patchwork_15232 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-nick: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [PASS][5] -> [DMESG-WARN][6] ([fdo#105541])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][7] -> [FAIL][8] ([fdo#111407])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [INCOMPLETE][9] ([fdo# 111542]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-bsw-n3050: [FAIL][11] ([fdo#100368]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][13] ([fdo#102614]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
Participating hosts (49 -> 45)
------------------------------
Missing (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7314 -> Patchwork_15232
CI-20190529: 20190529
CI_DRM_7314: 443bcbddaac9f2667bc1cecd29086d739a42c6f9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5272: 5997df31db10f190fe8b70d920b6a6b8d3b24126 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15232: 460c9296c42da16ed7ef3a51d826214a0f75eb7f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
460c9296c42d drm/i915/bios: use a flag for vbt hdmi level shift presence
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev3)
@ 2019-11-12 14:09 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-12 14:09 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev3)
URL : https://patchwork.freedesktop.org/series/68998/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7314 -> Patchwork_15232
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15232 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15232, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15232:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
Known issues
------------
Here are the changes found in Patchwork_15232 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-nick: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [PASS][5] -> [DMESG-WARN][6] ([fdo#105541])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][7] -> [FAIL][8] ([fdo#111407])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [INCOMPLETE][9] ([fdo# 111542]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-bsw-n3050: [FAIL][11] ([fdo#100368]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][13] ([fdo#102614]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7314/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
Participating hosts (49 -> 45)
------------------------------
Missing (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7314 -> Patchwork_15232
CI-20190529: 20190529
CI_DRM_7314: 443bcbddaac9f2667bc1cecd29086d739a42c6f9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5272: 5997df31db10f190fe8b70d920b6a6b8d3b24126 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15232: 460c9296c42da16ed7ef3a51d826214a0f75eb7f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
460c9296c42d drm/i915/bios: use a flag for vbt hdmi level shift presence
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15232/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev4)
@ 2019-11-12 20:02 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-12 20:02 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev4)
URL : https://patchwork.freedesktop.org/series/68998/
State : failure
== Summary ==
Applying: drm/i915/bios: use a flag for vbt hdmi level shift presence
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/display/intel_bios.c
M drivers/gpu/drm/i915/display/intel_ddi.c
M drivers/gpu/drm/i915/i915_drv.h
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/i915_drv.h
Auto-merging drivers/gpu/drm/i915/display/intel_ddi.c
Auto-merging drivers/gpu/drm/i915/display/intel_bios.c
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev4)
@ 2019-11-12 20:02 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-12 20:02 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bios: use a flag for vbt hdmi level shift presence (rev4)
URL : https://patchwork.freedesktop.org/series/68998/
State : failure
== Summary ==
Applying: drm/i915/bios: use a flag for vbt hdmi level shift presence
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/display/intel_bios.c
M drivers/gpu/drm/i915/display/intel_ddi.c
M drivers/gpu/drm/i915/i915_drv.h
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/i915_drv.h
Auto-merging drivers/gpu/drm/i915/display/intel_ddi.c
Auto-merging drivers/gpu/drm/i915/display/intel_bios.c
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence
2019-11-05 15:21 ` Ville Syrjälä
@ 2019-11-05 15:37 ` Ville Syrjälä
0 siblings, 0 replies; 17+ messages in thread
From: Ville Syrjälä @ 2019-11-05 15:37 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Tue, Nov 05, 2019 at 05:21:06PM +0200, Ville Syrjälä wrote:
> On Tue, Nov 05, 2019 at 03:59:57PM +0200, Jani Nikula wrote:
> > On Tue, 05 Nov 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > > On Tue, Nov 05, 2019 at 03:39:00PM +0200, Jani Nikula wrote:
> > >> The pre-initialized magic value is a bit silly, switch to a flag
> > >> instead. While at it, clean up the validity checks. No functional
> > >> changes apart from the added checks.
> > >>
> > >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > >> ---
> > >> drivers/gpu/drm/i915/display/intel_bios.c | 10 +---------
> > >> drivers/gpu/drm/i915/display/intel_ddi.c | 19 +++++++++++--------
> > >> drivers/gpu/drm/i915/i915_drv.h | 8 ++------
> > >> 3 files changed, 14 insertions(+), 23 deletions(-)
> > >>
> > >> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> > >> index a03f56b7b4ef..c19b234bebe6 100644
> > >> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> > >> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> > >> @@ -1509,6 +1509,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
> > >> port_name(port),
> > >> hdmi_level_shift);
> > >> info->hdmi_level_shift = hdmi_level_shift;
> > >> + info->hdmi_level_shift_set = true;
> > >> }
> > >>
> > >> if (bdb_version >= 204) {
> > >> @@ -1692,8 +1693,6 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
> > >> static void
> > >> init_vbt_defaults(struct drm_i915_private *dev_priv)
> > >> {
> > >> - enum port port;
> > >> -
> > >> dev_priv->vbt.crt_ddc_pin = GMBUS_PIN_VGADDC;
> > >>
> > >> /* Default to having backlight */
> > >> @@ -1721,13 +1720,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
> > >> dev_priv->vbt.lvds_ssc_freq = intel_bios_ssc_frequency(dev_priv,
> > >> !HAS_PCH_SPLIT(dev_priv));
> > >> DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
> > >> -
> > >> - for_each_port(port) {
> > >> - struct ddi_vbt_port_info *info =
> > >> - &dev_priv->vbt.ddi_port_info[port];
> > >> -
> > >> - info->hdmi_level_shift = HDMI_LEVEL_SHIFT_UNKNOWN;
> > >> - }
> > >> }
> > >>
> > >> /* Defaults to initialize only if there is no VBT. */
> > >> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> > >> index c91521bcf06a..ec51f6971b16 100644
> > >> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > >> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > >> @@ -888,11 +888,10 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
> > >>
> > >> static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port port)
> > >> {
> > >> + struct ddi_vbt_port_info *port_info = &dev_priv->vbt.ddi_port_info[port];
> > >> int n_entries, level, default_entry;
> > >> enum phy phy = intel_port_to_phy(dev_priv, port);
> > >>
> > >> - level = dev_priv->vbt.ddi_port_info[port].hdmi_level_shift;
> > >> -
> > >> if (INTEL_GEN(dev_priv) >= 12) {
> > >> if (intel_phy_is_combo(dev_priv, phy))
> > >> icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
> > >> @@ -927,14 +926,18 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
> > >> return 0;
> > >> }
> > >>
> > >> - /* Choose a good default if VBT is badly populated */
> > >> - if (level == HDMI_LEVEL_SHIFT_UNKNOWN || level >= n_entries)
> > >> - level = default_entry;
> > >> -
> > >> if (WARN_ON_ONCE(n_entries == 0))
> > >> return 0;
> > >> - if (WARN_ON_ONCE(level >= n_entries))
> > >> - level = n_entries - 1;
> > >> +
> > >> + if (WARN_ON_ONCE(default_entry >= n_entries))
> > >> + default_entry = n_entries - 1;
> > >> +
> > >> + if (port_info->hdmi_level_shift_set &&
> > >> + !WARN_ON_ONCE(port_info->hdmi_level_shift >= n_entries)) {
> > >> + level = port_info->hdmi_level_shift;
> > >> + } else {
> > >> + level = default_entry;
> > >> + }
> > >
> > > I'd probably simplify that to something like:
> > >
> > > if (level_shift_set)
> > > level = level_shift;
> > > else
> > > level = default;
> > > if (WARN_ON_ONCE(level >= n_entries))
> > > level = n_entries - 1;
> >
> > I wanted to add the distinction between the default_entry being bogus
> > and the VBT being bogus.
>
> Any 'default>=n_entries' check is dead code anyway so we'd not
> lose anything with the simpler code.
Hmm. I guess we would lose the bad_vbt->default fallback.
But that really should be dead code as well, so not entirely
convinced such a belt+suspenders approach is warranted.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence
2019-11-05 13:59 ` Jani Nikula
@ 2019-11-05 15:21 ` Ville Syrjälä
2019-11-05 15:37 ` Ville Syrjälä
0 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjälä @ 2019-11-05 15:21 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Tue, Nov 05, 2019 at 03:59:57PM +0200, Jani Nikula wrote:
> On Tue, 05 Nov 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Tue, Nov 05, 2019 at 03:39:00PM +0200, Jani Nikula wrote:
> >> The pre-initialized magic value is a bit silly, switch to a flag
> >> instead. While at it, clean up the validity checks. No functional
> >> changes apart from the added checks.
> >>
> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_bios.c | 10 +---------
> >> drivers/gpu/drm/i915/display/intel_ddi.c | 19 +++++++++++--------
> >> drivers/gpu/drm/i915/i915_drv.h | 8 ++------
> >> 3 files changed, 14 insertions(+), 23 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> >> index a03f56b7b4ef..c19b234bebe6 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> >> @@ -1509,6 +1509,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
> >> port_name(port),
> >> hdmi_level_shift);
> >> info->hdmi_level_shift = hdmi_level_shift;
> >> + info->hdmi_level_shift_set = true;
> >> }
> >>
> >> if (bdb_version >= 204) {
> >> @@ -1692,8 +1693,6 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
> >> static void
> >> init_vbt_defaults(struct drm_i915_private *dev_priv)
> >> {
> >> - enum port port;
> >> -
> >> dev_priv->vbt.crt_ddc_pin = GMBUS_PIN_VGADDC;
> >>
> >> /* Default to having backlight */
> >> @@ -1721,13 +1720,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
> >> dev_priv->vbt.lvds_ssc_freq = intel_bios_ssc_frequency(dev_priv,
> >> !HAS_PCH_SPLIT(dev_priv));
> >> DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
> >> -
> >> - for_each_port(port) {
> >> - struct ddi_vbt_port_info *info =
> >> - &dev_priv->vbt.ddi_port_info[port];
> >> -
> >> - info->hdmi_level_shift = HDMI_LEVEL_SHIFT_UNKNOWN;
> >> - }
> >> }
> >>
> >> /* Defaults to initialize only if there is no VBT. */
> >> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> >> index c91521bcf06a..ec51f6971b16 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> >> @@ -888,11 +888,10 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
> >>
> >> static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port port)
> >> {
> >> + struct ddi_vbt_port_info *port_info = &dev_priv->vbt.ddi_port_info[port];
> >> int n_entries, level, default_entry;
> >> enum phy phy = intel_port_to_phy(dev_priv, port);
> >>
> >> - level = dev_priv->vbt.ddi_port_info[port].hdmi_level_shift;
> >> -
> >> if (INTEL_GEN(dev_priv) >= 12) {
> >> if (intel_phy_is_combo(dev_priv, phy))
> >> icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
> >> @@ -927,14 +926,18 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
> >> return 0;
> >> }
> >>
> >> - /* Choose a good default if VBT is badly populated */
> >> - if (level == HDMI_LEVEL_SHIFT_UNKNOWN || level >= n_entries)
> >> - level = default_entry;
> >> -
> >> if (WARN_ON_ONCE(n_entries == 0))
> >> return 0;
> >> - if (WARN_ON_ONCE(level >= n_entries))
> >> - level = n_entries - 1;
> >> +
> >> + if (WARN_ON_ONCE(default_entry >= n_entries))
> >> + default_entry = n_entries - 1;
> >> +
> >> + if (port_info->hdmi_level_shift_set &&
> >> + !WARN_ON_ONCE(port_info->hdmi_level_shift >= n_entries)) {
> >> + level = port_info->hdmi_level_shift;
> >> + } else {
> >> + level = default_entry;
> >> + }
> >
> > I'd probably simplify that to something like:
> >
> > if (level_shift_set)
> > level = level_shift;
> > else
> > level = default;
> > if (WARN_ON_ONCE(level >= n_entries))
> > level = n_entries - 1;
>
> I wanted to add the distinction between the default_entry being bogus
> and the VBT being bogus.
Any 'default>=n_entries' check is dead code anyway so we'd not
lose anything with the simpler code.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence
2019-11-05 13:50 ` Ville Syrjälä
@ 2019-11-05 13:59 ` Jani Nikula
2019-11-05 15:21 ` Ville Syrjälä
0 siblings, 1 reply; 17+ messages in thread
From: Jani Nikula @ 2019-11-05 13:59 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Tue, 05 Nov 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Nov 05, 2019 at 03:39:00PM +0200, Jani Nikula wrote:
>> The pre-initialized magic value is a bit silly, switch to a flag
>> instead. While at it, clean up the validity checks. No functional
>> changes apart from the added checks.
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.c | 10 +---------
>> drivers/gpu/drm/i915/display/intel_ddi.c | 19 +++++++++++--------
>> drivers/gpu/drm/i915/i915_drv.h | 8 ++------
>> 3 files changed, 14 insertions(+), 23 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>> index a03f56b7b4ef..c19b234bebe6 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -1509,6 +1509,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
>> port_name(port),
>> hdmi_level_shift);
>> info->hdmi_level_shift = hdmi_level_shift;
>> + info->hdmi_level_shift_set = true;
>> }
>>
>> if (bdb_version >= 204) {
>> @@ -1692,8 +1693,6 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
>> static void
>> init_vbt_defaults(struct drm_i915_private *dev_priv)
>> {
>> - enum port port;
>> -
>> dev_priv->vbt.crt_ddc_pin = GMBUS_PIN_VGADDC;
>>
>> /* Default to having backlight */
>> @@ -1721,13 +1720,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
>> dev_priv->vbt.lvds_ssc_freq = intel_bios_ssc_frequency(dev_priv,
>> !HAS_PCH_SPLIT(dev_priv));
>> DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
>> -
>> - for_each_port(port) {
>> - struct ddi_vbt_port_info *info =
>> - &dev_priv->vbt.ddi_port_info[port];
>> -
>> - info->hdmi_level_shift = HDMI_LEVEL_SHIFT_UNKNOWN;
>> - }
>> }
>>
>> /* Defaults to initialize only if there is no VBT. */
>> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
>> index c91521bcf06a..ec51f6971b16 100644
>> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
>> @@ -888,11 +888,10 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
>>
>> static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port port)
>> {
>> + struct ddi_vbt_port_info *port_info = &dev_priv->vbt.ddi_port_info[port];
>> int n_entries, level, default_entry;
>> enum phy phy = intel_port_to_phy(dev_priv, port);
>>
>> - level = dev_priv->vbt.ddi_port_info[port].hdmi_level_shift;
>> -
>> if (INTEL_GEN(dev_priv) >= 12) {
>> if (intel_phy_is_combo(dev_priv, phy))
>> icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
>> @@ -927,14 +926,18 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
>> return 0;
>> }
>>
>> - /* Choose a good default if VBT is badly populated */
>> - if (level == HDMI_LEVEL_SHIFT_UNKNOWN || level >= n_entries)
>> - level = default_entry;
>> -
>> if (WARN_ON_ONCE(n_entries == 0))
>> return 0;
>> - if (WARN_ON_ONCE(level >= n_entries))
>> - level = n_entries - 1;
>> +
>> + if (WARN_ON_ONCE(default_entry >= n_entries))
>> + default_entry = n_entries - 1;
>> +
>> + if (port_info->hdmi_level_shift_set &&
>> + !WARN_ON_ONCE(port_info->hdmi_level_shift >= n_entries)) {
>> + level = port_info->hdmi_level_shift;
>> + } else {
>> + level = default_entry;
>> + }
>
> I'd probably simplify that to something like:
>
> if (level_shift_set)
> level = level_shift;
> else
> level = default;
> if (WARN_ON_ONCE(level >= n_entries))
> level = n_entries - 1;
I wanted to add the distinction between the default_entry being bogus
and the VBT being bogus.
BR,
Jani.
>
> Either way:
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>>
>> return level;
>> }
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index 7e0f67babe20..67bdfe6de3fa 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -627,13 +627,9 @@ struct ddi_vbt_port_info {
>>
>> int max_tmds_clock;
>>
>> - /*
>> - * This is an index in the HDMI/DVI DDI buffer translation table.
>> - * The special value HDMI_LEVEL_SHIFT_UNKNOWN means the VBT didn't
>> - * populate this field.
>> - */
>> -#define HDMI_LEVEL_SHIFT_UNKNOWN 0xff
>> + /* This is an index in the HDMI/DVI DDI buffer translation table. */
>> u8 hdmi_level_shift;
>> + u8 hdmi_level_shift_set:1;
>>
>> u8 supports_dvi:1;
>> u8 supports_hdmi:1;
>> --
>> 2.20.1
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence
2019-11-05 13:39 [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence Jani Nikula
@ 2019-11-05 13:50 ` Ville Syrjälä
2019-11-05 13:59 ` Jani Nikula
0 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjälä @ 2019-11-05 13:50 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Tue, Nov 05, 2019 at 03:39:00PM +0200, Jani Nikula wrote:
> The pre-initialized magic value is a bit silly, switch to a flag
> instead. While at it, clean up the validity checks. No functional
> changes apart from the added checks.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 10 +---------
> drivers/gpu/drm/i915/display/intel_ddi.c | 19 +++++++++++--------
> drivers/gpu/drm/i915/i915_drv.h | 8 ++------
> 3 files changed, 14 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index a03f56b7b4ef..c19b234bebe6 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1509,6 +1509,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
> port_name(port),
> hdmi_level_shift);
> info->hdmi_level_shift = hdmi_level_shift;
> + info->hdmi_level_shift_set = true;
> }
>
> if (bdb_version >= 204) {
> @@ -1692,8 +1693,6 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
> static void
> init_vbt_defaults(struct drm_i915_private *dev_priv)
> {
> - enum port port;
> -
> dev_priv->vbt.crt_ddc_pin = GMBUS_PIN_VGADDC;
>
> /* Default to having backlight */
> @@ -1721,13 +1720,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
> dev_priv->vbt.lvds_ssc_freq = intel_bios_ssc_frequency(dev_priv,
> !HAS_PCH_SPLIT(dev_priv));
> DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
> -
> - for_each_port(port) {
> - struct ddi_vbt_port_info *info =
> - &dev_priv->vbt.ddi_port_info[port];
> -
> - info->hdmi_level_shift = HDMI_LEVEL_SHIFT_UNKNOWN;
> - }
> }
>
> /* Defaults to initialize only if there is no VBT. */
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index c91521bcf06a..ec51f6971b16 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -888,11 +888,10 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
>
> static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port port)
> {
> + struct ddi_vbt_port_info *port_info = &dev_priv->vbt.ddi_port_info[port];
> int n_entries, level, default_entry;
> enum phy phy = intel_port_to_phy(dev_priv, port);
>
> - level = dev_priv->vbt.ddi_port_info[port].hdmi_level_shift;
> -
> if (INTEL_GEN(dev_priv) >= 12) {
> if (intel_phy_is_combo(dev_priv, phy))
> icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
> @@ -927,14 +926,18 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
> return 0;
> }
>
> - /* Choose a good default if VBT is badly populated */
> - if (level == HDMI_LEVEL_SHIFT_UNKNOWN || level >= n_entries)
> - level = default_entry;
> -
> if (WARN_ON_ONCE(n_entries == 0))
> return 0;
> - if (WARN_ON_ONCE(level >= n_entries))
> - level = n_entries - 1;
> +
> + if (WARN_ON_ONCE(default_entry >= n_entries))
> + default_entry = n_entries - 1;
> +
> + if (port_info->hdmi_level_shift_set &&
> + !WARN_ON_ONCE(port_info->hdmi_level_shift >= n_entries)) {
> + level = port_info->hdmi_level_shift;
> + } else {
> + level = default_entry;
> + }
I'd probably simplify that to something like:
if (level_shift_set)
level = level_shift;
else
level = default;
if (WARN_ON_ONCE(level >= n_entries))
level = n_entries - 1;
Either way:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> return level;
> }
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 7e0f67babe20..67bdfe6de3fa 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -627,13 +627,9 @@ struct ddi_vbt_port_info {
>
> int max_tmds_clock;
>
> - /*
> - * This is an index in the HDMI/DVI DDI buffer translation table.
> - * The special value HDMI_LEVEL_SHIFT_UNKNOWN means the VBT didn't
> - * populate this field.
> - */
> -#define HDMI_LEVEL_SHIFT_UNKNOWN 0xff
> + /* This is an index in the HDMI/DVI DDI buffer translation table. */
> u8 hdmi_level_shift;
> + u8 hdmi_level_shift_set:1;
>
> u8 supports_dvi:1;
> u8 supports_hdmi:1;
> --
> 2.20.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence
@ 2019-11-05 13:39 Jani Nikula
2019-11-05 13:50 ` Ville Syrjälä
0 siblings, 1 reply; 17+ messages in thread
From: Jani Nikula @ 2019-11-05 13:39 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
The pre-initialized magic value is a bit silly, switch to a flag
instead. While at it, clean up the validity checks. No functional
changes apart from the added checks.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 10 +---------
drivers/gpu/drm/i915/display/intel_ddi.c | 19 +++++++++++--------
drivers/gpu/drm/i915/i915_drv.h | 8 ++------
3 files changed, 14 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index a03f56b7b4ef..c19b234bebe6 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1509,6 +1509,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
port_name(port),
hdmi_level_shift);
info->hdmi_level_shift = hdmi_level_shift;
+ info->hdmi_level_shift_set = true;
}
if (bdb_version >= 204) {
@@ -1692,8 +1693,6 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
static void
init_vbt_defaults(struct drm_i915_private *dev_priv)
{
- enum port port;
-
dev_priv->vbt.crt_ddc_pin = GMBUS_PIN_VGADDC;
/* Default to having backlight */
@@ -1721,13 +1720,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
dev_priv->vbt.lvds_ssc_freq = intel_bios_ssc_frequency(dev_priv,
!HAS_PCH_SPLIT(dev_priv));
DRM_DEBUG_KMS("Set default to SSC at %d kHz\n", dev_priv->vbt.lvds_ssc_freq);
-
- for_each_port(port) {
- struct ddi_vbt_port_info *info =
- &dev_priv->vbt.ddi_port_info[port];
-
- info->hdmi_level_shift = HDMI_LEVEL_SHIFT_UNKNOWN;
- }
}
/* Defaults to initialize only if there is no VBT. */
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index c91521bcf06a..ec51f6971b16 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -888,11 +888,10 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port port)
{
+ struct ddi_vbt_port_info *port_info = &dev_priv->vbt.ddi_port_info[port];
int n_entries, level, default_entry;
enum phy phy = intel_port_to_phy(dev_priv, port);
- level = dev_priv->vbt.ddi_port_info[port].hdmi_level_shift;
-
if (INTEL_GEN(dev_priv) >= 12) {
if (intel_phy_is_combo(dev_priv, phy))
icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
@@ -927,14 +926,18 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
return 0;
}
- /* Choose a good default if VBT is badly populated */
- if (level == HDMI_LEVEL_SHIFT_UNKNOWN || level >= n_entries)
- level = default_entry;
-
if (WARN_ON_ONCE(n_entries == 0))
return 0;
- if (WARN_ON_ONCE(level >= n_entries))
- level = n_entries - 1;
+
+ if (WARN_ON_ONCE(default_entry >= n_entries))
+ default_entry = n_entries - 1;
+
+ if (port_info->hdmi_level_shift_set &&
+ !WARN_ON_ONCE(port_info->hdmi_level_shift >= n_entries)) {
+ level = port_info->hdmi_level_shift;
+ } else {
+ level = default_entry;
+ }
return level;
}
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 7e0f67babe20..67bdfe6de3fa 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -627,13 +627,9 @@ struct ddi_vbt_port_info {
int max_tmds_clock;
- /*
- * This is an index in the HDMI/DVI DDI buffer translation table.
- * The special value HDMI_LEVEL_SHIFT_UNKNOWN means the VBT didn't
- * populate this field.
- */
-#define HDMI_LEVEL_SHIFT_UNKNOWN 0xff
+ /* This is an index in the HDMI/DVI DDI buffer translation table. */
u8 hdmi_level_shift;
+ u8 hdmi_level_shift_set:1;
u8 supports_dvi:1;
u8 supports_hdmi:1;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
end of thread, other threads:[~2019-11-12 20:02 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 10:32 [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence Jani Nikula
2019-11-07 10:32 ` [Intel-gfx] " Jani Nikula
2019-11-07 10:47 ` Ville Syrjälä
2019-11-07 10:47 ` [Intel-gfx] " Ville Syrjälä
2019-11-07 13:03 ` ✓ Fi.CI.BAT: success for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev2) Patchwork
2019-11-07 13:03 ` [Intel-gfx] " Patchwork
2019-11-08 14:25 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-08 14:25 ` [Intel-gfx] " Patchwork
2019-11-12 14:09 ` ✗ Fi.CI.BAT: failure for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev3) Patchwork
2019-11-12 14:09 ` [Intel-gfx] " Patchwork
2019-11-12 20:02 ` ✗ Fi.CI.BAT: failure for drm/i915/bios: use a flag for vbt hdmi level shift presence (rev4) Patchwork
2019-11-12 20:02 ` [Intel-gfx] " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-11-05 13:39 [PATCH] drm/i915/bios: use a flag for vbt hdmi level shift presence Jani Nikula
2019-11-05 13:50 ` Ville Syrjälä
2019-11-05 13:59 ` Jani Nikula
2019-11-05 15:21 ` Ville Syrjälä
2019-11-05 15:37 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.