* [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel
@ 2019-11-07 11:11 Soeren Moch
2019-11-07 11:11 ` [U-Boot] [PATCH 2/2] arm: dts: rk3399-rockpro64: slightly increase center voltage Soeren Moch
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Soeren Moch @ 2019-11-07 11:11 UTC (permalink / raw)
To: u-boot
The most important change for u-boot is the fix for the vdd-log pwm
voltage regulator to avoid overvoltage for the VD_LOGIC power domain.
Signed-off-by: Soeren Moch <smoch@web.de>
---
Cc: Kever Yang <kever.yang@rock-chips.com>
Cc: u-boot at lists.denx.de
---
arch/arm/dts/rk3399-rockpro64.dts | 57 ++++++++++++++++++++++++++-----
1 file changed, 49 insertions(+), 8 deletions(-)
diff --git a/arch/arm/dts/rk3399-rockpro64.dts b/arch/arm/dts/rk3399-rockpro64.dts
index 1f2394e058..e544deb61d 100644
--- a/arch/arm/dts/rk3399-rockpro64.dts
+++ b/arch/arm/dts/rk3399-rockpro64.dts
@@ -58,6 +58,13 @@
};
};
+ fan: pwm-fan {
+ compatible = "pwm-fan";
+ #cooling-cells = <2>;
+ fan-supply = <&vcc12v_dcin>;
+ pwms = <&pwm1 0 50000 0>;
+ };
+
sdio_pwrseq: sdio-pwrseq {
compatible = "mmc-pwrseq-simple";
clocks = <&rk808 1>;
@@ -166,7 +173,7 @@
regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <800000>;
- regulator-max-microvolt = <1400000>;
+ regulator-max-microvolt = <1700000>;
vin-supply = <&vcc5v0_sys>;
};
};
@@ -222,6 +229,10 @@
status = "okay";
};
+&hdmi_sound {
+ status = "okay";
+};
+
&gpu {
mali-supply = <&vdd_gpu>;
status = "okay";
@@ -236,8 +247,8 @@
rk808: pmic at 1b {
compatible = "rockchip,rk808";
reg = <0x1b>;
- interrupt-parent = <&gpio1>;
- interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
#clock-cells = <1>;
clock-output-names = "xin32k", "rk808-clkout2";
pinctrl-names = "default";
@@ -504,11 +515,25 @@
status = "okay";
bt656-supply = <&vcc1v8_dvp>;
- audio-supply = <&vcca1v8_codec>;
+ audio-supply = <&vcc_3v0>;
sdmmc-supply = <&vcc_sdio>;
gpio1830-supply = <&vcc_3v0>;
};
+&pcie0 {
+ ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
+ num-lanes = <4>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pcie_perst>;
+ vpcie12v-supply = <&vcc12v_dcin>;
+ vpcie3v3-supply = <&vcc3v3_pcie>;
+ status = "okay";
+};
+
+&pcie_phy {
+ status = "okay";
+};
+
&pmu_io_domains {
pmu1830-supply = <&vcc_3v0>;
status = "okay";
@@ -538,6 +563,10 @@
};
pcie {
+ pcie_perst: pcie-perst {
+ rockchip,pins = <2 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+
pcie_pwr_en: pcie-pwr-en {
rockchip,pins = <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
};
@@ -545,7 +574,7 @@
pmic {
pmic_int_l: pmic-int-l {
- rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
+ rockchip,pins = <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
};
vsel1_gpio: vsel1-gpio {
@@ -580,6 +609,10 @@
status = "okay";
};
+&pwm1 {
+ status = "okay";
+};
+
&pwm2 {
status = "okay";
};
@@ -591,7 +624,6 @@
&sdmmc {
bus-width = <4>;
- cap-mmc-highspeed;
cap-sd-highspeed;
cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>;
disable-wp;
@@ -603,12 +635,21 @@
&sdhci {
bus-width = <8>;
- mmc-hs400-1_8v;
- mmc-hs400-enhanced-strobe;
+ mmc-hs200-1_8v;
non-removable;
status = "okay";
};
+&spi1 {
+ status = "okay";
+
+ flash at 0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <10000000>;
+ };
+};
+
&tcphy0 {
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 2/2] arm: dts: rk3399-rockpro64: slightly increase center voltage
2019-11-07 11:11 [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel Soeren Moch
@ 2019-11-07 11:11 ` Soeren Moch
2019-11-08 3:23 ` Kever Yang
2019-11-07 20:04 ` [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel Vasily Khoruzhick
2019-11-08 3:22 ` Kever Yang
2 siblings, 1 reply; 11+ messages in thread
From: Soeren Moch @ 2019-11-07 11:11 UTC (permalink / raw)
To: u-boot
The rk3399 VD_CENTER voltage domain is not subject to dynamic voltage
scaling. So the regulator reset voltage of 0.9V is used on this board.
Let u-boot initialize the center voltage to 0.95V as it is done for the
VD_LOGIC domain. This avoids instability and occasional linux kernel
Opses on this board.
Signed-off-by: Soeren Moch <smoch@web.de>
---
Cc: Kever Yang <kever.yang@rock-chips.com>
Cc: u-boot at lists.denx.de
---
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
index a073ea25f5..4648513ea9 100644
--- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
@@ -11,6 +11,11 @@
};
};
+&vdd_center {
+ regulator-min-microvolt = <950000>;
+ regulator-max-microvolt = <950000>;
+};
+
&vdd_log {
regulator-init-microvolt = <950000>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel
2019-11-07 11:11 [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel Soeren Moch
2019-11-07 11:11 ` [U-Boot] [PATCH 2/2] arm: dts: rk3399-rockpro64: slightly increase center voltage Soeren Moch
@ 2019-11-07 20:04 ` Vasily Khoruzhick
2019-11-07 20:25 ` Soeren Moch
2019-11-08 3:22 ` Kever Yang
2 siblings, 1 reply; 11+ messages in thread
From: Vasily Khoruzhick @ 2019-11-07 20:04 UTC (permalink / raw)
To: u-boot
On Thu, Nov 7, 2019 at 3:11 AM Soeren Moch <smoch@web.de> wrote:
>
> The most important change for u-boot is the fix for the vdd-log pwm
> voltage regulator to avoid overvoltage for the VD_LOGIC power domain.
I don't see any changes to vdd-log regulator in this patch that can
help avoiding overvoltage. It just bumps regulator-max-microvolt to
1700000.
> Signed-off-by: Soeren Moch <smoch@web.de>
> ---
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Cc: u-boot at lists.denx.de
> ---
> arch/arm/dts/rk3399-rockpro64.dts | 57 ++++++++++++++++++++++++++-----
> 1 file changed, 49 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/dts/rk3399-rockpro64.dts b/arch/arm/dts/rk3399-rockpro64.dts
> index 1f2394e058..e544deb61d 100644
> --- a/arch/arm/dts/rk3399-rockpro64.dts
> +++ b/arch/arm/dts/rk3399-rockpro64.dts
> @@ -58,6 +58,13 @@
> };
> };
>
> + fan: pwm-fan {
> + compatible = "pwm-fan";
> + #cooling-cells = <2>;
> + fan-supply = <&vcc12v_dcin>;
> + pwms = <&pwm1 0 50000 0>;
> + };
> +
> sdio_pwrseq: sdio-pwrseq {
> compatible = "mmc-pwrseq-simple";
> clocks = <&rk808 1>;
> @@ -166,7 +173,7 @@
> regulator-always-on;
> regulator-boot-on;
> regulator-min-microvolt = <800000>;
> - regulator-max-microvolt = <1400000>;
> + regulator-max-microvolt = <1700000>;
> vin-supply = <&vcc5v0_sys>;
> };
> };
> @@ -222,6 +229,10 @@
> status = "okay";
> };
>
> +&hdmi_sound {
> + status = "okay";
> +};
> +
> &gpu {
> mali-supply = <&vdd_gpu>;
> status = "okay";
> @@ -236,8 +247,8 @@
> rk808: pmic at 1b {
> compatible = "rockchip,rk808";
> reg = <0x1b>;
> - interrupt-parent = <&gpio1>;
> - interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
> #clock-cells = <1>;
> clock-output-names = "xin32k", "rk808-clkout2";
> pinctrl-names = "default";
> @@ -504,11 +515,25 @@
> status = "okay";
>
> bt656-supply = <&vcc1v8_dvp>;
> - audio-supply = <&vcca1v8_codec>;
> + audio-supply = <&vcc_3v0>;
> sdmmc-supply = <&vcc_sdio>;
> gpio1830-supply = <&vcc_3v0>;
> };
>
> +&pcie0 {
> + ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
> + num-lanes = <4>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pcie_perst>;
> + vpcie12v-supply = <&vcc12v_dcin>;
> + vpcie3v3-supply = <&vcc3v3_pcie>;
> + status = "okay";
> +};
> +
> +&pcie_phy {
> + status = "okay";
> +};
> +
> &pmu_io_domains {
> pmu1830-supply = <&vcc_3v0>;
> status = "okay";
> @@ -538,6 +563,10 @@
> };
>
> pcie {
> + pcie_perst: pcie-perst {
> + rockchip,pins = <2 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> +
> pcie_pwr_en: pcie-pwr-en {
> rockchip,pins = <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
> };
> @@ -545,7 +574,7 @@
>
> pmic {
> pmic_int_l: pmic-int-l {
> - rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
> + rockchip,pins = <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
> };
>
> vsel1_gpio: vsel1-gpio {
> @@ -580,6 +609,10 @@
> status = "okay";
> };
>
> +&pwm1 {
> + status = "okay";
> +};
> +
> &pwm2 {
> status = "okay";
> };
> @@ -591,7 +624,6 @@
>
> &sdmmc {
> bus-width = <4>;
> - cap-mmc-highspeed;
> cap-sd-highspeed;
> cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>;
> disable-wp;
> @@ -603,12 +635,21 @@
>
> &sdhci {
> bus-width = <8>;
> - mmc-hs400-1_8v;
> - mmc-hs400-enhanced-strobe;
> + mmc-hs200-1_8v;
> non-removable;
> status = "okay";
> };
>
> +&spi1 {
> + status = "okay";
> +
> + flash at 0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <10000000>;
> + };
> +};
> +
> &tcphy0 {
> status = "okay";
> };
> --
> 2.17.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel
2019-11-07 20:04 ` [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel Vasily Khoruzhick
@ 2019-11-07 20:25 ` Soeren Moch
2019-11-07 20:28 ` Vasily Khoruzhick
0 siblings, 1 reply; 11+ messages in thread
From: Soeren Moch @ 2019-11-07 20:25 UTC (permalink / raw)
To: u-boot
On 07.11.19 21:04, Vasily Khoruzhick wrote:
> On Thu, Nov 7, 2019 at 3:11 AM Soeren Moch <smoch@web.de> wrote:
>> The most important change for u-boot is the fix for the vdd-log pwm
>> voltage regulator to avoid overvoltage for the VD_LOGIC power domain.
> I don't see any changes to vdd-log regulator in this patch that can
> help avoiding overvoltage. It just bumps regulator-max-microvolt to
> 1700000.
The duty-cycle of this pwm regulator is calculated from the min and max
values. And with a max value that is set too low for the actual
circuitry, a wrong duty-cycle is calculated that results in a higher
voltage that what is set in regulator-init-microvolt.
I measured the voltage on the board, with the original setting it was
far above the allowed 1.0V, this patch fixes this, also see [1].
Regards,
Soeren
[1] https://patchwork.kernel.org/patch/11173465/
>
>> Signed-off-by: Soeren Moch <smoch@web.de>
>> ---
>> Cc: Kever Yang <kever.yang@rock-chips.com>
>> Cc: u-boot at lists.denx.de
>> ---
>> arch/arm/dts/rk3399-rockpro64.dts | 57 ++++++++++++++++++++++++++-----
>> 1 file changed, 49 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/dts/rk3399-rockpro64.dts b/arch/arm/dts/rk3399-rockpro64.dts
>> index 1f2394e058..e544deb61d 100644
>> --- a/arch/arm/dts/rk3399-rockpro64.dts
>> +++ b/arch/arm/dts/rk3399-rockpro64.dts
>> @@ -58,6 +58,13 @@
>> };
>> };
>>
>> + fan: pwm-fan {
>> + compatible = "pwm-fan";
>> + #cooling-cells = <2>;
>> + fan-supply = <&vcc12v_dcin>;
>> + pwms = <&pwm1 0 50000 0>;
>> + };
>> +
>> sdio_pwrseq: sdio-pwrseq {
>> compatible = "mmc-pwrseq-simple";
>> clocks = <&rk808 1>;
>> @@ -166,7 +173,7 @@
>> regulator-always-on;
>> regulator-boot-on;
>> regulator-min-microvolt = <800000>;
>> - regulator-max-microvolt = <1400000>;
>> + regulator-max-microvolt = <1700000>;
>> vin-supply = <&vcc5v0_sys>;
>> };
>> };
>> @@ -222,6 +229,10 @@
>> status = "okay";
>> };
>>
>> +&hdmi_sound {
>> + status = "okay";
>> +};
>> +
>> &gpu {
>> mali-supply = <&vdd_gpu>;
>> status = "okay";
>> @@ -236,8 +247,8 @@
>> rk808: pmic at 1b {
>> compatible = "rockchip,rk808";
>> reg = <0x1b>;
>> - interrupt-parent = <&gpio1>;
>> - interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
>> + interrupt-parent = <&gpio3>;
>> + interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
>> #clock-cells = <1>;
>> clock-output-names = "xin32k", "rk808-clkout2";
>> pinctrl-names = "default";
>> @@ -504,11 +515,25 @@
>> status = "okay";
>>
>> bt656-supply = <&vcc1v8_dvp>;
>> - audio-supply = <&vcca1v8_codec>;
>> + audio-supply = <&vcc_3v0>;
>> sdmmc-supply = <&vcc_sdio>;
>> gpio1830-supply = <&vcc_3v0>;
>> };
>>
>> +&pcie0 {
>> + ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
>> + num-lanes = <4>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pcie_perst>;
>> + vpcie12v-supply = <&vcc12v_dcin>;
>> + vpcie3v3-supply = <&vcc3v3_pcie>;
>> + status = "okay";
>> +};
>> +
>> +&pcie_phy {
>> + status = "okay";
>> +};
>> +
>> &pmu_io_domains {
>> pmu1830-supply = <&vcc_3v0>;
>> status = "okay";
>> @@ -538,6 +563,10 @@
>> };
>>
>> pcie {
>> + pcie_perst: pcie-perst {
>> + rockchip,pins = <2 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
>> + };
>> +
>> pcie_pwr_en: pcie-pwr-en {
>> rockchip,pins = <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
>> };
>> @@ -545,7 +574,7 @@
>>
>> pmic {
>> pmic_int_l: pmic-int-l {
>> - rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
>> + rockchip,pins = <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
>> };
>>
>> vsel1_gpio: vsel1-gpio {
>> @@ -580,6 +609,10 @@
>> status = "okay";
>> };
>>
>> +&pwm1 {
>> + status = "okay";
>> +};
>> +
>> &pwm2 {
>> status = "okay";
>> };
>> @@ -591,7 +624,6 @@
>>
>> &sdmmc {
>> bus-width = <4>;
>> - cap-mmc-highspeed;
>> cap-sd-highspeed;
>> cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>;
>> disable-wp;
>> @@ -603,12 +635,21 @@
>>
>> &sdhci {
>> bus-width = <8>;
>> - mmc-hs400-1_8v;
>> - mmc-hs400-enhanced-strobe;
>> + mmc-hs200-1_8v;
>> non-removable;
>> status = "okay";
>> };
>>
>> +&spi1 {
>> + status = "okay";
>> +
>> + flash at 0 {
>> + compatible = "jedec,spi-nor";
>> + reg = <0>;
>> + spi-max-frequency = <10000000>;
>> + };
>> +};
>> +
>> &tcphy0 {
>> status = "okay";
>> };
>> --
>> 2.17.1
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> https://lists.denx.de/listinfo/u-boot
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel
2019-11-07 20:25 ` Soeren Moch
@ 2019-11-07 20:28 ` Vasily Khoruzhick
0 siblings, 0 replies; 11+ messages in thread
From: Vasily Khoruzhick @ 2019-11-07 20:28 UTC (permalink / raw)
To: u-boot
On Thu, Nov 7, 2019 at 12:26 PM Soeren Moch <smoch@web.de> wrote:
>
> On 07.11.19 21:04, Vasily Khoruzhick wrote:
> > On Thu, Nov 7, 2019 at 3:11 AM Soeren Moch <smoch@web.de> wrote:
> >> The most important change for u-boot is the fix for the vdd-log pwm
> >> voltage regulator to avoid overvoltage for the VD_LOGIC power domain.
> > I don't see any changes to vdd-log regulator in this patch that can
> > help avoiding overvoltage. It just bumps regulator-max-microvolt to
> > 1700000.
> The duty-cycle of this pwm regulator is calculated from the min and max
> values. And with a max value that is set too low for the actual
> circuitry, a wrong duty-cycle is calculated that results in a higher
> voltage that what is set in regulator-init-microvolt.
> I measured the voltage on the board, with the original setting it was
> far above the allowed 1.0V, this patch fixes this, also see [1].
Thanks for explanation!
> Regards,
> Soeren
>
> [1] https://patchwork.kernel.org/patch/11173465/
> >
> >> Signed-off-by: Soeren Moch <smoch@web.de>
> >> ---
> >> Cc: Kever Yang <kever.yang@rock-chips.com>
> >> Cc: u-boot at lists.denx.de
> >> ---
> >> arch/arm/dts/rk3399-rockpro64.dts | 57 ++++++++++++++++++++++++++-----
> >> 1 file changed, 49 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/arch/arm/dts/rk3399-rockpro64.dts b/arch/arm/dts/rk3399-rockpro64.dts
> >> index 1f2394e058..e544deb61d 100644
> >> --- a/arch/arm/dts/rk3399-rockpro64.dts
> >> +++ b/arch/arm/dts/rk3399-rockpro64.dts
> >> @@ -58,6 +58,13 @@
> >> };
> >> };
> >>
> >> + fan: pwm-fan {
> >> + compatible = "pwm-fan";
> >> + #cooling-cells = <2>;
> >> + fan-supply = <&vcc12v_dcin>;
> >> + pwms = <&pwm1 0 50000 0>;
> >> + };
> >> +
> >> sdio_pwrseq: sdio-pwrseq {
> >> compatible = "mmc-pwrseq-simple";
> >> clocks = <&rk808 1>;
> >> @@ -166,7 +173,7 @@
> >> regulator-always-on;
> >> regulator-boot-on;
> >> regulator-min-microvolt = <800000>;
> >> - regulator-max-microvolt = <1400000>;
> >> + regulator-max-microvolt = <1700000>;
> >> vin-supply = <&vcc5v0_sys>;
> >> };
> >> };
> >> @@ -222,6 +229,10 @@
> >> status = "okay";
> >> };
> >>
> >> +&hdmi_sound {
> >> + status = "okay";
> >> +};
> >> +
> >> &gpu {
> >> mali-supply = <&vdd_gpu>;
> >> status = "okay";
> >> @@ -236,8 +247,8 @@
> >> rk808: pmic at 1b {
> >> compatible = "rockchip,rk808";
> >> reg = <0x1b>;
> >> - interrupt-parent = <&gpio1>;
> >> - interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
> >> + interrupt-parent = <&gpio3>;
> >> + interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
> >> #clock-cells = <1>;
> >> clock-output-names = "xin32k", "rk808-clkout2";
> >> pinctrl-names = "default";
> >> @@ -504,11 +515,25 @@
> >> status = "okay";
> >>
> >> bt656-supply = <&vcc1v8_dvp>;
> >> - audio-supply = <&vcca1v8_codec>;
> >> + audio-supply = <&vcc_3v0>;
> >> sdmmc-supply = <&vcc_sdio>;
> >> gpio1830-supply = <&vcc_3v0>;
> >> };
> >>
> >> +&pcie0 {
> >> + ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
> >> + num-lanes = <4>;
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pcie_perst>;
> >> + vpcie12v-supply = <&vcc12v_dcin>;
> >> + vpcie3v3-supply = <&vcc3v3_pcie>;
> >> + status = "okay";
> >> +};
> >> +
> >> +&pcie_phy {
> >> + status = "okay";
> >> +};
> >> +
> >> &pmu_io_domains {
> >> pmu1830-supply = <&vcc_3v0>;
> >> status = "okay";
> >> @@ -538,6 +563,10 @@
> >> };
> >>
> >> pcie {
> >> + pcie_perst: pcie-perst {
> >> + rockchip,pins = <2 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
> >> + };
> >> +
> >> pcie_pwr_en: pcie-pwr-en {
> >> rockchip,pins = <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
> >> };
> >> @@ -545,7 +574,7 @@
> >>
> >> pmic {
> >> pmic_int_l: pmic-int-l {
> >> - rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
> >> + rockchip,pins = <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
> >> };
> >>
> >> vsel1_gpio: vsel1-gpio {
> >> @@ -580,6 +609,10 @@
> >> status = "okay";
> >> };
> >>
> >> +&pwm1 {
> >> + status = "okay";
> >> +};
> >> +
> >> &pwm2 {
> >> status = "okay";
> >> };
> >> @@ -591,7 +624,6 @@
> >>
> >> &sdmmc {
> >> bus-width = <4>;
> >> - cap-mmc-highspeed;
> >> cap-sd-highspeed;
> >> cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>;
> >> disable-wp;
> >> @@ -603,12 +635,21 @@
> >>
> >> &sdhci {
> >> bus-width = <8>;
> >> - mmc-hs400-1_8v;
> >> - mmc-hs400-enhanced-strobe;
> >> + mmc-hs200-1_8v;
> >> non-removable;
> >> status = "okay";
> >> };
> >>
> >> +&spi1 {
> >> + status = "okay";
> >> +
> >> + flash at 0 {
> >> + compatible = "jedec,spi-nor";
> >> + reg = <0>;
> >> + spi-max-frequency = <10000000>;
> >> + };
> >> +};
> >> +
> >> &tcphy0 {
> >> status = "okay";
> >> };
> >> --
> >> 2.17.1
> >>
> >> _______________________________________________
> >> U-Boot mailing list
> >> U-Boot at lists.denx.de
> >> https://lists.denx.de/listinfo/u-boot
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel
2019-11-07 11:11 [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel Soeren Moch
2019-11-07 11:11 ` [U-Boot] [PATCH 2/2] arm: dts: rk3399-rockpro64: slightly increase center voltage Soeren Moch
2019-11-07 20:04 ` [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel Vasily Khoruzhick
@ 2019-11-08 3:22 ` Kever Yang
2019-11-08 8:45 ` Soeren Moch
2019-11-18 2:56 ` [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel【请注意，邮件由u-boot-bounces@lists.denx.de代发】 Kever Yang
2 siblings, 2 replies; 11+ messages in thread
From: Kever Yang @ 2019-11-08 3:22 UTC (permalink / raw)
To: u-boot
On 2019/11/7 下午7:11, Soeren Moch wrote:
> The most important change for u-boot is the fix for the vdd-log pwm
> voltage regulator to avoid overvoltage for the VD_LOGIC power domain.
>
> Signed-off-by: Soeren Moch <smoch@web.de>
> =2D--
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Cc: u-boot at lists.denx.de
> =2D--
Why is the "=2D- -" here?
Otherwise looks good to me.
Reviewed-by: Kever Yang<kever.yang@rock-chips.com>
Thanks,
- Kever
> arch/arm/dts/rk3399-rockpro64.dts | 57 ++++++++++++++++++++++++++-----
> 1 file changed, 49 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/dts/rk3399-rockpro64.dts b/arch/arm/dts/rk3399-rockp=
> ro64.dts
> index 1f2394e058..e544deb61d 100644
> =2D-- a/arch/arm/dts/rk3399-rockpro64.dts
> +++ b/arch/arm/dts/rk3399-rockpro64.dts
> @@ -58,6 +58,13 @@
> };
> };
>
> + fan: pwm-fan {
> + compatible =3D "pwm-fan";
> + #cooling-cells =3D <2>;
> + fan-supply =3D <&vcc12v_dcin>;
> + pwms =3D <&pwm1 0 50000 0>;
> + };
> +
> sdio_pwrseq: sdio-pwrseq {
> compatible =3D "mmc-pwrseq-simple";
> clocks =3D <&rk808 1>;
> @@ -166,7 +173,7 @@
> regulator-always-on;
> regulator-boot-on;
> regulator-min-microvolt =3D <800000>;
> - regulator-max-microvolt =3D <1400000>;
> + regulator-max-microvolt =3D <1700000>;
> vin-supply =3D <&vcc5v0_sys>;
> };
> };
> @@ -222,6 +229,10 @@
> status =3D "okay";
> };
>
> +&hdmi_sound {
> + status =3D "okay";
> +};
> +
> &gpu {
> mali-supply =3D <&vdd_gpu>;
> status =3D "okay";
> @@ -236,8 +247,8 @@
> rk808: pmic at 1b {
> compatible =3D "rockchip,rk808";
> reg =3D <0x1b>;
> - interrupt-parent =3D <&gpio1>;
> - interrupts =3D <21 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent =3D <&gpio3>;
> + interrupts =3D <10 IRQ_TYPE_LEVEL_LOW>;
> #clock-cells =3D <1>;
> clock-output-names =3D "xin32k", "rk808-clkout2";
> pinctrl-names =3D "default";
> @@ -504,11 +515,25 @@
> status =3D "okay";
>
> bt656-supply =3D <&vcc1v8_dvp>;
> - audio-supply =3D <&vcca1v8_codec>;
> + audio-supply =3D <&vcc_3v0>;
> sdmmc-supply =3D <&vcc_sdio>;
> gpio1830-supply =3D <&vcc_3v0>;
> };
>
> +&pcie0 {
> + ep-gpios =3D <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
> + num-lanes =3D <4>;
> + pinctrl-names =3D "default";
> + pinctrl-0 =3D <&pcie_perst>;
> + vpcie12v-supply =3D <&vcc12v_dcin>;
> + vpcie3v3-supply =3D <&vcc3v3_pcie>;
> + status =3D "okay";
> +};
> +
> +&pcie_phy {
> + status =3D "okay";
> +};
> +
> &pmu_io_domains {
> pmu1830-supply =3D <&vcc_3v0>;
> status =3D "okay";
> @@ -538,6 +563,10 @@
> };
>
> pcie {
> + pcie_perst: pcie-perst {
> + rockchip,pins =3D <2 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> +
> pcie_pwr_en: pcie-pwr-en {
> rockchip,pins =3D <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
> };
> @@ -545,7 +574,7 @@
>
> pmic {
> pmic_int_l: pmic-int-l {
> - rockchip,pins =3D <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
> + rockchip,pins =3D <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
> };
>
> vsel1_gpio: vsel1-gpio {
> @@ -580,6 +609,10 @@
> status =3D "okay";
> };
>
> +&pwm1 {
> + status =3D "okay";
> +};
> +
> &pwm2 {
> status =3D "okay";
> };
> @@ -591,7 +624,6 @@
>
> &sdmmc {
> bus-width =3D <4>;
> - cap-mmc-highspeed;
> cap-sd-highspeed;
> cd-gpios =3D <&gpio0 7 GPIO_ACTIVE_LOW>;
> disable-wp;
> @@ -603,12 +635,21 @@
>
> &sdhci {
> bus-width =3D <8>;
> - mmc-hs400-1_8v;
> - mmc-hs400-enhanced-strobe;
> + mmc-hs200-1_8v;
> non-removable;
> status =3D "okay";
> };
>
> +&spi1 {
> + status =3D "okay";
> +
> + flash at 0 {
> + compatible =3D "jedec,spi-nor";
> + reg =3D <0>;
> + spi-max-frequency =3D <10000000>;
> + };
> +};
> +
> &tcphy0 {
> status =3D "okay";
> };
> =2D-
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 2/2] arm: dts: rk3399-rockpro64: slightly increase center voltage
2019-11-07 11:11 ` [U-Boot] [PATCH 2/2] arm: dts: rk3399-rockpro64: slightly increase center voltage Soeren Moch
@ 2019-11-08 3:23 ` Kever Yang
2019-11-18 2:55 ` [U-Boot] [PATCH 2/2] arm: dts: rk3399-rockpro64: slightly increase center voltage【请注意，邮件由u-boot-bounces@lists.denx.de代发】 Kever Yang
0 siblings, 1 reply; 11+ messages in thread
From: Kever Yang @ 2019-11-08 3:23 UTC (permalink / raw)
To: u-boot
On 2019/11/7 下午7:11, Soeren Moch wrote:
> The rk3399 VD_CENTER voltage domain is not subject to dynamic voltage
> scaling. So the regulator reset voltage of 0.9V is used on this board.
> Let u-boot initialize the center voltage to 0.95V as it is done for the
> VD_LOGIC domain. This avoids instability and occasional linux kernel
> Opses on this board.
>
> Signed-off-by: Soeren Moch <smoch@web.de>
> =2D--
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Cc: u-boot at lists.denx.de
> =2D--
> arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 5 +++++
Reviewed-by: Kever Yang<kever.yang@rock-chips.com>
Thanks,
- Kever
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk33=
> 99-rockpro64-u-boot.dtsi
> index a073ea25f5..4648513ea9 100644
> =2D-- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> @@ -11,6 +11,11 @@
> };
> };
>
> +&vdd_center {
> + regulator-min-microvolt =3D <950000>;
> + regulator-max-microvolt =3D <950000>;
> +};
> +
> &vdd_log {
> regulator-init-microvolt =3D <950000>;
> };
> =2D-
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel
2019-11-08 3:22 ` Kever Yang
@ 2019-11-08 8:45 ` Soeren Moch
2019-11-08 11:41 ` Soeren Moch
2019-11-18 2:56 ` [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel【请注意，邮件由u-boot-bounces@lists.denx.de代发】 Kever Yang
1 sibling, 1 reply; 11+ messages in thread
From: Soeren Moch @ 2019-11-08 8:45 UTC (permalink / raw)
To: u-boot
On 08.11.19 04:22, Kever Yang wrote:
>
> On 2019/11/7 下午7:11, Soeren Moch wrote:
>> The most important change for u-boot is the fix for the vdd-log pwm
>> voltage regulator to avoid overvoltage for the VD_LOGIC power domain.
>>
>> Signed-off-by: Soeren Moch <smoch@web.de>
>> =2D--
>> Cc: Kever Yang <kever.yang@rock-chips.com>
>> Cc: u-boot at lists.denx.de
>> =2D--
>
> Why is the "=2D- -" here?
'git send-email' encodes the patch this way. I use git version 2.17.1 .
Apparently this this done to avoid problems with MTAs, I also saw 'From'
in a patch description encoded in this special way.
Seems to be no problem for other tools, e.g. u-boot patchwork converts
this back to the more traditional readable form.
I'm not sure what I should do about this, seems to be more a feature
than a bug.
>
> Otherwise looks good to me.
>
>
> Reviewed-by: Kever Yang<kever.yang@rock-chips.com>
Thanks,
Soeren
>
> Thanks,
> - Kever
>
>> arch/arm/dts/rk3399-rockpro64.dts | 57 ++++++++++++++++++++++++++-----
>> 1 file changed, 49 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/dts/rk3399-rockpro64.dts
>> b/arch/arm/dts/rk3399-rockp=
>> ro64.dts
>> index 1f2394e058..e544deb61d 100644
>> =2D-- a/arch/arm/dts/rk3399-rockpro64.dts
>> +++ b/arch/arm/dts/rk3399-rockpro64.dts
>> @@ -58,6 +58,13 @@
>> };
>> };
>>
>> + fan: pwm-fan {
>> + compatible =3D "pwm-fan";
>> + #cooling-cells =3D <2>;
>> + fan-supply =3D <&vcc12v_dcin>;
>> + pwms =3D <&pwm1 0 50000 0>;
>> + };
>> +
>> sdio_pwrseq: sdio-pwrseq {
>> compatible =3D "mmc-pwrseq-simple";
>> clocks =3D <&rk808 1>;
>> @@ -166,7 +173,7 @@
>> regulator-always-on;
>> regulator-boot-on;
>> regulator-min-microvolt =3D <800000>;
>> - regulator-max-microvolt =3D <1400000>;
>> + regulator-max-microvolt =3D <1700000>;
>> vin-supply =3D <&vcc5v0_sys>;
>> };
>> };
>> @@ -222,6 +229,10 @@
>> status =3D "okay";
>> };
>>
>> +&hdmi_sound {
>> + status =3D "okay";
>> +};
>> +
>> &gpu {
>> mali-supply =3D <&vdd_gpu>;
>> status =3D "okay";
>> @@ -236,8 +247,8 @@
>> rk808: pmic at 1b {
>> compatible =3D "rockchip,rk808";
>> reg =3D <0x1b>;
>> - interrupt-parent =3D <&gpio1>;
>> - interrupts =3D <21 IRQ_TYPE_LEVEL_LOW>;
>> + interrupt-parent =3D <&gpio3>;
>> + interrupts =3D <10 IRQ_TYPE_LEVEL_LOW>;
>> #clock-cells =3D <1>;
>> clock-output-names =3D "xin32k", "rk808-clkout2";
>> pinctrl-names =3D "default";
>> @@ -504,11 +515,25 @@
>> status =3D "okay";
>>
>> bt656-supply =3D <&vcc1v8_dvp>;
>> - audio-supply =3D <&vcca1v8_codec>;
>> + audio-supply =3D <&vcc_3v0>;
>> sdmmc-supply =3D <&vcc_sdio>;
>> gpio1830-supply =3D <&vcc_3v0>;
>> };
>>
>> +&pcie0 {
>> + ep-gpios =3D <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
>> + num-lanes =3D <4>;
>> + pinctrl-names =3D "default";
>> + pinctrl-0 =3D <&pcie_perst>;
>> + vpcie12v-supply =3D <&vcc12v_dcin>;
>> + vpcie3v3-supply =3D <&vcc3v3_pcie>;
>> + status =3D "okay";
>> +};
>> +
>> +&pcie_phy {
>> + status =3D "okay";
>> +};
>> +
>> &pmu_io_domains {
>> pmu1830-supply =3D <&vcc_3v0>;
>> status =3D "okay";
>> @@ -538,6 +563,10 @@
>> };
>>
>> pcie {
>> + pcie_perst: pcie-perst {
>> + rockchip,pins =3D <2 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
>> + };
>> +
>> pcie_pwr_en: pcie-pwr-en {
>> rockchip,pins =3D <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
>> };
>> @@ -545,7 +574,7 @@
>>
>> pmic {
>> pmic_int_l: pmic-int-l {
>> - rockchip,pins =3D <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
>> + rockchip,pins =3D <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
>> };
>>
>> vsel1_gpio: vsel1-gpio {
>> @@ -580,6 +609,10 @@
>> status =3D "okay";
>> };
>>
>> +&pwm1 {
>> + status =3D "okay";
>> +};
>> +
>> &pwm2 {
>> status =3D "okay";
>> };
>> @@ -591,7 +624,6 @@
>>
>> &sdmmc {
>> bus-width =3D <4>;
>> - cap-mmc-highspeed;
>> cap-sd-highspeed;
>> cd-gpios =3D <&gpio0 7 GPIO_ACTIVE_LOW>;
>> disable-wp;
>> @@ -603,12 +635,21 @@
>>
>> &sdhci {
>> bus-width =3D <8>;
>> - mmc-hs400-1_8v;
>> - mmc-hs400-enhanced-strobe;
>> + mmc-hs200-1_8v;
>> non-removable;
>> status =3D "okay";
>> };
>>
>> +&spi1 {
>> + status =3D "okay";
>> +
>> + flash at 0 {
>> + compatible =3D "jedec,spi-nor";
>> + reg =3D <0>;
>> + spi-max-frequency =3D <10000000>;
>> + };
>> +};
>> +
>> &tcphy0 {
>> status =3D "okay";
>> };
>> =2D-
>> 2.17.1
>>
>>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel
2019-11-08 8:45 ` Soeren Moch
@ 2019-11-08 11:41 ` Soeren Moch
0 siblings, 0 replies; 11+ messages in thread
From: Soeren Moch @ 2019-11-08 11:41 UTC (permalink / raw)
To: u-boot
On 08.11.19 09:45, Soeren Moch wrote:
> On 08.11.19 04:22, Kever Yang wrote:
>> On 2019/11/7 下午7:11, Soeren Moch wrote:
>>> The most important change for u-boot is the fix for the vdd-log pwm
>>> voltage regulator to avoid overvoltage for the VD_LOGIC power domain.
>>>
>>> Signed-off-by: Soeren Moch <smoch@web.de>
>>> =2D--
>>> Cc: Kever Yang <kever.yang@rock-chips.com>
>>> Cc: u-boot at lists.denx.de
>>> =2D--
>> Why is the "=2D- -" here?
> 'git send-email' encodes the patch this way. I use git version 2.17.1 .
> Apparently this this done to avoid problems with MTAs, I also saw 'From'
> in a patch description encoded in this special way.
> Seems to be no problem for other tools, e.g. u-boot patchwork converts
> this back to the more traditional readable form.
>
> I'm not sure what I should do about this, seems to be more a feature
> than a bug.
Apparently 'git send-email' changed the default transfer encoding from
unspecified 8bit to quoted-printable.
Do you want me to resend these patches with simpler transfer encoding,
e.g. 7bit?
Thanks,
Soeren
>> Otherwise looks good to me.
>>
>>
>> Reviewed-by: Kever Yang<kever.yang@rock-chips.com>
> Thanks,
> Soeren
>> Thanks,
>> - Kever
>>
>>> arch/arm/dts/rk3399-rockpro64.dts | 57 ++++++++++++++++++++++++++-----
>>> 1 file changed, 49 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/arch/arm/dts/rk3399-rockpro64.dts
>>> b/arch/arm/dts/rk3399-rockp=
>>> ro64.dts
>>> index 1f2394e058..e544deb61d 100644
>>> =2D-- a/arch/arm/dts/rk3399-rockpro64.dts
>>> +++ b/arch/arm/dts/rk3399-rockpro64.dts
>>> @@ -58,6 +58,13 @@
>>> };
>>> };
>>>
>>> + fan: pwm-fan {
>>> + compatible =3D "pwm-fan";
>>> + #cooling-cells =3D <2>;
>>> + fan-supply =3D <&vcc12v_dcin>;
>>> + pwms =3D <&pwm1 0 50000 0>;
>>> + };
>>> +
>>> sdio_pwrseq: sdio-pwrseq {
>>> compatible =3D "mmc-pwrseq-simple";
>>> clocks =3D <&rk808 1>;
>>> @@ -166,7 +173,7 @@
>>> regulator-always-on;
>>> regulator-boot-on;
>>> regulator-min-microvolt =3D <800000>;
>>> - regulator-max-microvolt =3D <1400000>;
>>> + regulator-max-microvolt =3D <1700000>;
>>> vin-supply =3D <&vcc5v0_sys>;
>>> };
>>> };
>>> @@ -222,6 +229,10 @@
>>> status =3D "okay";
>>> };
>>>
>>> +&hdmi_sound {
>>> + status =3D "okay";
>>> +};
>>> +
>>> &gpu {
>>> mali-supply =3D <&vdd_gpu>;
>>> status =3D "okay";
>>> @@ -236,8 +247,8 @@
>>> rk808: pmic at 1b {
>>> compatible =3D "rockchip,rk808";
>>> reg =3D <0x1b>;
>>> - interrupt-parent =3D <&gpio1>;
>>> - interrupts =3D <21 IRQ_TYPE_LEVEL_LOW>;
>>> + interrupt-parent =3D <&gpio3>;
>>> + interrupts =3D <10 IRQ_TYPE_LEVEL_LOW>;
>>> #clock-cells =3D <1>;
>>> clock-output-names =3D "xin32k", "rk808-clkout2";
>>> pinctrl-names =3D "default";
>>> @@ -504,11 +515,25 @@
>>> status =3D "okay";
>>>
>>> bt656-supply =3D <&vcc1v8_dvp>;
>>> - audio-supply =3D <&vcca1v8_codec>;
>>> + audio-supply =3D <&vcc_3v0>;
>>> sdmmc-supply =3D <&vcc_sdio>;
>>> gpio1830-supply =3D <&vcc_3v0>;
>>> };
>>>
>>> +&pcie0 {
>>> + ep-gpios =3D <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
>>> + num-lanes =3D <4>;
>>> + pinctrl-names =3D "default";
>>> + pinctrl-0 =3D <&pcie_perst>;
>>> + vpcie12v-supply =3D <&vcc12v_dcin>;
>>> + vpcie3v3-supply =3D <&vcc3v3_pcie>;
>>> + status =3D "okay";
>>> +};
>>> +
>>> +&pcie_phy {
>>> + status =3D "okay";
>>> +};
>>> +
>>> &pmu_io_domains {
>>> pmu1830-supply =3D <&vcc_3v0>;
>>> status =3D "okay";
>>> @@ -538,6 +563,10 @@
>>> };
>>>
>>> pcie {
>>> + pcie_perst: pcie-perst {
>>> + rockchip,pins =3D <2 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
>>> + };
>>> +
>>> pcie_pwr_en: pcie-pwr-en {
>>> rockchip,pins =3D <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
>>> };
>>> @@ -545,7 +574,7 @@
>>>
>>> pmic {
>>> pmic_int_l: pmic-int-l {
>>> - rockchip,pins =3D <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
>>> + rockchip,pins =3D <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
>>> };
>>>
>>> vsel1_gpio: vsel1-gpio {
>>> @@ -580,6 +609,10 @@
>>> status =3D "okay";
>>> };
>>>
>>> +&pwm1 {
>>> + status =3D "okay";
>>> +};
>>> +
>>> &pwm2 {
>>> status =3D "okay";
>>> };
>>> @@ -591,7 +624,6 @@
>>>
>>> &sdmmc {
>>> bus-width =3D <4>;
>>> - cap-mmc-highspeed;
>>> cap-sd-highspeed;
>>> cd-gpios =3D <&gpio0 7 GPIO_ACTIVE_LOW>;
>>> disable-wp;
>>> @@ -603,12 +635,21 @@
>>>
>>> &sdhci {
>>> bus-width =3D <8>;
>>> - mmc-hs400-1_8v;
>>> - mmc-hs400-enhanced-strobe;
>>> + mmc-hs200-1_8v;
>>> non-removable;
>>> status =3D "okay";
>>> };
>>>
>>> +&spi1 {
>>> + status =3D "okay";
>>> +
>>> + flash at 0 {
>>> + compatible =3D "jedec,spi-nor";
>>> + reg =3D <0>;
>>> + spi-max-frequency =3D <10000000>;
>>> + };
>>> +};
>>> +
>>> &tcphy0 {
>>> status =3D "okay";
>>> };
>>> =2D-
>>> 2.17.1
>>>
>>>
>>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 2/2] arm: dts: rk3399-rockpro64: slightly increase center voltage【请注意，邮件由u-boot-bounces@lists.denx.de代发】
2019-11-08 3:23 ` Kever Yang
@ 2019-11-18 2:55 ` Kever Yang
0 siblings, 0 replies; 11+ messages in thread
From: Kever Yang @ 2019-11-18 2:55 UTC (permalink / raw)
To: u-boot
On 2019/11/8 上午11:23, Kever Yang wrote:
>
> On 2019/11/7 下午7:11, Soeren Moch wrote:
>> The rk3399 VD_CENTER voltage domain is not subject to dynamic voltage
>> scaling. So the regulator reset voltage of 0.9V is used on this board.
>> Let u-boot initialize the center voltage to 0.95V as it is done for the
>> VD_LOGIC domain. This avoids instability and occasional linux kernel
>> Opses on this board.
>>
>> Signed-off-by: Soeren Moch <smoch@web.de>
>> =2D--
>> Cc: Kever Yang <kever.yang@rock-chips.com>
>> Cc: u-boot at lists.denx.de
>> =2D--
>> arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 5 +++++
>
> Reviewed-by: Kever Yang<kever.yang@rock-chips.com>
>
Applied to u-boot-rockchip master .
Thanks,
- Kever
> Thanks,
> - Kever
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
>> b/arch/arm/dts/rk33=
>> 99-rockpro64-u-boot.dtsi
>> index a073ea25f5..4648513ea9 100644
>> =2D-- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
>> +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
>> @@ -11,6 +11,11 @@
>> };
>> };
>>
>> +&vdd_center {
>> + regulator-min-microvolt =3D <950000>;
>> + regulator-max-microvolt =3D <950000>;
>> +};
>> +
>> &vdd_log {
>> regulator-init-microvolt =3D <950000>;
>> };
>> =2D-
>> 2.17.1
>>
>>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel【请注意，邮件由u-boot-bounces@lists.denx.de代发】
2019-11-08 3:22 ` Kever Yang
2019-11-08 8:45 ` Soeren Moch
@ 2019-11-18 2:56 ` Kever Yang
1 sibling, 0 replies; 11+ messages in thread
From: Kever Yang @ 2019-11-18 2:56 UTC (permalink / raw)
To: u-boot
On 2019/11/8 上午11:22, Kever Yang wrote:
>
> On 2019/11/7 下午7:11, Soeren Moch wrote:
>> The most important change for u-boot is the fix for the vdd-log pwm
>> voltage regulator to avoid overvoltage for the VD_LOGIC power domain.
>>
>> Signed-off-by: Soeren Moch <smoch@web.de>
>> =2D--
>> Cc: Kever Yang <kever.yang@rock-chips.com>
>> Cc: u-boot at lists.denx.de
>> =2D--
>
> Why is the "=2D- -" here?
>
> Otherwise looks good to me.
>
>
> Reviewed-by: Kever Yang<kever.yang@rock-chips.com>
Applied to u-boot-rockchip master.
Thanks,
- Kever
>
> Thanks,
> - Kever
>
>> arch/arm/dts/rk3399-rockpro64.dts | 57 ++++++++++++++++++++++++++-----
>> 1 file changed, 49 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/dts/rk3399-rockpro64.dts
>> b/arch/arm/dts/rk3399-rockp=
>> ro64.dts
>> index 1f2394e058..e544deb61d 100644
>> =2D-- a/arch/arm/dts/rk3399-rockpro64.dts
>> +++ b/arch/arm/dts/rk3399-rockpro64.dts
>> @@ -58,6 +58,13 @@
>> };
>> };
>>
>> + fan: pwm-fan {
>> + compatible =3D "pwm-fan";
>> + #cooling-cells =3D <2>;
>> + fan-supply =3D <&vcc12v_dcin>;
>> + pwms =3D <&pwm1 0 50000 0>;
>> + };
>> +
>> sdio_pwrseq: sdio-pwrseq {
>> compatible =3D "mmc-pwrseq-simple";
>> clocks =3D <&rk808 1>;
>> @@ -166,7 +173,7 @@
>> regulator-always-on;
>> regulator-boot-on;
>> regulator-min-microvolt =3D <800000>;
>> - regulator-max-microvolt =3D <1400000>;
>> + regulator-max-microvolt =3D <1700000>;
>> vin-supply =3D <&vcc5v0_sys>;
>> };
>> };
>> @@ -222,6 +229,10 @@
>> status =3D "okay";
>> };
>>
>> +&hdmi_sound {
>> + status =3D "okay";
>> +};
>> +
>> &gpu {
>> mali-supply =3D <&vdd_gpu>;
>> status =3D "okay";
>> @@ -236,8 +247,8 @@
>> rk808: pmic at 1b {
>> compatible =3D "rockchip,rk808";
>> reg =3D <0x1b>;
>> - interrupt-parent =3D <&gpio1>;
>> - interrupts =3D <21 IRQ_TYPE_LEVEL_LOW>;
>> + interrupt-parent =3D <&gpio3>;
>> + interrupts =3D <10 IRQ_TYPE_LEVEL_LOW>;
>> #clock-cells =3D <1>;
>> clock-output-names =3D "xin32k", "rk808-clkout2";
>> pinctrl-names =3D "default";
>> @@ -504,11 +515,25 @@
>> status =3D "okay";
>>
>> bt656-supply =3D <&vcc1v8_dvp>;
>> - audio-supply =3D <&vcca1v8_codec>;
>> + audio-supply =3D <&vcc_3v0>;
>> sdmmc-supply =3D <&vcc_sdio>;
>> gpio1830-supply =3D <&vcc_3v0>;
>> };
>>
>> +&pcie0 {
>> + ep-gpios =3D <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
>> + num-lanes =3D <4>;
>> + pinctrl-names =3D "default";
>> + pinctrl-0 =3D <&pcie_perst>;
>> + vpcie12v-supply =3D <&vcc12v_dcin>;
>> + vpcie3v3-supply =3D <&vcc3v3_pcie>;
>> + status =3D "okay";
>> +};
>> +
>> +&pcie_phy {
>> + status =3D "okay";
>> +};
>> +
>> &pmu_io_domains {
>> pmu1830-supply =3D <&vcc_3v0>;
>> status =3D "okay";
>> @@ -538,6 +563,10 @@
>> };
>>
>> pcie {
>> + pcie_perst: pcie-perst {
>> + rockchip,pins =3D <2 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
>> + };
>> +
>> pcie_pwr_en: pcie-pwr-en {
>> rockchip,pins =3D <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
>> };
>> @@ -545,7 +574,7 @@
>>
>> pmic {
>> pmic_int_l: pmic-int-l {
>> - rockchip,pins =3D <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
>> + rockchip,pins =3D <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
>> };
>>
>> vsel1_gpio: vsel1-gpio {
>> @@ -580,6 +609,10 @@
>> status =3D "okay";
>> };
>>
>> +&pwm1 {
>> + status =3D "okay";
>> +};
>> +
>> &pwm2 {
>> status =3D "okay";
>> };
>> @@ -591,7 +624,6 @@
>>
>> &sdmmc {
>> bus-width =3D <4>;
>> - cap-mmc-highspeed;
>> cap-sd-highspeed;
>> cd-gpios =3D <&gpio0 7 GPIO_ACTIVE_LOW>;
>> disable-wp;
>> @@ -603,12 +635,21 @@
>>
>> &sdhci {
>> bus-width =3D <8>;
>> - mmc-hs400-1_8v;
>> - mmc-hs400-enhanced-strobe;
>> + mmc-hs200-1_8v;
>> non-removable;
>> status =3D "okay";
>> };
>>
>> +&spi1 {
>> + status =3D "okay";
>> +
>> + flash at 0 {
>> + compatible =3D "jedec,spi-nor";
>> + reg =3D <0>;
>> + spi-max-frequency =3D <10000000>;
>> + };
>> +};
>> +
>> &tcphy0 {
>> status =3D "okay";
>> };
>> =2D-
>> 2.17.1
>>
>>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-11-18 2:56 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 11:11 [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel Soeren Moch
2019-11-07 11:11 ` [U-Boot] [PATCH 2/2] arm: dts: rk3399-rockpro64: slightly increase center voltage Soeren Moch
2019-11-08 3:23 ` Kever Yang
2019-11-18 2:55 ` [U-Boot] [PATCH 2/2] arm: dts: rk3399-rockpro64: slightly increase center voltage【请注意，邮件由u-boot-bounces@lists.denx.de代发】 Kever Yang
2019-11-07 20:04 ` [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel Vasily Khoruzhick
2019-11-07 20:25 ` Soeren Moch
2019-11-07 20:28 ` Vasily Khoruzhick
2019-11-08 3:22 ` Kever Yang
2019-11-08 8:45 ` Soeren Moch
2019-11-08 11:41 ` Soeren Moch
2019-11-18 2:56 ` [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel【请注意，邮件由u-boot-bounces@lists.denx.de代发】 Kever Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.