Re: [PATCH 1/3] staging: wfx: replace uint32_t with u32

["gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>]

On Wed, Nov 06, 2019 at 12:24:03PM +0000, Jerome Pouiller wrote:
> Hello Jules,
> 
> On Wednesday 6 November 2019 02:09:09 CET Jules Irenge wrote:
> > Replace kernel type uint32_t with u32.
> > As per recommendation of checkpatch tool.
> > 
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> >  drivers/staging/wfx/bh.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c
> > index 955ed3a1dd73..337af22b0150 100644
> > --- a/drivers/staging/wfx/bh.c
> > +++ b/drivers/staging/wfx/bh.c
> > @@ -239,7 +239,7 @@ static int bh_work_tx(struct wfx_dev *wdev, int max_msg)
> >   */
> >  static void ack_sdio_data(struct wfx_dev *wdev)
> >  {
> > -       uint32_t cfg_reg;
> > +       u32  cfg_reg;
> Why there are two spaces between u32 and cfg_reg?

Yes, that's not ok, I can't take this patch as-is for that reason alone.

> 
> > 
> >         config_reg_read(wdev, &cfg_reg);
> >         if (cfg_reg & 0xFF) {
> > --
> > 2.23.0
> 
> There are plenty of other occurrences of uintXX_t:
> 
>    $ git grep '\buint[0-9]*_t\b' drivers/staging/wfx | wc -l
>    628
> 
> Why do you solve this one particularly?
> 
> 
> In add, the driver use more often uintXX_t than uXX:
> 
>    $ git grep '\bu[0-9]\+\b' drivers/staging/wfx | wc -l  
>    171
> 
> In other parts of kernel, uintXX_t are not rare:
> 
>    $ git grep '\buint[0-9]*_t\b' | grep -v staging | wc -l 
>    94005
> 
> I have a slight preference for uintXX_t, because it is less specific to
> kernel (and because vim highlights uintXX_t but does not highlight uXX).

uintXX_t really doesn't make sense in the kernel, as the "namespace" is
wrong, but we tolerate it.  Ideally you will use the right types.

Also, use the vim-addon-linux-coding-style pluging, makes writing kernel
code using vim much easier.

thanks,

greg k-h