* [PATCH v1] platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table
@ 2019-11-07 17:05 Andy Shevchenko
2019-11-07 23:59 ` Nobuhiro Iwamatsu
2019-11-08 13:18 ` Greg Kroah-Hartman
0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2019-11-07 17:05 UTC (permalink / raw)
To: Jan Kiszka, Greg Kroah-Hartman; +Cc: stable, Andy Shevchenko
From: Jan Kiszka <jan.kiszka@siemens.com>
The SIMATIC IPC227E uses the PMC clock for on-board components and gets
stuck during boot if the clock is disabled. Therefore, add this device
to the critical systems list.
Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
Cc: <stable@vger.kernel.org>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
- resend for stable inclusion
drivers/platform/x86/pmc_atom.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
index aa53648a2214..9aca5e7ce6d0 100644
--- a/drivers/platform/x86/pmc_atom.c
+++ b/drivers/platform/x86/pmc_atom.c
@@ -415,6 +415,13 @@ static const struct dmi_system_id critclk_systems[] = {
DMI_MATCH(DMI_BOARD_NAME, "CB6363"),
},
},
+ {
+ .ident = "SIMATIC IPC227E",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "6ES7647-8B"),
+ },
+ },
{ /*sentinel*/ }
};
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table
2019-11-07 17:05 [PATCH v1] platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table Andy Shevchenko
@ 2019-11-07 23:59 ` Nobuhiro Iwamatsu
2019-11-08 13:18 ` Greg Kroah-Hartman
1 sibling, 0 replies; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2019-11-07 23:59 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Jan Kiszka, Greg Kroah-Hartman, stable
Hi,
2019年11月8日(金) 2:05 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The SIMATIC IPC227E uses the PMC clock for on-board components and gets
> stuck during boot if the clock is disabled. Therefore, add this device
> to the critical systems list.
You forgot to add original commit ID.
Best regards,
Nobuhiro
>
> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> - resend for stable inclusion
>
> drivers/platform/x86/pmc_atom.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index aa53648a2214..9aca5e7ce6d0 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -415,6 +415,13 @@ static const struct dmi_system_id critclk_systems[] = {
> DMI_MATCH(DMI_BOARD_NAME, "CB6363"),
> },
> },
> + {
> + .ident = "SIMATIC IPC227E",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "6ES7647-8B"),
> + },
> + },
> { /*sentinel*/ }
> };
>
> --
> 2.24.0
>
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table
2019-11-07 17:05 [PATCH v1] platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table Andy Shevchenko
2019-11-07 23:59 ` Nobuhiro Iwamatsu
@ 2019-11-08 13:18 ` Greg Kroah-Hartman
2019-11-08 13:24 ` Jan Kiszka
1 sibling, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-11-08 13:18 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Jan Kiszka, stable
On Thu, Nov 07, 2019 at 07:05:30PM +0200, Andy Shevchenko wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The SIMATIC IPC227E uses the PMC clock for on-board components and gets
> stuck during boot if the clock is disabled. Therefore, add this device
> to the critical systems list.
>
> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> - resend for stable inclusion
What git id is this in Linus's tree, and what tree(s) is this backport
for?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table
2019-11-08 13:18 ` Greg Kroah-Hartman
@ 2019-11-08 13:24 ` Jan Kiszka
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2019-11-08 13:24 UTC (permalink / raw)
To: Greg Kroah-Hartman, Andy Shevchenko; +Cc: stable
On 08.11.19 14:18, Greg Kroah-Hartman wrote:
> On Thu, Nov 07, 2019 at 07:05:30PM +0200, Andy Shevchenko wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> The SIMATIC IPC227E uses the PMC clock for on-board components and gets
>> stuck during boot if the clock is disabled. Therefore, add this device
>> to the critical systems list.
>>
>> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>>
>> - resend for stable inclusion
>
> What git id is this in Linus's tree, and what tree(s) is this backport
> for?
Upstream ID ad0d315b4d4e7138f43acf03308192ec00e9614d.
We should target down to 4.14, the last stable kernel that got bothered
by 648e921888ad as far as I can see.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-08 13:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 17:05 [PATCH v1] platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table Andy Shevchenko
2019-11-07 23:59 ` Nobuhiro Iwamatsu
2019-11-08 13:18 ` Greg Kroah-Hartman
2019-11-08 13:24 ` Jan Kiszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.