All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH 3/3] cpu-plug-test: fix leaks
Date: Thu,  7 Nov 2019 23:27:31 +0400	[thread overview]
Message-ID: <20191107192731.17330-4-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20191107192731.17330-1-marcandre.lureau@redhat.com>

Spotted by ASAN.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/cpu-plug-test.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/cpu-plug-test.c b/tests/cpu-plug-test.c
index 058cef5ac1..30e514bbfb 100644
--- a/tests/cpu-plug-test.c
+++ b/tests/cpu-plug-test.c
@@ -99,6 +99,7 @@ static void test_plug_with_device_add(gconstpointer data)
 
         cpu = qobject_to(QDict, e);
         if (qdict_haskey(cpu, "qom-path")) {
+            qobject_unref(e);
             continue;
         }
 
@@ -107,6 +108,7 @@ static void test_plug_with_device_add(gconstpointer data)
 
         qtest_qmp_device_add_qdict(qts, td->device_model, props);
         hotplugged++;
+        qobject_unref(e);
     }
 
     /* make sure that there were hotplugged CPUs */
-- 
2.24.0.rc0.20.gd81542e6f3



  parent reply	other threads:[~2019-11-07 19:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 19:27 [PATCH 0/3] Some memory leak fixes Marc-André Lureau
2019-11-07 19:27 ` [PATCH 1/3] virtio-input: fix memory leak on unrealize Marc-André Lureau
2019-11-08  9:53   ` Michael S. Tsirkin
2019-11-07 19:27 ` [PATCH 2/3] qtest: fix qtest_qmp_device_add leak Marc-André Lureau
2019-11-07 20:31   ` Laurent Vivier
2019-11-07 20:41     ` Marc-André Lureau
2019-11-08  9:54   ` Thomas Huth
2019-11-07 19:27 ` Marc-André Lureau [this message]
2019-11-08 10:56   ` [PATCH 3/3] cpu-plug-test: fix leaks Thomas Huth
2019-11-07 21:57 ` [PATCH 0/3] Some memory leak fixes no-reply
2019-11-08  9:57   ` Thomas Huth
2019-11-08 10:17     ` Laurent Vivier
2019-11-08  9:53 ` Michael S. Tsirkin
2019-11-20 14:50   ` Marc-André Lureau
2019-11-20 14:59     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107192731.17330-4-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.