From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC3EFC6194 for ; Fri, 8 Nov 2019 13:01:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A274B2087E for ; Fri, 8 Nov 2019 13:01:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="Il3DCL7v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727691AbfKHNBd (ORCPT ); Fri, 8 Nov 2019 08:01:33 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:42797 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727507AbfKHNBc (ORCPT ); Fri, 8 Nov 2019 08:01:32 -0500 Received: by mail-lj1-f195.google.com with SMTP id n5so6121799ljc.9 for ; Fri, 08 Nov 2019 05:01:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IwcdyWxRDO/TUjQjvqfZVlSTaDYPWlQZLs741mWfW6c=; b=Il3DCL7vnUfDWk2t/dT7/uKy401t+E+TEtTumQV7aGFBMSqoz6kukNHfbvmCHSIxMK /rjkT3HHQ6iR29tHP+WnfsMgbjiel7Xdx3fOgzUS6UsDe/1qYDJMkQYd0Q/dL26XEB28 /roXQK+QbBY6A5W42j+SwAhdORazO7kdTzDWo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IwcdyWxRDO/TUjQjvqfZVlSTaDYPWlQZLs741mWfW6c=; b=puqaUb6n+U3gK/MvfA30hermXx+Mjp+68zQ0UB+YKI8vq9kvsdcHhOEYRhACgMl0fd twvf3JByJEO2lCPMzmqVT6cv49R6KflI1RVegkDWVtPx+Nu0ixiOxn3Y7cg7Y29Oa35O FQYlQbcF+pEwGgqcXJKCHa5uYqdExPBVkbzQTrgEzL2rM5WFEYAvEtLNpC9Tmcs3FVG2 l6cMf9luRQ1DuGdVSaKtEDCJaV4zl+FGIWRZ1+YnMUbAhHkf7XynBcNMk+i+1+qLN+lb 19fUJguEKjwg3dzx95V7kWPDfx6pRWioDOnKom4+Hja/yIIZLY2ef0vkFjz++jTn2J9G bLlg== X-Gm-Message-State: APjAAAVxUj7W6gFCLp5GneBdGV89dppRyq5Nfet9SIQJ+fsZHYS6OUsI GRHr9syDKmAIDIWfThHAGB1x4A== X-Google-Smtp-Source: APXvYqwQjL+XRBKvPBVlIVCDZcxIlePYwv4P23TGc8rNS3Ec1QKm2jAO9MNSrExrOF8chImjosB07Q== X-Received: by 2002:a2e:8601:: with SMTP id a1mr6905527lji.159.1573218090373; Fri, 08 Nov 2019 05:01:30 -0800 (PST) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id d28sm2454725lfn.33.2019.11.08.05.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 05:01:29 -0800 (PST) From: Rasmus Villemoes To: Qiang Zhao , Li Yang , Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Scott Wood , Rasmus Villemoes Subject: [PATCH v4 02/47] soc: fsl: qe: drop volatile qualifier of struct qe_ic::regs Date: Fri, 8 Nov 2019 14:00:38 +0100 Message-Id: <20191108130123.6839-3-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191108130123.6839-1-linux@rasmusvillemoes.dk> References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The actual io accessors (e.g. in_be32) implicitly add a volatile qualifier to their address argument. Remove volatile from the struct definition and the qe_ic_(read/write) helpers, in preparation for switching from the ppc-specific io accessors to generic ones. Signed-off-by: Rasmus Villemoes --- drivers/soc/fsl/qe/qe_ic.c | 4 ++-- drivers/soc/fsl/qe/qe_ic.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c index 9bac546998d3..791adcd121d1 100644 --- a/drivers/soc/fsl/qe/qe_ic.c +++ b/drivers/soc/fsl/qe/qe_ic.c @@ -171,12 +171,12 @@ static struct qe_ic_info qe_ic_info[] = { }, }; -static inline u32 qe_ic_read(volatile __be32 __iomem * base, unsigned int reg) +static inline u32 qe_ic_read(__be32 __iomem *base, unsigned int reg) { return in_be32(base + (reg >> 2)); } -static inline void qe_ic_write(volatile __be32 __iomem * base, unsigned int reg, +static inline void qe_ic_write(__be32 __iomem *base, unsigned int reg, u32 value) { out_be32(base + (reg >> 2), value); diff --git a/drivers/soc/fsl/qe/qe_ic.h b/drivers/soc/fsl/qe/qe_ic.h index 08c695672a03..9420378d9b6b 100644 --- a/drivers/soc/fsl/qe/qe_ic.h +++ b/drivers/soc/fsl/qe/qe_ic.h @@ -72,7 +72,7 @@ struct qe_ic { /* Control registers offset */ - volatile u32 __iomem *regs; + u32 __iomem *regs; /* The remapper for this QEIC */ struct irq_domain *irqhost; -- 2.23.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A5DFA372C for ; Fri, 8 Nov 2019 13:07:36 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEA18206A3 for ; Fri, 8 Nov 2019 13:07:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="Il3DCL7v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEA18206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 478gY01dV9zF6x4 for ; Sat, 9 Nov 2019 00:07:32 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::242; helo=mail-lj1-x242.google.com; envelope-from=linux@rasmusvillemoes.dk; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="Il3DCL7v"; dkim-atps=neutral Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 478gQ75tv3zF6qp for ; Sat, 9 Nov 2019 00:01:33 +1100 (AEDT) Received: by mail-lj1-x242.google.com with SMTP id l20so6125091lje.4 for ; Fri, 08 Nov 2019 05:01:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IwcdyWxRDO/TUjQjvqfZVlSTaDYPWlQZLs741mWfW6c=; b=Il3DCL7vnUfDWk2t/dT7/uKy401t+E+TEtTumQV7aGFBMSqoz6kukNHfbvmCHSIxMK /rjkT3HHQ6iR29tHP+WnfsMgbjiel7Xdx3fOgzUS6UsDe/1qYDJMkQYd0Q/dL26XEB28 /roXQK+QbBY6A5W42j+SwAhdORazO7kdTzDWo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IwcdyWxRDO/TUjQjvqfZVlSTaDYPWlQZLs741mWfW6c=; b=AHYn5zKFWu0ddc8yxk/U9oa0MrFGvBwFbosQFG27B54kY4W5zlFdx/lCc7lo1AIUS1 sc/o/GN6u3BS0RBiOPW+KYI6IdwkRIByk1/F08gKBvBP8sgd1EVhKIcQGy2unHmKd/wx EeHJu/YxZhz0F+I3K6WBG/1La+mIwplM6eiehL6ot393z6LFJwb2rMeH5D74nmAx+VQi ShCX9iS61mBC7BItNz5hov6D2BUzjTOpBJkwor8IRGnxm//Nud9sGOAmhPKUt47cmXqY iWfdbvbGau8Y0z5zSPyJGWU2ldK9tUCeIj+pOJzIeErM/OKE8YcJgbkKgCtZetpzF6C+ cwqw== X-Gm-Message-State: APjAAAUhAc/NvVt/ABcNMzS/+GLBolWW4Mbi16WWXQSBGnTvhkOLcuVh diQARTVEdoxZqYNYcER1YbTTzw== X-Google-Smtp-Source: APXvYqwQjL+XRBKvPBVlIVCDZcxIlePYwv4P23TGc8rNS3Ec1QKm2jAO9MNSrExrOF8chImjosB07Q== X-Received: by 2002:a2e:8601:: with SMTP id a1mr6905527lji.159.1573218090373; Fri, 08 Nov 2019 05:01:30 -0800 (PST) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id d28sm2454725lfn.33.2019.11.08.05.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 05:01:29 -0800 (PST) From: Rasmus Villemoes To: Qiang Zhao , Li Yang , Christophe Leroy Subject: [PATCH v4 02/47] soc: fsl: qe: drop volatile qualifier of struct qe_ic::regs Date: Fri, 8 Nov 2019 14:00:38 +0100 Message-Id: <20191108130123.6839-3-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191108130123.6839-1-linux@rasmusvillemoes.dk> References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Wood , Rasmus Villemoes , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" The actual io accessors (e.g. in_be32) implicitly add a volatile qualifier to their address argument. Remove volatile from the struct definition and the qe_ic_(read/write) helpers, in preparation for switching from the ppc-specific io accessors to generic ones. Signed-off-by: Rasmus Villemoes --- drivers/soc/fsl/qe/qe_ic.c | 4 ++-- drivers/soc/fsl/qe/qe_ic.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c index 9bac546998d3..791adcd121d1 100644 --- a/drivers/soc/fsl/qe/qe_ic.c +++ b/drivers/soc/fsl/qe/qe_ic.c @@ -171,12 +171,12 @@ static struct qe_ic_info qe_ic_info[] = { }, }; -static inline u32 qe_ic_read(volatile __be32 __iomem * base, unsigned int reg) +static inline u32 qe_ic_read(__be32 __iomem *base, unsigned int reg) { return in_be32(base + (reg >> 2)); } -static inline void qe_ic_write(volatile __be32 __iomem * base, unsigned int reg, +static inline void qe_ic_write(__be32 __iomem *base, unsigned int reg, u32 value) { out_be32(base + (reg >> 2), value); diff --git a/drivers/soc/fsl/qe/qe_ic.h b/drivers/soc/fsl/qe/qe_ic.h index 08c695672a03..9420378d9b6b 100644 --- a/drivers/soc/fsl/qe/qe_ic.h +++ b/drivers/soc/fsl/qe/qe_ic.h @@ -72,7 +72,7 @@ struct qe_ic { /* Control registers offset */ - volatile u32 __iomem *regs; + u32 __iomem *regs; /* The remapper for this QEIC */ struct irq_domain *irqhost; -- 2.23.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1CE3C5DF60 for ; Fri, 8 Nov 2019 13:02:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 950AD2087E for ; Fri, 8 Nov 2019 13:02:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qZfQ5G3g"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="Il3DCL7v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 950AD2087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hWb7doDzhG7tWt/2wMTCH4sJLiSi9e2Hzmdh4v6Ut+w=; b=qZfQ5G3gocoh8x FnFqeFw5az57KQVKfOs7eJ4hkeWWjMKU2vSgbCOZpptS+lY4FL/5pGOCSw1nSFgW2UwjeIZbZYuop YH5XGHUb5wqjwV5+LjPZ4gYVC4eiRBXiGFELpMlPZ0rjl7q6LRNs/BWyVNElh8GENW+bBaesL74UN hAG4paGqqNnZCseo/c/I0riRCx43gQ97ZU/6RwwrSrRGqGuVj0Xn9VuyOzQaPkifRye3BfKXrdxLm oPmsJRwLgVDDs2Igd7k+47JwESfqDOg8WYN4Rf/OcsapgUk9Ydcj64gINLS8F57ugNIPtYUNaE+7S jbZ8F11XOuHsoPsiu2yA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT3tp-0004Y2-F9; Fri, 08 Nov 2019 13:02:01 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT3tN-0004Eh-Dv for linux-arm-kernel@lists.infradead.org; Fri, 08 Nov 2019 13:01:34 +0000 Received: by mail-lj1-x244.google.com with SMTP id v8so6130399ljh.5 for ; Fri, 08 Nov 2019 05:01:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IwcdyWxRDO/TUjQjvqfZVlSTaDYPWlQZLs741mWfW6c=; b=Il3DCL7vnUfDWk2t/dT7/uKy401t+E+TEtTumQV7aGFBMSqoz6kukNHfbvmCHSIxMK /rjkT3HHQ6iR29tHP+WnfsMgbjiel7Xdx3fOgzUS6UsDe/1qYDJMkQYd0Q/dL26XEB28 /roXQK+QbBY6A5W42j+SwAhdORazO7kdTzDWo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IwcdyWxRDO/TUjQjvqfZVlSTaDYPWlQZLs741mWfW6c=; b=jKlSIwpkCsXB0eVvNl+/HyfhwL4hXBHo/6+YHEAqUAMxnpdspn13RsPIS95EEbp6S/ mksBYPwQ1bRQ/QFNA/fEHShYxVPimo+JbVnMZYx5/lXnzf0eNadAHzHZs4wAhI1RF2ns estAbMFBMDkcjweO2MU8mFXHWxQNtU6aZvj1uYykAdBGOXb40qslVh8Uf/jMES8nXMVQ HLmakt7hY/67H3Bnt0tUTDzrmPy/+zmRXVn87gX8ybLxzK4dfWlLA16k1+oOSgBPQ+TE kplhAdJ3UXMgwLJpKPmAUCHQJ7OTawnLGKxWgLK0sGVW/GKxpmqvnRI2cqDy7BG4yKX0 uINg== X-Gm-Message-State: APjAAAWUD2xlZT+PBaduA3JN5CdgKF/0EaGUU+2Nk/IEFtNMQkZ0W/F3 v+1p87zQMkjQttGxw9pWxdQUkw== X-Google-Smtp-Source: APXvYqwQjL+XRBKvPBVlIVCDZcxIlePYwv4P23TGc8rNS3Ec1QKm2jAO9MNSrExrOF8chImjosB07Q== X-Received: by 2002:a2e:8601:: with SMTP id a1mr6905527lji.159.1573218090373; Fri, 08 Nov 2019 05:01:30 -0800 (PST) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id d28sm2454725lfn.33.2019.11.08.05.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 05:01:29 -0800 (PST) From: Rasmus Villemoes To: Qiang Zhao , Li Yang , Christophe Leroy Subject: [PATCH v4 02/47] soc: fsl: qe: drop volatile qualifier of struct qe_ic::regs Date: Fri, 8 Nov 2019 14:00:38 +0100 Message-Id: <20191108130123.6839-3-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191108130123.6839-1-linux@rasmusvillemoes.dk> References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191108_050133_482179_B816FAAF X-CRM114-Status: GOOD ( 12.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Wood , Rasmus Villemoes , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org The actual io accessors (e.g. in_be32) implicitly add a volatile qualifier to their address argument. Remove volatile from the struct definition and the qe_ic_(read/write) helpers, in preparation for switching from the ppc-specific io accessors to generic ones. Signed-off-by: Rasmus Villemoes --- drivers/soc/fsl/qe/qe_ic.c | 4 ++-- drivers/soc/fsl/qe/qe_ic.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c index 9bac546998d3..791adcd121d1 100644 --- a/drivers/soc/fsl/qe/qe_ic.c +++ b/drivers/soc/fsl/qe/qe_ic.c @@ -171,12 +171,12 @@ static struct qe_ic_info qe_ic_info[] = { }, }; -static inline u32 qe_ic_read(volatile __be32 __iomem * base, unsigned int reg) +static inline u32 qe_ic_read(__be32 __iomem *base, unsigned int reg) { return in_be32(base + (reg >> 2)); } -static inline void qe_ic_write(volatile __be32 __iomem * base, unsigned int reg, +static inline void qe_ic_write(__be32 __iomem *base, unsigned int reg, u32 value) { out_be32(base + (reg >> 2), value); diff --git a/drivers/soc/fsl/qe/qe_ic.h b/drivers/soc/fsl/qe/qe_ic.h index 08c695672a03..9420378d9b6b 100644 --- a/drivers/soc/fsl/qe/qe_ic.h +++ b/drivers/soc/fsl/qe/qe_ic.h @@ -72,7 +72,7 @@ struct qe_ic { /* Control registers offset */ - volatile u32 __iomem *regs; + u32 __iomem *regs; /* The remapper for this QEIC */ struct irq_domain *irqhost; -- 2.23.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel