Hi Thomas,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on powerpc/next]
[cannot apply to v5.4-rc6 next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Thomas-Falcon/powerpc-pseries-mobility-notify-network-peers-after-migration/20191108-030800
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   arch/powerpc//platforms/pseries/mobility.c: In function 'post_mobility_fixup':
>> arch/powerpc//platforms/pseries/mobility.c:383:4: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
       if (netif_device_present(netdev) &&
       ^~
   arch/powerpc//platforms/pseries/mobility.c:388:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
        call_netdevice_notifiers(NETDEV_RESEND_IGMP,
        ^~~~~~~~~~~~~~~~~~~~~~~~

vim +/if +383 arch/powerpc//platforms/pseries/mobility.c

   332	
   333	void post_mobility_fixup(void)
   334	{
   335		int rc;
   336		int activate_fw_token;
   337		struct net_device *netdev;
   338		struct net *net;
   339	
   340		activate_fw_token = rtas_token("ibm,activate-firmware");
   341		if (activate_fw_token == RTAS_UNKNOWN_SERVICE) {
   342			printk(KERN_ERR "Could not make post-mobility "
   343			       "activate-fw call.\n");
   344			return;
   345		}
   346	
   347		do {
   348			rc = rtas_call(activate_fw_token, 0, 1, NULL);
   349		} while (rtas_busy_delay(rc));
   350	
   351		if (rc)
   352			printk(KERN_ERR "Post-mobility activate-fw failed: %d\n", rc);
   353	
   354		/*
   355		 * We don't want CPUs to go online/offline while the device
   356		 * tree is being updated.
   357		 */
   358		cpus_read_lock();
   359	
   360		/*
   361		 * It's common for the destination firmware to replace cache
   362		 * nodes.  Release all of the cacheinfo hierarchy's references
   363		 * before updating the device tree.
   364		 */
   365		cacheinfo_teardown();
   366	
   367		rc = pseries_devicetree_update(MIGRATION_SCOPE);
   368		if (rc)
   369			printk(KERN_ERR "Post-mobility device tree update "
   370				"failed: %d\n", rc);
   371	
   372		cacheinfo_rebuild();
   373	
   374		cpus_read_unlock();
   375	
   376		/* Possibly switch to a new RFI flush type */
   377		pseries_setup_rfi_flush();
   378	
   379		/* need to force a gratuitous ARP on running interfaces */
   380		rtnl_lock();
   381		for_each_net(net) {
   382			for_each_netdev(net, netdev) {
 > 383				if (netif_device_present(netdev) &&
   384				    netif_running(netdev) &&
   385				    !(netdev->flags & (IFF_NOARP | IFF_LOOPBACK)))
   386					call_netdevice_notifiers(NETDEV_NOTIFY_PEERS,
   387								 netdev);
   388					call_netdevice_notifiers(NETDEV_RESEND_IGMP,
   389								 netdev);
   390			}
   391		}
   392		rtnl_unlock();
   393	
   394		return;
   395	}
   396	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation