From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19762C17440 for ; Sat, 9 Nov 2019 02:47:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E986421019 for ; Sat, 9 Nov 2019 02:47:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726597AbfKICrz (ORCPT ); Fri, 8 Nov 2019 21:47:55 -0500 Received: from mga04.intel.com ([192.55.52.120]:42457 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726061AbfKICrz (ORCPT ); Fri, 8 Nov 2019 21:47:55 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2019 18:47:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,283,1569308400"; d="scan'208";a="201515057" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by fmsmga008.fm.intel.com with ESMTP; 08 Nov 2019 18:47:54 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id 44A8A300E00; Fri, 8 Nov 2019 18:47:54 -0800 (PST) Date: Fri, 8 Nov 2019 18:47:54 -0800 From: Andi Kleen To: "liuqi (BA)" Cc: "linux-kernel@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Jin Yao , Ravi Bangoria , Davidlohr Bueso , Zhangshaokun , huangdaode , linyunsheng , John Garry Subject: Re: [QUESTION]perf stat: comment of miss ratio Message-ID: <20191109024754.GA573472@tassilo.jf.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Relevant code is checked to make sure that the ratio is calculated by > > L1-dcache-load-misses/L1-dcache-loads, data "7.58%=30249/399189*100%" also > > proves this conclusion. > > So, I'm not sure why we use "of all L1-dcache hits" here to describe miss > ratio, Yes you're right it should be "of all L1-dcache accesses" Please send a patch to fix the string and also check if this isn't wrong with some other ratio too. -Andi