* [PATCH v2] tcp: remove redundant new line from tcp_event_sk_skb
@ 2019-11-09 10:43 Tony Lu
2019-11-10 3:56 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tony Lu @ 2019-11-09 10:43 UTC (permalink / raw)
To: edumazet, rostedt, mingo; +Cc: laoar.shao, netdev, linux-kernel
This removes '\n' from trace event class tcp_event_sk_skb to avoid
redundant new blank line and make output compact.
Fixes: af4325ecc24f ("tcp: expose sk_state in tcp_retransmit_skb tracepoint")
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Yafang Shao <laoar.shao@gmail.com>
Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
---
v1->v2:
- append Fixes tag
---
include/trace/events/tcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
index 2bc9960a31aa..cf97f6339acb 100644
--- a/include/trace/events/tcp.h
+++ b/include/trace/events/tcp.h
@@ -86,7 +86,7 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
),
- TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s\n",
+ TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
__entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
__entry->saddr_v6, __entry->daddr_v6,
show_tcp_state_name(__entry->state))
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] tcp: remove redundant new line from tcp_event_sk_skb
2019-11-09 10:43 [PATCH v2] tcp: remove redundant new line from tcp_event_sk_skb Tony Lu
@ 2019-11-10 3:56 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-10 3:56 UTC (permalink / raw)
To: tonylu; +Cc: edumazet, rostedt, mingo, laoar.shao, netdev, linux-kernel
From: Tony Lu <tonylu@linux.alibaba.com>
Date: Sat, 9 Nov 2019 18:43:06 +0800
> This removes '\n' from trace event class tcp_event_sk_skb to avoid
> redundant new blank line and make output compact.
>
> Fixes: af4325ecc24f ("tcp: expose sk_state in tcp_retransmit_skb tracepoint")
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Reviewed-by: Yafang Shao <laoar.shao@gmail.com>
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> ---
> v1->v2:
> - append Fixes tag
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-10 3:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-09 10:43 [PATCH v2] tcp: remove redundant new line from tcp_event_sk_skb Tony Lu
2019-11-10 3:56 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.