All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Anderson <dianders@chromium.org>
To: Paul Burton <paul.burton@mips.com>,
	Jason Wessel <jason.wessel@windriver.com>,
	Daniel Thompson <daniel.thompson@linaro.org>
Cc: qiaochong@loongson.cn, kgdb-bugreport@lists.sourceforge.net,
	ralf@linux-mips.org, "Douglas Anderson" <dianders@chromium.org>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"James Hogan" <jhogan@kernel.org>,
	"Mike Rapoport" <rppt@linux.ibm.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Serge Semin" <fancer.lancer@gmail.com>,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: [PATCH 1/5] MIPS: kdb: Remove old workaround for backtracing on other CPUs
Date: Sat,  9 Nov 2019 11:16:40 -0800	[thread overview]
Message-ID: <20191109111623.1.I30a0cac4d9880040c8d41495bd9a567fe3e24989@changeid> (raw)
In-Reply-To: <20191109191644.191766-1-dianders@chromium.org>

As of commit 2277b492582d ("kdb: Fix stack crawling on 'running' CPUs
that aren't the master") we no longer need any special case for doing
stack dumps on CPUs that are not the kdb master.  Let's remove.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
I have no way to test this personally, so hopefully someone who uses
kdb/kgdb on MIPS can.

Ideally this patch should be Acked by MIPS folks and then land through
the kdb/kgdb tree since the next patch in the series, ("kdb:
kdb_current_regs should be private") depends on it.

 arch/mips/kernel/traps.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 342e41de9d64..46fbcfeaae9a 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -210,11 +210,6 @@ void show_stack(struct task_struct *task, unsigned long *sp)
 			regs.regs[29] = task->thread.reg29;
 			regs.regs[31] = 0;
 			regs.cp0_epc = task->thread.reg31;
-#ifdef CONFIG_KGDB_KDB
-		} else if (atomic_read(&kgdb_active) != -1 &&
-			   kdb_current_regs) {
-			memcpy(&regs, kdb_current_regs, sizeof(regs));
-#endif /* CONFIG_KGDB_KDB */
 		} else {
 			prepare_frametrace(&regs);
 		}
-- 
2.24.0.432.g9d3f5f5b63-goog


  reply	other threads:[~2019-11-09 19:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-09 19:16 [PATCH 0/5] kdb: Don't implicitly change tasks; plus misc fixups Douglas Anderson
2019-11-09 19:16 ` Douglas Anderson [this message]
2019-11-14 10:51   ` [PATCH 1/5] MIPS: kdb: Remove old workaround for backtracing on other CPUs Daniel Thompson
2019-11-14 16:10     ` Doug Anderson
2019-11-15  0:30     ` Paul Burton
2019-11-09 19:16 ` [PATCH 2/5] kdb: kdb_current_regs should be private Douglas Anderson
2019-11-09 19:16 ` [PATCH 3/5] kdb: kdb_current_task shouldn't be exported Douglas Anderson
2019-11-09 19:16 ` [PATCH 4/5] kdb: Gid rid of implicit setting of the current task / regs Douglas Anderson
2019-11-09 19:16 ` [PATCH 5/5] kdb: Get rid of confusing diag msg from "rd" if current task has no regs Douglas Anderson
2020-01-28 16:59 ` [PATCH 0/5] kdb: Don't implicitly change tasks; plus misc fixups Doug Anderson
2020-01-29  1:42   ` Andrew Morton
2020-01-29 15:23     ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191109111623.1.I30a0cac4d9880040c8d41495bd9a567fe3e24989@changeid \
    --to=dianders@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=daniel.thompson@linaro.org \
    --cc=ebiederm@xmission.com \
    --cc=f4bug@amsat.org \
    --cc=fancer.lancer@gmail.com \
    --cc=jason.wessel@windriver.com \
    --cc=jhogan@kernel.org \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=paul.burton@mips.com \
    --cc=qiaochong@loongson.cn \
    --cc=ralf@linux-mips.org \
    --cc=rppt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.