Hi Arnd,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on v5.4-rc6 next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Arnd-Bergmann/drivers-y2038-updates/20191110-071326
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git a2582cdc32f071422e0197a6c59bd1235b426ce2
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from include/net/net_namespace.h:38:0,
                    from include/linux/inet.h:42,
                    from net///802/fddi.c:32:
>> include/linux/skbuff.h:3659:19: warning: 'struct __kernel_old_timespec' declared inside parameter list will not be visible outside of this definition or declaration
               struct __kernel_old_timespec *stamp)
                      ^~~~~~~~~~~~~~~~~~~~~
   include/linux/skbuff.h: In function 'skb_get_timestampns':
>> include/linux/skbuff.h:3663:7: error: dereferencing pointer to incomplete type 'struct __kernel_old_timespec'
     stamp->tv_sec = ts.tv_sec;
          ^~
--
   In file included from net///ipv4/tcp.c:255:0:
>> include/linux/skbuff.h:3659:19: warning: 'struct __kernel_old_timespec' declared inside parameter list will not be visible outside of this definition or declaration
               struct __kernel_old_timespec *stamp)
                      ^~~~~~~~~~~~~~~~~~~~~
   include/linux/skbuff.h: In function 'skb_get_timestampns':
>> include/linux/skbuff.h:3663:7: error: dereferencing pointer to incomplete type 'struct __kernel_old_timespec'
     stamp->tv_sec = ts.tv_sec;
          ^~
   net///ipv4/tcp.c: In function 'tcp_recv_timestamp':
>> net///ipv4/tcp.c:1874:13: error: variable 'ts_old' has initializer but incomplete type
         struct __kernel_old_timespec ts_old = {
                ^~~~~~~~~~~~~~~~~~~~~
>> net///ipv4/tcp.c:1875:8: error: 'struct __kernel_old_timespec' has no member named 'tv_sec'
          .tv_sec = tss->ts[0].tv_sec,
           ^~~~~~
>> net///ipv4/tcp.c:1875:17: warning: excess elements in struct initializer
          .tv_sec = tss->ts[0].tv_sec,
                    ^~~
   net///ipv4/tcp.c:1875:17: note: (near initialization for 'ts_old')
>> net///ipv4/tcp.c:1876:8: error: 'struct __kernel_old_timespec' has no member named 'tv_nsec'
          .tv_nsec = tss->ts[0].tv_nsec,
           ^~~~~~~
   net///ipv4/tcp.c:1876:18: warning: excess elements in struct initializer
          .tv_nsec = tss->ts[0].tv_nsec,
                     ^~~
   net///ipv4/tcp.c:1876:18: note: (near initialization for 'ts_old')
>> net///ipv4/tcp.c:1874:35: error: storage size of 'ts_old' isn't known
         struct __kernel_old_timespec ts_old = {
                                      ^~~~~~
   net///ipv4/tcp.c:1874:35: warning: unused variable 'ts_old' [-Wunused-variable]
--
   In file included from include/linux/if_ether.h:19:0,
                    from include/uapi/linux/ethtool.h:19,
                    from include/linux/ethtool.h:18,
                    from include/linux/netdevice.h:37,
                    from include/net/cfg80211.h:13,
                    from net///mac80211/trace.c:7:
>> include/linux/skbuff.h:3659:19: warning: 'struct __kernel_old_timespec' declared inside parameter list will not be visible outside of this definition or declaration
               struct __kernel_old_timespec *stamp)
                      ^~~~~~~~~~~~~~~~~~~~~
   include/linux/skbuff.h: In function 'skb_get_timestampns':
>> include/linux/skbuff.h:3663:7: error: dereferencing pointer to incomplete type 'struct __kernel_old_timespec'
     stamp->tv_sec = ts.tv_sec;
          ^~
   In file included from net///mac80211/trace.h:2717:0,
                    from net///mac80211/trace.c:11:
   include/trace/define_trace.h: At top level:
   include/trace/define_trace.h:95:42: fatal error: ./trace.h: No such file or directory
    #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
                                             ^
   compilation terminated.

vim +3663 include/linux/skbuff.h

  3657	
  3658	static inline void skb_get_timestampns(const struct sk_buff *skb,
> 3659					       struct __kernel_old_timespec *stamp)
  3660	{
  3661		struct timespec64 ts = ktime_to_timespec64(skb->tstamp);
  3662	
> 3663		stamp->tv_sec = ts.tv_sec;
  3664		stamp->tv_nsec = ts.tv_nsec;
  3665	}
  3666	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation