From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 11 Nov 2019 14:16:09 +0100 Subject: [Buildroot] [PATCH 1/2] package/gcnano-binaries: new package In-Reply-To: References: <20191106155611.31575-1-scooby22@web.de> <20191106155611.31575-2-scooby22@web.de> <20191106230831.0a4017c6@windsurf> Message-ID: <20191111141609.757023f1@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Jens, On Mon, 11 Nov 2019 11:19:31 +0100 "Jens Kleintje" wrote: > > Please use the "github" helper macro: > > > GCNANO_BINARIES_VERSION = c01642ed5e18cf09ecd905af193e935cb3be95ed > > GCNANO_BINARIES_SITE = $(call github,STMicroelectronics,gcnano-binaries,$(GCNANO_BINARIES_VERSION)) > > > and remove the _SITE_METHOD variable. > The page (https://github.com/STMicroelectronics/gcnano-binaries) > has no release and no tag. So I think there is no archive directory. Not a problem, the github macro works with any arbitrary commit. > > > + rm -f $(STAGING_DIR)/usr/lib/pkgconfig/wayland-egl.pc > > > Why are you removing this .pc file ? > The file is already provided by wayland package. > I saw it from in the yocto package > https://github.com/STMicroelectronics/meta-st-stm32mp/blob/thud/recipes-graphics/gcnano-userland/gcnano-userland-binary.inc Then, if you could add a comment in the .mk file about this, it would be good. > > Could you rework your patch to take into account those comments ? > Will come soon. Great, thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com